July 2014 - aarch64-port-dev

JTreg failures in aarch64 jdk7u
by Edward Nevill 04 Sep '14

04 Sep '14

Hi, I have been looking at the jtreg hotspot failures in aarch64 jdk7. There are a large number of failures because many of the jtreg hotspot tests contain code which is specific to jdk8, even though it is a jdk7 build. This is because the hotspot sub-repo came originally from jdk8 (hs 25.0-b70) instead of the standard jdk7u hotspot (hs 24.80-b07) and there are many tests which depend on jdk8, either because the tests use jdk8 source features, or because they rely on jdk8 APIs. For example, all (38) of the mathexact tests are invalid and therefore fail because mathexact does not exist on jdk7. The following is a summary of the results i get for jdk7 hotspot Test results: passed: 343; failed: 102; error: 1 For comparison, i tried running the same tests on x86 jdk7 with the following results. Test results: passed: 311; failed: 134; error: 1 I then took the jtreg test suite from the hs24 build and ran it on both aarch64 and x86 vsns of jdk7 with the following results. aarch64: Test results: passed: 279; failed: 11; error: 2 x86: Test results: passed: 286; failed: 4; error: 2 Here aarch64 still gets more failures than x86 because some of the tests make assumptions about testing hs24 vs hs25 (eg. the behaviour of various -XX: options). However the number of test failures is much smaller. So, what is the best way to resolve this? 1) Prune the existing aarch64 jtreg hotspot tree to remove any tests which are specific to jdk8 or 2) Generate an exclude list to exclude the above tests but leave them in place in the tree or 3) Replace the existing aarch64 jtreg hotspot tree (from hs25) with the one from hs24 (which gets 11 failures) and then either prune or exclude the much smaller set of tests which depend on some feature of hs24. I am happy to implement whichever solution as long as the solution works and is satisfactory to everyone. All the best, Ed.

2 1

hg: aarch64-port/jdk8/hotspot: Use TLS for ThreadLocalStorage::thread()
by aph＠redhat.com 31 Jul '14

31 Jul '14

Changeset: 5b248d10f0ae Author: aph Date: 2014-07-31 04:53 -0400 URL: http://hg.openjdk.java.net/aarch64-port/jdk8/hotspot/rev/5b248d10f0ae Use TLS for ThreadLocalStorage::thread() ! src/os_cpu/linux_aarch64/vm/globals_linux_aarch64.hpp ! src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.cpp ! src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.hpp

1 0

Use TLS for Thread::current()
by Andrew Haley 31 Jul '14

31 Jul '14

Here's a nice piece of low-hanging fruit. I did some profiling and discovered that more than 1-2% of the runtime is spent in ThreadLocalStorage::thread() ! We were using pthread_getspecific(), which is not an efficient mechanism. It doesn't matter much for Java, which keeps the current Thread in a register, but it matters a lot for the C++ runtime, which uses ThreadLocalStorage::thread() in 1667 different places. Linux's TLS (thread-local storage) mechanism keeps a pointer to a TLS thread block in system register tpidr_el0, so TLS access looks like this, first calculating the offset from the static TLS block, and then adding it to the thread pointer: adrp x0, 0x7fb7d4f000 ldr x1, [x0,#3312] add x0, x0, #0xcf0 blr x1 ldr x0, [x0,#8] ret mrs x1, tpidr_el0 ldr x20, [x1,x0] which looks pretty good. I don't think that we could do very much better than this with a custom mechanism. Andrew. changeset: 7204:5b248d10f0ae tag: tip user: aph date: Thu Jul 31 04:53:53 2014 -0400 summary: Use TLS for ThreadLocalStorage::thread() diff -r 5e238903a875 -r 5b248d10f0ae src/os_cpu/linux_aarch64/vm/globals_linux_aarch64.hpp --- a/src/os_cpu/linux_aarch64/vm/globals_linux_aarch64.hpp Tue Jul 29 06:00:26 2014 -0400 +++ b/src/os_cpu/linux_aarch64/vm/globals_linux_aarch64.hpp Thu Jul 31 04:53:53 2014 -0400 @@ -39,4 +39,6 @@ // Used on 64 bit platforms for UseCompressedOops base address define_pd_global(uintx,HeapBaseMinAddress, 2*G); +extern __thread Thread *aarch64_currentThread; + #endif // OS_CPU_LINUX_AARCH64_VM_GLOBALS_LINUX_AARCH64_HPP diff -r 5e238903a875 -r 5b248d10f0ae src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.cpp --- a/src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.cpp Tue Jul 29 06:00:26 2014 -0400 +++ b/src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.cpp Thu Jul 31 04:53:53 2014 -0400 @@ -26,32 +26,6 @@ #include "runtime/threadLocalStorage.hpp" #include "runtime/thread.inline.hpp" -// Map stack pointer (%esp) to thread pointer for faster TLS access -// -// Here we use a flat table for better performance. Getting current thread -// is down to one memory access (read _sp_map[%esp>>12]) in generated code -// and two in runtime code (-fPIC code needs an extra load for _sp_map). -// -// This code assumes stack page is not shared by different threads. It works -// in 32-bit VM when page size is 4K (or a multiple of 4K, if that matters). -// -// Notice that _sp_map is allocated in the bss segment, which is ZFOD -// (zero-fill-on-demand). While it reserves 4M address space upfront, -// actual memory pages are committed on demand. -// -// If an application creates and destroys a lot of threads, usually the -// stack space freed by a thread will soon get reused by new thread -// (this is especially true in NPTL or LinuxThreads in fixed-stack mode). -// No memory page in _sp_map is wasted. -// -// However, it's still possible that we might end up populating & -// committing a large fraction of the 4M table over time, but the actual -// amount of live data in the table could be quite small. The max wastage -// is less than 4M bytes. If it becomes an issue, we could use madvise() -// with MADV_DONTNEED to reclaim unused (i.e. all-zero) pages in _sp_map. -// MADV_DONTNEED on Linux keeps the virtual memory mapping, but zaps the -// physical memory page (i.e. similar to MADV_FREE on Solaris). - void ThreadLocalStorage::generate_code_for_get_thread() { // nothing we can do here for user-level thread } @@ -59,6 +33,9 @@ void ThreadLocalStorage::pd_init() { } +__thread Thread *aarch64_currentThread; + void ThreadLocalStorage::pd_set_thread(Thread* thread) { os::thread_local_storage_at_put(ThreadLocalStorage::thread_index(), thread); + aarch64_currentThread = thread; } diff -r 5e238903a875 -r 5b248d10f0ae src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.hpp --- a/src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.hpp Tue Jul 29 06:00:26 2014 -0400 +++ b/src/os_cpu/linux_aarch64/vm/threadLS_linux_aarch64.hpp Thu Jul 31 04:53:53 2014 -0400 @@ -29,8 +29,8 @@ public: - static Thread* thread() { - return (Thread*) os::thread_local_storage_at(thread_index()); - } + static Thread *thread() { + return aarch64_currentThread; + } #endif // OS_CPU_LINUX_AARCH64_VM_THREADLS_LINUX_AARCH64_HPP

1 0

JDK8: Add char_array_equals
by Edward Nevill 31 Jul '14

31 Jul '14

Hi, This is the first of three patches. This one adds support for char_array_equals, the next two will add support for encodeISOArray and indexOf. This has taken slightly longer than expected because I got sidetracked with other issues. Also, I am on holiday tomorrow so it will be next week sometime before I can generate the other two patches. All the best, Ed. --- CUT HERE --- # HG changeset patch # User Edward Nevill edward.nevill(a)linaro.org # Date 1406805043 -3600 # Thu Jul 31 12:10:43 2014 +0100 # Node ID a028c5a90df38cda792a68056923a0d5975e5837 # Parent 5e238903a8753fdca06994bec8b36363ae930664 Add char_array_equals intrinsic diff -r 5e238903a875 -r a028c5a90df3 src/cpu/aarch64/vm/aarch64.ad --- a/src/cpu/aarch64/vm/aarch64.ad Tue Jul 29 06:00:26 2014 -0400 +++ b/src/cpu/aarch64/vm/aarch64.ad Thu Jul 31 12:10:43 2014 +0100 @@ -11677,6 +11677,20 @@ ins_pipe(pipe_class_memory); %} +instruct array_equals(iRegP_R1 ary1, iRegP_R2 ary2, iRegI_R0 result, + iRegP_R10 tmp, rFlagsReg cr) +%{ + match(Set result (AryEq ary1 ary2)); + effect(KILL tmp, USE_KILL ary1, USE_KILL ary2, KILL cr); + + format %{ "Array Equals $ary1,ary2 -> $result // KILL $tmp" %} + ins_encode %{ + __ char_arrays_equals($ary1$$Register, $ary2$$Register, + $result$$Register, $tmp$$Register); + %} + ins_pipe(pipe_class_memory); +%} + // ============================================================================ // This name is KNOWN by the ADLC and cannot be changed. // The ADLC forces a 'TypeRawPtr::BOTTOM' output type diff -r 5e238903a875 -r a028c5a90df3 src/cpu/aarch64/vm/macroAssembler_aarch64.cpp --- a/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp Tue Jul 29 06:00:26 2014 -0400 +++ b/src/cpu/aarch64/vm/macroAssembler_aarch64.cpp Thu Jul 31 12:10:43 2014 +0100 @@ -3512,3 +3512,71 @@ BLOCK_COMMENT("} string_equals"); } + +// Compare char[] arrays aligned to 4 bytes +void MacroAssembler::char_arrays_equals(Register ary1, Register ary2, + Register result, Register tmp1) +{ + Register cnt1 = rscratch1; + Register cnt2 = rscratch2; + Register tmp2 = rscratch2; + + Label SAME, DIFFER, NEXT, TAIL03, TAIL01; + + int length_offset = arrayOopDesc::length_offset_in_bytes(); + int base_offset = arrayOopDesc::base_offset_in_bytes(T_CHAR); + + BLOCK_COMMENT("char_arrays_equals {"); + + // different until proven equal + mov(result, false); + + // same array? + cmp(ary1, ary2); + br(Assembler::EQ, SAME); + + // ne if either null + cbz(ary1, DIFFER); + cbz(ary2, DIFFER); + + // lengths ne? + ldrw(cnt1, Address(ary1, length_offset)); + ldrw(cnt2, Address(ary2, length_offset)); + cmp(cnt1, cnt2); + br(Assembler::NE, DIFFER); + + lea(ary1, Address(ary1, base_offset)); + lea(ary2, Address(ary2, base_offset)); + + subs(cnt1, cnt1, 4); + br(LT, TAIL03); + + BIND(NEXT); + ldr(tmp1, Address(post(ary1, 8))); + ldr(tmp2, Address(post(ary2, 8))); + subs(cnt1, cnt1, 4); + eor(tmp1, tmp1, tmp2); + cbnz(tmp1, DIFFER); + br(GE, NEXT); + + BIND(TAIL03); // 0-3 chars left, cnt1 = #chars left - 4 + tst(cnt1, 0b10); + br(EQ, TAIL01); + ldrw(tmp1, Address(post(ary1, 4))); + ldrw(tmp2, Address(post(ary2, 4))); + cmp(tmp1, tmp2); + br(NE, DIFFER); + BIND(TAIL01); // 0-1 chars left + tst(cnt1, 0b01); + br(EQ, SAME); + ldrh(tmp1, ary1); + ldrh(tmp2, ary2); + cmp(tmp1, tmp2); + br(NE, DIFFER); + + BIND(SAME); + mov(result, true); + BIND(DIFFER); // result already set + + BLOCK_COMMENT("} char_arrays_equals"); +} diff -r 5e238903a875 -r a028c5a90df3 src/cpu/aarch64/vm/macroAssembler_aarch64.hpp --- a/src/cpu/aarch64/vm/macroAssembler_aarch64.hpp Tue Jul 29 06:00:26 2014 -0400 +++ b/src/cpu/aarch64/vm/macroAssembler_aarch64.hpp Thu Jul 31 12:10:43 2014 +0100 @@ -1085,6 +1085,8 @@ void string_equals(Register str1, Register str2, Register cnt, Register result, Register tmp1); + void char_arrays_equals(Register ary1, Register ary2, + Register result, Register tmp1); }; // Used by aarch64.ad to control code generation --- CUT HERE ---

2 1

JTREG, SPECjbb2013 and Hadoop/Terasort results for OpenJDK 8 on AArch64
by Edward Nevill 30 Jul '14

30 Jul '14

This is a summary of the JTREG test results =========================================== The build and test results are cycled every 10 days. For detailed information on the test output please refer to: http://openjdk.linaro.org/openjdk8-jtreg-nightly-tests/summary/2014/211/sum… ------------------------------------------------------------------------------- client-release/hotspot ------------------------------------------------------------------------------- Build 0: aarch64/2014/jun/24 pass: 538; fail: 19 Build 1: aarch64/2014/jun/25 pass: 538; fail: 19 Build 2: aarch64/2014/jun/28 pass: 536; fail: 28 Build 3: aarch64/2014/jul/03 pass: 545; fail: 19 Build 4: aarch64/2014/jul/08 pass: 545; fail: 19 Build 5: aarch64/2014/jul/09 pass: 545; fail: 19 Build 6: aarch64/2014/jul/10 pass: 545; fail: 19 Build 7: aarch64/2014/jul/23 pass: 545; fail: 19 Build 8: aarch64/2014/jul/29 pass: 545; fail: 19 Build 9: aarch64/2014/jul/30 pass: 545; fail: 19 ------------------------------------------------------------------------------- client-release/jdk ------------------------------------------------------------------------------- Build 0: aarch64/2014/jun/24 pass: 4,970; fail: 495; error: 45 Build 1: aarch64/2014/jun/25 pass: 4,967; fail: 498; error: 45 Build 2: aarch64/2014/jun/28 pass: 4,968; fail: 497; error: 45 Build 3: aarch64/2014/jul/03 pass: 5,228; fail: 234; error: 48 Build 4: aarch64/2014/jul/08 pass: 5,242; fail: 219; error: 49 Build 5: aarch64/2014/jul/09 pass: 5,238; fail: 217; error: 55 Build 6: aarch64/2014/jul/10 pass: 5,230; fail: 234; error: 46 Build 7: aarch64/2014/jul/23 pass: 5,281; fail: 182; error: 47 Build 8: aarch64/2014/jul/29 pass: 5,267; fail: 199; error: 44 Build 9: aarch64/2014/jul/30 pass: 5,279; fail: 185; error: 46 ------------------------------------------------------------------------------- client-release/langtools ------------------------------------------------------------------------------- Build 0: aarch64/2014/jun/24 pass: 2,999; error: 16 Build 1: aarch64/2014/jun/25 pass: 3,000; fail: 1; error: 14 Build 2: aarch64/2014/jun/28 pass: 2,999; error: 16 Build 3: aarch64/2014/jul/03 pass: 2,999; error: 16 Build 4: aarch64/2014/jul/08 pass: 2,999; error: 16 Build 5: aarch64/2014/jul/09 pass: 3,000; error: 15 Build 6: aarch64/2014/jul/10 pass: 2,999; error: 16 Build 7: aarch64/2014/jul/23 pass: 3,000; error: 15 Build 8: aarch64/2014/jul/29 pass: 2,999; error: 16 Build 9: aarch64/2014/jul/30 pass: 2,999; error: 16 ------------------------------------------------------------------------------- server-release/hotspot ------------------------------------------------------------------------------- Build 0: aarch64/2014/jun/24 pass: 554; fail: 3 Build 1: aarch64/2014/jun/25 pass: 555; fail: 2 Build 2: aarch64/2014/jun/28 pass: 553; fail: 11 Build 3: aarch64/2014/jul/03 pass: 562; fail: 2 Build 4: aarch64/2014/jul/08 pass: 562; fail: 2 Build 5: aarch64/2014/jul/09 pass: 562; fail: 2 Build 6: aarch64/2014/jul/10 pass: 562; fail: 2 Build 7: aarch64/2014/jul/23 pass: 562; fail: 2 Build 8: aarch64/2014/jul/29 pass: 562; fail: 2 Build 9: aarch64/2014/jul/30 pass: 562; fail: 2 ------------------------------------------------------------------------------- server-release/jdk ------------------------------------------------------------------------------- Build 0: aarch64/2014/jun/24 pass: 4,973; fail: 492; error: 45 Build 1: aarch64/2014/jun/25 pass: 4,975; fail: 491; error: 44 Build 2: aarch64/2014/jun/28 pass: 4,973; fail: 493; error: 44 Build 3: aarch64/2014/jul/03 pass: 5,239; fail: 221; error: 50 Build 4: aarch64/2014/jul/08 pass: 5,239; fail: 217; error: 54 Build 5: aarch64/2014/jul/09 pass: 5,231; fail: 231; error: 48 Build 6: aarch64/2014/jul/10 pass: 5,246; fail: 212; error: 52 Build 7: aarch64/2014/jul/23 pass: 5,291; fail: 174; error: 45 Build 8: aarch64/2014/jul/29 pass: 5,285; fail: 182; error: 43 Build 9: aarch64/2014/jul/30 pass: 5,292; fail: 172; error: 46 ------------------------------------------------------------------------------- server-release/langtools ------------------------------------------------------------------------------- Build 0: aarch64/2014/jun/24 pass: 3,004; error: 11 Build 1: aarch64/2014/jun/25 pass: 3,004; error: 11 Build 2: aarch64/2014/jun/28 pass: 3,004; error: 11 Build 3: aarch64/2014/jul/03 pass: 3,004; error: 11 Build 4: aarch64/2014/jul/08 pass: 3,004; error: 11 Build 5: aarch64/2014/jul/09 pass: 3,004; error: 11 Build 6: aarch64/2014/jul/10 pass: 3,004; error: 11 Build 7: aarch64/2014/jul/23 pass: 3,004; error: 11 Build 8: aarch64/2014/jul/29 pass: 3,004; error: 11 Build 9: aarch64/2014/jul/30 pass: 3,004; error: 11 Previous results can be found here: http://openjdk.linaro.org/openjdk8-jtreg-nightly-tests/index.html SPECjbb2013 composite regression test completed =============================================== This test measures the relative performance of the server compiler running the SPECjbb2013 composite tests and compares the performance against the baseline performance of the server compiler taken on 2014-04-01. In accordance with [1], the SPECjbb2013 tests are run on a system which is not production ready and does not meet all the requirements for publishing compliant results. The numbers below shall be treated as non-compliant (nc) and are for experimental purposes only. Relative performance: Server max-jOPS (nc): 0.93x Relative performance: Server critical-jOPS (nc): 0.99x Details of the test setup and historical results may be found here: http://openjdk.linaro.org/SPECjbb2013-1.00-results/ [1] http://www.spec.org/fairuse.html#Academic Regression test Hadoop-Terasort completed ========================================= This test measures the performance of the server and client compilers running Hadoop sorting a 1GB file using Terasort and compares the performance against the baseline performance of the Zero interpreter and against the baseline performance of the client and server compilers on 2014-04-01. Relative performance: Zero: 1.0, Client: 49.35, Server: 81.59 Client 49.35 / Client 2014-04-01 (43.00): 1.15x Server 81.59 / Server 2014-04-01 (71.00): 1.15x Details of the test setup and historical results may be found here: http://openjdk.linaro.org/hadoop-terasort-benchmark-results/ This is a summary of the jcstress test results ============================================== The build and test results are cycled every 10 days. 2014-07-03 pass rate: 898/898, results: http://openjdk.linaro.org/jcstress-nightly-runs/2014/184/results/ 2014-07-04 pass rate: 898/898, results: http://openjdk.linaro.org/jcstress-nightly-runs/2014/185/results/ 2014-07-11 pass rate: 898/898, results: http://openjdk.linaro.org/jcstress-nightly-runs/2014/192/results/ 2014-07-23 pass rate: 898/898, results: http://openjdk.linaro.org/jcstress-nightly-runs/2014/204/results/ 2014-07-29 pass rate: 898/898, results: http://openjdk.linaro.org/jcstress-nightly-runs/2014/210/results/ 2014-07-30 pass rate: 898/898, results: http://openjdk.linaro.org/jcstress-nightly-runs/2014/211/results/ For detailed information on the test output please refer to: http://openjdk.linaro.org/jcstress-nightly-runs/

1 0

hg: aarch64-port/jdk9/hotspot: 6 new changesets
by aph＠redhat.com 29 Jul '14

29 Jul '14

Changeset: d54c77f1c233 Author: mduigou Date: 2014-07-09 21:56 +0000 URL: http://hg.openjdk.java.net/aarch64-port/jdk9/hotspot/rev/d54c77f1c233 8047734: Backout use of -Og Reviewed-by: iveresov ! make/bsd/makefiles/gcc.make ! make/linux/makefiles/gcc.make ! make/solaris/makefiles/gcc.make Changeset: edb991a23998 Author: aph Date: 2014-07-29 09:42 -0400 URL: http://hg.openjdk.java.net/aarch64-port/jdk9/hotspot/rev/edb991a23998 Delete dead code. ! src/cpu/aarch64/vm/aarch64.ad ! src/cpu/aarch64/vm/aarch64Test.cpp ! src/cpu/aarch64/vm/assembler_aarch64.hpp ! src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp - src/cpu/aarch64/vm/c1_LinearScan_aarch64.cpp ! src/cpu/aarch64/vm/c1_LinearScan_aarch64.hpp ! src/cpu/aarch64/vm/c1_MacroAssembler_aarch64.cpp ! src/cpu/aarch64/vm/cppInterpreterGenerator_aarch64.hpp ! src/cpu/aarch64/vm/interp_masm_aarch64.cpp ! src/cpu/aarch64/vm/macroAssembler_aarch64.hpp ! src/cpu/aarch64/vm/macroAssembler_aarch64.inline.hpp ! src/cpu/aarch64/vm/methodHandles_aarch64.cpp ! src/cpu/aarch64/vm/nativeInst_aarch64.cpp ! src/cpu/aarch64/vm/nativeInst_aarch64.hpp ! src/cpu/aarch64/vm/register_aarch64.hpp ! src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp ! src/cpu/aarch64/vm/stubGenerator_aarch64.cpp Changeset: aaf6ac661162 Author: aph Date: 2014-07-29 06:00 -0400 URL: http://hg.openjdk.java.net/aarch64-port/jdk9/hotspot/rev/aaf6ac661162 Define uabs(). Use it everywhere an absolute value is wanted. ! src/cpu/aarch64/vm/assembler_aarch64.cpp ! src/cpu/aarch64/vm/assembler_aarch64.hpp ! src/cpu/aarch64/vm/macroAssembler_aarch64.cpp ! src/cpu/aarch64/vm/stubGenerator_aarch64.cpp Changeset: d2f9c971fef8 Author: aph Date: 2014-07-29 12:53 -0400 URL: http://hg.openjdk.java.net/aarch64-port/jdk9/hotspot/rev/d2f9c971fef8 Re-add this file. + src/cpu/aarch64/vm/c1_LinearScan_aarch64.cpp Changeset: 53b2f147e42b Author: aph Date: 2014-07-29 12:54 -0400 URL: http://hg.openjdk.java.net/aarch64-port/jdk9/hotspot/rev/53b2f147e42b Temporary patch to disable warnings when optimization is off. ! make/linux/makefiles/gcc.make Changeset: fee71cc4c9cf Author: aph Date: 2014-07-29 14:00 -0400 URL: http://hg.openjdk.java.net/aarch64-port/jdk9/hotspot/rev/fee71cc4c9cf Merge ! src/cpu/aarch64/vm/assembler_aarch64.cpp ! src/cpu/aarch64/vm/assembler_aarch64.hpp ! src/cpu/aarch64/vm/macroAssembler_aarch64.cpp ! src/cpu/aarch64/vm/macroAssembler_aarch64.hpp ! src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp ! src/cpu/aarch64/vm/stubGenerator_aarch64.cpp

1 0

JDK9: Temporary patch to disable warnings when optimization is off
by Andrew Haley 29 Jul '14

29 Jul '14

JDK9 won't build right now; this just gets it going again. Waiting for a better patch from upstream, when we can pull this out. Andrew. # HG changeset patch # User aph # Date 1406652852 14400 # Tue Jul 29 12:54:12 2014 -0400 # Node ID 53b2f147e42b4eb968461ebb653880f86cf91500 # Parent d2f9c971fef82904215abb1455404604bd76feca Temporary patch to disable warnings when optimization is off. diff -r d2f9c971fef8 -r 53b2f147e42b make/linux/makefiles/gcc.make --- a/make/linux/makefiles/gcc.make Tue Jul 29 12:53:13 2014 -0400 +++ b/make/linux/makefiles/gcc.make Tue Jul 29 12:54:12 2014 -0400 @@ -231,8 +231,8 @@ CFLAGS_WARN/BYFILE = $(CFLAGS_WARN/$@)$(CFLAGS_WARN/DEFAULT$(CFLAGS_WARN/$@)) # optimization control flags (Used by fastdebug and release variants) -OPT_CFLAGS/NOOPT=-O0 -OPT_CFLAGS/DEBUG=-O0 +OPT_CFLAGS/NOOPT=-O0 -Wno-error=cpp +OPT_CFLAGS/DEBUG=-O0 -Wno-error=cpp OPT_CFLAGS/SIZE=-Os OPT_CFLAGS/SPEED=-O3 @@ -340,7 +340,7 @@ endif # Allow no optimizations. -DEBUG_CFLAGS=-O0 +DEBUG_CFLAGS=-O0 -Wno-error=cpp # DEBUG_BINARIES uses full -g debug information for all configs ifeq ($(DEBUG_BINARIES), true)

1 0

hg: aarch64-port/jdk7u/hotspot: Replace hotspot jtreg test suite with tests from jdk7u
by ed＠camswl.com 29 Jul '14

29 Jul '14

Changeset: c05f1aa9f822 Author: Edward Nevill edward.nevill(a)linaro.org Date: 2014-07-29 14:57 +0100 URL: http://hg.openjdk.java.net/aarch64-port/jdk7u/hotspot/rev/c05f1aa9f822 Replace hotspot jtreg test suite with tests from jdk7u ! test/Makefile ! test/TEST.ROOT - test/TEST.groups - test/aarch64/DoubleArithTests.java - test/aarch64/DoubleCmpTests.java - test/aarch64/FloatArithTests.java - test/aarch64/FloatCmpTests.java - test/aarch64/IntArithTests.java - test/aarch64/IntCmpTests.java - test/aarch64/IntLogicTests.java - test/aarch64/IntShiftTests.java - test/aarch64/LongArithTests.java - test/aarch64/LongCmpTests.java - test/aarch64/LongLogicTests.java - test/aarch64/LongShiftTests.java ! test/compiler/5091921/Test7005594.sh ! test/compiler/6431242/Test.java ! test/compiler/6589834/Test_ia32.java ! test/compiler/6636138/Test1.java ! test/compiler/6636138/Test2.java + test/compiler/6653795/UnsafeGetAddressTest.java ! test/compiler/6795161/Test.java ! test/compiler/6857159/Test6857159.sh ! test/compiler/6859338/Test6859338.java - test/compiler/6896617/Test6896617.java - test/compiler/6934604/TestByteBoxing.java - test/compiler/6934604/TestDoubleBoxing.java - test/compiler/6934604/TestFloatBoxing.java - test/compiler/6934604/TestIntBoxing.java - test/compiler/6934604/TestLongBoxing.java - test/compiler/6934604/TestShortBoxing.java ! test/compiler/7068051/Test7068051.sh ! test/compiler/7070134/Test7070134.sh - test/compiler/7088419/CRCTest.java ! test/compiler/7116216/StackOverflow.java ! test/compiler/7141637/SpreadNullArg.java + test/compiler/7158807/Test7158807.java ! test/compiler/7200264/Test7200264.sh ! test/compiler/8000805/Test8000805.java ! test/compiler/8005419/Test8005419.java - test/compiler/8011706/Test8011706.java - test/compiler/8011771/Test8011771.java - test/compiler/8011901/Test8011901.java - test/compiler/8015436/Test8015436.java - test/compiler/ciReplay/TestSA.sh - test/compiler/ciReplay/TestVM.sh - test/compiler/ciReplay/TestVM_no_comp_level.sh - test/compiler/ciReplay/common.sh - test/compiler/codecache/CheckReservedInitialCodeCacheSizeArgOrder.java - test/compiler/codecache/CheckUpperLimit.java - test/compiler/inlining/DefaultAndConcreteMethodsCHA.java - test/compiler/inlining/InlineDefaultMethod.java - test/compiler/inlining/InlineDefaultMethod1.java + test/compiler/intrinsics/hashcode/TestHashCode.java - test/compiler/intrinsics/mathexact/AddExactICondTest.java - test/compiler/intrinsics/mathexact/AddExactIConstantTest.java - test/compiler/intrinsics/mathexact/AddExactILoadTest.java - test/compiler/intrinsics/mathexact/AddExactILoopDependentTest.java - test/compiler/intrinsics/mathexact/AddExactINonConstantTest.java - test/compiler/intrinsics/mathexact/AddExactIRepeatTest.java - test/compiler/intrinsics/mathexact/AddExactLConstantTest.java - test/compiler/intrinsics/mathexact/AddExactLNonConstantTest.java - test/compiler/intrinsics/mathexact/CompareTest.java - test/compiler/intrinsics/mathexact/DecExactITest.java - test/compiler/intrinsics/mathexact/DecExactLTest.java - test/compiler/intrinsics/mathexact/GVNTest.java - test/compiler/intrinsics/mathexact/IncExactITest.java - test/compiler/intrinsics/mathexact/IncExactLTest.java - test/compiler/intrinsics/mathexact/MulExactICondTest.java - test/compiler/intrinsics/mathexact/MulExactIConstantTest.java - test/compiler/intrinsics/mathexact/MulExactILoadTest.java - test/compiler/intrinsics/mathexact/MulExactILoopDependentTest.java - test/compiler/intrinsics/mathexact/MulExactINonConstantTest.java - test/compiler/intrinsics/mathexact/MulExactIRepeatTest.java - test/compiler/intrinsics/mathexact/MulExactLConstantTest.java - test/compiler/intrinsics/mathexact/MulExactLNonConstantTest.java - test/compiler/intrinsics/mathexact/NegExactIConstantTest.java - test/compiler/intrinsics/mathexact/NegExactILoadTest.java - test/compiler/intrinsics/mathexact/NegExactILoopDependentTest.java - test/compiler/intrinsics/mathexact/NegExactINonConstantTest.java - test/compiler/intrinsics/mathexact/NegExactLConstantTest.java - test/compiler/intrinsics/mathexact/NegExactLNonConstantTest.java - test/compiler/intrinsics/mathexact/NestedMathExactTest.java - test/compiler/intrinsics/mathexact/SplitThruPhiTest.java - test/compiler/intrinsics/mathexact/SubExactICondTest.java - test/compiler/intrinsics/mathexact/SubExactIConstantTest.java - test/compiler/intrinsics/mathexact/SubExactILoadTest.java - test/compiler/intrinsics/mathexact/SubExactILoopDependentTest.java - test/compiler/intrinsics/mathexact/SubExactINonConstantTest.java - test/compiler/intrinsics/mathexact/SubExactIRepeatTest.java - test/compiler/intrinsics/mathexact/SubExactLConstantTest.java - test/compiler/intrinsics/mathexact/SubExactLNonConstantTest.java - test/compiler/intrinsics/mathexact/Verify.java - test/compiler/intrinsics/stringequals/TestStringEqualsBadLength.java - test/compiler/jsr292/ConcurrentClassLoadingTest.java - test/compiler/jsr292/CreatesInterfaceDotEqualsCallInfo.java - test/compiler/jsr292/createsInterfaceDotEqualsCallInfo.js - test/compiler/jsr292/methodHandleExceptions/ByteClassLoader.java - test/compiler/jsr292/methodHandleExceptions/TestAMEnotNPE.java - test/compiler/jsr292/methodHandleExceptions/p/C.java - test/compiler/jsr292/methodHandleExceptions/p/Dok.java - test/compiler/jsr292/methodHandleExceptions/p/E.java - test/compiler/jsr292/methodHandleExceptions/p/F.java - test/compiler/jsr292/methodHandleExceptions/p/I.java - test/compiler/jsr292/methodHandleExceptions/p/Tdirect.java - test/compiler/jsr292/methodHandleExceptions/p/Treflect.java - test/compiler/profiling/TestUnexpectedProfilingMismatch.java - test/compiler/profiling/unloadingconflict/B.java - test/compiler/profiling/unloadingconflict/TestProfileConflictClassUnloading.java ! test/compiler/regalloc/C1ObjectSpillInLogicOp.java - test/compiler/startup/SmallCodeCacheStartup.java - test/compiler/startup/StartupOutput.java - test/compiler/tiered/CompLevelsTest.java - test/compiler/tiered/NonTieredLevelsTest.java - test/compiler/tiered/TieredLevelsTest.java - test/compiler/types/TypeSpeculation.java - test/compiler/uncommontrap/StackOverflowGuardPagesOff.java - test/compiler/uncommontrap/TestStackBangRbp.java - test/compiler/uncommontrap/UncommonTrapStackBang.java - test/compiler/unsafe/GetUnsafeObjectG1PreBarrier.java - test/compiler/whitebox/ClearMethodStateTest.java - test/compiler/whitebox/CompilerWhiteBoxTest.java - test/compiler/whitebox/DeoptimizeAllTest.java - test/compiler/whitebox/DeoptimizeMethodTest.java - test/compiler/whitebox/EnqueueMethodForCompilationTest.java - test/compiler/whitebox/IsMethodCompilableTest.java - test/compiler/whitebox/MakeMethodNotCompilableTest.java - test/compiler/whitebox/SetDontInlineMethodTest.java - test/compiler/whitebox/SetForceInlineMethodTest.java - test/gc/6941923/Test6941923.java + test/gc/6941923/test6941923.sh - test/gc/TestG1ZeroPGCTJcmdThreadPrint.java - test/gc/TestObjectAlignment.java - test/gc/TestSystemGC.java ! test/gc/TestVerifyDuringStartup.java + test/gc/TestVerifySilently.java - test/gc/arguments/TestAlignmentToUseLargePages.java - test/gc/arguments/TestCMSHeapSizeFlags.java - test/gc/arguments/TestCompressedClassFlags.java + test/gc/arguments/TestDynMaxHeapFreeRatio.java + test/gc/arguments/TestDynMinHeapFreeRatio.java - test/gc/arguments/TestG1HeapRegionSize.java - test/gc/arguments/TestG1HeapSizeFlags.java - test/gc/arguments/TestHeapFreeRatio.java - test/gc/arguments/TestInitialTenuringThreshold.java - test/gc/arguments/TestMaxHeapSizeTools.java - test/gc/arguments/TestMaxNewSize.java - test/gc/arguments/TestMinInitialErgonomics.java - test/gc/arguments/TestParallelHeapSizeFlags.java - test/gc/arguments/TestSerialHeapSizeFlags.java - test/gc/arguments/TestUnrecognizedVMOptionsHandling.java - test/gc/arguments/TestUseCompressedOopsErgo.java - test/gc/arguments/TestUseCompressedOopsErgoTools.java - test/gc/concurrentMarkSweep/CheckAllocateAndSystemGC.java - test/gc/concurrentMarkSweep/GuardShrinkWarning.java - test/gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java - test/gc/g1/TestHumongousAllocInitialMark.java - test/gc/g1/TestShrinkToOneRegion.java + test/gc/heap_inspection/TestG1ConcurrentGCHeapDump.java + test/gc/heap_inspection/TestPrintClassHistogram.java + test/gc/init/TestHandleExceedingProcessSizeLimitIn32BitBuilds.java - test/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java - test/gc/metaspace/G1AddMetaspaceDependency.java - test/gc/metaspace/TestMetaspaceMemoryPool.java - test/gc/metaspace/TestMetaspacePerfCounters.java - test/gc/metaspace/TestMetaspaceSizeFlags.java - test/gc/metaspace/TestPerfCountersAndMemoryPools.java - test/gc/parallelScavenge/AdaptiveGCBoundary.java - test/gc/startup_warnings/TestCMS.java - test/gc/startup_warnings/TestCMSForegroundFlags.java - test/gc/startup_warnings/TestCMSIncrementalMode.java - test/gc/startup_warnings/TestCMSNoIncrementalMode.java - test/gc/startup_warnings/TestDefNewCMS.java - test/gc/startup_warnings/TestDefaultMaxRAMFraction.java - test/gc/startup_warnings/TestG1.java - test/gc/startup_warnings/TestIncGC.java - test/gc/startup_warnings/TestParNewCMS.java - test/gc/startup_warnings/TestParNewSerialOld.java - test/gc/startup_warnings/TestParallelGC.java - test/gc/startup_warnings/TestParallelScavengeSerialOld.java - test/gc/startup_warnings/TestSerialGC.java ! test/runtime/6626217/Test6626217.sh + test/runtime/6878713/Test6878713.sh + test/runtime/6878713/testcase.jar ! test/runtime/6888954/vmerrors.sh ! test/runtime/6929067/Test6929067.sh + test/runtime/7020373/Test7020373.sh + test/runtime/7020373/testcase.jar ! test/runtime/7107135/Test7107135.sh ! test/runtime/7110720/Test7110720.sh + test/runtime/7158804/Test7158804.sh ! test/runtime/7162488/Test7162488.sh - test/runtime/7194254/Test7194254.java - test/runtime/8001071/Test8001071.java - test/runtime/8001071/Test8001071.sh - test/runtime/8003720/Asmator.java - test/runtime/8003720/Test8003720.java - test/runtime/8003720/Victim.java - test/runtime/8003720/VictimClassLoader.java - test/runtime/8007320/ConstMethodTest.java - test/runtime/8007475/StackMapFrameTest.java - test/runtime/8024804/RegisterNatives.java - test/runtime/8026365/InvokeSpecialAnonTest.java - test/runtime/8026394/InterfaceObjectTest.java - test/runtime/CDSCompressedKPtrs/CDSCompressedKPtrs.java - test/runtime/CDSCompressedKPtrs/CDSCompressedKPtrsError.java - test/runtime/CDSCompressedKPtrs/XShareAuto.java - test/runtime/ClassFile/JsrRewriting.java - test/runtime/ClassFile/JsrRewritingTestCase.jar - test/runtime/ClassFile/OomWhileParsingRepeatedJsr.java - test/runtime/ClassFile/testcase.jar - test/runtime/ClassUnload/KeepAliveClass.java - test/runtime/ClassUnload/KeepAliveClassLoader.java - test/runtime/ClassUnload/KeepAliveObject.java - test/runtime/ClassUnload/KeepAliveSoftReference.java - test/runtime/ClassUnload/UnloadTest.java - test/runtime/ClassUnload/classes/test/Empty.java - test/runtime/CommandLine/BooleanFlagWithInvalidValue.java - test/runtime/CommandLine/ConfigFileParsing.java - test/runtime/CommandLine/FlagWithInvalidValue.java - test/runtime/CommandLine/NonBooleanFlagWithInvalidBooleanPrefix.java - test/runtime/CommandLine/PrintGCApplicationConcurrentTime.java - test/runtime/CommandLine/UnrecognizedVMOption.java - test/runtime/CompressedOops/CompressedClassPointers.java - test/runtime/CompressedOops/CompressedKlassPointerAndOops.java - test/runtime/InitialThreadOverflow/DoOverflow.java - test/runtime/InitialThreadOverflow/invoke.cxx - test/runtime/InitialThreadOverflow/testme.sh - test/runtime/InternalApi/ThreadCpuTimesDeadlock.java - test/runtime/LoadClass/LoadClassNegative.java - test/runtime/LoadClass/TestForName.java - test/runtime/LoadClass/dummy.jar - test/runtime/Metaspace/FragmentMetaspace.java - test/runtime/Metaspace/FragmentMetaspaceSimple.java - test/runtime/Metaspace/classes/test/Empty.java ! test/runtime/NMT/ThreadedVirtualAllocTestType.java ! test/runtime/NMT/VirtualAllocTestType.java - test/runtime/RedefineObject/Agent.java - test/runtime/RedefineObject/TestRedefineObject.java - test/runtime/RedefineObject/WalkThroughInvoke.java - test/runtime/SharedArchiveFile/CdsDifferentObjectAlignment.java - test/runtime/SharedArchiveFile/CdsSameObjectAlignment.java - test/runtime/SharedArchiveFile/SharedArchiveFile.java ! test/runtime/XCheckJniJsig/XCheckJSig.java - test/runtime/contended/Basic.java - test/runtime/contended/DefaultValue.java - test/runtime/contended/HasNonStatic.java - test/runtime/contended/Inheritance1.java - test/runtime/contended/OopMaps.java - test/runtime/contended/Options.java - test/runtime/interned/SanityTest.java ! test/runtime/jsig/Test8017498.sh - test/runtime/lambda-features/PublicStaticInterfaceMethodHandling.java - test/runtime/memory/MultiAllocateNullCheck.java - test/runtime/memory/ReadFromNoaccessArea.java - test/runtime/memory/ReserveMemory.java - test/runtime/memory/RunUnitTestsConcurrently.java - test/runtime/memory/StressVirtualSpaceResize.java - test/runtime/testlibrary/ClassUnloadCommon.java - test/runtime/testlibrary/GeneratedClassLoader.java - test/sanity/ExecuteInternalVMTests.java ! test/sanity/WBApi.java - test/sanity/WhiteBox.java ! test/serviceability/ParserTest.java + test/serviceability/sa/jmap-hashcode/Test8028623.java - test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapProc.java - test/serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java - test/serviceability/threads/TestFalseDeadLock.java + test/testlibrary/com/oracle/java/testlibrary/DynamicVMOptionChecker.java + test/testlibrary/com/oracle/java/testlibrary/TestDynamicVMOption.java - test/testlibrary/ctw/Makefile - test/testlibrary/ctw/README - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathDirEntry.java - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJarEntry.java - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassPathJarInDirEntry.java - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/ClassesListInFile.java - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/CompileTheWorld.java - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/Compiler.java - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/PathHandler.java - test/testlibrary/ctw/src/sun/hotspot/tools/ctw/Utils.java - test/testlibrary/ctw/test/Bar.java - test/testlibrary/ctw/test/ClassesDirTest.java - test/testlibrary/ctw/test/ClassesListTest.java - test/testlibrary/ctw/test/CtwTest.java - test/testlibrary/ctw/test/Foo.java - test/testlibrary/ctw/test/JarDirTest.java - test/testlibrary/ctw/test/JarsTest.java - test/testlibrary/ctw/test/classes.lst - test/testlibrary/whitebox/Makefile - test/testlibrary/whitebox/sun/hotspot/WhiteBox.java - test/testlibrary/whitebox/sun/hotspot/parser/DiagnosticCommand.java

1 0

RFR: jdk7: Replace hotspot jtreg test suite
by Edward Nevill 29 Jul '14

29 Jul '14

Hi, The linked patch replaces the existing jtreg test suite in jtreg/hotspot, with the jtreg test suite from the jdk7u tip. I have gone through the failures and fixed tests which were obviously broken (eg. -m64 on gcc command line, incorrect options on jmap, undefined symbols on link etc). The following are the results I get now. Test results: passed: 286; failed: 2 The 2 failures are FAILED: gc/arguments/TestDynMaxHeapFreeRatio.java FAILED: gc/arguments/TestDynMinHeapFreeRatio.java Note that in order to run the tests you must specify -timeout:3 as some of the tests take longer than the standard 2 minutes (this is true on x86 as well). OK to push? Ed. Link here http://people.linaro.org/~edward.nevill/patches/jdk7u_jtreg.patch

2 1

hg: aarch64-port/jdk8/hotspot: Define uabs(). Use it everywhere an absolute value is wanted.
by aph＠redhat.com 29 Jul '14

29 Jul '14

Changeset: 5e238903a875 Author: aph Date: 2014-07-29 06:00 -0400 URL: http://hg.openjdk.java.net/aarch64-port/jdk8/hotspot/rev/5e238903a875 Define uabs(). Use it everywhere an absolute value is wanted. ! src/cpu/aarch64/vm/assembler_aarch64.cpp ! src/cpu/aarch64/vm/assembler_aarch64.hpp ! src/cpu/aarch64/vm/macroAssembler_aarch64.cpp ! src/cpu/aarch64/vm/stubGenerator_aarch64.cpp

1 0