October 2016 - aarch64-port-dev

RFR: AArch64: -XX:-UseOnStackReplacement does not work together with -XX:+TieredCompilation.
by Ningsheng Jian 21 Feb '17

21 Feb '17

Hi, Hotspot patch [1] introduces a test case hotspot/test/compiler/interpreter/DisableOSRTest.java which also exposes the same issue on aarch64. I.e. with -XX:-UseOnStackReplacement and -XX:+TieredCompilation options, there are still OSR compilations found from -XX:+PrintCompilation. On x86, the increment_mask_and_jump just jumps to the next instruction if backedge_counter_overflow is not generated. So there is no such issue - but is it intended? The following fix on AArch64 is to revert [2] to align with x86 code and assign the correct branch target based on the UseOnStackReplacement option. http://people.linaro.org/~ningsheng.jian/disable-osr/webrev.00/ Tested with jtreg. [1] http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/fd222df9f27c [2] http://hg.openjdk.java.net/aarch64-port/jdk8/hotspot/rev/18e5cbbe8abf

2 3

Fwd: Compact strings enablement - JTreg runs
by Stuart Monteith 30 Jan '17

30 Jan '17

Hello, I sent this to the wrong address by accident, and it hadn't bounced - the autocorrect kicked in this time. With a view to enable compact strings by default, I've run JTreg against a build from yesterday with "-XX:-CompactStrings" and "-XX:+CompactStrings". I get the following differences: 0: JTwork-compactoff pass: 5,840; fail: 1,793; error: 21; not run: 331 1: JTwork-compacton pass: 5,836; fail: 1,793; error: 25; not run: 331 0 1 Test fail pass com/sun/jdi/InterruptHangTest.java pass error java/awt/Dialog/CloseDialog/CloseDialogTest.java fail pass java/awt/Graphics2D/DrawString/DrawStringCrash.java pass error java/lang/instrument/PremainClass/NoPremainAgentTest.java pass fail java/rmi/activation/Activatable/restartCrashedService/RestartCrashedService.java pass fail java/rmi/server/RMISocketFactory/useSocketFactory/unicast/UseCustomSocketFactory.java error pass java/util/ResourceBundle/modules/visibility/visibility.sh pass fail java/util/concurrent/tck/JSR166TestCase.java pass error java/util/stream/boottest/java.base/java/util/stream/SpinedBufferTest.java fail pass java/util/zip/EntryCount64k.java pass error sun/security/provider/SecureRandom/StrongSecureRandom.java pass error tools/launcher/ArgFileSyntax.java 12 differences Ideally there would be 0 failures and errors in both, but I'll check to see what the differences were. Some of the names are suspicious, others - such as concurrency tests - look like they have the potential to have issues. AFAICT, this is the only changed needed to make compact strings the default: hotspot/src/cpu/aarch64/vm/globals_aarch64.hpp -- define_pd_global(bool, CompactStrings, false); ++ define_pd_global(bool, CompactStrings, true); hasNegatives - please find attached my most recent results with my hasNegatives intrinsic. The vertical axis is time (logarithmic) -lower is better. The horizontal axis is the number of characters scanned before has_negatives returns true. I'm trying to even-out the middle to lower side of the graph, as I expect has_negatives will trip either early, or late. Regards, Stuart

3 16

RFR: Backport patch for 8165673 to aarch64/jdk8u
by Felix Yang 09 Jan '17

09 Jan '17

Hi, I see the same issue (8165673) for aarch64/jdk8u repo, and I am trying to backport this patch: # HG changeset patch # User adinn # Date 1474964726 -3600 # Tue Sep 27 09:25:26 2016 +0100 # Node ID f96dfffcb4148c3615826adda611e80fe1c264f9 # Parent 2765f61021270b8e5d2954eb81b33e8311332f62 8165673: AArch64: Fix JNI floating point argument handling Reviewed-by: aph, adinn Contributed-by: ningsheng.jian(a)linaro.org Here are the link to the original jdk9 patch: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/9cc82b204d20 The backport patch with some adaptations for the test case: http://cr.openjdk.java.net/~fyang/8165673-backport/webrev.01/ Tested with Jtreg using an aarch64 server build. OK to backport? As I don't have write permission of the icedtea branch ( http://icedtea.classpath.org/hg/icedtea7-forest/hotspot/) can someone do a backport for it please? Thanks for your help, Felix

4 6

RFR: 8168909 aarch3264: arm32/64 port contribution cleanups
by Bob Vandette 22 Nov '16

22 Nov '16

Please review these cleanups of the contributed ARM code. Let me know what you think of the proposed new configure option for selecting the 64-bit aarch64 port sources. http://cr.openjdk.java.net/~bobv/8168909/webrev <http://cr.openjdk.java.net/~bobv/8168909/webrev> Here’s what is changed: 1. Remove additional support for the no longer supported regenerated interpreter. 2. Change the configure flag used to select arm or aarch64 hotspot directory to --with-cpu-port 3. Changes to arm sources required due to last merge. Changes made in closed files need to be applied to new open files. Bob.

3 3

JEP to add Oracle arm32/arm64 port to JDK 9
by Edward Nevill 24 Oct '16

24 Oct '16

Hi, I have submitted the following JEP to add the Oracle contributed arm32/arm64 port to JDK 9. https://bugs.openjdk.java.net/browse/JDK-8168503 I have filed this with the jdk9-fc-request label and sent a copy to jep-submit(a)openjdk.java.net. Please feel free to comment either on the list, or on the JBS issue above, All the best, Ed.

2 1

RFR: 8168567 - Fix for 81666972 (not 8160376) breaks aarch64 build
by White, Derek 24 Oct '16

24 Oct '16

Please review simple fix to repair aarch64 build. BUG: JDK-8168567 (https://bugs.openjdk.java.net/browse/JDK-8168567) Webrev: http://cr.openjdk.java.net/~drwhite/8168567/webrev.01 Built on aarch64, smoketested. Thanks - Derek

2 2

FYI - Fix for 8160376 broke aarch64.
by White, Derek 24 Oct '16

24 Oct '16

There's an un-terminated #ifdef See changeset at http://hg.openjdk.java.net/jdk9/hs/hotspot/comparison/ad402ced3a63/src/cpu/… I actually can't see a review request for this change anywhere, but I may have missed it. But there could be a process error here. Although I appreciate people trying to keep aarch64 up to date in the face of shared changes, it's important that we (aarch64 folks) get to see these changes before they go in. I've added new bug JDK-8168567<https://bugs.openjdk.java.net/browse/JDK-8168567>. I'm happy to fix it, unless someone else can get checkin faster than I can.... - Derek

2 3

Fireside chat notes
by Edward Nevill 21 Oct '16

21 Oct '16

Hi, The following are some notes from the fireside chat earlier today. Two items were discussed - The Oracle arm32/arm64 contribution All present were generally in agreement with the outline proposed by Ed Nevill on the list (http://mail.openjdk.java.net/pipermail/aarch32-port-dev/2016-October/000532…) It was proposed that Ed Nevill should submit a JEP to merge the arm32/arm64 contribution into JDK 9. An FC exemption will be requested to target JDK 9. - The Huawei softfp contribution There are currently two conflicting softfp implementations for JDK 8 on aarch32, one from Huawei, one from Azul (plus a third implementation for JDK 9 as part of the Oracle arm32/arm64 contribution). It was proposed that we wait until the complete contributions targeting C1 are available before deciding what to do next. I propose we have the next fireside chat on Thurs 3rd Nov at 15:00 UTC. Stuart, if you could set up the conference call. All the best, Ed.

2 1

Reminder: Fireside chat
by Edward Nevill 21 Oct '16

21 Oct '16

[cross posted to aarch32-port-dev] Hi, Just a reminder about the fireside chat at 1500 UTC today. If you are using the bluejeans video conferencing for the first time you may wish to try the link AOT as it has to download a plugin first time you use it (plugin works on Linux or Windows). Alternatively you can dial in. All the best, Ed. On Tue, Oct 18, 2016 at 2:28 PM, Stuart Monteith <stuart.monteith(a)linaro.org > wrote: > Hello, > This week we'll be having a fireside chat on Friday at 1500 UTC, > 1600 BST, 1100 EDT. I might not be joining, but that is not required > for the chat to start. > > In order to join in, please join the chat at Bluejeans here: > https://bluejeans.com/387542473 > > Alternatively you may dial in using one of the following numbers > > http://bluejeans.com/numbers > > and enter the Meeting ID: 387542473 > > Please do not use any of the 'freefone' numbers, because although they > may be free for you they cost us $$$$. > > Best Regards, > Stuart >

1 0

[RFR] u111 Update
by Andrew Hughes 19 Oct '16

19 Oct '16

Hi, OpenJDK 8 was recently updated with a security update, u111. Here is the corresponding update for aarch64/jdk8u, aarch64-jdk8u111-b16 (aarch64-jdk8u111-b14 was the first attempt, but we had to make two subsequent revisions, first to include 8160591 support for AArch64, and a second due to a confusing patch from Oracle) http://cr.openjdk.java.net/~andrew/aarch64-8/u111/webrev.01/ Ok to push? Changes: - S6882559: new JEditorPane("text/plain","") fails for null context class loader - S8049171: Additional tests for jarsigner's warnings - S8140530: Creating a VolatileImage with size 0,0 results in no longer working g2d.drawString - S8142926: OutputAnalyzer's shouldXXX() calls return this - S8146490: Direct indirect CRL checks - S8147077: IllegalArgumentException thrown by api/java_awt/Component/FlipBufferStrategy/indexTGF_General - S8148127: IllegalArgumentException thrown by JCK test api/java_awt/Component/FlipBufferStrategy/indexTGF_General in opengl pipeline - S8150611: Security problem on sun.misc.resources.Messages* - S8151921: Improved page resolution - S8155968: Update command line options - S8155973, CVE-2016-5542: Tighten jar checks - S8156794: Extend data sharing - S8157176: Improved classfile parsing - S8157306: Random infrequent null pointer exceptions in javac - S8157653: [Parfait] Uninitialised variable in awt_Font.cpp - S8157739, CVE-2016-5554: Classloader Consistency Checking - S8157749: Improve handling of DNS error replies - S8157753: Audio replay enhancement - S8157759: LCMS Transform Sampling Enhancement - S8157764: Better handling of interpolation plugins - S8158302: Handle contextual glyph substitutions - S8158734: JEditorPane.createEditorKitForContentType throws NPE after 6882559 - S8158993, CVE-2016-5568: Service Menu services - S8159495: Fix index offsets - S8159503: Amend Annotation Actions - S8159511: Stack map validation - S8159515: Improve indy validation - S8159519, CVE-2016-5573: Reformat JDWP messages - S8159684: (tz) Support tzdata2016f - S8160090: Better signature handling in pack200 - S8160094: Improve pack200 layout - S8160098: Clean up color profiles - S8160591, CVE-2016-5582: Improve internal array handling - S8160838, CVE-2016-5573: Better HTTP service - S8160904: Typo in code from 8079718 fix : enableCustomValueHanlde - S8160934: isnan() is not available on older MSVC compilers - S8161141: correct bugId for JDK-8158994 fix push - S8162411: Service Menu services 2 - S8162419: closed/com/oracle/jfr/runtime/TestVMInfoEvent.sh failing after JDK-8155968 - S8162511: 8u111 L10n resource file updates - S8162792: Remove constraint DSA keySize < 1024 from jdk.jar.disabledAlgorithms in jdk8 - S8164452: 8u111 L10n resource file update - msgdrop 20 - S8165816: jarsigner -verify shows jar unsigned if it was signed with a weak algorithm - S8166381: Back out changes to the java.security file to not disable MD5 Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222

2 2