April 2016 - aarch64-port-dev

[PATCH] [jdk8u] Remove unused template which breaks builds with GCC 6
by Andrew Hughes 15 May '16

15 May '16

Webrev: http://cr.openjdk.java.net/~andrew/aarch64-8/gcc6/webrev.01/ The min template: template <class T> static const T& min (const T& a, const T& b) causes the build to fail with GCC 6 [0], where the default C++ standard (-std=gnu++98) has to be explicitly specified, as the default has changed. /builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-5.b15.fc24.aarch64/openjdk/hotspot/src/share/vm/utilities/globalDefinitions.hpp:1113:18: warning: variable templates only available with -std=c++14 or -std=gnu++14 #define min(a,b) Do_not_use_min_use_MIN2_instead ^ /builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-5.b15.fc24.aarch64/openjdk/hotspot/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp:197:36: note: in expansion of macro 'min' template <class T> static const T& min (const T& a, const T& b) { ^~~ /builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-5.b15.fc24.aarch64/openjdk/hotspot/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp:198:3: error: expected ';' before 'return' return (a > b) ? b : a; ^~~~~~ /builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-5.b15.fc24.aarch64/openjdk/hotspot/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp:199:1: error: expected declaration before '}' token } ^ The template appears to be unused and removing it allows the build to succeed with GCC 6. Ok to push? [0] https://bugzilla.redhat.com/show_bug.cgi?id=1307224#c1 -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222

3 9

Initial import from shenandoah/jdk8u/hotspot
by Roman Kennke 11 May '16

11 May '16

Hi there, I would like to push the initial import of Shenandoah code from http://hg.openjdk.java.net/shenandoah/jdk8u/hotspot I uplaoded a summary of all the changesets that would get pushed to: http://cr.openjdk.java.net/~rkennke/jdk8u-aarch64-shenandoah-changsets. txt Unfortunately, webrev doesn't seem to work well with many changesets like this. It can do it, but it ain't pretty :-) http://cr.openjdk.java.net/~rkennke/jdk8u-aarch64-shenandoah/webrev.00/ (still uploading as I write this, it might take a while to complete...) Unfortunately this includes some stuff from http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot that is not in aarch64-port yet. In particular, that's everything between jdk8u71-b15 (the point where aarch64-port/jdk8u is) up to jdk8u82-b00 (the point where shenandoah/jdk8u is). Upstream is currently at jdk8u102-b03, so we might want to bring both aarch64- port/jdk8u and shenandoah/jdk8u up to that first? Roman

2 1

RFR(XS): 8155717: Aarch64: enable loop superword's unrolling analysis
by Roland Westrelin 04 May '16

04 May '16

http://cr.openjdk.java.net/~roland/8155717/webrev.00/ Loop unrolling analysis can help on arm for smaller data types (bytes). For other data types, it drives more inlining which can also be beneficial. This also includes the change Michael ok'ed to shared code. Roland.

3 4

8u backport: 8155612: Aarch64: vector nodes need to support misaligned offset
by Roland Westrelin 04 May '16

04 May '16

I'd like to backport 8155612 (and its companion 8155653) to 8u. Here are the changesets: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/9e21d8c18a7d http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/e118111d4433 Roland.

1 1

8155790: aarch64: debug VM fails to start after 8155617
by Edward Nevill 30 Apr '16

30 Apr '16

Hi, Please review the following webrev http://cr.openjdk.java.net/~enevill/8155790/ JIRA: https://bugs.openjdk.java.net/browse/JDK-8155790 This fixes an issue where the debug build fails to start after 8155617 with the error # Internal Error (/scratch/rwestrel/hs-comp/hotspot/src/share/vm/runtime/stubRoutines.cpp:344), pid=16911, tid=16912 # assert(s.body[i] == 32) failed: what? The problem is that I failed to observe that the base register must point immediately after the end of the block being zeroed on exit from the zero loop. In addition the base register can sometimes be byte aligned due to vectorisation and this was not handled. The above webrev fixes this. I have tested a debug build with jtreg hotspot and langtools. OK to push? Ed.

2 1

RFR: 8155617: aarch64: ClearArray does not use DC ZVA
by Edward Nevill 29 Apr '16

29 Apr '16

Hi, Please review the following webrev http://cr.openjdk.java.net/~enevill/8155617/bzero6 https://bugs.openjdk.java.net/browse/JDK-8155617 This is the bzero3 version previously discussed on the aarch64 list with the inner DC ZVA outlined. The outlining of the DC ZVA loop made no measurable difference to performance. I have also tuned the BlockZeroingLowLimit to default to 4 x cache line size rather than always defaulting to 256. Updated performance charts here:- http://cr.openjdk.java.net/~enevill/8155617/bzero6.pdf The chart show the performance improvement on 3 different partners HW. The benchmark was the following JHM test provided by Andrew Haley http://people.linaro.org/~edward.nevill/block_zero/ArrayFill.java The charts have been normalised so that the original jdk9 hs-comp tree is shown as 100%. The figures are % of original performance so lower is better. This is done to avoid disclosing absolute performance information on partner's HW. Orig: Original jdk9 hs-comp bzero6: jdk9 hs-comp with bzero6 Orig (no prf): Original jdk9 hs-comp (-XX:AllocatePrefetchStyle=0) bzero6 (no pref): jdk9 hs-comp with bzero6 (-XX:AllocatePrefetchStyle=0) There is significant interaction between prefetch and block zeroing as discussed previously. Some partners benefit from prefetch, others do not. The proposed patch does not change the behaviour of prefetch (ie. it leaves it enabled) as I think there should be a separate tuning exercise to tune prefetch for different partners HW. OK to push? Ed.

2 3

hg: aarch64-port/jdk8u-shenandoah/hotspot: Initial import of Shenandoah
by aph＠redhat.com 29 Apr '16

29 Apr '16

Changeset: 04726a0d70bb Author: rkennke Date: 2016-04-29 16:18 +0200 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/04726a… Initial import of Shenandoah ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/jniFastGetField_x86_64.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp + src/cpu/x86/vm/shenandoahBarrierSet_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/cpu/x86/vm/x86_64.ad ! src/os_cpu/linux_x86/vm/os_linux_x86.cpp ! src/share/vm/adlc/formssel.cpp ! src/share/vm/asm/assembler.cpp ! src/share/vm/c1/c1_LIR.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_LIRGenerator.hpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciObjectFactory.hpp ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/dictionary.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionBounds.inline.hpp ! src/share/vm/gc_implementation/g1/satbQueue.cpp ! src/share/vm/gc_implementation/g1/satbQueue.hpp ! src/share/vm/gc_implementation/shared/gcTrace.hpp + src/share/vm/gc_implementation/shenandoah/brooksPointer.cpp + src/share/vm/gc_implementation/shenandoah/brooksPointer.hpp + src/share/vm/gc_implementation/shenandoah/brooksPointer.inline.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSet.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSet.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahBarrierSet.inline.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahCollectionSet.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahCollectionSet.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahCollectorPolicy.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahCollectorPolicy.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentMark.inline.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentThread.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahConcurrentThread.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahFreeSet.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahFreeSet.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeap.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeap.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeap.inline.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegion.inline.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegionSet.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahHeapRegionSet.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahHumongous.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahJNICritical.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahJNICritical.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahMarkCompact.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahMarkCompact.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahMonitoringSupport.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahMonitoringSupport.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahOopClosures.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahOopClosures.inline.hpp + src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.cpp + src/share/vm/gc_implementation/shenandoah/shenandoahRootProcessor.hpp + src/share/vm/gc_implementation/shenandoah/shenandoah_globals.cpp + src/share/vm/gc_implementation/shenandoah/shenandoah_globals.hpp + src/share/vm/gc_implementation/shenandoah/shenandoah_specialized_oop_closures.hpp + src/share/vm/gc_implementation/shenandoah/vm_operations_shenandoah.cpp + src/share/vm/gc_implementation/shenandoah/vm_operations_shenandoah.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/gc_interface/gcCause.hpp ! src/share/vm/gc_interface/gcName.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/barrierSet.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/specialized_oop_closures.hpp ! src/share/vm/memory/threadLocalAllocBuffer.cpp ! src/share/vm/memory/threadLocalAllocBuffer.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceMirrorKlass.cpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/objArrayKlass.cpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/oops/oop.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/oops/typeArrayKlass.cpp ! src/share/vm/oops/typeArrayOop.hpp ! src/share/vm/opto/classes.cpp ! src/share/vm/opto/classes.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/ifg.cpp ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopPredicate.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/multnode.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp + src/share/vm/opto/shenandoahSupport.cpp + src/share/vm/opto/shenandoahSupport.hpp ! src/share/vm/opto/split_if.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/precompiled/precompiled.hpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnv.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/biasedLocking.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/globals.cpp ! src/share/vm/runtime/globals_extension.hpp ! src/share/vm/runtime/handles.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/jniHandles.cpp ! src/share/vm/runtime/jniHandles.hpp ! src/share/vm/runtime/mutexLocker.cpp ! src/share/vm/runtime/mutexLocker.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vm_operations.hpp ! src/share/vm/services/memoryManager.cpp ! src/share/vm/services/memoryManager.hpp ! src/share/vm/services/memoryPool.hpp ! src/share/vm/services/memoryService.cpp ! src/share/vm/services/memoryService.hpp ! src/share/vm/services/serviceUtil.hpp + src/share/vm/services/shenandoahMemoryPool.cpp + src/share/vm/services/shenandoahMemoryPool.hpp ! src/share/vm/services/threadService.cpp ! src/share/vm/utilities/growableArray.hpp ! src/share/vm/utilities/top.hpp

1 0

Shenandoah import (2nd attempt)
by Roman Kennke 29 Apr '16

29 Apr '16

So here's my second attempt at importing Shenandoah into the Aarch64- Shenandoah integration repository. Compared to the previous one, it adds some missing barriers that have been found by testing the old one, and it now comes as a single big patch. Webrev: http://cr.openjdk.java.net/~rkennke/jdk8u-aarch64-shenandoah/webrev.01/ (If it doesn't show up correctly, it means it hasn't completed uploading yet, just wait a little). Please review and commit if you find it ok. Roman

2 3

hg: aarch64-port/jdk8u/hotspot: 8155015: Aarch64: bad assert in spill generation code
by rwestrel＠redhat.com 28 Apr '16

28 Apr '16

Changeset: 5d6d52ede653 Author: roland Date: 2016-04-25 15:14 +0200 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/hotspot/rev/5d6d52ede653 8155015: Aarch64: bad assert in spill generation code Reviewed-by: thartmann ! src/cpu/aarch64/vm/aarch64.ad

1 0

8u backport: 8155015: Aarch64: bad assert in spill generation code
by Roland Westrelin 27 Apr '16

27 Apr '16

I'd like to backport 8155015 that I just pushed to 9: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/9fca65b0a9a1 Can I go ahead? Roland.

2 1