April 2016 - aarch64-port-dev

RFR(XS): 8155015: Aarch64: bad assert in spill generation code
by Roland Westrelin 27 Apr '16

27 Apr '16

http://cr.openjdk.java.net/~roland/8155015/webrev.00/ I hit that broken assert when doing some testing. Roland.

2 2

CFV: New aarch64-port Committer Felix Yang
by Edward Nevill 26 Apr '16

26 Apr '16

3 4

Re: [aarch64-port-dev ] aarch64: RFR: Block zeroing by 'DC ZVA'
by Andrew Haley 25 Apr '16

25 Apr '16

On 04/19/2016 01:54 PM, Long Chen wrote: > Thanks for all these nice comments. Here is a revised version: > > http://people.linaro.org/~long.chen/block_zeroing/block_zeroing.v02.patch > > > Changes: > > 1. Are DC and IC really synonyms? > > DC and IC assembling was supposed to be distinguished by different > cache_maintenance parameters. I create two enums ‘icache_maintanence’ and > ‘dcache_maintanence’ in the revised patch, to make it look better. > > + enum icache_maintenance {IVAU = 0b0101}; > + enum dcache_maintenance {CVAC = 0b1010, CVAU = 0b1011, CIVAC = 0b1110, > ZVA = 0b100}; > + void dc(dcache_maintenance cm, Register Rt) { > + sys(0b011, 0b0111, cm, 0b001, Rt); > + } > + > + void ic(icache_maintenance cm, Register Rt) { > + sys(0b011, 0b0111, cm, 0b001, Rt); > } That looks better, yes. > 5. To avoid scratching a new register, I write a small piece of code > after the dc zva loop in block_zero, so that block_zero doesn’t need to > fall through to fill_words to zero the small part of array. This code might > not perform as good as fill_words (unrolled), but it requires one less > register, and the code size becomes smaller as well. > The final code is like this: > > 0x0000007f7d3dd4fc: cmp x11, #0x20 > 0x0000007f7d3dd500: b.lt 0x0000007f7d3dd538 > 0x0000007f7d3dd504: neg x8, x10 > 0x0000007f7d3dd508: and x8, x8, #0x3f > 0x0000007f7d3dd50c: cbz x8, 0x0000007f7d3dd520 > 0x0000007f7d3dd510: sub x11, x11, x8, asr #3 > 0x0000007f7d3dd514: sub x8, x8, #0x8 > 0x0000007f7d3dd518: str xzr, [x10],#8 > 0x0000007f7d3dd51c: cbnz x8, 0x0000007f7d3dd514 > 0x0000007f7d3dd520: sub x11, x11, #0x8 > 0x0000007f7d3dd524: dc zva, x10 > 0x0000007f7d3dd528: subs x11, x11, #0x8 > 0x0000007f7d3dd52c: add x10, x10, #0x40 > 0x0000007f7d3dd530: b.ge 0x0000007f7d3dd524 > 0x0000007f7d3dd534: add x11, x11, #0x8 > 0x0000007f7d3dd538: tbz w11, #0, 0x0000007f7d3dd544 > 0x0000007f7d3dd53c: str xzr, [x10],#8 > 0x0000007f7d3dd540: sub x11, x11, #0x1 > 0x0000007f7d3dd544: cbz x11, 0x0000007f7d3dd554 > 0x0000007f7d3dd548: sub x11, x11, #0x2 > 0x0000007f7d3dd54c: stp xzr, xzr, [x10],#16 > 0x0000007f7d3dd550: cbnz x11, 0x0000007f7d3dd548 > > Would this be fine? It might well be. I'd like Ed to do a few measurements of large and small block zeroing. My guess is that a reasonably small unrolled loop doing STP ZR, ZR will work better than anything else, but we'll see. Thanks, Andrew.

3 6

RFR(XXS) JDK-8154379: MIN_STACK_SHADOW_PAGES should equal DEFAULT_STACK_SHADOW_PAGES on aarch64
by Chris Plummer 22 Apr '16

22 Apr '16

Hello, Please review the following diff. I would appreciate it if someone could verify that the open aarch64 port still runs properly after this change. Testing with just "bin/java" should be enough. https://bugs.openjdk.java.net/browse/JDK-8154379 diff --git a/src/cpu/aarch64/vm/globals_aarch64.hpp b/src/cpu/aarch64/vm/globals_aarch64.hpp --- a/src/cpu/aarch64/vm/globals_aarch64.hpp +++ b/src/cpu/aarch64/vm/globals_aarch64.hpp @@ -50,7 +50,7 @@ #define MIN_STACK_YELLOW_PAGES 1 #define MIN_STACK_RED_PAGES 1 -#define MIN_STACK_SHADOW_PAGES 1 +#define MIN_STACK_SHADOW_PAGES DEFAULT_STACK_SHADOW_PAGES #define MIN_STACK_RESERVED_PAGES (0) define_pd_global(intx, StackYellowPages, DEFAULT_STACK_YELLOW_PAGES); thanks, Chris

4 9

Repo busted
by Andrew Haley 22 Apr '16

22 Apr '16

A recent HotSpot merge seems to have broken jdk9/hs/hotspot for AArch64. I'm on it. Andrew.

1 0

New forest: aarch64-port/jdk8u-shenandoah/
by Andrew Haley 22 Apr '16

22 Apr '16

http://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/ This is an integration forest for AArch64 JDK8u and the Shenandoah GC. It's not for development: all changes will come either from the Shenandoah project repositories or from aarch64-port/jdk8u. It should be kept up-to-date with aarch64-port/jdk8u, which in turn should be kept up-to-date with jdk8u upstream. Because Shenandoah only touches HotSpot, the other trees should be no different from aarch64-port/jdk8u. All changes should be posted here. Changes from the two feeder repositories will usually be automatically accepted. At Red Hat we'll be using this forest to make preview packages available to developers who are interested in Shenandoah and want to kick the tyres. Andrew.

2 3

8u backport: 8154537: AArch64: some integer rotate instructions are never emitted
by Roland Westrelin 20 Apr '16

20 Apr '16

I'm backporting 8154537 (pushed to 9 yesterday) to http://hg.openjdk.java.net/aarch64-port/jdk8u That patch applies cleanly. Here is the jdk 9 patch for the record: http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/52cfeb90ea8b Roland.

3 6

RFR: u91
by Andrew Hughes 20 Apr '16

20 Apr '16

Hi, OpenJDK 8 was recently updated with a security update, u91. Here is the corresponding update for aarch64/jdk8u, aarch64-jdk8u91-b14 http://cr.openjdk.java.net/~andrew/aarch64-8/u91/ Ok to push? Incidentally, we'll need to also add a aarch64-jdk8u91-b15 tag to incorporate the AArch64 port of 8132051: Better byte behavior, which was added after aarch64-jdk8u91-b14 was tagged. I suggest we do that together with a merge of the upstream u91 which has just been pushed. Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222

3 3

hg: aarch64-port/jdk8u/nashorn: Added tag aarch64-jdk8u91-b14 for changeset 6c5e2fc0638d
by gnu.andrew＠redhat.com 20 Apr '16

20 Apr '16

Changeset: 68091b9af73e Author: andrew Date: 2016-04-10 22:47 +0100 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/nashorn/rev/68091b9af73e Added tag aarch64-jdk8u91-b14 for changeset 6c5e2fc0638d ! .hgtags

1 0

hg: aarch64-port/jdk8u/jdk: 20 new changesets
by gnu.andrew＠redhat.com 20 Apr '16

20 Apr '16

Changeset: 1b87cb7b6d8b Author: dsamersoff Date: 2016-01-22 16:12 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/1b87cb7b6d8b 8002116: This JdbReadTwiceTest.sh gets an exit 1 Summary: Explicitly check readability of file in question Reviewed-by: sla, dholmes, olagneau ! test/com/sun/jdi/JdbReadTwiceTest.sh Changeset: 0638b09b899b Author: sla Date: 2016-01-22 17:58 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/0638b09b899b 8036132: Tab characters in test/com/sun/jdi files Reviewed-by: alanb, mikael ! test/com/sun/jdi/CatchPatternTest.sh ! test/com/sun/jdi/GetLocalVariables4Test.sh ! test/com/sun/jdi/JdbReadTwiceTest.sh ! test/com/sun/jdi/NullLocalVariable.sh ! test/com/sun/jdi/PrivateTransportTest.sh ! test/com/sun/jdi/RedefineFinal.sh ! test/com/sun/jdi/RedefineIntConstantToLong.sh ! test/com/sun/jdi/StringConvertTest.sh ! test/com/sun/jdi/SuspendNoFlagTest.sh Changeset: d0e779dd55b9 Author: kshefov Date: 2016-02-15 14:43 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/d0e779dd55b9 8038963: com/sun/jdi tests fail because cygwin's ps sometimes misses processes Reviewed-by: coffeys ! test/com/sun/jdi/ShellScaffold.sh Changeset: a35481eb16ac Author: ykantser Date: 2016-01-22 18:04 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/a35481eb16ac 8044419: TEST_BUG: com/sun/jdi/JdbReadTwiceTest.sh fails when run under root Reviewed-by: dsamersoff, sla Contributed-by: mattias.tobiasson(a)oracle.com ! test/com/sun/jdi/JdbReadTwiceTest.sh Changeset: 2840655de5ba Author: dsamersoff Date: 2016-01-22 18:06 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/2840655de5ba 8074146: [TEST_BUG] jdb has succeded to read an unreadable file Summary: Remove this testcase Reviewed-by: sla, egahlin ! test/com/sun/jdi/JdbReadTwiceTest.sh Changeset: d55480081ed6 Author: robm Date: 2016-01-25 14:07 +0000 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/d55480081ed6 8129952: Ensure thread consistency Reviewed-by: chegar ! src/share/classes/java/io/ObjectInputStream.java Changeset: 387e211e84e0 Author: igerasim Date: 2015-11-27 10:59 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/387e211e84e0 8134297: NPE in GSSNameElement nameType check Reviewed-by: xuelei ! src/share/classes/sun/security/jgss/wrapper/GSSNameElement.java Changeset: 3625e8f95863 Author: igerasim Date: 2015-12-24 08:42 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/3625e8f95863 8138593: Make DSA more fair Summary: Changed nounce K generation to FIPS 186-4 B2.1 Reviewed-by: mullan ! src/share/classes/sun/security/provider/DSA.java ! test/java/security/Signature/TestInitSignWithMyOwnRandom.java ! test/sun/security/provider/DSA/TestDSA2.java Changeset: b6e94d7710f2 Author: vadim Date: 2015-10-20 12:08 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/b6e94d7710f2 8139008: Better state table management Reviewed-by: prr, srl, mschoene ! src/share/native/sun/font/layout/StateTableProcessor2.cpp Changeset: 20b718f7d39b Author: vadim Date: 2015-11-18 12:18 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/20b718f7d39b 8141229: [Parfait] Null pointer dereference in cmsstrcasecmp of cmserr.c Reviewed-by: prr, serb ! src/share/native/sun/java2d/cmm/lcms/cmscgats.c Changeset: 27e87873dfe3 Author: vadim Date: 2015-12-10 12:13 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/27e87873dfe3 8143002: [Parfait] JNI exception pending in fontpath.c:1300 Reviewed-by: prr, serb ! src/solaris/native/sun/awt/fontpath.c Changeset: 57ea4a1ac8d7 Author: ascarpino Date: 2015-12-21 10:43 -0800 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/57ea4a1ac8d7 8143945: Better GCM validation Reviewed-by: xuelei, mullan ! src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java Changeset: 6b03c6b870f4 Author: sjiang Date: 2016-01-22 13:41 +0100 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/6b03c6b870f4 8144430: Improve JMX connections Reviewed-by: dfuchs, jbachorik, skoivu ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java ! src/share/classes/java/io/ObjectInputStream.java ! src/share/classes/javax/management/remote/rmi/RMIJRMPServerImpl.java ! src/share/classes/sun/management/jmxremote/ConnectorBootstrap.java + src/share/classes/sun/misc/JavaObjectInputStreamAccess.java + src/share/classes/sun/misc/ObjectStreamClassValidator.java ! src/share/classes/sun/misc/SharedSecrets.java + src/share/classes/sun/rmi/server/DeserializationChecker.java ! src/share/classes/sun/rmi/server/MarshalInputStream.java ! src/share/classes/sun/rmi/server/UnicastServerRef.java Changeset: 47b9ded5921d Author: coffeys Date: 2016-01-08 16:21 +0000 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/47b9ded5921d 8146477: [TEST_BUG] ClientJSSEServerJSSE.java failing again Reviewed-by: mullan ! test/sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java Changeset: c6782e9d11c4 Author: prr Date: 2016-01-13 11:28 -0800 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/c6782e9d11c4 8146494: Better ligature substitution Reviewed-by: vadim, mschoene ! src/share/native/sun/font/layout/LigatureSubstProc.cpp ! src/share/native/sun/font/layout/LigatureSubstProc2.cpp Changeset: 42074f34351e Author: prr Date: 2016-01-13 11:28 -0800 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/42074f34351e 8146498: Better device table adjustments Reviewed-by: vadim, mschoene ! src/share/native/sun/font/layout/DeviceTables.cpp Changeset: bf3e62dcf0f4 Author: igerasim Date: 2016-01-15 11:49 +0300 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/bf3e62dcf0f4 8146967: [TEST_BUG] javax/security/auth/SubjectDomainCombiner/Optimize.java should use 4-args ProtectionDomain constructor Reviewed-by: mullan, valeriep ! test/javax/security/auth/SubjectDomainCombiner/Optimize.java Changeset: 44a76f73864d Author: rpatil Date: 2016-02-12 00:13 +0530 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/44a76f73864d 8148446: (tz) Support tzdata2016a Reviewed-by: okutsu, aefimov ! make/data/tzdata/VERSION ! make/data/tzdata/asia ! make/data/tzdata/backward ! make/data/tzdata/europe ! make/data/tzdata/northamerica ! make/data/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/sun/util/calendar/zi/tzdata/VERSION ! test/sun/util/calendar/zi/tzdata/asia ! test/sun/util/calendar/zi/tzdata/backward ! test/sun/util/calendar/zi/tzdata/europe ! test/sun/util/calendar/zi/tzdata/northamerica ! test/sun/util/calendar/zi/tzdata/zone.tab Changeset: e559bd990501 Author: asaha Date: 2016-02-28 18:59 -0800 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/e559bd990501 8150790: 8u75 L10n resource file translation update Summary: 8u75 L10n resource file translation update Reviewed-by: naoto Contributed-by: li.jiang(a)oracle.com ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties ! src/share/classes/sun/applet/resources/MsgAppletViewer_de.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_ko.java ! src/share/classes/sun/awt/resources/awt_de.properties ! src/share/classes/sun/launcher/resources/launcher_ko.properties ! src/share/classes/sun/management/resources/agent_ko.properties ! src/share/classes/sun/rmi/server/resources/rmid_ko.properties ! src/share/classes/sun/security/tools/keytool/Resources_de.java ! src/share/classes/sun/security/tools/policytool/Resources_ko.java ! src/share/classes/sun/security/util/AuthResources_ko.java ! src/share/classes/sun/tools/jar/resources/jar_ko.properties Changeset: 0e757f8bf24c Author: andrew Date: 2016-04-10 22:47 +0100 URL: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/0e757f8bf24c Added tag aarch64-jdk8u91-b14 for changeset e559bd990501 ! .hgtags

1 0