January 2019 - aarch64-port-dev

AARCH64 support for lworld
by Dmitry Samersoff 08 Sep '19

08 Sep '19

Hello Everybody, I started implementation of AARCH64 support for lworld. I'm on very early stage so any advices are highly appreciated. Should I file a CR for this task somewhere? What is correct way to do it? -Dmitry -- Dmitry Samersoff http://devnull.samersoff.net * There will come soft rains ...

6 28

[Roland Westrelin] Re: Aarch64 port for ZGC, so far
by Roland Westrelin 24 May '19

24 May '19

Just noticed I didn't include the mailing lists in that reply. Roland.

7 43

Re: [aarch64-port-dev ] RFR(S): 8215792: AArch64: String.indexOf generates incorrect result
by Pengfei Li (Arm Technology China) 19 May '19

19 May '19

Hi Dmitrij, Thanks a lot for your reply. > since cnt2 is used as counter, wouldn't it be easier and shorter just to substract cnt1 from cnt2 at the beginning of this code. Total (cnt2 - cnt1 +1) combinations must be checked. That is why first sustraction is by (wordSize/str2_chr_size - 1). > Then whole fix will be probably just 1 line at the beginning: sub(cnt2, cnt2, cnt1); I don't think the whole fix could be as easy as "sub(cnt2, cnt2, cnt1)" because cnt2 is the counter which counts number of bytes not processed. It could be different from the number of bytes after current first-character-match index. But this is just my thought. Perhaps I didn't understand your idea and code thoroughly. So could you post your shorter fix and let's test if it's right? -- Thanks, Pengfei

6 14

RFR: RFR: Bulk integration shenandoah/jdk8u -> aarch64-port/jdk8u-shenandoah 2018-12-13
by Roman Kennke 29 Apr '19

29 Apr '19

Please review the following proposed changes: This integrates changes from shenandoah/jdk8u into aarch64-port/jdk8u-shenandoah repository, reaching back to September 2018. It's bugfixes, improvements and new features that have been originally done in Shenandoah dev repo, and then backported to Shenandoah JDK8u repo and tested there for a while too. List of changes: http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-12-13… Webrev showing only shared-changes: http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-12-13… Full webrev: http://cr.openjdk.java.net/~rkennke/jdk8u-shenandoah-integration-2018-12-13… Thanks, Roman

5 15

RFR: 8217368: AArch64: C2 recursive stack locking optimisation not triggered
by Nick Gasson (Arm Technology China) 03 Apr '19

03 Apr '19

Hi, While I was cleaning up the patch for 8216350 I noticed an issue in the implementation of recursive locking in aarch64_enc_fast_lock: Bug: https://bugs.openjdk.java.net/browse/JDK-8217368 Webrev: http://cr.openjdk.java.net/~ngasson/8217368/webrev.0/ First we load the markOop of the object we want to lock and OR it with markOopDesc::unlocked_value (1). Then we do a CAS to exchange the address of the box on our thread's stack with the object's header word iff it's equal to the (markOop | 1) we just computed. If this fails, then we should check for a recursive lock by comparing (~(page size - 1) | 3) & (markOop - SP) == 0 Where "markOop" is the current object header word loaded by the failed CAS. This checks that the lock bits are zero (locked) and the stack address of the displaced header is within one page of the current SP. But on AArch64 we actually do this: (~(page size - 1) | 3) & ((old markOop | 1) - SP) == 0 Where "old markOop | 1" is the compare-to value used for the CAS. This is always false as the result has at least bit #0 set. This only affects C2, the C1_MacroAssembler version has the correct test. The diff looks big but all it does is swap the usage of registers `tmp' and `disp_hdr' in the first section so the markOop loaded by the CAS ends up in disp_hdr and tmp holds the (markOop | 1) compare-to value. Ran jtreg, plus jcstress with -XX:+UseLSE and -XX:-UseLSE. Also added another microbenchmark to micro/org/openjdk/bench/vm/lang/LockUnlock.java as I couldn't find an existing JMH case that triggered this. Without patch: Result "org.openjdk.bench.vm.lang.LockUnlock.testRecursiveSynchronizationNoBias": 510.781 ?(99.9%) 1.196 ns/op [Average] (min, avg, max) = (508.769, 510.781, 513.854), stdev = 1.597 CI (99.9%): [509.585, 511.977] (assumes normal distribution) With patch: Result "org.openjdk.bench.vm.lang.LockUnlock.testRecursiveSynchronizationNoBias": 197.038 ?(99.9%) 0.096 ns/op [Average] (min, avg, max) = (196.886, 197.038, 197.296), stdev = 0.128 CI (99.9%): [196.942, 197.134] (assumes normal distribution) Two other minor things: * Does anyone know what the comment "// Load Compare Value application register." means? It's present in the PPC and S390 ports too. * The x86 port #ifdef LP64 uses "7 - os::vm_page_size()" as the mask in the recursive lock test. I think the "7" here is markOopDesc::biased_lock_mask and is presumably there to prevent a silent mutual exclusion failure if a markOop with the bias locking bits set ends up the fast_lock path (although this should never happen). Should we change markOopDesc::lock_mask_in_place to markOopDesc::biased_lock_mask_in_place in the AArch64 port too? Thanks, Nick

4 14

RFR(S): 8214922: Add vectorization support for fmin/fmax
by Pengfei Li (Arm Technology China) 12 Mar '19

12 Mar '19

Hi, JBS: https://bugs.openjdk.java.net/browse/JDK-8214922 Webrev: http://cr.openjdk.java.net/~pli/rfr/8214922/webrev.00/ This is the vectorization support of floating-point min/max. Both vector binary operations and reduction operations are added. For C2 vectorization nodes, I see similar code in project panama (http://hg.openjdk.java.net/panama/dev/) So to reduce duplicate work and help future code merge between jdk/jdk and panama/dev, most of the hotspot shared codes in this patch are copied from panama/dev. I still made one thing different from panama code. It is that for reduction min/max, scalar operations are transformed only when the number of lanes in the vector is greater than 2. I did this as on some architectures, such as AArch64, there is no reduction min/max for 2 floats or 2 doubles. We can surely add a fallback matching rule in ad file for these cases just like reduce_add2F or reduce_add2D in aarch64.ad. But based on my test[1], the fallback implementations show worse performance than the original scalar version. Please let me know if you agree with this change or not. [1] http://cr.openjdk.java.net/~pli/rfr/8214922/TestSIMDFpMinMax.java -- Thanks, Pengfei

6 22

[NEW BUG]Missing LoadStore barrier in interpreter?
by Lun Liu 02 Mar '19

02 Mar '19

Hi aarch64-port devs, I am new to the OpenJDK community so hope I am posting on the right mailing list. I noticed in the template interpreter only a StoreStore barrier is used before a volatile write. According to JMM cookbook I think a LoadStore barrier is also needed to prevent reordering between a normal read and a volatile write. In the template interpreter it seems like LoadLoad | LoadStore barriers are inserted after both normal read and volatile read so it should be fine but I think this might cause a problem if the compiler generates a normal read using dmb barriers and the interpreter is executing the volatile write. Could this be a potential bug? I am browsing aarch64-port/jdk8u code with the following changeset as the lastest change changeset: 9947:1d411780111d tag: tip user: fyang date: Mon Dec 24 13:42:31 2018 +0800 summary: 8209414: AArch64: method handle invocation does not respect JVMTI interp_only mode This could be fixed by a simple patch below diff -r 1d411780111d src/cpu/aarch64/vm/templateTable_aarch64.cpp --- a/src/cpu/aarch64/vm/templateTable_aarch64.cpp Mon Dec 24 13:42:31 2018 +0800 +++ b/src/cpu/aarch64/vm/templateTable_aarch64.cpp Wed Jan 30 21:34:47 2019 +0100 @@ -2633,7 +2633,7 @@ { Label notVolatile; __ tbz(r5, ConstantPoolCacheEntry::is_volatile_shift, notVolatile); - __ membar(MacroAssembler::StoreStore); + __ membar(MacroAssembler::StoreStore | LoadStore); __ bind(notVolatile); } Thank you for any help. Best, -- Lun Liu PhD Candidate Computer Science Department University of California, Los Angeles

5 21

[RFR] [8u] 8u192 Upstream Sync
by Andrew Hughes 26 Feb '19

26 Feb '19

Hi, I propose to merge jdk8u192-b12 into the aarch64/shenandoah-jdk8u repository to create aarch64-shenandoah-jdk8u192-b12. As webrevs for such merges tend not to illustrate the actual changes taking place very well, I have instead just include the merge changesets this time and saved on uploading about a gigabyte of largely useless data... http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/corba/merge.changeset http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/jaxp/merge.changeset http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/jaxws/merge.changeset http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/jdk/merge.changeset http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/hotspot/merge.changeset http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/langtools/merge.change… http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/nashorn/merge.changeset http://cr.openjdk.java.net/~andrew/shenandoah-8/u192/root/merge.changeset Changes in aarch64-shenandoah-jdk8u191-b14: [These are committed changes but not yet tagged] - S8155627: Enable SA on AArch64 - S8209414: AArch64: method handle invocation does not respect JVMTI interp_only mode Changes in aarch64-shenandoah-jdk8u192-b12: - S6260348: GTK+ L&F JTextComponent not respecting desktop caret blink rate - S6730115: Fastdebug VM crashes with "ExceptionMark destructor expects no pending exceptions" error - S8008321: compile.cpp verify_graph_edges uses bool as int - S8022177: Windows/MSYS builds broken - S8026331: hs_err improvement: Print if we have seen any OutOfMemoryErrors or StackOverflowErrors - S8026335: hs_err improvement: Print exact compressed oops mode and the heap base value. - S8027584: Disable ccache by default - S8031668: TOOLCHAIN_FIND_COMPILER unexpectedly resolves symbolic links - S8031759: Improved tool overriding in configure - S8033292: only warn, not fail, on unknown variables in configure - S8034199: Add 'reconfigure' target for re-creating a configuration - S8034788: Rewrite toolchain.m4 to support multiple toolchains per platform. - S8035074: hs_err improvement: Add time zone information in the hs_err file - S8035495: Improvements in autoconf integration - S8035725: Must keep microsoft VS_PATH on PATH after toolchain detection - S8035730: Configure fails in cygwin if current dir is in /home/user - S8035751: Clean up Visual Studio detection logic - S8035825: Warn instead of fail when calling the configure wrapper directly - S8036003: Add --with-native-debug-symbols=[none|internal|external|zipped] - S8038340: Cleanup and fix sysroot and devkit handling on Linux and Solaris - S8039030: 9-dev windows-i586 build failed with mktemp: command not found - S8041623: Solaris Studio 12.4 C++ 5.13, CHECK_UNHANDLED_OOPS use of class oop's copy constructor definitions causing error level diagnostic. - S8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) - S8048128: Fix for Solaris Studio C++ 5.13, CHECK_UNHANDLED_OOPS breaks PPC build. - S8057538: Build the freetype library during configure on Windows - S8061305: Javadoc crashes when method name ends with "Property" - S8067239: [TESTBUG] javax/xml/bind/marshal/8036981/Test.java failed - S8069124: runtime/NMT/MallocSiteHashOverflow.java failing in nightlies - S8075942: ArrayIndexOutOfBoundsException in sun.java2d.pisces.Dasher.goTo - S8077420: Build failure with SS12u4 - S8078437: Enable use of devkits for Windows - S8078628: linux-zero does not build without precompiled header - S8079788: Fix broken CL version detection in configure for some Visual Studio configurations - S8081202: Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier" - S8081323: ConstantPool::_resolved_references is missing in heap dump - S8114823: G1 doesn't honor request to disable class unloading - S8134157: adlc fails to compile with SS12u4 - S8138692: libjsig compilation is missing EXTRA_CFLAGS on macosx - S8140470: javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java failed with AccessControlException - S8148175: C1: G1 barriers don't preserve FP registers - S8148351: Only display resolved symlink for compiler, do not change path - S8150426: Wrong cast in metadata_at_put - S8150688: Fix os_windows siglabel - S8150954: Taking screenshots on x11 composite desktop produce wrong result - S8153194: PreserveFPRegistersTest.java runs out of memory in the nightlies - S8156824: com.sun.jndi.ldap.pool.PoolCleaner should clear its context class loader - S8158012: Use SW prefetch instructions instead of BIS for allocation prefetches on SPARC Core C4 - S8160748: Inconsistent types for ideal_reg - S8162362: Introduce system property to control enabled ciphersuites - S8162540: Crash in C2 escape analysis with assert: "node should be registered" - S8165463: Native implementation of sunmscapi should use operator new (nothrow) for allocations - S8165489: Missing G1 barrier in Unsafe_GetObjectVolatile - S8176033: New cygwin grep does not match \r as newline - S8176192: Incorrect usage of Iterator in Java 8 In com.sun.jndi.ldap.EventSupport.removeNamingListener - S8178370: [TEST_BUG] java/security/Signature/SignatureLength.java fails - S8179079: Incremental HotSpot builds broken on Windows - S8179675: Build with error on windows with new Cygwin grep - S8185723: Zero: segfaults on Power PC 32-bit - S8185855: Debug exception stacks should be clearer - S8186171: HashMap: Entry.setValue may not work after Iterator.remove() called for previous entries - S8186461: Zero's atomic_copy64() should use SPE instructions on linux-powerpcspe - S8186646: Nashorn: "duplicate code" assertion when binding a vararg function that just passes arguments along - S8187577: JVM crash during gc doing concurrent marking - S8188030: AWT java apps fail to start when some minimal fonts are present - S8188083: NullPointerExcpn-java.awt.image.FilteredImageSource.startProduction JDK-8079607 - S8189170: Add option to disable stack overflow checking in primordial thread for use with JNI_CreateJavaJVM - S8189760: sun/security/ssl/CertPathRestrictions/TLSRestrictions.java failed with unexpected Exception intermittently - S8193171: keytool -list displays "JKS" for a PKCS12 keystore - S8193758: Update copyright headers of files in src tree that are missing Classpath exception - S8194412: Adding 256 units of IsoFields.QUARTER_YEARS broken - S8194642: Improve OOM error reporting for JDK8 - S8195095: Images are not scaled correctly in JEditorPane - S8195738: scroll poistion in ScrollPane is reset after calling validate() - S8196108: Add build support for VS 2015/2017 - S8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols - S8196880: VS2017 Addition of Global Delete Operator with Size Parameter Conflicts with Arena's Chunk Provided One - S8196884: VS2017 Multiple Type Cast Conversion Compilation Errors - S8197864: VS2017 (C4334) Result of 32-bit Shift Implicitly Converted to 64 bits - S8197868: VS2017 (C2065) 'timezone': Undeclared Identifier in share/runtime/os.cpp - S8198304: VS2017 (C4838, C4312) Various conversion issues with gtest tests - S8198898: Compilation errors in jdk.crypto.mscapi with VS 2017 - S8199748: Touch keyboard is not shown, if text component gets focus from other text component - S8200353: Shift or Capslock not working in Textfield after accented keystrokes - S8201240: Improve releasing native resources of BufImgSurfaceData.ICMColorData - S8201369: Inet4AddressImpl_getLocalHostName reverse lookup on Solaris only - S8201495: [Zero] Reduce limits of max heap size for boot JDK on s390 - S8201509: Zero: S390 31bit atomic_copy64 inline assembler is wrong - S8202600: [Zero] Undefined behaviour in src/os_cpu/linux_zero/vm/os_linux_zero.cpp - S8202696: Remove exclusion range for phonetic chars in windows fontconfig.properties - S8203182: Release session if initialization of SunPKCS11 Signature fails - S8203349: 8u hotspot should recognise later Windows compilers - S8203499: Uninitialised memory in WinAccessBridge.cpp - S8203790: MSVCP dependency introduced in awt.dll - S8203845: backport of JDK-8034788 inadvertently rolled back JDK-8187045 changes to toolchain.m4 - S8204053: libsaproc.so not linked with -z,noexecstack - S8204872: [8u] VS2017: more instances of "error C3680: cannot concatenate user-defined string literals with mismatched literal suffix identifiers" - S8205104: EXTRA_LDFLAGS not consistently being used - S8205440: [8u] DWORD64 required for later Windows compilers - S8205677: [8u] casts and type change for 8u to enable later Windows compilers - S8206406: StubCodeDesc constructor publishes partially-constructed objects on StubCodeDesc::_list - S8206425: .gnu_debuglink sections added unconditionally when no debuginfo is stripped - S8206454: [8u] os::current_stack_pointer() fails to compile on later Windows compilers (warning C4172: returning address of local variable) - S8206914: add jdk8u-dev test failures to ProblemList.txt - S8207402: Stray *.debuginfo files when not stripping debug info - S8207853: Need to regenerate configure in jdk8u-dev - S8209002: 8u192 installed exe and dll files have wrong file version - S8210423: Backport of 8034788 breaks GCC version detection - S8210658: Remove and retag jdk8u192-b10 tag in source repository - S8210951: Test sun/security/ssl/SSLContextImpl/CustomizedCipherSuites.java fails diffstat for corba b/.hgtags | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diffstat for hotspot b/.hgtags | 14 b/make/aix/makefiles/jsig.make | 2 b/make/aix/makefiles/saproc.make | 2 b/make/aix/makefiles/vm.make | 2 b/make/bsd/makefiles/jsig.make | 4 b/make/bsd/makefiles/saproc.make | 2 b/make/bsd/makefiles/vm.make | 2 b/make/linux/makefiles/defs.make | 54 - b/make/linux/makefiles/jsig.make | 10 b/make/linux/makefiles/saproc.make | 13 b/make/linux/makefiles/vm.make | 10 b/make/solaris/makefiles/adlc.make | 5 b/make/windows/makefiles/compile.make | 55 + b/make/windows/makefiles/sanity.make | 7 b/make/windows/makefiles/vm.make | 4 b/src/cpu/ppc/vm/methodHandles_ppc.cpp | 2 b/src/cpu/ppc/vm/ppc.ad | 6 b/src/cpu/sparc/vm/methodHandles_sparc.cpp | 2 b/src/cpu/sparc/vm/sparc.ad | 6 b/src/cpu/sparc/vm/vm_version_sparc.cpp | 22 b/src/cpu/sparc/vm/vtableStubs_sparc.cpp | 4 b/src/cpu/x86/vm/c1_Runtime1_x86.cpp | 56 - b/src/cpu/x86/vm/interpreterRT_x86_64.cpp | 8 b/src/cpu/x86/vm/macroAssembler_x86.cpp | 2 b/src/cpu/x86/vm/methodHandles_x86.cpp | 2 b/src/cpu/x86/vm/vtableStubs_x86_32.cpp | 4 b/src/cpu/x86/vm/vtableStubs_x86_64.cpp | 4 b/src/cpu/x86/vm/x86.ad | 6 b/src/os/aix/vm/os_aix.cpp | 10 b/src/os/aix/vm/os_aix.hpp | 8 b/src/os/bsd/vm/os_bsd.cpp | 4 b/src/os/bsd/vm/os_bsd.hpp | 3 b/src/os/linux/vm/os_linux.cpp | 63 + b/src/os/linux/vm/os_linux.hpp | 3 b/src/os/solaris/vm/os_solaris.cpp | 23 b/src/os/windows/vm/os_windows.cpp | 36 - b/src/os_cpu/linux_ppc/vm/os_linux_ppc.cpp | 6 b/src/os_cpu/linux_sparc/vm/os_linux_sparc.cpp | 6 b/src/os_cpu/linux_x86/vm/os_linux_x86.cpp | 6 b/src/os_cpu/linux_zero/vm/os_linux_zero.cpp | 5 b/src/os_cpu/linux_zero/vm/os_linux_zero.hpp | 24 b/src/os_cpu/windows_x86/vm/os_windows_x86.cpp | 7 b/src/share/vm/adlc/arena.hpp | 7 b/src/share/vm/adlc/output_c.cpp | 6 b/src/share/vm/c1/c1_CFGPrinter.cpp | 2 b/src/share/vm/classfile/altHashing.cpp | 6 b/src/share/vm/classfile/classFileParser.cpp | 4 b/src/share/vm/classfile/classLoaderData.cpp | 4 b/src/share/vm/classfile/dictionary.cpp | 2 b/src/share/vm/classfile/dictionary.hpp | 2 b/src/share/vm/classfile/javaClasses.hpp | 2 b/src/share/vm/classfile/vmSymbols.hpp | 2 b/src/share/vm/code/exceptionHandlerTable.cpp | 2 b/src/share/vm/code/nmethod.cpp | 8 b/src/share/vm/compiler/compileBroker.cpp | 2 b/src/share/vm/compiler/disassembler.cpp | 2 b/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp | 86 +- b/src/share/vm/gc_implementation/g1/collectionSetChooser.cpp | 2 b/src/share/vm/gc_implementation/g1/collectionSetChooser.hpp | 2 b/src/share/vm/gc_implementation/g1/concurrentMark.cpp | 80 +- b/src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp | 8 b/src/share/vm/gc_implementation/g1/g1AllocRegion.cpp | 4 b/src/share/vm/gc_implementation/g1/g1Allocator.hpp | 2 b/src/share/vm/gc_implementation/g1/g1BiasedArray.cpp | 6 b/src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp | 20 b/src/share/vm/gc_implementation/g1/g1CardCounts.cpp | 4 b/src/share/vm/gc_implementation/g1/g1CardCounts.hpp | 2 b/src/share/vm/gc_implementation/g1/g1CodeCacheRemSet.cpp | 12 b/src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp | 78 +- b/src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp | 4 b/src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp | 14 b/src/share/vm/gc_implementation/g1/g1ErgoVerbose.hpp | 6 b/src/share/vm/gc_implementation/g1/g1GCPhaseTimes.cpp | 4 b/src/share/vm/gc_implementation/g1/g1HRPrinter.cpp | 12 b/src/share/vm/gc_implementation/g1/g1InCSetState.hpp | 6 b/src/share/vm/gc_implementation/g1/g1MarkSweep.cpp | 31 b/src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp | 2 b/src/share/vm/gc_implementation/g1/g1RemSet.cpp | 2 b/src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp | 30 b/src/share/vm/gc_implementation/g1/g1RootProcessor.cpp | 51 + b/src/share/vm/gc_implementation/g1/g1RootProcessor.hpp | 23 b/src/share/vm/gc_implementation/g1/g1StringDedupQueue.cpp | 2 b/src/share/vm/gc_implementation/g1/g1StringDedupStat.cpp | 24 b/src/share/vm/gc_implementation/g1/g1StringDedupTable.cpp | 12 b/src/share/vm/gc_implementation/g1/heapRegion.cpp | 92 +- b/src/share/vm/gc_implementation/g1/heapRegion.hpp | 6 b/src/share/vm/gc_implementation/g1/heapRegion.inline.hpp | 2 b/src/share/vm/gc_implementation/g1/heapRegionManager.cpp | 2 b/src/share/vm/gc_implementation/g1/heapRegionManager.inline.hpp | 4 b/src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp | 16 b/src/share/vm/gc_implementation/g1/heapRegionSet.cpp | 14 b/src/share/vm/gc_implementation/g1/satbQueue.cpp | 4 b/src/share/vm/gc_implementation/parallelScavenge/gcTaskManager.cpp | 4 b/src/share/vm/gc_implementation/shared/mutableNUMASpace.cpp | 2 b/src/share/vm/interpreter/interpreterRuntime.cpp | 4 b/src/share/vm/interpreter/oopMapCache.cpp | 6 b/src/share/vm/interpreter/oopMapCache.hpp | 4 b/src/share/vm/memory/allocation.cpp | 2 b/src/share/vm/memory/barrierSet.cpp | 4 b/src/share/vm/memory/blockOffsetTable.cpp | 2 b/src/share/vm/memory/cardTableModRefBS.cpp | 2 b/src/share/vm/memory/cardTableModRefBS.hpp | 12 b/src/share/vm/memory/generation.cpp | 2 b/src/share/vm/memory/guardedMemory.cpp | 8 b/src/share/vm/memory/metaspace.cpp | 19 b/src/share/vm/memory/metaspace.hpp | 4 b/src/share/vm/memory/tenuredGeneration.cpp | 4 b/src/share/vm/memory/threadLocalAllocBuffer.cpp | 6 b/src/share/vm/memory/threadLocalAllocBuffer.inline.hpp | 8 b/src/share/vm/memory/universe.cpp | 20 b/src/share/vm/memory/universe.hpp | 4 b/src/share/vm/oops/constantPool.cpp | 14 b/src/share/vm/oops/constantPool.hpp | 3 b/src/share/vm/oops/cpCache.cpp | 10 b/src/share/vm/oops/markOop.cpp | 2 b/src/share/vm/oops/method.cpp | 4 b/src/share/vm/oops/objArrayKlass.cpp | 2 b/src/share/vm/oops/oop.cpp | 2 b/src/share/vm/oops/oopsHierarchy.hpp | 12 b/src/share/vm/oops/typeArrayOop.hpp | 2 b/src/share/vm/opto/buildOopMap.cpp | 4 b/src/share/vm/opto/callnode.cpp | 4 b/src/share/vm/opto/chaitin.cpp | 6 b/src/share/vm/opto/compile.cpp | 14 b/src/share/vm/opto/escape.cpp | 12 b/src/share/vm/opto/gcm.cpp | 4 b/src/share/vm/opto/idealGraphPrinter.cpp | 4 b/src/share/vm/opto/macro.cpp | 6 b/src/share/vm/opto/matcher.cpp | 4 b/src/share/vm/opto/matcher.hpp | 10 b/src/share/vm/opto/output.cpp | 4 b/src/share/vm/opto/reg_split.cpp | 6 b/src/share/vm/opto/split_if.cpp | 6 b/src/share/vm/opto/type.cpp | 4 b/src/share/vm/opto/type.hpp | 18 b/src/share/vm/prims/jvmtiTagMap.cpp | 4 b/src/share/vm/prims/methodHandles.cpp | 42 - b/src/share/vm/prims/perf.cpp | 16 b/src/share/vm/prims/unsafe.cpp | 332 +++++----- b/src/share/vm/prims/whitebox.cpp | 12 b/src/share/vm/runtime/arguments.cpp | 14 b/src/share/vm/runtime/deoptimization.cpp | 2 b/src/share/vm/runtime/globals.hpp | 6 b/src/share/vm/runtime/memprofiler.cpp | 4 b/src/share/vm/runtime/os.cpp | 28 b/src/share/vm/runtime/os.hpp | 21 b/src/share/vm/runtime/safepoint.cpp | 22 b/src/share/vm/runtime/sharedRuntime.cpp | 4 b/src/share/vm/runtime/stubCodeGenerator.cpp | 8 b/src/share/vm/runtime/stubCodeGenerator.hpp | 6 b/src/share/vm/runtime/thread.cpp | 14 b/src/share/vm/runtime/thread.hpp | 5 b/src/share/vm/runtime/unhandledOops.cpp | 2 b/src/share/vm/runtime/vm_version.cpp | 6 b/src/share/vm/services/attachListener.cpp | 47 - b/src/share/vm/services/attachListener.hpp | 3 b/src/share/vm/services/diagnosticArgument.cpp | 2 b/src/share/vm/services/heapDumper.cpp | 51 + b/src/share/vm/services/mallocSiteTable.cpp | 2 b/src/share/vm/services/mallocSiteTable.hpp | 3 b/src/share/vm/services/memoryManager.cpp | 4 b/src/share/vm/services/memoryPool.cpp | 4 b/src/share/vm/services/threadService.cpp | 2 b/src/share/vm/trace/traceStream.hpp | 14 b/src/share/vm/utilities/exceptions.cpp | 46 + b/src/share/vm/utilities/exceptions.hpp | 15 b/src/share/vm/utilities/globalDefinitions.hpp | 4 b/src/share/vm/utilities/nativeCallStack.cpp | 16 b/src/share/vm/utilities/nativeCallStack.hpp | 6 b/src/share/vm/utilities/ostream.cpp | 4 b/src/share/vm/utilities/stack.hpp | 9 b/src/share/vm/utilities/stack.inline.hpp | 8 b/src/share/vm/utilities/vmError.cpp | 77 +- b/test/compiler/gcbarriers/PreserveFPRegistersTest.java | 120 +++ b/test/gc/class_unloading/TestClassUnloadingDisabled.java | 116 +++ 175 files changed, 1623 insertions(+), 986 deletions(-) diffstat for ../webrevs/shenandoah-8/u192/jaxp b/.hgtags | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diffstat for /jaxws b/.hgtags | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diffstat for jdk b/.hgtags | 14 b/make/CopyFiles.gmk | 24 b/make/CreateJars.gmk | 15 b/make/lib/Awt2dLibraries.gmk | 37 - b/make/lib/CoreLibraries.gmk | 5 b/make/mapfiles/libawt/mapfile-vers | 1 b/make/mapfiles/libawt/mapfile-vers-linux | 1 b/make/mapfiles/libawt_xawt/mapfile-vers | 1 b/src/share/classes/com/sun/java/swing/plaf/gtk/GTKEngine.java | 6 b/src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java | 14 b/src/share/classes/com/sun/jndi/ldap/EventSupport.java | 28 - b/src/share/classes/com/sun/jndi/ldap/LdapPoolManager.java | 13 b/src/share/classes/com/sun/jndi/ldap/pool/PoolCleaner.java | 4 b/src/share/classes/com/sun/tracing/ProviderFactory.java | 24 b/src/share/classes/java/awt/image/FilteredImageSource.java | 6 b/src/share/classes/java/security/IdentityScope.java | 4 b/src/share/classes/java/security/Signature.java | 2 b/src/share/classes/java/time/temporal/IsoFields.java | 7 b/src/share/classes/java/util/HashMap.java | 27 - b/src/share/classes/javax/swing/text/html/ImageView.java | 8 b/src/share/classes/sun/awt/ExtendedKeyCodes.java | 25 b/src/share/classes/sun/awt/image/BufImgSurfaceData.java | 15 b/src/share/classes/sun/java2d/pisces/Dasher.java | 2 b/src/share/classes/sun/misc/InnocuousThread.java | 59 +- b/src/share/classes/sun/security/jca/ProviderList.java | 2 b/src/share/classes/sun/security/pkcs/PKCS8Key.java | 1 b/src/share/classes/sun/security/pkcs11/P11Signature.java | 86 +-- b/src/share/classes/sun/security/provider/AuthPolicyFile.java | 3 b/src/share/classes/sun/security/provider/DSA.java | 12 b/src/share/classes/sun/security/provider/PolicyFile.java | 4 b/src/share/classes/sun/security/ssl/SSLContextImpl.java | 145 ++++- b/src/share/classes/sun/security/ssl/SSLEngineImpl.java | 20 b/src/share/classes/sun/security/ssl/SSLSocketImpl.java | 19 b/src/share/classes/sun/security/tools/keytool/Main.java | 14 b/src/share/classes/sun/security/util/AnchorCertificates.java | 2 b/src/share/classes/sun/security/util/SignatureFileVerifier.java | 5 b/src/share/classes/sun/security/x509/CertificateExtensions.java | 3 b/src/share/classes/sun/security/x509/X509Key.java | 1 b/src/share/lib/security/BlacklistedCertsConverter.java | 4 b/src/share/native/sun/awt/image/BufImgSurfaceData.c | 26 b/src/solaris/classes/sun/awt/X11/XRobotPeer.java | 5 b/src/solaris/classes/sun/java2d/x11/XSurfaceData.java | 25 b/src/solaris/native/java/net/Inet4AddressImpl.c | 44 - b/src/solaris/native/java/net/Inet6AddressImpl.c | 47 - b/src/solaris/native/sun/awt/awt_Robot.c | 78 ++ b/src/solaris/native/sun/awt/fontpath.c | 11 b/src/solaris/native/sun/awt/gtk2_interface.c | 28 - b/src/solaris/native/sun/awt/gtk2_interface.h | 6 b/src/windows/bin/java_md.c | 39 - b/src/windows/classes/sun/awt/windows/fontconfig.properties | 4 b/src/windows/native/sun/bridge/WinAccessBridge.cpp | 11 b/src/windows/native/sun/security/mscapi/security.cpp | 135 ++++- b/src/windows/native/sun/windows/awt_Component.cpp | 2 b/src/windows/native/sun/windows/awt_ScrollPane.cpp | 20 b/test/ProblemList.txt | 26 b/test/TEST.groups | 1 b/test/com/sun/jndi/ldap/RemoveNamingListenerTest.java | 241 ++++++++ b/test/java/awt/BasicStroke/DashStrokeTest.java | 69 ++ b/test/java/awt/ScrollPane/ScrollPaneValidateTest.java | 91 +++ b/test/java/awt/font/PhoneticExtensions/PhoneticExtensionsGlyphTest.java | 82 +++ b/test/java/awt/image/FilteredImageSourceTest.java | 212 +++++++ b/test/java/security/Signature/SignatureLength.java | 95 ++- b/test/java/time/test/java/time/TestLocalDate.java | 39 + b/test/java/util/HashMap/Bug8186171Test.java | 157 +++++ b/test/javax/swing/JEditorPane/8195095/ImageViewTest.java | 142 +++++ b/test/javax/xml/crypto/dsig/SecurityManager/XMLDSigWithSecMgr.java | 10 b/test/sun/security/ssl/CertPathRestrictions/JSSEServer.java | 47 - b/test/sun/security/ssl/CertPathRestrictions/TLSRestrictions.java | 101 +-- b/test/sun/security/ssl/SSLContextImpl/CustomizedCipherSuites.java | 270 ++++++++++ b/test/sun/security/tools/keytool/ListPKCS12.java | 53 + 70 files changed, 2315 insertions(+), 465 deletions(-) diffstat for langtools b/.hgtags | 14 + b/src/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java | 7 b/test/com/sun/javadoc/testMethodEndingInProperty/Test.java | 26 +++ b/test/com/sun/javadoc/testMethodEndingInProperty/TestMethodEndingInProperty.java | 73 ++++++++++ 4 files changed, 119 insertions(+), 1 deletion(-) diffstat for ../webrevs/shenandoah-8/u192/nashorn b/.hgtags | 14 +++++ b/src/jdk/nashorn/internal/runtime/CompiledFunction.java | 3 + b/test/script/basic/JDK-8186646.js | 39 +++++++++++++++ 3 files changed, 56 insertions(+) diffstat for root b/.hgtags | 18 b/common/autoconf/Makefile.in | 4 b/common/autoconf/autogen.sh | 42 b/common/autoconf/basics.m4 | 468 b/common/autoconf/basics_windows.m4 | 14 b/common/autoconf/boot-jdk.m4 | 2 b/common/autoconf/build-performance.m4 | 40 b/common/autoconf/compare.sh.in | 4 b/common/autoconf/configure | 99 b/common/autoconf/configure.ac | 53 b/common/autoconf/flags.m4 | 808 b/common/autoconf/generated-configure.sh |29137 +++++++++++++++++++++++-------- b/common/autoconf/help.m4 | 88 b/common/autoconf/hotspot-spec.gmk.in | 4 b/common/autoconf/jdk-options.m4 | 89 b/common/autoconf/libraries.m4 | 246 b/common/autoconf/platform.m4 | 2 b/common/autoconf/spec.gmk.in | 34 b/common/autoconf/toolchain.m4 | 1759 - b/common/autoconf/toolchain_windows.m4 | 629 b/common/bin/compare.sh | 2 b/configure | 9 b/make/Main.gmk | 13 b/make/common/MakeBase.gmk | 47 b/make/common/NativeCompilation.gmk | 97 b/make/devkit/Makefile | 2 b/make/devkit/Tools.gmk | 27 27 files changed, 25074 insertions(+), 8663 deletions(-) Built on x86_64. There are a couple of known aarch64 issues which I have fixes applied for, but will push on top of 8u201 (didn't catch them until 8u201 work was done) Ok to push? Thanks, -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Web Site: http://fuseyism.com Twitter: https://twitter.com/gnu_andrew_java PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222

3 3

RFC: 64 bit literal oops
by Stuart Monteith 14 Feb '19

14 Feb '19

Hello, I've been testing my patch to make literal oops 64-bit rather than 48-bit. This is a necessary prerequisite for ZGC to operate on aarch64 using tagged pointers. I'm not submitting this in it's final form, but just for a view on whether this is the proper way to do this. The patch is here: http://cr.openjdk.java.net/~smonteith/oop64/webrev-20181002/ I've tested it against jtreg and G1GC, and get clean results as compared to without the patch. No issues are apparent running SPECjbb-2015. There are essentially 7 changes: 1. There is a new options: -XX:+Use64BitLiteralOops 2. MacroAssembler::patch_oop(address,address) patches 64-bit addresses if the flag is enabled. 3. MacroAssembler::target_addr_for_insn(address, unsigned) is modified to pull out a 64-bit target address, if there is an extra movk, and then calls ShouldNotReachHere(). 4. MacroAssembler::mov(Register, Address) has been changed to call movptr with a flag set if the address is an Oop. 5. MacroAssembler::movptr(Register, uintptr_t) has been modified to take a flag indicating if it is an oop that is being emitted. If Use64BitLiteralOops has been set, then an additional movk is emitted to make up the 64 bit literal. 6. NativeInstruction::is_oop_at(int) was added, to detect if an oop exists at the address. 7. NativeMovConstReg::next_instruction_address() has been changed to handle get the address after "movz, movk, movk" and with 64 bit oops "movz, movk, movk, movk." (6) has never been observed,, so I don't consider it tested - there aren't circumstances where it returns true, so arguably it it should be replaced by an appropriate assert. Likewise, (3) is also an unnecessary change - the ShouldNotReachHere() never traps during testing - it was left in for review purposes. It has been mentioned to me that we could just use 64-bit literals, as that would make things simpler - I look forward to people's opinions. It was also mentioned ages ago that in future the coloured bits could be made irrelevant for ZGC. There is the up and coming 52-bit VA scheme for Arm v8. If we are to use >48 bits of address space we will have to ask for it explicitly, in which case we'd need to use 64 bit oops. The class metadata could remain 48-bit in that case. There is an interesting presentation on 52-bit VA here: https://connect.linaro.org/resources/yvr18/yvr18-119/ BR, Stuart

4 8

Re: [aarch64-port-dev ] RFR(M): 8212043: Add floating-point Math.min/max intrinsics
by Bhateja, Jatin 06 Feb '19

06 Feb '19

Hi Pengfei, Your final patch (http://cr.openjdk.java.net/~pli/rfr/8212043/webrev.04/) to support floating point scalar max/min intrinsic also included following test case which is not up streamed to jdk repository. test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxIntrinsics.java Can you kindly add this test case, I’m working on supporting these new intrinsics for X86 platform and will like to use the test case you created. Thanks and Regards, Jatin Bhateja From: Pengfei Li (Arm Technology China) <Pengfei.Li(a)arm.com<mailto:Pengfei.Li@arm.com>> ---------- Forwarded message --------- Date: Wed, Dec 19, 2018 at 6:38 PM Subject: RE: [aarch64-port-dev ] RFR(M): 8212043: Add floating-point Math.min/max intrinsics To: Andrew Dinn <adinn(a)redhat.com<mailto:adinn@redhat.com>>, Andrew Haley <aph(a)redhat.com<mailto:aph@redhat.com>>, hotspot-compiler-dev(a)openjdk.java.net<mailto:hotspot-compiler-dev@openjdk.java.net> <hotspot-compiler-dev(a)openjdk.java.net<mailto:hotspot-compiler-dev@openjdk.java.net>>, aarch64-port-dev(a)openjdk.java.net<mailto:aarch64-port-dev@openjdk.java.net> <aarch64-port-dev(a)openjdk.java.net<mailto:aarch64-port-dev@openjdk.java.net>> Cc: nd <nd(a)arm.com<mailto:nd@arm.com>> Hi > Pengfei, I am sure you will be pleased to know this has finally been pushed to > the dev repo. Thanks a lot Andrew Dinn and Andrew Haley! This could not happen without your help. And for the next step, the follow-up patch for vectorization is almost ready. I will post it in another new thread soon later. -- Thanks, Pengfei

5 5