January 2021 - aarch64-port-dev

Re: [aarch64-port-dev ] [11u] RFR (S) 8212043: AArch64: Add floating-point Math.min/max intrinsics
by Hohensee, Paul 16 Feb '21

16 Feb '21

These look good, and I see you've tagged the issues. I'll do the Intel backports if these issues are approved. Thanks, Paul -----Original Message----- From: aarch64-port-dev <aarch64-port-dev-retn(a)openjdk.java.net> on behalf of Dmitry Chuyko <dmitry.chuyko(a)bell-sw.com> Date: Monday, January 25, 2021 at 12:15 PM To: "jdk-updates-dev(a)openjdk.java.net" <jdk-updates-dev(a)openjdk.java.net> Cc: "aarch64-port-dev(a)openjdk.java.net" <aarch64-port-dev(a)openjdk.java.net> Subject: RE: [aarch64-port-dev ] [11u] RFR (S) 8212043: AArch64: Add floating-point Math.min/max intrinsics Hi Paul, Thank you. Here are three pieces for aarch64 part (diffs do not depend on each other): Intrinsics: http://cr.openjdk.java.net/~dchuyko/8212043/webrev.11u.01/ Graal test: http://cr.openjdk.java.net/~dchuyko/8215687/webrev.11u.00/ jtreg test: http://cr.openjdk.java.net/~dchuyko/8218550/webrev.11u.00/ Testing: aarch64 build, tier1, tier2, Graal HotspotTest (with Graal enabled) - fails because of ECB, TestFpMinMaxIntrinsics. I'd be grateful if you take x86 part. -Dmitry On 1/22/21 10:34 PM, Hohensee, Paul wrote: > This looks fine to me, but please split the patch into two separate ones for 8212043 and 8215687, and push them together. > > Looking at the 8212043 links, we should also backport this test issue. > > https://bugs.openjdk.java.net/browse/JDK-8218550: Add test omitted from JDK-8212043 > > And, if we're going to do this for aarch64, I'd want to see the Intel version backported too, see > > https://bugs.openjdk.java.net/browse/JDK-8217561: X86: Add floating-point Math.min/max intrinsics > > and the issues linked from it. > > https://bugs.openjdk.java.net/browse/JDK-8220407: compiler/intrinsics/math/TestFpMinMaxIntrinsics.java timedout > https://bugs.openjdk.java.net/browse/JDK-8227222: vmTestbase/jit/FloatingPoint/gen_math/Loops04/Loops04.java hits assert(((!attributes->uses_vl()) || (attributes->get_vector_len() == AVX_512bit) || (!_legacy_mode_vl) || (attributes->is_legacy_mode()))) failed: XMM register should be 0-15 > > I'd be willing to take these on if the this aarch64 backport is approved. > > Thanks, > Paul > > -----Original Message----- > From: jdk-updates-dev <jdk-updates-dev-retn(a)openjdk.java.net> on behalf of Dmitry Chuyko <dmitry.chuyko(a)bell-sw.com> > Date: Tuesday, January 19, 2021 at 7:10 AM > To: "jdk-updates-dev(a)openjdk.java.net" <jdk-updates-dev(a)openjdk.java.net> > Cc: "aarch64-port-dev(a)openjdk.java.net" <aarch64-port-dev(a)openjdk.java.net> > Subject: [11u] RFR (S) 8212043: AArch64: Add floating-point Math.min/max intrinsics > > Hello, > > Original RFE: https://bugs.openjdk.java.net/browse/JDK-8212043 > Original post-fix: https://bugs.openjdk.java.net/browse/JDK-8215687 > > Original patch mostly applies cleanly except macro() additions in > classes.hpp that were missing surroundings - they are redone manually. > Initial post-fix for CheckGraalIntrinsics (HotspotTest) Graal test was > modified to mark new intrinsics as toBeInvestigated in JDK 11+ and this > change is included in the changeset. > > 11u webrev: http://cr.openjdk.java.net/~dchuyko/8212043/webrev.11u.00/ > > Testing: tier1, tier2; compiler/graalunit with Graal on - > CheckGraalIntrinsics fails because of ECB intrinsics (JDK-8229848, > jdk11u-jvmci-defer) but not not because of min/max. > > -- > Thanks, > -Dmitry > >

2 1

Re: [aarch64-port-dev ] [11u] RFR (S) 8212043: AArch64: Add floating-point Math.min/max intrinsics
by Hohensee, Paul 13 Feb '21

13 Feb '21

This looks fine to me, but please split the patch into two separate ones for 8212043 and 8215687, and push them together. Looking at the 8212043 links, we should also backport this test issue. https://bugs.openjdk.java.net/browse/JDK-8218550: Add test omitted from JDK-8212043 And, if we're going to do this for aarch64, I'd want to see the Intel version backported too, see https://bugs.openjdk.java.net/browse/JDK-8217561: X86: Add floating-point Math.min/max intrinsics and the issues linked from it. https://bugs.openjdk.java.net/browse/JDK-8220407: compiler/intrinsics/math/TestFpMinMaxIntrinsics.java timedout https://bugs.openjdk.java.net/browse/JDK-8227222: vmTestbase/jit/FloatingPoint/gen_math/Loops04/Loops04.java hits assert(((!attributes->uses_vl()) || (attributes->get_vector_len() == AVX_512bit) || (!_legacy_mode_vl) || (attributes->is_legacy_mode()))) failed: XMM register should be 0-15 I'd be willing to take these on if the this aarch64 backport is approved. Thanks, Paul -----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn(a)openjdk.java.net> on behalf of Dmitry Chuyko <dmitry.chuyko(a)bell-sw.com> Date: Tuesday, January 19, 2021 at 7:10 AM To: "jdk-updates-dev(a)openjdk.java.net" <jdk-updates-dev(a)openjdk.java.net> Cc: "aarch64-port-dev(a)openjdk.java.net" <aarch64-port-dev(a)openjdk.java.net> Subject: [11u] RFR (S) 8212043: AArch64: Add floating-point Math.min/max intrinsics Hello, Original RFE: https://bugs.openjdk.java.net/browse/JDK-8212043 Original post-fix: https://bugs.openjdk.java.net/browse/JDK-8215687 Original patch mostly applies cleanly except macro() additions in classes.hpp that were missing surroundings - they are redone manually. Initial post-fix for CheckGraalIntrinsics (HotspotTest) Graal test was modified to mark new intrinsics as toBeInvestigated in JDK 11+ and this change is included in the changeset. 11u webrev: http://cr.openjdk.java.net/~dchuyko/8212043/webrev.11u.00/ Testing: tier1, tier2; compiler/graalunit with Graal on - CheckGraalIntrinsics fails because of ECB intrinsics (JDK-8229848, jdk11u-jvmci-defer) but not not because of min/max. -- Thanks, -Dmitry

3 3

[8u] RFR: JDK-8257192: Integrate AArch64 JIT port into 8u
by Andrew Hughes 03 Feb '21

03 Feb '21

Umbrella Bug: https://bugs.openjdk.java.net/browse/JDK-8257192 Webrevs: jdk: https://cr.openjdk.java.net/~andrew/openjdk8/8257192/jdk/webrev.01/ hotspot: https://cr.openjdk.java.net/~andrew/openjdk8/8257192/hotspot/webrev.01/ The aarch64 port was originally developed at Red Hat against OpenJDK 7 and 8, then later integrated into OpenJDK 9. The 8u port has continued to be maintained in the aarch64-port/jdk8u and aarch64-port/shenandoah-jdk8u trees since and has been used for Red Hat's AArch64 binaries. It was also merged into the IcedTea HotSpot tree early in the development of OpenJDK 8u support, and later fixes have been cherry-picked across from the aarch64-port trees for each release. The port has been stable for a long time and, although it is a large patch, finally integrating it into 8u upstream should be low risk. There are few changes to shared HotSpot code (mostly header inclusion, the main one is memory barrier support for AArch64) and the 8u version of the port has had over half a decade of production use. To create the patch, the HotSpot sources for 8u275 and IcedTea's 3.17.1 (based on 8u275) were compared and a few minor unrelated fixes removed. The new sources were also compared against the copies in aarch64/shenandoah-jdk8u which showed only changes related to the Shenandoah garbage collector as missing. For the JDK changes, the few differences between aarch64/shenandoah-jdk8u's jdk repository and 8u's were resolved. The patch has fully bootstrapped on RHEL 7 + AArch64, applied on top of jdk8u282-b03. The bug list below was constructed by collating the AArch64 sections of the IcedTea release notes. It doesn't include any changes that don't have OpenJDK bugs, mainly from the initial development process. Let's get this integrated for 8u282 and make AArch64 a first class member of OpenJDK 8u. Just before rampdown is the best time to do this, as it always gives us the option to roll back to this point, without losing other 8u282 changes. This is what we also did with TLSv1.3. Such a rollback should be unnecessary though, as this port has been in production for a long time! Bugs: - JDK-7009641: Don't fail VM when CodeCache is full - JDK-8073108: [AArch64] Use x86 and SPARC CPU instructions for GHASH acceleration - JDK-8130309: Need to bailout cleanly if creation of stubs fails when codecache is out of space (AArch64 changes) - JDK-8131779: AARCH64: add Montgomery multiply intrinsic - JDK-8132875: AArch64: Fix error introduced into AArch64 CodeCache by commit for 8130309 - JDK-8135018: AARCH64: Missing memory barriers for CMS collector - JDK-8145320: Create unsafe_arraycopy and generic_arraycopy for AArch64 - JDK-8148328: aarch64: redundant lsr instructions in stub code. - JDK-8148783: aarch64: SEGV running SpecJBB2013 - JDK-8148948: aarch64: generate_copy_longs calls align() incorrectly - JDK-8149080: AArch64: Recognise disjoint array copy in stub code - JDK-8149365: aarch64: memory copy does not prefetch on backwards copy - JDK-8149907: aarch64: use load/store pair instructions in call_stub - JDK-8150038: aarch64: make use of CBZ and CBNZ when comparing narrow pointer with zero - JDK-8150045: arraycopy causes segfaults in SATB during garbage collection - JDK-8150082: aarch64: optimise small array copy - JDK-8150229: aarch64: pipeline class for several instructions is not set correctly - JDK-8150313: aarch64: optimise array copy using SIMD instructions - JDK-8150394: aarch64: add support for 8.1 LSE CAS instructions - JDK-8150652: Remove unused code in AArch64 back end - JDK-8151340: aarch64: prefetch the destination word for write prior to ldxr/stxr loops. - JDK-8151502: optimize pd_disjoint_words and pd_conjoint_words - JDK-8151775: aarch64: add support for 8.1 LSE atomic operations - JDK-8152537: aarch64: Make use of CBZ and CBNZ when comparing unsigned values with zero. - JDK-8152840: aarch64: improve _unsafe_arraycopy stub routine - JDK-8153172: aarch64: hotspot crashes after the 8.1 LSE patch is merged - JDK-8153713: aarch64: improve short array clearing using store pair - JDK-8153797: aarch64: Add Arrays.fill stub code - JDK-8154413: AArch64: Better byte behaviour - JDK-8154537: AArch64: some integer rotate instructions are never emitted - JDK-8154739: AArch64: TemplateTable::fast_xaccess loads in wrong mode - JDK-8155015: Aarch64: bad assert in spill generation code - JDK-8155100: AArch64: Relax alignment requirement for byte_map_base - JDK-8155612: Aarch64: vector nodes need to support misaligned offset - JDK-8155617: aarch64: ClearArray does not use DC ZVA - JDK-8155627: Enable SA on AArch64 - JDK-8155653: TestVectorUnalignedOffset.java not pushed with 8155612 - JDK-8156731: aarch64: java/util/Arrays/Correct.java fails due to _generic_arraycopy stub routine - JDK-8157841: aarch64: prefetch ignores cache line size - JDK-8157906: aarch64: some more integer rotate instructions are never emitted - JDK-8158913: aarch64: SEGV running Spark terasort - JDK-8159052: aarch64: optimise unaligned copies in pd_disjoint_words and pd_conjoint_words - JDK-8159063: aarch64: optimise unaligned array copy long - JDK-8160748: [AArch64] Inconsistent types for ideal_reg - JDK-8161072: AArch64: jtreg compiler/uncommontrap/TestDeoptOOM failure - JDK-8161190: AArch64: Fix overflow in immediate cmp instruction - JDK-8164113: AArch64: follow-up the fix for 8161598 - JDK-8165673: AArch64: Fix JNI floating point argument handling - JDK-8167200: AArch64: Broken stack pointer adjustment in interpreter - JDK-8167421: AArch64: in one core system, fatal error: Illegal threadstate encountered - JDK-8167595: AArch64: SEGV in stub code cipherBlockChaining_decryptAESCrypt - JDK-8168699: Validate special case invocations [AArch64 support] - JDK-8168888: Port 8160591: Improve internal array handling to AArch64. - JDK-8170100: AArch64: Crash in C1-compiled code accessing References - JDK-8170188: jtreg test compiler/types/TestMeetIncompatibleInterfaceArrays.java causes JVM crash - JDK-8170873: PPC64/aarch64: Poor StrictMath performance due to non-optimized compilation - JDK-8171537: aarch64: compiler/c1/Test6849574.java generates guarantee failure in C1 - JDK-8172881: AArch64: assertion failure: the int pressure is incorrect - JDK-8173472: AArch64: C1 comparisons with null only use 32-bit instructions - JDK-8176100: [AArch64] [REDO][REDO] G1 Needs pre barrier on dereference of weak JNI handles - JDK-8177661: Correct ad rule output register types from iRegX to iRegXNoSp - JDK-8179954: AArch64: C1 and C2 volatile accesses are not sequentially consistent - JDK-8182581: aarch64: fix for crash caused by earlyret of compiled method - JDK-8183925: [AArch64] Decouple crash protection from watcher thread - JDK-8186325: AArch64: jtreg test hotspot/test/gc/g1/TestJNIWeakG1/TestJNIWeakG1.java SEGV - JDK-8187224: aarch64: some inconsistency between aarch64_ad.m4 and aarch64.ad - JDK-8189170: [AArch64] Add option to disable stack overflow checking in primordial thread for use with JNI_CreateJavaJVM - JDK-8193133: Assertion failure because 0xDEADDEAD can be in-heap - JDK-8195685: AArch64 port of 8174962: Better interface invocations - JDK-8195859: AArch64: vtableStubs gtest fails after 8174962 - JDK-8196136: AArch64: Correct register use in patch for JDK-8194686 - JDK-8196221: AArch64: Mistake in committed patch for JDK-8195859 - JDK-8199712: [AArch64] Flight Recorder - JDK-8203481: Incorrect constraint for unextended_sp in frame:safe_for_sender - JDK-8203699: java/lang/invoke/SpecialInterfaceCall fails with SIGILL on aarch64 - JDK-8205421: AARCH64: StubCodeMark should be placed after alignment - JDK-8206163: AArch64: incorrect code generation for StoreCM - JDK-8207345: Trampoline generation code reads from uninitialized memory - JDK-8207838: AArch64: Float registers incorrectly restored in JNI call - JDK-8209413: AArch64: NPE in clhsdb jstack command - JDK-8209414: [AArch64] method handle invocation does not respect JVMTI interp_only mode - JDK-8209415: Fix JVMTI test failure HS202 - JDK-8209420: Track membars for volatile accesses so they can be properly optimized - JDK-8209835: Aarch64: elide barriers on all volatile operations - JDK-8210425: [AArch64] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization - JDK-8211064: [AArch64] Interpreter and c1 don't correctly handle jboolean results in native calls - JDK-8211233: MemBarNode::trailing_membar() and MemBarNode::leading_membar() need to handle dying subgraphs better - JDK-8213134: AArch64: vector shift failed with MaxVectorSize=8 - JDK-8213419: [AArch64] C2 may hang in MulLNode::Ideal()/MulINode::Ideal() with gcc 8.2.1 - JDK-8214857: "bad trailing membar" assert failure at memnode.cpp:3220 - JDK-8215951: AArch64: jtreg test vmTestbase/nsk/jvmti/PopFrame/popframe005 segfaults - JDK-8215961: jdk/jfr/event/os/TestCPUInformation.java fails on AArch64 - JDK-8216350: AArch64: monitor unlock fast path not called - JDK-8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64 - JDK-8217368: AArch64: C2 recursive stack locking optimisation not triggered - JDK-8218185: aarch64: missing LoadStore barrier in TemplateTable::putfield_or_static - JDK-8219011: Implement MacroAssembler::warn method on AArch64 - JDK-8219635: aarch64: missing LoadStore barrier in TemplateTable::fast_storefield - JDK-8221220: AArch64: Add StoreStore membar explicitly for Volatile Writes in TemplateTable - JDK-8221658: aarch64: add necessary predicate for ubfx patterns - JDK-8224671: AArch64: mauve System.arraycopy test failure - JDK-8224828: aarch64: rflags is not correct after safepoint poll - JDK-8224851: AArch64: fix warnings and errors with Clang and GCC 8.3 - JDK-8224880: AArch64: java/javac error with AllocatePrefetchDistance - JDK-8228400: Remove built-in AArch64 simulator - JDK-8228406: Superfluous change in chaitin.hpp - JDK-8228593: Revert explicit JDK 7 support additions - JDK-8228716: Revert InstanceKlass::print_on debug additions - JDK-8228718: Revert incorrect backport of JDK-8129757 to 8-aarch64 - JDK-8228725: AArch64: Purge method call format support - JDK-8228747: Revert "unused" attribute from test_arraycopy_func - JDK-8228767: Revert ResourceMark additions - JDK-8228770: Revert development hsdis changes - JDK-8229123: Revert build fixes for aarch64/zero - JDK-8229124: Revert disassembler.cpp changes - JDK-8229145: Revert TemplateTable::bytecode() visibility change - JDK-8233839: aarch64: missing memory barrier in NewObjectArrayStub and NewTypeArrayStub - JDK-8237512: AArch64: aarch64TestHook leaks a BufferBlob - JDK-8246482: Build failures with +JFR -PCH - JDK-8247979: aarch64: missing side effect of killing flags for clearArray_reg_reg - JDK-8248219: aarch64: missing memory barrier in fast_storefield and fast_accessfield -- Andrew :) Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222

6 15

git: openjdk/aarch64-port: master: 8260574: Remove parallel constructs in GenCollectedHeap::process_roots
by Thomas Schatzl 31 Jan '21

31 Jan '21

Changeset: 8a9004da Author: Albert Mingkun Yang <ayang(a)openjdk.org> Committer: Thomas Schatzl <tschatzl(a)openjdk.org> Date: 2021-01-31 17:03:37 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/8a9004da 8260574: Remove parallel constructs in GenCollectedHeap::process_roots Reviewed-by: tschatzl, kbarrett ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/serial/genMarkSweep.cpp ! src/hotspot/share/gc/serial/serialHeap.cpp ! src/hotspot/share/gc/serial/serialHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/strongRootsScope.cpp ! src/hotspot/share/gc/shared/strongRootsScope.hpp

1 0

git: openjdk/aarch64-port: master: 8260501: [Vector API] Improve register usage for shift operations on x86
by Jie Fu 31 Jan '21

31 Jan '21

Changeset: 0da9cad5 Author: Jie Fu <jiefu(a)openjdk.org> Date: 2021-01-31 00:27:55 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/0da9cad5 8260501: [Vector API] Improve register usage for shift operations on x86 Reviewed-by: vlivanov, kvn ! src/hotspot/cpu/x86/x86.ad

1 0

git: openjdk/aarch64-port: master: 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs
by Daniel D.Daugherty 30 Jan '21

30 Jan '21

Changeset: a61ff87c Author: Daniel D. Daugherty <dcubed(a)openjdk.org> Date: 2021-01-30 15:23:34 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/a61ff87c 8260685: ProblemList 2 compiler/jvmci/compilerToVM tests in Xcomp configs Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList-Xcomp.txt

1 0

git: openjdk/aarch64-port: master: 8260462: Missing <thead> in Modality.html
by Alexey Ivanov 30 Jan '21

30 Jan '21

Changeset: fcfe6478 Author: Alexey Ivanov <aivanov(a)openjdk.org> Date: 2021-01-30 11:54:59 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/fcfe6478 8260462: Missing <thead> in Modality.html Reviewed-by: serb, psadhukhan ! src/java.desktop/share/classes/java/awt/doc-files/Modality.html

1 0

git: openjdk/aarch64-port: master: 8260630: Templatize literal_size
by Kim Barrett 30 Jan '21

30 Jan '21

Changeset: 67a34daf Author: Kim Barrett <kbarrett(a)openjdk.org> Date: 2021-01-30 09:56:53 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/67a34daf 8260630: Templatize literal_size 8260629: Remove explicit instantiation of Hashtable with oop value Reviewed-by: pliden, tschatzl, coleenp ! src/hotspot/share/utilities/hashtable.cpp

1 0

git: openjdk/aarch64-port: master: 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB
by Yasumasa Suenaga 30 Jan '21

30 Jan '21

Changeset: 6b24e98c Author: Yasumasa Suenaga <ysuenaga(a)openjdk.org> Date: 2021-01-30 03:46:23 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/6b24e98c 8259008: ArithmeticException was thrown at "Monitor Cache Dump" on HSDB Reviewed-by: dcubed, gziemski, eosterlund, cjplummer, sspitsyn ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectSynchronizer.java + test/hotspot/jtreg/serviceability/sa/TestObjectMonitorIterate.java

1 0

git: openjdk/aarch64-port: master: 8249867: xml declaration is not followed by a newline
by Joe Wang 30 Jan '21

30 Jan '21

Changeset: 69ee314b Author: Joe Wang <joehw(a)openjdk.org> Date: 2021-01-30 02:34:52 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/69ee314b 8249867: xml declaration is not followed by a newline Reviewed-by: rriggs, naoto, lancea, dfuchs ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToStream.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/DOMConstants.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/LSSerializerImpl.java ! src/java.xml/share/classes/module-info.java ! test/jaxp/javax/xml/jaxp/unittest/common/prettyprint/PrettyPrintTest.java

1 0