April 2021 - aarch64-port-dev

Re: [aarch64-port-dev ] JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
by Bernhard Urban-Forster 30 Jun '21

30 Jun '21

Thanks Vladimir and Andrew! > 1) support for macos/aarch64 is not just jep-391, we split our jep into pieces, > some of them were macos/aarch64 independent and were pushed to upstream > as separate commits ( for example, macos MAP_JIT support). also some > important pieces from community ( like JNF dependency removal by Phil Race). > All these pieces need to be backported before jep-391. For JEP 388 we have a similar situation, although those independent changes are at a smaller scale I would say. For example let's have a look at JDK-8248403 [1], does it need its own PR on the jdk11u repository or is it fine package it all together in one big PR? Here is a rebased jdk11u branch btw: https://github.com/lewurm/jdk11u/commits/jdk11u-windows > 2) we have a plan to go in a traditional way, ojdk17 -> ojdk15 -> ojdk13 > -> ojdk11 I would say jdk13u/jdk15u is low-priority for us, but I can have a look at them for JEP 388 once I've figured out the process for jdk11u (assuming it's the same). > Cross compilation is not a requirement for a backport. Cross compilation is the only way to build Windows+Arm64 today, so we need at least the hacky variant that I suggested. Thanks, -Bernhard [1] https://bugs.openjdk.java.net/browse/JDK-8248403 ________________________________________ From: Vladimir Kempik Sent: Wednesday, March 24, 2021 09:53 To: Bernhard Urban-Forster Cc: Andrew Haley; Anton Kozlov; aarch64-port-dev(a)openjdk.java.net; Monica Beckwith; jdk-updates-dev(a)openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u Hello there are few caveats with backporting jep-391: 1) support for macos/aarch64 is not just jep-391, we split our jep into pieces, some of them were macos/aarch64 independent and were pushed to upstream as separate commits ( for example, macos MAP_JIT support). also some important pieces from community ( like JNF dependency removal by Phil Race). All these pieces need to be backported before jep-391. 2) we have a plan to go in a traditional way, ojdk17 -> ojdk15 -> ojdk13 -> ojdk11 If you don’t want to bother with jdk15/13 I would suggest you to go without waiting for jep-391. Regards , Vladimir > 24 марта 2021 г., в 00:35, Bernhard Urban-Forster <beurba(a)microsoft.com> написал(а): > > Hello, > > Spinning off the discussion from here: https://github.com/openjdk/jdk/pull/2200#issuecomment-804927150 > > And further context, there have been some discussions about it before: > https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-October/00972… > > > Open questions: > > 1. JEP 391 (macOS/AArch64) has a dependency on JEP 388, and I'm assuming we want both to be backported. Question: Is it preferred to do it one go (both together), or should we do it separately (that would be Windows first, then macOS)? > > 2. JEP 388 includes build changes to add cross compilation support for Windows in a hacky way. It's enough to get a build out of it [1], but it's not exactly clean. It was eventually cleaned up with the "WINENV" patch by Magnus [2], but imho it isn't trivial to backport that change. Thoughts? > > > Assuming the answer to question 1 is to split the backports: I think https://github.com/openjdk/aarch64-port/tree/jdk11-windows by Ludovic is in an okay shape, but I will take it for a spin tomorrow and then submit an initial PR against https://github.com/openjdk/jdk11u > > > Thank you, > -Bernhard > > > [1] with workarounds: https://github.com/openjdk/jdk/pull/212#issuecomment-695024586 > [2] https://github.com/openjdk/jdk/pull/1597

8 20

git: openjdk/aarch64-port: master: 8266328: C2: Remove InlineWarmCalls
by Vladimir Ivanov 30 Apr '21

30 Apr '21

Changeset: f86b70c3 Author: Vladimir Ivanov <vlivanov(a)openjdk.org> Date: 2021-04-30 22:17:04 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/f86b70c391c2909676a7d9821b… 8266328: C2: Remove InlineWarmCalls Reviewed-by: kvn, iveresov ! src/hotspot/share/opto/bytecodeInfo.cpp ! src/hotspot/share/opto/c2_globals.hpp ! src/hotspot/share/opto/callGenerator.cpp ! src/hotspot/share/opto/callGenerator.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/doCall.cpp ! src/hotspot/share/opto/parse.hpp

1 0

git: openjdk/aarch64-port: master: 8252237: C2: Call to compute_separating_interferences has wrong argument order
by Rahul Raghavan 30 Apr '21

30 Apr '21

Changeset: 928d6324 Author: Rahul Raghavan <rraghavan(a)openjdk.org> Date: 2021-04-30 20:15:48 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/928d63242e614676f96bd3e6bf… 8252237: C2: Call to compute_separating_interferences has wrong argument order Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/coalesce.cpp

1 0

git: openjdk/aarch64-port: master: 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all
by Daniel D.Daugherty 30 Apr '21

30 Apr '21

Changeset: 50fa1623 Author: Daniel D. Daugherty <dcubed(a)openjdk.org> Date: 2021-04-30 19:55:19 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/50fa1623adca74f79413fd127d… 8266389: ProblemList java/awt/Graphics2D/DrawString/DrawRotatedStringUsingRotatedFont.java on generic-all Reviewed-by: mikael, prr ! test/jdk/ProblemList.txt

1 0

git: openjdk/aarch64-port: master: 8266155: Convert java.base to use Stream.toList()
by Pavel Rappo 30 Apr '21

30 Apr '21

Changeset: dd05158b Author: Ian Graves <igraves(a)openjdk.org> Committer: Pavel Rappo <prappo(a)openjdk.org> Date: 2021-04-30 19:52:26 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/dd05158b24e8b399052a170ea9… 8266155: Convert java.base to use Stream.toList() Reviewed-by: bpb, naoto, iris, chegar ! src/java.base/share/classes/java/lang/String.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/util/ResourceBundle.java ! src/java.base/share/classes/jdk/internal/module/IllegalAccessLogger.java ! src/java.base/share/classes/jdk/internal/module/ModulePatcher.java ! src/java.base/share/classes/jdk/internal/module/ModuleReferences.java ! src/java.base/share/classes/sun/net/util/IPAddressUtil.java ! src/java.base/share/classes/sun/util/locale/LocaleMatcher.java

1 0

git: openjdk/aarch64-port: master: 8260560: convert jdeps and jdeprscan tools to use Stream.toList()
by Pavel Rappo 30 Apr '21

30 Apr '21

Changeset: c36c63a0 Author: Ian Graves <igraves(a)openjdk.org> Committer: Pavel Rappo <prappo(a)openjdk.org> Date: 2021-04-30 19:51:36 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/c36c63a008fa5e8b00dfc36c88… 8260560: convert jdeps and jdeprscan tools to use Stream.toList() Reviewed-by: alanb, mchung, iris ! src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/Main.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/scan/Scan.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ClassFileReader.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/ModuleInfoBuilder.java

1 0

git: openjdk/aarch64-port: master: 8266318: Switch to macos prefix for macOS bundles
by Mikael Vidstedt 30 Apr '21

30 Apr '21

Changeset: 096e9e5d Author: Mikael Vidstedt <mikael(a)openjdk.org> Date: 2021-04-30 19:05:39 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/096e9e5d13183f947089b5c792… 8266318: Switch to macos prefix for macOS bundles Reviewed-by: prr, erikj, iris ! .github/workflows/submit.yml ! make/autoconf/platform.m4 ! make/conf/jib-profiles.js

1 0

git: openjdk/aarch64-port: master: 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface
by Daniel Fuchs 30 Apr '21

30 Apr '21

Changeset: 0544a732 Author: Daniel Fuchs <dfuchs(a)openjdk.org> Date: 2021-04-30 17:21:55 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/0544a732a44309bf7cbb44846d… 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface Reviewed-by: chegar ! src/java.net.http/share/classes/jdk/internal/net/http/Stream.java ! test/jdk/java/net/httpclient/http2/server/Http2TestServerConnection.java

1 0

git: openjdk/aarch64-port: master: 8266220: keytool still prompt for store password on a password-less pkcs12 file if -storetype pkcs12 is specified
by Weijun Wang 30 Apr '21

30 Apr '21

Changeset: 48bb996a Author: Weijun Wang <weijun(a)openjdk.org> Date: 2021-04-30 14:04:13 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/48bb996ac9098fc33f6d52e2af… 8266220: keytool still prompt for store password on a password-less pkcs12 file if -storetype pkcs12 is specified Reviewed-by: coffeys, hchao ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! test/jdk/sun/security/tools/keytool/PKCS12Passwd.java

1 0

git: openjdk/aarch64-port: master: 8266040: Lanai: Incorrect calculations of clipping boundaries
by Jayathirth D V 30 Apr '21

30 Apr '21

Changeset: 87de5b75 Author: Alexey Ushakov <avu(a)openjdk.org> Committer: Jayathirth D V <jdv(a)openjdk.org> Date: 2021-04-30 13:53:58 +0000 URL: https://git.openjdk.java.net/aarch64-port/commit/87de5b750d2289512f002ecd30… 8266040: Lanai: Incorrect calculations of clipping boundaries Reviewed-by: jdv ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLClip.m ! src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m

1 0