RFR: 8196221: AArch64: Mistake in committed patch for JDK-8195859
Apologies in advance -- I'm really not having a very good week ... The patch submitted for review for 8195859 )and, worse, committed to the dev jdk and jdk10 repos) was not the one applied to the test JVM. It omitted a call argument. As a consequence my testing succeeded but the AArch64 build is still broken and in need of update -- both the dev jdk tree and jdk10. The following extra patch inserts the extra argument in the offending call. jira: https://bugs.openjdk.java.net/browse/JDK-8196221 webrev: http://cr.openjdk.java.net/~adinn/8196221/webrev/ Testing: As per 8195859 i.e. the gtest now succeeds and standard java programs work. But ... this time the submitted patch was definitely the one used to update the dev jdk and jdk10 test JVMs which passed the tests. regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
On 26/01/18 17:26, Andrew Dinn wrote:
jira: https://bugs.openjdk.java.net/browse/JDK-8196221 webrev: http://cr.openjdk.java.net/~adinn/8196221/webrev/
OK, thanks. :-) -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hi Andrew, Please, follow fix request process for jdk 10 if you want to push this into jdk10: http://openjdk.java.net/projects/jdk/10/fix-request-process Vladimir On 1/26/18 9:26 AM, Andrew Dinn wrote:
Apologies in advance -- I'm really not having a very good week ...
The patch submitted for review for 8195859 )and, worse, committed to the dev jdk and jdk10 repos) was not the one applied to the test JVM. It omitted a call argument. As a consequence my testing succeeded but the AArch64 build is still broken and in need of update -- both the dev jdk tree and jdk10.
The following extra patch inserts the extra argument in the offending call.
jira: https://bugs.openjdk.java.net/browse/JDK-8196221 webrev: http://cr.openjdk.java.net/~adinn/8196221/webrev/
Testing:
As per 8195859 i.e. the gtest now succeeds and standard java programs work. But ... this time the submitted patch was definitely the one used to update the dev jdk and jdk10 test JVMs which passed the tests.
regards,
Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
Hi Vladimir, On 26/01/18 19:41, Vladimir Kozlov wrote:
Hi Andrew,
Please, follow fix request process for jdk 10 if you want to push this into jdk10:
http://openjdk.java.net/projects/jdk/10/fix-request-process I have labelled the JIRA withjdk10-fix-request and added the necessary explanatory comment.
Thanks for responding to this (and also the previous patches). regards, Andrew Dinn -----------
Approved. Regards, Vladimir On 1/27/18 8:53 AM, Andrew Dinn wrote:
Hi Vladimir,
On 26/01/18 19:41, Vladimir Kozlov wrote:
Hi Andrew,
Please, follow fix request process for jdk 10 if you want to push this into jdk10:
http://openjdk.java.net/projects/jdk/10/fix-request-process I have labelled the JIRA withjdk10-fix-request and added the necessary explanatory comment.
Thanks for responding to this (and also the previous patches).
regards,
Andrew Dinn -----------
On 29/01/18 20:21, Vladimir Kozlov wrote:
Approved. Thanks, Vladimir. I have pushed the patch to the jdk development jdk10 and jdk trees.
regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
participants (3)
-
Andrew Dinn
-
Andrew Haley
-
Vladimir Kozlov