RFR: 8149907: aarch64: use load/store pair instructions in call_stub
Hi, Please review the following webrev: http://cr.openjdk.java.net/~fyang/8149907/webrev.00/ Jira issue: https://bugs.openjdk.java.net/browse/JDK-8149907 This patch make use of load/store pair instructions in call_stub saving 24 load/store instructions. Tested with jtreg hotspot & langtools. Is it OK? Thanks, Felix.
On 02/16/2016 11:28 AM, Felix Yang wrote:
Please review the following webrev: http://cr.openjdk.java.net/~fyang/8149907/webrev.00/
I guess this is okay, but it's a lot less self-documenting than it was. If there are any unused locals (e.g. r27_save) you must delete them or use them in assertions. Andrew.
Hi Andrew, Thanks for the suggestions. I have updated the patch with the unused locals removed. New webrev: http://cr.openjdk.java.net/~fyang/8149907/webrev.01/ How about this one? Thanks for your help, Felix On 16 February 2016 at 19:46, Andrew Haley <aph@redhat.com> wrote:
On 02/16/2016 11:28 AM, Felix Yang wrote:
Please review the following webrev: http://cr.openjdk.java.net/~fyang/8149907/webrev.00/
I guess this is okay, but it's a lot less self-documenting than it was.
If there are any unused locals (e.g. r27_save) you must delete them or use them in assertions.
Andrew.
On 02/17/2016 02:11 PM, Felix Yang wrote:
Thanks for the suggestions. I have updated the patch with the unused locals removed. New webrev: http://cr.openjdk.java.net/~fyang/8149907/webrev.01/ How about this one?
What are r19_off and its friends used for now? Why are they still defined? Andrew.
Hi, I updated the webrev with the unused ENUM members removed. New webrev: http://cr.openjdk.java.net/~fyang/8149907/webrev.02/ Thanks, Felix On 17 February 2016 at 22:16, Andrew Haley <aph@redhat.com> wrote:
On 02/17/2016 02:11 PM, Felix Yang wrote:
Thanks for the suggestions. I have updated the patch with the unused locals removed. New webrev: http://cr.openjdk.java.net/~fyang/8149907/webrev.01/ How about this one?
What are r19_off and its friends used for now? Why are they still defined?
Andrew.
participants (2)
-
Andrew Haley
-
Felix Yang