[PATCH] [jdk8u] jvm.cfg parsing broken, resulting in broken JDK
Webrev: http://cr.openjdk.java.net/~andrew/aarch64-8/sync/jdk.webrev.02/ This change: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/2940c1ead99bd7635 introduced a change to jvm.cfg parsing local to the 8u port. Then, this change: http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/9399aa7ef558 removed part of that patch, breaking jvm.cfg parsing: "Error: missing `client' JVM at `/builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-6.b15.fc24.aarch64/openjdk/build/jdk8.build/images/j2sdk-image/jre/lib/aarch64/client/libjvm.so'." [0] This webrev removes the rest of 2940c1ead99bd7635 and replaces jvm.cfg with the version used in OpenJDK 9, allowing aarch64/jdk8u to build again. Ok to push? [0] https://bugzilla.redhat.com/show_bug.cgi?id=1307224#c14 -- Andrew :) Senior Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
On 25/02/16 00:34, Andrew Hughes wrote:
Webrev: http://cr.openjdk.java.net/~andrew/aarch64-8/sync/jdk.webrev.02/
This change:
http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/2940c1ead99bd7635
introduced a change to jvm.cfg parsing local to the 8u port. Then, this change:
http://hg.openjdk.java.net/aarch64-port/jdk8u/jdk/rev/9399aa7ef558
removed part of that patch, breaking jvm.cfg parsing:
"Error: missing `client' JVM at `/builddir/build/BUILD/java-1.8.0-openjdk-1.8.0.72-6.b15.fc24.aarch64/openjdk/build/jdk8.build/images/j2sdk-image/jre/lib/aarch64/client/libjvm.so'." [0]
This webrev removes the rest of 2940c1ead99bd7635 and replaces jvm.cfg with the version used in OpenJDK 9, allowing aarch64/jdk8u to build again.
Ok to push?
Yes, this looks right to me. It also explains why my latest build is having problems when I run without -server. So, please push. regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in UK and Wales under Company Registration No. 3798903 Directors: Michael Cunningham (US), Michael O'Neill (Ireland), Paul Argiry (US)
participants (2)
-
Andrew Dinn
-
Andrew Hughes