Re: [aarch64-port-dev ] JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Thanks Vladimir and Andrew!
1) support for macos/aarch64 is not just jep-391, we split our jep into pieces, some of them were macos/aarch64 independent and were pushed to upstream as separate commits ( for example, macos MAP_JIT support). also some important pieces from community ( like JNF dependency removal by Phil Race). All these pieces need to be backported before jep-391.
For JEP 388 we have a similar situation, although those independent changes are at a smaller scale I would say. For example let's have a look at JDK-8248403 [1], does it need its own PR on the jdk11u repository or is it fine package it all together in one big PR? Here is a rebased jdk11u branch btw: https://github.com/lewurm/jdk11u/commits/jdk11u-windows
2) we have a plan to go in a traditional way, ojdk17 -> ojdk15 -> ojdk13 -> ojdk11
I would say jdk13u/jdk15u is low-priority for us, but I can have a look at them for JEP 388 once I've figured out the process for jdk11u (assuming it's the same).
Cross compilation is not a requirement for a backport.
Cross compilation is the only way to build Windows+Arm64 today, so we need at least the hacky variant that I suggested. Thanks, -Bernhard [1] https://bugs.openjdk.java.net/browse/JDK-8248403 ________________________________________ From: Vladimir Kempik Sent: Wednesday, March 24, 2021 09:53 To: Bernhard Urban-Forster Cc: Andrew Haley; Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u Hello there are few caveats with backporting jep-391: 1) support for macos/aarch64 is not just jep-391, we split our jep into pieces, some of them were macos/aarch64 independent and were pushed to upstream as separate commits ( for example, macos MAP_JIT support). also some important pieces from community ( like JNF dependency removal by Phil Race). All these pieces need to be backported before jep-391. 2) we have a plan to go in a traditional way, ojdk17 -> ojdk15 -> ojdk13 -> ojdk11 If you don’t want to bother with jdk15/13 I would suggest you to go without waiting for jep-391. Regards , Vladimir
24 марта 2021 г., в 00:35, Bernhard Urban-Forster <beurba@microsoft.com> написал(а):
Hello,
Spinning off the discussion from here: https://github.com/openjdk/jdk/pull/2200#issuecomment-804927150
And further context, there have been some discussions about it before: https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-October/009727...
Open questions:
1. JEP 391 (macOS/AArch64) has a dependency on JEP 388, and I'm assuming we want both to be backported. Question: Is it preferred to do it one go (both together), or should we do it separately (that would be Windows first, then macOS)?
2. JEP 388 includes build changes to add cross compilation support for Windows in a hacky way. It's enough to get a build out of it [1], but it's not exactly clean. It was eventually cleaned up with the "WINENV" patch by Magnus [2], but imho it isn't trivial to backport that change. Thoughts?
Assuming the answer to question 1 is to split the backports: I think https://github.com/openjdk/aarch64-port/tree/jdk11-windows by Ludovic is in an okay shape, but I will take it for a spin tomorrow and then submit an initial PR against https://github.com/openjdk/jdk11u
Thank you, -Bernhard
[1] with workarounds: https://github.com/openjdk/jdk/pull/212#issuecomment-695024586 [2] https://github.com/openjdk/jdk/pull/1597
On 3/24/21 10:10 PM, Bernhard Urban-Forster wrote:
Cross compilation is not a requirement for a backport. Cross compilation is the only way to build Windows+Arm64 today, so we need at least the hacky variant that I suggested.
Time to fix that, surely? A bootstrapping build should be a minimum. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
On 3/24/21 10:10 PM, Bernhard Urban-Forster wrote:
Here is a rebased jdk11u branch btw: https://github.com/lewurm/jdk11u/commits/jdk11u-windows
Can you create a PR against current https://github.com/openjdk/jdk11u, please? -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Cross compilation is the only way to build Windows+Arm64 today, so we need at least the hacky variant that I suggested. Time to fix that, surely? A bootstrapping build should be a minimum.
The problem is that MSVC and friends aren't available for Windows/AArch64 host, and there is no ETA when Microsoft is gonna ship them [1, 2]. Also cygwin isn't available. You could run both via emulation, but that's not fun. The only viable route on that front is to build through WSL1 (support for that was added by the aforementioned WINENV patch) which would replace the cygwin environment, but would still run x86 MSVC binaries through emulation. However that scenario doesn't even work yet on tip today.
Can you create a PR against current https://github.com/openjdk/jdk11u please?
Bot said no :-/ https://github.com/openjdk/jdk11u/pull/2 What happened to switching it over to Skara tooling [3]? I *really* wanna avoid dealing with webrevs. -Bernhard [1] https://developercommunity.visualstudio.com/t/ARM64-Build-of-Visual-Studio/8... [2] https://developercommunity.visualstudio.com/t/Native-ARM-Support-for-Visual-... [3] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-February/004934... ________________________________________ From: Andrew Haley <aph@redhat.com> Sent: Thursday, March 25, 2021 16:11 To: Bernhard Urban-Forster; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u On 3/24/21 10:10 PM, Bernhard Urban-Forster wrote:
Can you create a PR against current https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk11u&data=04%7C01%7Cbeurba%40microsoft.com%7C445121a02e404d77c1d908d8efa0639f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522819449702559%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=MqWuufR9B9%2FpGhhmygD4NxiMY3Iy2YrGhp5EZSxaGh4%3D&reserved=0, please? -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2F&data=04%7C01%7Cbeurba%40microsoft.com%7C445121a02e404d77c1d908d8efa0639f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522819449702559%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VNOEr3y9eQCp7vGIfdSZtPr%2B4nZheGXVTXRE%2FZVuf9Y%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeybase.io%2Fandrewhaley&data=04%7C01%7Cbeurba%40microsoft.com%7C445121a02e404d77c1d908d8efa0639f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522819449702559%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=CQjNW1ZMiqi2kd24oikuB%2BqtVTgriwuod6%2Bxosp1NUE%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
On 3/25/21 4:00 PM, Bernhard Urban-Forster wrote:
Bot said no :-/ https://github.com/openjdk/jdk11u/pull/2
Huh? It looks fine. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
On Thu, 2021-03-25 at 16:21 +0000, Andrew Haley wrote:
On 3/25/21 4:00 PM, Bernhard Urban-Forster wrote:
Bot said no :-/ https://github.com/openjdk/jdk11u/pull/2
Huh? It looks fine.
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs. It hasn't been announced that we actually transition, unfortunately. I don't see anything beyond the proposal email, but we have had a meeting where the proposal was agreed on. Let me ask Christoph about what's up with the skara announcement for 11u. Thanks, Severin [1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-February/004934...
On 3/25/21 4:30 PM, Severin Gehwolf wrote:
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer
auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
Hah, that's actually a good idea! Let's do the review feedback loop on that PR, and once finalized I can turn that into a webrev. That doesn't sound too painful to me :-) Thanks, -Bernhard ________________________________________ From: Andrew Haley <aph@redhat.com> Sent: Thursday, March 25, 2021 17:42 To: Severin Gehwolf; Bernhard Urban-Forster; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u On 3/25/21 4:30 PM, Severin Gehwolf wrote:
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2F&data=04%7C01%7Cbeurba%40microsoft.com%7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gq599kym0%2BA8M%2BYjHUKR84Mw5od3vS2dLZ5PfjI1%2FIg%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeybase.io%2Fandrewhaley&data=04%7C01%7Cbeurba%40microsoft.com%7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=I0HxiyMAwKx1sYxvy8%2Fs8arCVLjO0g2LFDOJKGkMPak%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hello everyone, bumping this thread. Could I get some eyes on https://github.com/openjdk/jdk11u/pull/2 ? The current plan is to get the review done on GitHub and once everyone is happy, I'll convert it into a webrev. Thanks, -Bernhard ________________________________________ From: Bernhard Urban-Forster <beurba@microsoft.com> Sent: Thursday, March 25, 2021 22:48 To: Andrew Haley; Severin Gehwolf; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer
auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
Hah, that's actually a good idea! Let's do the review feedback loop on that PR, and once finalized I can turn that into a webrev. That doesn't sound too painful to me :-) Thanks, -Bernhard ________________________________________ From: Andrew Haley <aph@redhat.com> Sent: Thursday, March 25, 2021 17:42 To: Severin Gehwolf; Bernhard Urban-Forster; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u On 3/25/21 4:30 PM, Severin Gehwolf wrote:
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.redhat.com%2F&data=04%7C01%7Cbeurba%40microsoft.com%7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=gq599kym0%2BA8M%2BYjHUKR84Mw5od3vS2dLZ5PfjI1%2FIg%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeybase.io%2Fandrewhaley&data=04%7C01%7Cbeurba%40microsoft.com%7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=I0HxiyMAwKx1sYxvy8%2Fs8arCVLjO0g2LFDOJKGkMPak%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
On 4/30/21 10:09 PM, Bernhard Urban-Forster wrote:
bumping this thread. Could I get some eyes on https://github.com/openjdk/jdk11u/pull/2 ?
The current plan is to get the review done on GitHub and once everyone is happy, I'll convert it into a webrev.
It all looks fine to me. We'll be moving 11u to GitHub soon, so you can just copy your pull request over. As soon as the 11u transition is done, we can push it. I'd like to figure out some way to kick the tyres myself without a ton of effort. Maybe a Windows VM on a Mac M1 works? -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hello Well, it works, parallels 16.5 or qemu with m1 patches and win10 arm64 insider image from MS. Regards, Vladimir
1 мая 2021 г., в 12:04, Andrew Haley <aph@redhat.com> написал(а):
On 4/30/21 10:09 PM, Bernhard Urban-Forster wrote:
bumping this thread. Could I get some eyes on https://github.com/openjdk/jdk11u/pull/2 ?
The current plan is to get the review done on GitHub and once everyone is happy, I'll convert it into a webrev.
It all looks fine to me. We'll be moving 11u to GitHub soon, so you can just copy your pull request over.
As soon as the 11u transition is done, we can push it. I'd like to figure out some way to kick the tyres myself without a ton of effort. Maybe a Windows VM on a Mac M1 works?
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hi, just had a quick look at the PR. Since it contains several changes which are backports of a JBS bug item each, we should talk to the Skara folks on whether it's possible to merge such PRs somehow without squashing and with creating backports items in JBS for each change. Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Bernhard Urban-Forster Sent: Freitag, 30. April 2021 23:10 To: aph <aph@redhat.com>; Vladimir Kempik <vkempik@azul.com> Cc: Anton Kozlov <akozlov@azul.com>; aarch64-port-dev@openjdk.java.net; Monica Beckwith <Monica.Beckwith@microsoft.com>; jdk-updates- dev@openjdk.java.net; Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>; openjdk-aarch64 <openjdk- aarch64@microsoft.com> Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Hello everyone,
bumping this thread. Could I get some eyes on https://github.com/openjdk/jdk11u/pull/2 ?
The current plan is to get the review done on GitHub and once everyone is happy, I'll convert it into a webrev.
Thanks, -Bernhard
________________________________________ From: Bernhard Urban-Forster <beurba@microsoft.com> Sent: Thursday, March 25, 2021 22:48 To: Andrew Haley; Severin Gehwolf; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer
auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
Hah, that's actually a good idea! Let's do the review feedback loop on that PR, and once finalized I can turn that into a webrev. That doesn't sound too painful to me :-)
Thanks, -Bernhard
________________________________________ From: Andrew Haley <aph@redhat.com> Sent: Thursday, March 25, 2021 17:42 To: Severin Gehwolf; Bernhard Urban-Forster; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 3/25/21 4:30 PM, Severin Gehwolf wrote:
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw ww.redhat.com%2F&data=04%7C01%7Cbeurba%40microsoft.com%7C7 5b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47 %7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIj oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 000&sdata=gq599kym0%2BA8M%2BYjHUKR84Mw5od3vS2dLZ5PfjI1%2F Ig%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkey base.io%2Fandrewhaley&data=04%7C01%7Cbeurba%40microsoft.com %7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd01 1db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 D%7C1000&sdata=I0HxiyMAwKx1sYxvy8%2Fs8arCVLjO0g2LFDOJKGkMP ak%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
No, the Skara tooling will squash them into a single commit. You can still list all bugs in that commit, and it will create a backport record for each, but if they are in a single PR, then there will be one commit pushed to the repo. -- Kevin On 5/5/2021 2:15 PM, Langer, Christoph wrote:
Hi,
just had a quick look at the PR. Since it contains several changes which are backports of a JBS bug item each, we should talk to the Skara folks on whether it's possible to merge such PRs somehow without squashing and with creating backports items in JBS for each change.
Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Bernhard Urban-Forster Sent: Freitag, 30. April 2021 23:10 To: aph <aph@redhat.com>; Vladimir Kempik <vkempik@azul.com> Cc: Anton Kozlov <akozlov@azul.com>; aarch64-port-dev@openjdk.java.net; Monica Beckwith <Monica.Beckwith@microsoft.com>; jdk-updates- dev@openjdk.java.net; Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>; openjdk-aarch64 <openjdk- aarch64@microsoft.com> Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Hello everyone,
bumping this thread. Could I get some eyes on https://github.com/openjdk/jdk11u/pull/2 ?
The current plan is to get the review done on GitHub and once everyone is happy, I'll convert it into a webrev.
Thanks, -Bernhard
________________________________________ From: Bernhard Urban-Forster <beurba@microsoft.com> Sent: Thursday, March 25, 2021 22:48 To: Andrew Haley; Severin Gehwolf; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer
auto-close PRs. Sure. I don't care if it's been auto-closed, I can still review it. Hah, that's actually a good idea! Let's do the review feedback loop on that PR, and once finalized I can turn that into a webrev. That doesn't sound too painful to me :-)
Thanks, -Bernhard
________________________________________ From: Andrew Haley <aph@redhat.com> Sent: Thursday, March 25, 2021 17:42 To: Severin Gehwolf; Bernhard Urban-Forster; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 3/25/21 4:30 PM, Severin Gehwolf wrote:
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs. Sure. I don't care if it's been auto-closed, I can still review it.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw ww.redhat.com%2F&data=04%7C01%7Cbeurba%40microsoft.com%7C7 5b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47 %7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIj oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 000&sdata=gq599kym0%2BA8M%2BYjHUKR84Mw5od3vS2dLZ5PfjI1%2F Ig%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkey base.io%2Fandrewhaley&data=04%7C01%7Cbeurba%40microsoft.com %7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd01 1db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 D%7C1000&sdata=I0HxiyMAwKx1sYxvy8%2Fs8arCVLjO0g2LFDOJKGkMP ak%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hello what is the current state of this backport? can this be now integrated into git’s jdk11u-dev, so we can follow up with jep-391 backport ? Regards, Vladimir.
6 мая 2021 г., в 00:15, Langer, Christoph <christoph.langer@sap.com> написал(а):
Hi,
just had a quick look at the PR. Since it contains several changes which are backports of a JBS bug item each, we should talk to the Skara folks on whether it's possible to merge such PRs somehow without squashing and with creating backports items in JBS for each change.
Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Bernhard Urban-Forster Sent: Freitag, 30. April 2021 23:10 To: aph <aph@redhat.com>; Vladimir Kempik <vkempik@azul.com> Cc: Anton Kozlov <akozlov@azul.com>; aarch64-port-dev@openjdk.java.net; Monica Beckwith <Monica.Beckwith@microsoft.com>; jdk-updates- dev@openjdk.java.net; Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>; openjdk-aarch64 <openjdk- aarch64@microsoft.com> Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Hello everyone,
bumping this thread. Could I get some eyes on https://github.com/openjdk/jdk11u/pull/2 ?
The current plan is to get the review done on GitHub and once everyone is happy, I'll convert it into a webrev.
Thanks, -Bernhard
________________________________________ From: Bernhard Urban-Forster <beurba@microsoft.com> Sent: Thursday, March 25, 2021 22:48 To: Andrew Haley; Severin Gehwolf; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer
auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
Hah, that's actually a good idea! Let's do the review feedback loop on that PR, and once finalized I can turn that into a webrev. That doesn't sound too painful to me :-)
Thanks, -Bernhard
________________________________________ From: Andrew Haley <aph@redhat.com> Sent: Thursday, March 25, 2021 17:42 To: Severin Gehwolf; Bernhard Urban-Forster; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 3/25/21 4:30 PM, Severin Gehwolf wrote:
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw ww.redhat.com%2F&data=04%7C01%7Cbeurba%40microsoft.com%7C7 5b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47 %7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIj oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 000&sdata=gq599kym0%2BA8M%2BYjHUKR84Mw5od3vS2dLZ5PfjI1%2F Ig%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkey base.io%2Fandrewhaley&data=04%7C01%7Cbeurba%40microsoft.com %7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd01 1db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 D%7C1000&sdata=I0HxiyMAwKx1sYxvy8%2Fs8arCVLjO0g2LFDOJKGkMP ak%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hi Vladimir, Based on https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-May/006058.html we were waiting until the July CPU was branched for release, but it looks like that's been done already. If we can get confirmation from Andrew Haley on that, we'll go ahead with preparing the PR against jdk11u-dev shortly (Bernhard is away on paternity leave, so it will be created by someone else from our team). Thanks, Brian Stafford brstaffo@microsoft.com -----Original Message----- From: Vladimir Kempik <vkempik@azul.com> Sent: Wednesday, June 2, 2021 3:36 PM To: Langer, Christoph <christoph.langer@sap.com> Cc: Bernhard Urban-Forster <beurba@microsoft.com>; aph <aph@redhat.com>; Anton Kozlov <akozlov@azul.com>; aarch64-port-dev@openjdk.java.net; Monica Beckwith <Monica.Beckwith@microsoft.com>; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>; openjdk-aarch64 <openjdk-aarch64@microsoft.com> Subject: [EXTERNAL] Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u Hello what is the current state of this backport? can this be now integrated into git’s jdk11u-dev, so we can follow up with jep-391 backport ? Regards, Vladimir.
6 мая 2021 г., в 00:15, Langer, Christoph <christoph.langer@sap.com> написал(а):
Hi,
just had a quick look at the PR. Since it contains several changes which are backports of a JBS bug item each, we should talk to the Skara folks on whether it's possible to merge such PRs somehow without squashing and with creating backports items in JBS for each change.
Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Bernhard Urban-Forster Sent: Freitag, 30. April 2021 23:10 To: aph <aph@redhat.com>; Vladimir Kempik <vkempik@azul.com> Cc: Anton Kozlov <akozlov@azul.com>; aarch64-port-dev@openjdk.java.net; Monica Beckwith <Monica.Beckwith@microsoft.com>; jdk-updates- dev@openjdk.java.net; Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>; openjdk-aarch64 <openjdk- aarch64@microsoft.com> Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Hello everyone,
bumping this thread. Could I get some eyes on https://github.com/openjdk/jdk11u/pull/2 ?
The current plan is to get the review done on GitHub and once everyone is happy, I'll convert it into a webrev.
Thanks, -Bernhard
________________________________________ From: Bernhard Urban-Forster <beurba@microsoft.com> Sent: Thursday, March 25, 2021 22:48 To: Andrew Haley; Severin Gehwolf; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer
auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
Hah, that's actually a good idea! Let's do the review feedback loop on that PR, and once finalized I can turn that into a webrev. That doesn't sound too painful to me :-)
Thanks, -Bernhard
________________________________________ From: Andrew Haley <aph@redhat.com> Sent: Thursday, March 25, 2021 17:42 To: Severin Gehwolf; Bernhard Urban-Forster; Vladimir Kempik Cc: Anton Kozlov; aarch64-port-dev@openjdk.java.net; Monica Beckwith; jdk-updates-dev@openjdk.java.net; Magnus Ihse Bursie; openjdk-aarch64 Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 3/25/21 4:30 PM, Severin Gehwolf wrote:
Just to clarify. jdk11u hasn't transitioned to skara yet. jdk11u-dev will transition to it in June[1]. At that point the bots will no longer auto-close PRs.
Sure. I don't care if it's been auto-closed, I can still review it.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw ww.redhat.com%2F&data=04%7C01%7Cbeurba%40microsoft.com%7C7 5b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd011db47 %7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8eyJWIj oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 000&sdata=gq599kym0%2BA8M%2BYjHUKR84Mw5od3vS2dLZ5PfjI1%2F Ig%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkey base.io%2Fandrewhaley&data=04%7C01%7Cbeurba%40microsoft.com %7C75b981562be84529033908d8efad0888%7C72f988bf86f141af91ab2d7cd01 1db47%7C1%7C0%7C637522873741905341%7CUnknown%7CTWFpbGZsb3d8 eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 D%7C1000&sdata=I0HxiyMAwKx1sYxvy8%2Fs8arCVLjO0g2LFDOJKGkMP ak%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
On 6/3/21 1:11 AM, Brian Stafford wrote:
If we can get confirmation from Andrew Haley on that, we'll go ahead with preparing the PR against jdk11u-dev shortly (Bernhard is away on paternity leave, so it will be created by someone else from our team).
Let's see what the patch looks like and wed can take it from there. I hope that we can do this in a way that is not risky to anything else. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hi, now jdk11u-dev has switched to Github for the 11.0.13 CPU release. So it would be time to rebase the changes and open a PR here: https://github.com/openjdk/jdk11u-dev Once this PR has been reviewed and it's agreed that we want to merge the changes for JEP 388, we should not integrate it via the usual "/integrate" as this would squash all the single commits. I would then rather try to get it in via a "merge" PR - which I should be able to do as a maintainer of the Github repository. So, please let me know when the PR is ready and I'll have a look at the proper way to merge this. Alternatively, we can go for each single backport but I guess it would be cumbersome in this case... 😉 Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Andrew Haley Sent: Donnerstag, 3. Juni 2021 10:34 To: Brian Stafford <Brian.Stafford@microsoft.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates- dev@openjdk.java.net Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 6/3/21 1:11 AM, Brian Stafford wrote:
If we can get confirmation from Andrew Haley on that, we'll go ahead with preparing the PR against jdk11u-dev shortly (Bernhard is away on paternity leave, so it will be created by someone else from our team).
Let's see what the patch looks like and wed can take it from there. I hope that we can do this in a way that is not risky to anything else.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Thank you, Christoph. We are working on updating the PR (rebasing and resolving some newly-appearing merge conflicts) and our goal is to have it ready sometime next week. Thanks, Brian Stafford -----Original Message----- From: Langer, Christoph <christoph.langer@sap.com> Sent: Friday, June 4, 2021 12:01 AM To: aph <aph@redhat.com>; Brian Stafford <Brian.Stafford@microsoft.com>; Vladimir Kempik <vkempik@azul.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates-dev@openjdk.java.net; Bernhard Urban-Forster <beurba@microsoft.com>; Anton Kozlov <akozlov@azul.com>; Monica Beckwith <Monica.Beckwith@microsoft.com>; openjdk-aarch64 <openjdk-aarch64@microsoft.com> Subject: [EXTERNAL] RE: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u Hi, now jdk11u-dev has switched to Github for the 11.0.13 CPU release. So it would be time to rebase the changes and open a PR here: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk11u-dev&data=04%7C01%7CBrian.Stafford%40microsoft.com%7C195c2885d6fd446de4a308d92726968e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637583868973912183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=34IKQjKqH2NQe7x6ycp1xHF%2B0eSEBrWU760eHbb46ZM%3D&reserved=0 Once this PR has been reviewed and it's agreed that we want to merge the changes for JEP 388, we should not integrate it via the usual "/integrate" as this would squash all the single commits. I would then rather try to get it in via a "merge" PR - which I should be able to do as a maintainer of the Github repository. So, please let me know when the PR is ready and I'll have a look at the proper way to merge this. Alternatively, we can go for each single backport but I guess it would be cumbersome in this case... 😉 Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Andrew Haley Sent: Donnerstag, 3. Juni 2021 10:34 To: Brian Stafford <Brian.Stafford@microsoft.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates- dev@openjdk.java.net Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 6/3/21 1:11 AM, Brian Stafford wrote:
If we can get confirmation from Andrew Haley on that, we'll go ahead with preparing the PR against jdk11u-dev shortly (Bernhard is away on paternity leave, so it will be created by someone else from our team).
Let's see what the patch looks like and wed can take it from there. I hope that we can do this in a way that is not risky to anything else.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww .redhat.com%2F&data=04%7C01%7CBrian.Stafford%40microsoft.com%7C195 c2885d6fd446de4a308d92726968e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7 C0%7C637583868973912183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=CzHNQMdK JZc0OHQgbX8f8CJc3i8CN%2Bxzl9omntcO3KQ%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeyb ase.io%2Fandrewhaley&data=04%7C01%7CBrian.Stafford%40microsoft.com %7C195c2885d6fd446de4a308d92726968e%7C72f988bf86f141af91ab2d7cd011db47 %7C1%7C0%7C637583868973922183%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=dQ faUCYiw%2Blwiiu6SBLn7o1xaJZ43Tht0VfhXtH7Iss%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hi Christoph, I will be substituting for Bernhard while he's on leave. Internally, we have the PR on top of 11.0.12+5, but will be rebasing it to jdk11u-dev/e62d6a2f3 this week. We are still going through our internal review and testing cycles to make sure we don't break any other platforms, running jtreg:all on all available architecture/OS combinations before and after the backport, and SPEC benchmarks similar to the original port testing. As for the method of integration, I don't mind opening separate PRs if that makes reviews easier. Otherwise, thanks for looking into the merge option. Best regards, Reka -----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Langer, Christoph Sent: Friday, 4 June 2021 00:01 To: aph <aph@redhat.com>; Brian Stafford <Brian.Stafford@microsoft.com>; Vladimir Kempik <vkempik@azul.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates-dev@openjdk.java.net; Bernhard Urban-Forster <beurba@microsoft.com>; Anton Kozlov <akozlov@azul.com>; Monica Beckwith <Monica.Beckwith@microsoft.com>; openjdk-aarch64 <openjdk-aarch64@microsoft.com> Subject: [EXTERNAL] RE: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u Hi, now jdk11u-dev has switched to Github for the 11.0.13 CPU release. So it would be time to rebase the changes and open a PR here: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopenjdk%2Fjdk11u-dev&data=04%7C01%7Crekakovacs%40microsoft.com%7C8b4645b914334f1159a608d92726c490%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637583869744063373%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=FMCQkTYN2KLwKXXE8M2slc2P%2FYrN42qPmH%2BDZ%2BxOTOM%3D&reserved=0 Once this PR has been reviewed and it's agreed that we want to merge the changes for JEP 388, we should not integrate it via the usual "/integrate" as this would squash all the single commits. I would then rather try to get it in via a "merge" PR - which I should be able to do as a maintainer of the Github repository. So, please let me know when the PR is ready and I'll have a look at the proper way to merge this. Alternatively, we can go for each single backport but I guess it would be cumbersome in this case... 😉 Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Andrew Haley Sent: Donnerstag, 3. Juni 2021 10:34 To: Brian Stafford <Brian.Stafford@microsoft.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates- dev@openjdk.java.net Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 6/3/21 1:11 AM, Brian Stafford wrote:
If we can get confirmation from Andrew Haley on that, we'll go ahead with preparing the PR against jdk11u-dev shortly (Bernhard is away on paternity leave, so it will be created by someone else from our team).
Let's see what the patch looks like and wed can take it from there. I hope that we can do this in a way that is not risky to anything else.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww .redhat.com%2F&data=04%7C01%7Crekakovacs%40microsoft.com%7C8b4645b 914334f1159a608d92726c490%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7 C637583869744063373%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lTpD5pkJ6L20 t%2Bx56rlY%2FLNJtAUVL52wkVve1unjjsI%3D&reserved=0> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkeyb ase.io%2Fandrewhaley&data=04%7C01%7Crekakovacs%40microsoft.com%7C8 b4645b914334f1159a608d92726c490%7C72f988bf86f141af91ab2d7cd011db47%7C1 %7C0%7C637583869744063373%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=r3zlyg 1VkvS4uN225aEuW61Y1m9AERsc8GlJOlU2jkw%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
Hi Reka, thanks, please go ahead with opening a PR to jdk11u-dev, containing all the individual commits. Best regards Christoph
-----Original Message----- From: Reka Kovacs <rekakovacs@microsoft.com> Sent: Dienstag, 29. Juni 2021 02:17 To: Langer, Christoph <christoph.langer@sap.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates- dev@openjdk.java.net; Vladimir Kempik <vkempik@azul.com>; Brian Stafford <Brian.Stafford@microsoft.com>; aph <aph@redhat.com>; Bernhard Urban-Forster <beurba@microsoft.com>; Anton Kozlov <akozlov@azul.com>; Monica Beckwith <Monica.Beckwith@microsoft.com>; openjdk-aarch64 <openjdk-aarch64@microsoft.com> Subject: RE: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Hi Christoph,
I will be substituting for Bernhard while he's on leave. Internally, we have the PR on top of 11.0.12+5, but will be rebasing it to jdk11u-dev/e62d6a2f3 this week. We are still going through our internal review and testing cycles to make sure we don't break any other platforms, running jtreg:all on all available architecture/OS combinations before and after the backport, and SPEC benchmarks similar to the original port testing.
As for the method of integration, I don't mind opening separate PRs if that makes reviews easier. Otherwise, thanks for looking into the merge option.
Best regards, Reka
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Langer, Christoph Sent: Friday, 4 June 2021 00:01 To: aph <aph@redhat.com>; Brian Stafford <Brian.Stafford@microsoft.com>; Vladimir Kempik <vkempik@azul.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates- dev@openjdk.java.net; Bernhard Urban-Forster <beurba@microsoft.com>; Anton Kozlov <akozlov@azul.com>; Monica Beckwith <Monica.Beckwith@microsoft.com>; openjdk-aarch64 <openjdk- aarch64@microsoft.com> Subject: [EXTERNAL] RE: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
Hi,
now jdk11u-dev has switched to Github for the 11.0.13 CPU release. So it would be time to rebase the changes and open a PR here: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith ub.com%2Fopenjdk%2Fjdk11u- dev&data=04%7C01%7Crekakovacs%40microsoft.com%7C8b4645b9143 34f1159a608d92726c490%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0% 7C637583869744063373%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sda ta=FMCQkTYN2KLwKXXE8M2slc2P%2FYrN42qPmH%2BDZ%2BxOTOM%3D&a mp;reserved=0
Once this PR has been reviewed and it's agreed that we want to merge the changes for JEP 388, we should not integrate it via the usual "/integrate" as this would squash all the single commits. I would then rather try to get it in via a "merge" PR - which I should be able to do as a maintainer of the Github repository. So, please let me know when the PR is ready and I'll have a look at the proper way to merge this.
Alternatively, we can go for each single backport but I guess it would be cumbersome in this case... 😉
Best regards Christoph
-----Original Message----- From: jdk-updates-dev <jdk-updates-dev-retn@openjdk.java.net> On Behalf Of Andrew Haley Sent: Donnerstag, 3. Juni 2021 10:34 To: Brian Stafford <Brian.Stafford@microsoft.com> Cc: aarch64-port-dev@openjdk.java.net; jdk-updates- dev@openjdk.java.net Subject: Re: JDK-8253947: JEP 388 Windows/AArch64 backport to jdk11u
On 6/3/21 1:11 AM, Brian Stafford wrote:
If we can get confirmation from Andrew Haley on that, we'll go ahead with preparing the PR against jdk11u-dev shortly (Bernhard is away on paternity leave, so it will be created by someone else from our team).
Let's see what the patch looks like and wed can take it from there. I hope that we can do this in a way that is not risky to anything else.
-- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd.
<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw ww
.redhat.com%2F&data=04%7C01%7Crekakovacs%40microsoft.com%7C8 b4645b
914334f1159a608d92726c490%7C72f988bf86f141af91ab2d7cd011db47%7C1% 7C0%7
C637583869744063373%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw MDAiLCJQIj
oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=lTpD5pk J6L20
t%2Bx56rlY%2FLNJtAUVL52wkVve1unjjsI%3D&reserved=0>
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fkey b
ase.io%2Fandrewhaley&data=04%7C01%7Crekakovacs%40microsoft.co m%7C8
b4645b914334f1159a608d92726c490%7C72f988bf86f141af91ab2d7cd011db47 %7C1
%7C0%7C637583869744063373%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC 4wLjAwMDAi
LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=r3 zlyg
1VkvS4uN225aEuW61Y1m9AERsc8GlJOlU2jkw%3D&reserved=0 EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
On 6/29/21 11:07 PM, Langer, Christoph wrote:
thanks, please go ahead with opening a PR to jdk11u-dev, containing all the individual commits.
We're going to have to review these in pieces, I think. Let's see what the big PR looks like, then we can see if it's reviewable as a big lump. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
participants (8)
-
Andrew Haley
-
Bernhard Urban-Forster
-
Brian Stafford
-
Kevin Rushforth
-
Langer, Christoph
-
Reka Kovacs
-
Severin Gehwolf
-
Vladimir Kempik