March 2008 - core-libs-dev

Re: [PATCH] 4837946: Implement Karatsuba multiplication algorithm in BigInteger
by Alan Eliasen 06 Jun '09

06 Jun '09

Anonymous member wrote: > Out of curiousity, how does the Java implementation compare to GMP in > terms of speed? (Note: These numbers apply to the *revised* patch that I'll be posting in a few minutes.) It depends on the size of the numbers. When I run the regression tests that I wrote, my updated Java version runs in about 2 minutes. When I run the same regression test in Kaffe using GMP, it takes about 2 *hours*. (Some of the same tests using Java 1.6 take many, many hours without my optimizations for the pow() function). But those are a lot of small numbers. There is a lot of overhead in converting from Java to C types and back, and in Kaffe's relative slowness. And currently, only multiply() has been improved in my Java patches that I've submitted. Kaffe is about 25 times slower on the average program anyway. When you run Kaffe/GMP for very large numbers, Kaffe/GMP starts being very much faster. OpenJDK still can't compete for numbers that are on the cutting edge of number theory. But we'll be much better than we were before. If I were to write the same code in pure C using GMP, then GMP would be much faster. But I haven't done that. So it's hard to compare GMP to Java exactly. But some numbers. For multiplying the numbers 3^1000000 * 3^1000001, (with my fixes to do the exponentiation hundreds of thousands of times faster factored out; without these, JDK 1.6 would be thousands of times slower,) the times for 20 iterations are: JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP 292987 ms 28650 ms 866 ms Thus, for numbers of this size, my algorithms are more than 10 times faster than JDK 1.6, but 33 times slower than Kaffe/GMP. For multiplying the somewhat special form 2^1000000 * 2^1000001, (the arguments of this in binary are a 1 followed by a million zeroes) JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP 117298 ms 386 ms 474 ms So, my algorithm is 303 times faster than JDK, and just slightly faster than Kaffe/GMP. For multiplying numbers 3^14000000 * 3^14000001, the time for 1 iteration is: JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP 3499115 ms 89505 ms 910 ms Thus, for numbers of this size, my patches make it 38.9 times faster, but still 99 times slower than GMP. Sigh. Well, to be expected. If you work with large numbers, GMP becomes ridiculously faster. Kaffe with GMP becomes only slightly slower than pure GMP as the portion of time in Java gets small. GMP includes 3-way Toom-Cook multiplication, and the much faster FFT multiplication (which is O(n)) for very large numbers, and hand-crafted assembly language that uses 64-bit instructions and limbs on my 64-bit architecture (as opposed to the 32-bit ints used in BigInteger. Hopefully some day in the future, BigInteger will be rewritten to use longs internally instead of ints. Multiplying two 64-bit longs does 4 times as much work as multiplying two 32-bit ints, and will thus likely be significantly faster, especially on 64-bit architectures.) So GMP is still very much faster for very large numbers. It is also *much* faster in turning numbers into strings, and in exponentiation. The algorithms in BigInteger are horrible for pow() and toString(). See the following bugs: 4641897: BigInteger.toString() algorithm slow for large numbers http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4641897 4646474: BigInteger.pow() algorithm slow in 1.4.0 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4646474 I have several fixes for both of these. My JVM-based programming language Frink ( http://futureboy.us/frinkdocs/ ) implements many of these improvements, and is much faster for a variety of arguments. I just need to finish improving these for a variety of different arguments, and considering the threading and memory-size-vs-speed tradeoffs in implementing toString efficiently. -- Alan Eliasen | "Furious activity is no substitute eliasen(a)mindspring.com | for understanding." http://futureboy.us/ | --H.H. Williams

4 8

BigInteger performance improvements
by Alan Eliasen 04 Apr '08

04 Apr '08

I'm planning on tackling the performance issues in the BigInteger class. In short, inefficient algorithms are used for multiplication, exponentiation, conversion to strings, etc. I intend to improve this by adding algorithms with better asymptotic behavior that will work better for large numbers, while preserving the existing algorithms for use with smaller numbers. This encompasses a lot of different bug reports: 4228681: Some BigInteger operations are slow with very large numbers http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4228681 (This was closed but never fixed.) 4837946: Implement Karatsuba multiplication algorithm in BigInteger http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4837946 I've already done the work on this one. My implementation is intended to be easy to read, understand, and check. It significantly improves multiplication performance for large numbers. 4646474: BigInteger.pow() algorithm slow in 1.4.0 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4646474 This will be improved in a couple ways: * Rewrite pow() to use the above Karatsuba multiplication * Implement Karatsuba squaring * Finding a good threshhold for Karatsuba squaring * Rewrite pow() to use Karatsuba squaring * Add an optimization to use left-shifting for multiples of 2 in the base. This improves speed by thousands of times for things like Mersenne numbers. 4641897: BigInteger.toString() algorithm slow for large numbers http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4641897 This algorithm uses a very inefficient algorithm for large numbers. I plan to replace it with a recursive divide-and-conquer algorithm devised by Schoenhage and Strassen. I have developed and tested this in my own software. This operates hundreds or thousands of times faster than the current version for large numbers. It will also benefit from faster multiplication and exponentiation. In the future, we should also add multiplication routines that are even more efficient for very large numbers, such as Toom-Cook multiplication, which is more efficient than Karatsuba multiplication for even larger numbers. Has anyone else worked on these? Is this the right group? I will probably submit the Karatsuba multiplication patch soon. Would it be more preferable to implement *all* of these parts first and submit one large patch? -- Alan Eliasen | "Furious activity is no substitute eliasen(a)mindspring.com | for understanding." http://futureboy.us/ | --H.H. Williams

3 9

CFV: Doug Lea to Membership in the Core Libraries Group
by iris clark 28 Mar '08

28 Mar '08

Greetings, voting members of the Core Libraries Group! I hereby nominate Doug Lea to Membership in the Core Libraries Group. Please cast your vote by replying, publicly, to this message with either Vote: yes or Vote: no as the first line of the message body. You may, at your option, indicate the reason for your decision on subsequent lines. Votes must be cast in the open; votes sent as private replies will not be counted. Votes are due by midnight UTC next Monday, 31 March, after which time the votes will be tallied and reported to this list. Only Members of the Core Libraries are eligible to vote on this decision. The current Members are: Alan Bateman Christopher Hegarty David Bristor Iris Clark Jeff Nisewanger Joe Darcy Mark Reinhold Martin Buchholz Pete Soper Peter Jones Xueming Shen [1] http://blogs.sun.com/mr/entry/cosmology

7 6

hg: jdk7/tl/jdk: 17 new changesets
by daniel.daugherty＠sun.com 27 Mar '08

27 Mar '08

Changeset: 7dd94e5bbec4 Author: dcubed Date: 2008-03-24 14:31 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7dd94e5bbec4 6239043: 4/4 TransformerManagementThreadAddTests.java failed Summary: Clear fCheckedTransformers in order to properly record transformer() call data. Reviewed-by: sspitsyn ! test/java/lang/instrument/TransformerManagementThreadAddTests.java Changeset: d3dc2ede62ed Author: dcubed Date: 2008-03-24 14:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3dc2ede62ed 4926961: 4/4 TransformerManagementThreadRemoveTests hangs Summary: Changes motivated by Effective Java - Item 48 & Item 51. Reviewed-by: sspitsyn ! test/java/lang/instrument/TransformerManagementThreadAddTests.java ! test/java/lang/instrument/TransformerManagementThreadRemoveTests.java Changeset: bca8bf23ac59 Author: dcubed Date: 2008-03-24 15:05 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bca8bf23ac59 5088398: 3/2 java.lang.instrument TCK test deadlock (test11) Summary: Add regression test for single-threaded bootstrap classloader. Reviewed-by: sspitsyn + test/java/lang/instrument/ParallelTransformerLoader.sh + test/java/lang/instrument/ParallelTransformerLoaderAgent.java + test/java/lang/instrument/ParallelTransformerLoaderApp.java + test/java/lang/instrument/TestClass1.java + test/java/lang/instrument/TestClass2.java + test/java/lang/instrument/TestClass3.java Changeset: 114854ebaa21 Author: dcubed Date: 2008-03-24 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/114854ebaa21 6274276: 3/2 java.lang.instrument JAR manifest processing does not remove spaces from class names Summary: Attribute values should be extracted without leading or trailing whitespace. Reviewed-by: ohair, sspitsyn ! src/share/instrument/JarFacade.c + test/java/lang/instrument/ManifestTest.sh + test/java/lang/instrument/ManifestTestAgent.java + test/java/lang/instrument/ManifestTestApp.java Changeset: d4cd9e6a72da Author: dcubed Date: 2008-03-24 15:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d4cd9e6a72da 6289149: 4/4 Java Agent will pick wrong execution path while attaching Summary: Check for a declared premain() or agentmain() method before an inherited one Reviewed-by: sspitsyn ! src/share/classes/sun/instrument/InstrumentationImpl.java ! test/java/lang/instrument/PremainClass/DummyMain.java + test/java/lang/instrument/PremainClass/InheritAgent0001.java + test/java/lang/instrument/PremainClass/InheritAgent0010.java + test/java/lang/instrument/PremainClass/InheritAgent0011.java + test/java/lang/instrument/PremainClass/InheritAgent0100.java + test/java/lang/instrument/PremainClass/InheritAgent0101.java + test/java/lang/instrument/PremainClass/InheritAgent0110.java + test/java/lang/instrument/PremainClass/InheritAgent0111.java + test/java/lang/instrument/PremainClass/InheritAgent1000.java + test/java/lang/instrument/PremainClass/InheritAgent1001.java + test/java/lang/instrument/PremainClass/InheritAgent1010.java + test/java/lang/instrument/PremainClass/InheritAgent1011.java + test/java/lang/instrument/PremainClass/InheritAgent1100.java + test/java/lang/instrument/PremainClass/InheritAgent1101.java + test/java/lang/instrument/PremainClass/InheritAgent1110.java + test/java/lang/instrument/PremainClass/InheritAgent1111.java + test/java/lang/instrument/PremainClass/NoPremainAgent.java + test/java/lang/instrument/PremainClass/NoPremainAgent.sh + test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.java + test/java/lang/instrument/PremainClass/ZeroArgPremainAgent.sh Changeset: 8c1c6c50dd36 Author: dcubed Date: 2008-03-24 15:26 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c1c6c50dd36 6487488: 3/5 TEST_BUG: Something in test/java/lang/instrument creates a copy of an SCCS dir Summary: Only copy Java source files from ilib and bootreporter. Reviewed-by: sspitsyn ! test/java/lang/instrument/MakeJAR2.sh Changeset: e6e301984a4a Author: dcubed Date: 2008-03-24 15:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e6e301984a4a 6491461: 3/3 TEST: java/lang/instrument .sh tests need to use $TESTVMOPTS in their java commands Summary: Add ${TESTVMOPTS} to java test execution command(s). Reviewed-by: sspitsyn ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/PremainClass/PremainClassTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/ClassUnloadTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh Changeset: ebe8adae32b9 Author: dcubed Date: 2008-03-24 16:04 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ebe8adae32b9 6528548: 4/4 NativeMethodPrefixAgent.java times out intermittently in nightly Summary: Increase timeouts for tasks that take > 10 seconds on a 4-way Ultra-80 with all local resources. Reviewed-by: sspitsyn ! test/java/lang/instrument/BootClassPath/BootClassPathTest.sh ! test/java/lang/instrument/NativeMethodPrefixAgent.java ! test/java/lang/instrument/RetransformAgent.java ! test/java/lang/instrument/appendToClassLoaderSearch/CircularityErrorTest.sh ! test/java/lang/instrument/appendToClassLoaderSearch/run_tests.sh Changeset: 31959ddaf501 Author: dcubed Date: 2008-03-24 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/31959ddaf501 6545149: 4/4 JLI Instrumentation.redefineClasses SIGSEGVs on java/lang/Thread Summary: Add regression test for redefining class with native methods. Reviewed-by: sspitsyn + test/java/lang/instrument/RedefineClassWithNativeMethod.sh + test/java/lang/instrument/RedefineClassWithNativeMethodAgent.java + test/java/lang/instrument/RedefineClassWithNativeMethodApp.java Changeset: 719789c7132c Author: dcubed Date: 2008-03-24 16:23 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/719789c7132c 6547358: 2/2 j.l.i.: manifest attribute 'Can-Retransform-Classes' is ignored by isRetransformClassesSupported() Summary: isRetransformClassesSupported() should return the capability rather than give the agent the capability Reviewed-by: ohair, sspitsyn ! src/share/instrument/JPLISAgent.c Changeset: ba825e4b1b8b Author: dcubed Date: 2008-03-24 16:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ba825e4b1b8b 6547500: 2/2 j.l.i.: .retransformClasses throws unexpected InternalError Summary: retransformClasses() should catch both an empty classes array and a classes array that contains a NULL element. Reviewed-by: ohair, sspitsyn ! src/share/instrument/JPLISAgent.c Changeset: 823abb444593 Author: dcubed Date: 2008-03-24 16:59 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/823abb444593 6642405: 4/4 src/share/instrument/JPLISAgent.c line 286: "==" found where assignment "=" expected Summary: Fix incorrect variable assignment in initializeJPLISAgent(). Reviewed-by: ohair, sspitsyn ! src/share/instrument/JPLISAgent.c Changeset: 9f75a46fad8b Author: dcubed Date: 2008-03-24 17:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f75a46fad8b 6572160: 3/3 Instrumentation.getObjectSize triggers JVM crash in JPLISAssert in shutdown Summary: Tolerate JVMTI_ERROR_WRONG_PHASE return codes so that JLI methods can be called to the end of VM's life. Reviewed-by: ohair, sspitsyn ! src/share/instrument/InvocationAdapter.c ! src/share/instrument/JPLISAgent.c ! src/share/instrument/JPLISAgent.h ! src/share/instrument/Reentrancy.c ! src/share/instrument/Utilities.c + test/java/lang/instrument/StressGetObjectSizeApp.java + test/java/lang/instrument/StressGetObjectSizeTest.sh Changeset: 9a804b6297c3 Author: dcubed Date: 2008-03-24 17:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9a804b6297c3 6655234: 4/4 j.l.i.: setNativeMethodPrefix does not document that prefix string can be null Summary: Clarify wording for 'prefix' parameter to setNativeMethodPrefix(). Reviewed-by: sspitsyn ! src/share/classes/java/lang/instrument/Instrumentation.java Changeset: 1f45ae5ea94a Author: dcubed Date: 2008-03-24 17:20 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1f45ae5ea94a 6667089: 3/3 multiple redefinitions of a class break reflection Summary: Add regression test for multiple redefinitions of a class break reflection. Reviewed-by: sspitsyn + test/java/lang/instrument/RedefineMethodAddInvoke.sh + test/java/lang/instrument/RedefineMethodAddInvokeAgent.java + test/java/lang/instrument/RedefineMethodAddInvokeApp.java + test/java/lang/instrument/RedefineMethodAddInvokeTarget.java + test/java/lang/instrument/RedefineMethodAddInvokeTarget_1.java + test/java/lang/instrument/RedefineMethodAddInvokeTarget_2.java Changeset: 7bf5f01e419d Author: dcubed Date: 2008-03-26 20:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7bf5f01e419d 6679866: 3/2 portability issues with JLI-batch-200803 on Win* Summary: Make minor tweaks to the fix for 6274276 to make the Win* compiler happy... Reviewed-by: sspitsyn, ohair ! src/share/instrument/JarFacade.c Changeset: 52c76fc0a3a9 Author: dcubed Date: 2008-03-27 14:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/52c76fc0a3a9 Merge

1 0

hg: jdk7/tl/jdk: 43 new changesets
by tim.bell＠sun.com 27 Mar '08

27 Mar '08

Changeset: e4f19efd20b4 Author: ohair Date: 2008-03-04 09:47 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4f19efd20b4 6654456: OpenJDK build problem with freetype makefiles Summary: ifdef test on OPENJDK before it gets set based on source tree contents Reviewed-by: xdono ! make/common/shared/Platform.gmk Changeset: 80486f9d9221 Author: ohair Date: 2008-03-04 09:49 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/80486f9d9221 6637583: Build failure on latest Solaris, source missing include of resource.h? Summary: The include of sys/resource.h must be explicit Reviewed-by: xdono ! src/solaris/hpi/native_threads/src/sys_api_td.c Changeset: 929222887724 Author: ohair Date: 2008-03-04 09:50 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/929222887724 6638571: Fix freetype sanity check to work on solaris 64bit Summary: Missing -xarch options to build for 64bit Reviewed-by: xdono ! make/tools/freetypecheck/Makefile Changeset: 12b0d64c4953 Author: ohair Date: 2008-03-04 09:51 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/12b0d64c4953 6638060: Build failed with GNU make 3.81 (part of latest Solaris 'gmake') Summary: Changes to the way GNU make 3.81 deals with the env variable SHELL Reviewed-by: xdono ! make/java/nio/Makefile ! make/java/nio/genCharsetProvider.sh ! make/java/nio/genExceptions.sh Changeset: 82c85cfd8402 Author: ohair Date: 2008-03-04 09:52 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/82c85cfd8402 6668781: Openjdk windows cygwin build failure: no rule to make linker_md.obj target Summary: Use of GNU make vpath breaks on windows with C:/ style fullpaths Reviewed-by: xdono ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/Defs-windows.gmk ! make/common/Defs.gmk Changeset: 65c8fd93d01c Author: ohair Date: 2008-03-06 11:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/65c8fd93d01c 6628146: Exclude the .hgignore and .hgtags files from the source bundles Summary: Just add to list of SCM files. Reviewed-by: xdono ! make/common/shared/Platform.gmk Changeset: 48d06b4c6460 Author: ohair Date: 2008-03-09 14:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/48d06b4c6460 6672777: Broken deploy build from jdk fix 6668781 for cygwin windows Summary: deploy workspace does not set BUILDDIR, uses it, assumes it is jdk/make. Reviewed-by: xdono ! make/common/Defs.gmk Changeset: 8ef9fd5c28fd Author: ohair Date: 2008-03-10 16:51 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8ef9fd5c28fd 6649672: Adjustments to OUTPUTDIR default and mkdirs to avoid empty directory clutter Summary: OUTPUTDIR changes to make sure absolute path is correct. Reviewed-by: xdono ! make/common/Defs.gmk ! make/common/shared/Defs-control.gmk ! make/common/shared/Defs.gmk Changeset: dd6765f87558 Author: tbell Date: 2008-03-17 22:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dd6765f87558 Merge Changeset: 9ae056d2cffd Author: tbell Date: 2008-03-17 23:03 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9ae056d2cffd Merge Changeset: e0d783c556fc Author: son Date: 2008-03-13 15:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e0d783c556fc 6595651: Focus transfers broken for applications embedding AWT across processes Summary: Now we allow cross-process focus requests if focus is in embedder's process. Reviewed-by: ant ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h Changeset: 367edeff526e Author: son Date: 2008-03-13 16:12 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/367edeff526e 6616095: AWT's WindowDisposerRecord keeps AppContext alive too long Summary: WindowDisposerRecord should not keep strong reference to AppContext. Reviewed-by: art ! src/share/classes/java/awt/Window.java Changeset: e4e71142754b Author: son Date: 2008-03-13 16:19 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e4e71142754b 6632140: minor refactoring for XWM Summary: code cleanup and generificaion for XWM Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XWM.java Changeset: dc7dfc7d15ba Author: son Date: 2008-03-13 16:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc7dfc7d15ba 6592751: EmbeddedFrame disposal is fragile and breaks clean AppContext termination Summary: AppContext.dispose() should be ready to get exceptions during disposal of toplevels. Also now we mark windows peers as destroyed when native object has been destroyed. Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java ! src/windows/classes/sun/awt/windows/WObjectPeer.java ! src/windows/native/sun/windows/awt.h ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Object.cpp ! src/windows/native/sun/windows/awt_Object.h Changeset: 619d2d592b88 Author: son Date: 2008-03-13 16:32 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/619d2d592b88 6603256: Startup: Defer initialization of DropTarget's flavorMap Summary: SystemFlavorMap is lazily initialized now. Reviewed-by: uta ! src/share/classes/java/awt/datatransfer/SystemFlavorMap.java ! src/share/classes/java/awt/dnd/DropTarget.java Changeset: f3377ab93ee8 Author: son Date: 2008-03-13 16:42 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f3377ab93ee8 6607163: Linux: Cannot copy image from Java to OpenOffice Summary: TARGETS should have type ATOM Reviewed-by: denis ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: bbd8e20d5052 Author: son Date: 2008-03-13 16:47 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bbd8e20d5052 6636369: sun.awt.datatransfer.DataTransferer contains double-check idiom Summary: double-check has been removed Reviewed-by: dav ! src/share/classes/sun/awt/datatransfer/DataTransferer.java Changeset: c9ee9428aea9 Author: son Date: 2008-03-13 16:51 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c9ee9428aea9 6636331: ConcurrentModificationException in AppContext code Summary: Added synchronization to AppContext.getAppContexts() Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java Changeset: 86a5780cad99 Author: son Date: 2008-03-13 16:54 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/86a5780cad99 6636370: minor corrections and simplification of code in AppContext Summary: mainAppContext, isDisposed, and numAppContexts has beem made volatile. mostRecentThreadAppContext has been rewritten using ThreadLocal. Reviewed-by: art ! src/share/classes/sun/awt/AppContext.java Changeset: 026144f0d26a Author: son Date: 2008-03-13 16:56 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/026144f0d26a 6636368: XAtom contains unused code Summary: unused code has been removed Reviewed-by: dcherepanov ! src/solaris/classes/sun/awt/X11/XAtom.java Changeset: 63f02cc8ff3d Author: son Date: 2008-03-13 17:04 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/63f02cc8ff3d 6645885: small refactoring for XContentWindow Summary: move createContent() method from XDecoratedPeer to XContentWindow, so only XContentWindow keep information about the way we position it. Reviewed-by: anthony ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java Changeset: d9fb87af8b07 Author: son Date: 2008-03-13 17:08 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9fb87af8b07 6645856: static field XWindowPeer.defaultFont hides XWindow.defaultFont Summary: unnedded code has been removed. Added getter for XWindow.defaultFont to initialize it lazily. Reviewed-by: dav ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XMenuItemPeer.java ! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: 176e1fe7dead Author: son Date: 2008-03-13 17:14 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/176e1fe7dead 6538066: XSelection should be more passive Summary: Now only XClipboard know about XSelection, and XSelection knows nothing about XClipboard. Reviewed-by: uta, denis ! src/solaris/classes/sun/awt/X11/MotifDnDConstants.java ! src/solaris/classes/sun/awt/X11/MotifDnDDropTargetProtocol.java + src/solaris/classes/sun/awt/X11/OwnershipListener.java ! src/solaris/classes/sun/awt/X11/XClipboard.java ! src/solaris/classes/sun/awt/X11/XDnDConstants.java ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: fa0dc97ef9a0 Author: dcherepanov Date: 2008-03-14 17:23 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fa0dc97ef9a0 6522731: Location of the frame changes,when the frame is resized & non-resized. Summary: XMoveWindow() should use shell's location Reviewed-by: son ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java Changeset: 296b6e29a99d Author: dcherepanov Date: 2008-03-14 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/296b6e29a99d 6612497: api/java_awt/Container/index.html#isAncestorOf Container2019 hangs since JDK 7 b15 Summary: Partial rollback changes for 6567564 in the Component.getGC method Reviewed-by: art, son ! src/share/classes/java/awt/Component.java Changeset: 5ac897d182a6 Author: dcherepanov Date: 2008-03-14 18:50 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5ac897d182a6 6603010: Out-of-process Java Plug-In non-functional or barely functional on X11 platforms Summary: AWT XEmbed shouldn't use _SUN_XEMBED_START message Reviewed-by: art, son ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java Changeset: 92e3f57c933b Author: dcherepanov Date: 2008-03-14 20:40 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92e3f57c933b 6524352: support for high-resolution mouse wheel Summary: added support for high-resolution mouse wheel Reviewed-by: dav, son ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/event/MouseWheelEvent.java ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Component.h + test/java/awt/event/MouseEvent/SmoothWheel/SmoothWheel.java Changeset: 15ba7093f8e6 Author: dcherepanov Date: 2008-03-14 22:00 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/15ba7093f8e6 6578583: Regression: Modality is broken in windows vista home premium from jdk1.7 b02 onwards. Summary: WS_DISABLED style should be used to fix some modality bugs Reviewed-by: art, son ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Dialog.cpp ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h + test/java/awt/Modal/WsDisabledStyle/CloseBlocker/CloseBlocker.java + test/java/awt/Modal/WsDisabledStyle/OverBlocker/OverBlocker.java + test/java/awt/Modal/WsDisabledStyle/Winkey/Winkey.java Changeset: 9f51e4e1251e Author: anthony Date: 2008-03-18 12:04 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9f51e4e1251e 6608764: PropertyChangeListeners machinery should have a better locking scheme Summary: Change to use a private final object java.awt.Component.changeSupportLock for locking purposes instead of using this Reviewed-by: son, ant ! src/share/classes/java/awt/Component.java Changeset: 9b6848cf363c Author: anthony Date: 2008-03-18 13:53 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9b6848cf363c 6613927: Compilation of splashscreen png library failed on Ubuntu 7.04 (64bit) Summary: The macro PNG_NO_MMX_CODE should be defined when compiling on 64bit Linux Reviewed-by: yan, avu ! make/sun/splashscreen/Makefile Changeset: fd7f2562ea00 Author: anthony Date: 2008-03-18 14:10 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd7f2562ea00 6607660: java.awt.Container.getMouseEventTargetImpl should be invoked while holding the TreeLock Summary: The body of the method has been wrapped into the synchronized (getTreeLock()) { } block. Reviewed-by: son, art ! src/share/classes/java/awt/Container.java Changeset: e8b40b676b89 Author: anthony Date: 2008-03-18 14:20 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e8b40b676b89 6637796: setBounds doesn't enlarge Component Summary: Added the areBoundsValid() method that verifies whether the current bounds of the component are valid. Using the isValid() method for this purpose previously was incorrect. Reviewed-by: son, art ! src/share/classes/java/awt/Component.java + test/java/awt/Mixing/ValidBounds.java Changeset: 9306c5d6344f Author: anthony Date: 2008-03-18 14:36 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9306c5d6344f 6304277: PIT: Adding a TrayIcon closes a SplashScreen on Solaris but not on Win32 Summary: The Window.closeSplashScreen() method now verified the boolean flag isTrayIconWindow, and returns if it is true. Reviewed-by: son, dcherepanov ! src/share/classes/java/awt/Window.java Changeset: fc0164db7a3b Author: anthony Date: 2008-03-18 15:07 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fc0164db7a3b 6581927: REG : Non focusable frame can be minimized to very small & Frame icon can be seen on frame buttons. Summary: The SWP_NOSENDCHANGING flag should not be passed to the ::SetWindowPos() WinAPI function when we receive the WM_MOUSEMOVE message while manually handling the resizing of non-focusable frames. Reviewed-by: son, ant ! src/windows/native/sun/windows/awt_Frame.cpp + test/java/awt/Focus/NonFocusableResizableTooSmall/NonFocusableResizableTooSmall.java Changeset: 8a57a0be2a97 Author: anthony Date: 2008-03-18 16:19 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8a57a0be2a97 6589527: Window and Frame instances can hide their "Applet Warning" Summary: Additional constraints have been added for the setBounds() operation. Reviewed-by: son, art ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDialogPeer.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/motif/MDialogPeer.java ! src/solaris/classes/sun/awt/motif/MEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/motif/MFramePeer.java ! src/solaris/classes/sun/awt/motif/MWindowPeer.java ! src/windows/classes/sun/awt/windows/WDialogPeer.java ! src/windows/classes/sun/awt/windows/WEmbeddedFramePeer.java ! src/windows/classes/sun/awt/windows/WFramePeer.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java ! src/windows/native/sun/windows/awt_Window.cpp ! src/windows/native/sun/windows/awt_Window.h Changeset: 241fd18949db Author: anthony Date: 2008-03-20 11:09 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/241fd18949db 4993545: NativeInLightFixer adds asynchronousity Summary: All the hooks related to the NativeInLightFixer have been moved to the HW/LW mixing handling methods. The NativeInLightFixer itself has been removed. Reviewed-by: son, alexp ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java Changeset: 51c761339b1c Author: ant Date: 2008-03-19 16:23 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/51c761339b1c 6567410: PIT : java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java fails Summary: A filter flag has been added to the HCBT focus hook. Reviewed-by: dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: 810904060acf Author: ant Date: 2008-03-20 14:26 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/810904060acf Merge Changeset: 92e9ac30618a Author: son Date: 2008-03-20 16:21 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/92e9ac30618a 6630878: clean target in sun/xawt is incomplete Summary: clean target should remove .gen_icons Reviewed-by: yan ! make/sun/xawt/Makefile Changeset: 82233ac3d09f Author: ant Date: 2008-03-20 18:06 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/82233ac3d09f 6598089: JDK 7: AWT often goes into busy loop when showing dialog Summary: Preventing focus from getting in an endless loop. Reviewed-by: son ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java + test/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java Changeset: dbff1fcf1767 Author: ant Date: 2008-03-21 09:54 +0300 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dbff1fcf1767 6599270: Using EmbeddedFrame in SWT leads to a hang Summary: Excluding EmbeddedFrame from the workaround of activating a toplevel in not foreground process. Reviewed-by: son ! src/windows/native/sun/windows/awt_Frame.cpp Changeset: 0f955581dc0b Author: yan Date: 2008-03-24 06:33 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0f955581dc0b Merge Changeset: 75b405bff406 Author: tbell Date: 2008-03-27 10:42 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/75b405bff406 Merge

1 0

hg: jdk7/tl/jaxws: 6652588: Fix broken JPRT makefile target, no bundle saved
by tim.bell＠sun.com 27 Mar '08

27 Mar '08

Changeset: 59fd8224ba2d Author: ohair Date: 2008-03-04 10:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/59fd8224ba2d 6652588: Fix broken JPRT makefile target, no bundle saved Summary: jprt make rules were missing the bundle logic Reviewed-by: xdono ! make/Makefile

1 0

hg: jdk7/tl/jaxp: 6652588: Fix broken JPRT makefile target, no bundle saved
by tim.bell＠sun.com 27 Mar '08

27 Mar '08

Changeset: a3b3ba7d6034 Author: ohair Date: 2008-03-04 10:58 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/a3b3ba7d6034 6652588: Fix broken JPRT makefile target, no bundle saved Summary: jprt make rules missing the bundle up of the output Reviewed-by: xdono ! make/Makefile

1 0

hg: jdk7/tl/corba: 6624808: corba makefiles not using langtools compiler
by tim.bell＠sun.com 27 Mar '08

27 Mar '08

Changeset: a51017b6ba6d Author: ohair Date: 2008-03-06 13:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/a51017b6ba6d 6624808: corba makefiles not using langtools compiler Summary: If supplied, the langtools javac should be used. Reviewed-by: xdono ! make/common/shared/Defs.gmk

1 0

hg: jdk7/tl: 4 new changesets
by tim.bell＠sun.com 27 Mar '08

27 Mar '08

Changeset: be0ea51b2743 Author: ohair Date: 2008-03-05 18:56 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/rev/be0ea51b2743 6662830: OpenJDK build testing results Summary: Small corrections in the README. Reviewed-by: xdono ! README-builds.html Changeset: d83470fdf495 Author: ohair Date: 2008-03-09 13:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d83470fdf495 6649270: Change by-default openjdk building in control/make/makefile to use open source tree Summary: Change build rules to allow for openjdk builds by default when building the closed or production build. Reviewed-by: xdono ! Makefile ! make/Defs-internal.gmk Changeset: d6b08bdb9a54 Author: ohair Date: 2008-03-09 15:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/d6b08bdb9a54 6649672: Adjustments to OUTPUTDIR default and mkdirs to avoid empty directory clutter Summary: Cleanup of OUTPUTDIR handling Reviewed-by: xdono ! Makefile Changeset: f769c64f71ac Author: ohair Date: 2008-03-13 16:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/f769c64f71ac 6675289: Make default production build NOT include an openjdk build Summary: SKIP_OPENJDK_BUILD now set to true. Reviewed-by: xdono ! make/Defs-internal.gmk

1 0

Re: JNI-performance - Is it really that fast?
by Martin Buchholz 25 Mar '08

25 Mar '08

BTW, The implementation of ReentrantReadWriteLock is being changed significantly by the not-yet-integrated changes for *Synopsis* Excessive ThreadLocal storage used by ReentrantReadWriteLock http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6625723 which may make your particular workload faster (hopefully!) or slower. Martin On Tue, Mar 25, 2008 at 12:57 PM, Clemens Eisserer <linuxhippy(a)gmail.com> wrote: > Hi again, > > Thanks a lot for the valueable feedback :) > > > Biased locking is enabled 4 seconds after startup. > Thanks a lot Christian and greetings from Austria! > With your suggested flag the synchronization-overhead with > BiasedLocking shrinks to about 10-20% on my Dual-Core machine down > from a few hundred percent. > Do you know wether ReentrantLock could also be optimized to use > BiasedLocking? In my use-case most likely one thread will > aquire/release the lock again and again, maybe from time to time > another thread will aquire it, but rather seldom. > > > Our per primitive cost is still mostly > > consists of jni overhead for small primitives (think > > fillRect(1x1)). > For my fillRect(1x1) test the locking of AWT's ReentrantLock was far > more expensive than the JNI overhead even with almost no contention. > That was for a VolatileImage, on a Dual-Core machine, on a single-core > machine I tested on the hit was much smaller. > > > In the meantime the people who believe jni performance is very good > > please continue to speak up as I'm sure the vm engineers who have > > worked > > to improve this path over the years will appreciate the feedback. :-) > Its really impressive, congratulations and thanks to the vm engineers > who made that possible :) ;) > > Thanks a lot, lg Clemens >

1 0