April 2008 - core-libs-dev

hg: jdk7/tl/jdk: 2 new changesets
by mandy.chung＠sun.com 10 Apr '08

10 Apr '08

Changeset: fd563c5dd750 Author: mchung Date: 2008-04-10 10:47 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd563c5dd750 6610094: Add generic support for platform MXBeans of any type (also fixed 6681031) Summary: Add new methods in ManagementFactory class to obtain platform MXBeans Reviewed-by: alanb, dfuchs, emcmanus ! src/share/classes/com/sun/management/HotSpotDiagnosticMXBean.java ! src/share/classes/java/lang/management/ClassLoadingMXBean.java ! src/share/classes/java/lang/management/CompilationMXBean.java ! src/share/classes/java/lang/management/GarbageCollectorMXBean.java ! src/share/classes/java/lang/management/ManagementFactory.java ! src/share/classes/java/lang/management/MemoryMXBean.java ! src/share/classes/java/lang/management/MemoryManagerMXBean.java ! src/share/classes/java/lang/management/MemoryPoolMXBean.java ! src/share/classes/java/lang/management/OperatingSystemMXBean.java + src/share/classes/java/lang/management/PlatformComponent.java + src/share/classes/java/lang/management/PlatformManagedObject.java ! src/share/classes/java/lang/management/RuntimeMXBean.java ! src/share/classes/java/lang/management/ThreadInfo.java ! src/share/classes/java/lang/management/ThreadMXBean.java ! src/share/classes/java/util/logging/Logging.java ! src/share/classes/java/util/logging/LoggingMXBean.java ! src/share/classes/sun/management/ClassLoadingImpl.java ! src/share/classes/sun/management/CompilationImpl.java ! src/share/classes/sun/management/GarbageCollectorImpl.java ! src/share/classes/sun/management/GcInfoBuilder.java ! src/share/classes/sun/management/GcInfoCompositeData.java ! src/share/classes/sun/management/HotSpotDiagnostic.java ! src/share/classes/sun/management/HotspotCompilation.java ! src/share/classes/sun/management/HotspotInternal.java ! src/share/classes/sun/management/LockDataConverter.java ! src/share/classes/sun/management/ManagementFactory.java + src/share/classes/sun/management/ManagementFactoryHelper.java ! src/share/classes/sun/management/MappedMXBeanType.java ! src/share/classes/sun/management/MemoryImpl.java ! src/share/classes/sun/management/MemoryManagerImpl.java ! src/share/classes/sun/management/MemoryNotifInfoCompositeData.java ! src/share/classes/sun/management/MemoryPoolImpl.java ! src/share/classes/sun/management/MemoryUsageCompositeData.java ! src/share/classes/sun/management/MonitorInfoCompositeData.java ! src/share/classes/sun/management/NotificationEmitterSupport.java ! src/share/classes/sun/management/OperatingSystemImpl.java ! src/share/classes/sun/management/RuntimeImpl.java ! src/share/classes/sun/management/StackTraceElementCompositeData.java ! src/share/classes/sun/management/ThreadImpl.java ! src/share/classes/sun/management/ThreadInfoCompositeData.java ! src/share/classes/sun/management/Util.java ! src/share/classes/sun/management/VMManagementImpl.java ! src/share/classes/sun/management/VMOptionCompositeData.java ! test/com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.java ! test/com/sun/management/HotSpotDiagnosticMXBean/GetDiagnosticOptions.java ! test/com/sun/management/HotSpotDiagnosticMXBean/GetVMOption.java ! test/com/sun/management/HotSpotDiagnosticMXBean/SetVMOption.java + test/java/lang/management/ManagementFactory/GetPlatformMXBeans.java + test/java/lang/management/OperatingSystemMXBean/PlatformMXBeanTest.java Changeset: bcf689d26c1c Author: mchung Date: 2008-04-10 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bcf689d26c1c Merge

1 0

hg: jdk7/tl/jdk: 6529796: Support JIS X 0213:2004 in existing JDK versions, especially for Windows Vista
by xueming.shen＠sun.com 10 Apr '08

10 Apr '08

Changeset: cb934dd5e073 Author: sherman Date: 2008-04-10 14:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cb934dd5e073 6529796: Support JIS X 0213:2004 in existing JDK versions, especially for Windows Vista Summary: SJIS0213 support Reviewed-by: naoto ! make/java/sun_nio/FILES_java.gmk ! make/sun/nio/Makefile + make/tools/CharsetMapping/Makefile + make/tools/CharsetMapping/sjis0213.map ! make/tools/Makefile + make/tools/src/build/tools/charsetmapping/CharsetMapping.java + make/tools/src/build/tools/charsetmapping/GenerateMapping.java + src/share/classes/sun/nio/cs/CharsetMapping.java ! src/share/classes/sun/nio/cs/ext/ExtendedCharsets.java + src/share/classes/sun/nio/cs/ext/MS932_0213.java + src/share/classes/sun/nio/cs/ext/SJIS_0213.java

1 0

hg: jdk7/tl/jdk: 6684582: Launcher needs improved error reporting
by kumar.srinivasan＠sun.com 10 Apr '08

10 Apr '08

Changeset: c2019d1360ef Author: ksrini Date: 2008-04-10 09:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c2019d1360ef 6684582: Launcher needs improved error reporting Summary: indicate the missing main class in the error message Reviewed-by: darcy, kbr ! src/share/bin/emessages.h ! src/share/bin/java.c ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/Arrrghs.sh

1 0

6652379: File.setLastModified fails on large files (lnx only)
by Alan Bateman 10 Apr '08

10 Apr '08

I need a reviewer for 6652379. A recent change in the Linux kernel means utimes(2) fails for invalid argument cases where it didn't fail previously. This exposes a long standing bug in java.io.File's setLastModified implementation when setting the last modified time on large files. The attached patch fixes the bug by mostly eliminating the crud left over from the addition of large file support in JDK1.2. Thanks, Alan. diff -r f4205a7bdfd4 src/solaris/native/java/io/UnixFileSystem_md.c --- a/src/solaris/native/java/io/UnixFileSystem_md.c Mon Apr 07 14:19:23 2008 -0700 +++ b/src/solaris/native/java/io/UnixFileSystem_md.c Thu Apr 10 12:59:48 2008 +0100 @@ -58,70 +58,6 @@ Java_java_io_UnixFileSystem_initIDs(JNIE "path", "Ljava/lang/String;"); } - -/* -- Large-file support -- */ - -/* LINUX_FIXME: ifdef __solaris__ here is wrong. We need to move the - * definition of stat64 into a solaris_largefile.h and create a - * linux_largefile.h with a good stat64 structure to compile on - * glibc2.0 based systems. - */ -#if defined(__solaris__) && !defined(_LFS_LARGEFILE) || !_LFS_LARGEFILE - -/* The stat64 structure must be provided for systems without large-file support - (e.g., Solaris 2.5.1). These definitions are copied from the Solaris 2.6 - <sys/stat.h> and <sys/types.h> files. - */ - -typedef longlong_t off64_t; /* offsets within files */ -typedef u_longlong_t ino64_t; /* expanded inode type */ -typedef longlong_t blkcnt64_t; /* count of file blocks */ - -struct stat64 { - dev_t st_dev; - long st_pad1[3]; - ino64_t st_ino; - mode_t st_mode; - nlink_t st_nlink; - uid_t st_uid; - gid_t st_gid; - dev_t st_rdev; - long st_pad2[2]; - off64_t st_size; - timestruc_t st_atim; - timestruc_t st_mtim; - timestruc_t st_ctim; - long st_blksize; - blkcnt64_t st_blocks; - char st_fstype[_ST_FSTYPSZ]; - long st_pad4[8]; -}; - -#endif /* !_LFS_LARGEFILE */ - -typedef int (*STAT64)(const char *, struct stat64 *); - -#if defined(__linux__) && defined(_LARGEFILE64_SOURCE) -static STAT64 stat64_ptr = &stat64; -#else -static STAT64 stat64_ptr = NULL; -#endif - -#ifndef __linux__ -#ifdef __GNUC__ -static void init64IO(void) __attribute__((constructor)); -#else -#pragma init(init64IO) -#endif -#endif - -static void init64IO(void) { - void *handle = dlopen(0, RTLD_LAZY); - stat64_ptr = (STAT64) dlsym(handle, "_stat64"); - dlclose(handle); -} - - /* -- Path operations -- */ extern int canonicalize(char *path, const char *out, int len); @@ -151,18 +87,10 @@ static jboolean static jboolean statMode(const char *path, int *mode) { - if (stat64_ptr) { - struct stat64 sb; - if (((*stat64_ptr)(path, &sb)) == 0) { - *mode = sb.st_mode; - return JNI_TRUE; - } - } else { - struct stat sb; - if (stat(path, &sb) == 0) { - *mode = sb.st_mode; - return JNI_TRUE; - } + struct stat64 sb; + if (stat64(path, &sb) == 0) { + *mode = sb.st_mode; + return JNI_TRUE; } return JNI_FALSE; } @@ -266,16 +194,9 @@ Java_java_io_UnixFileSystem_getLastModif jlong rv = 0; WITH_FIELD_PLATFORM_STRING(env, file, ids.path, path) { - if (stat64_ptr) { - struct stat64 sb; - if (((*stat64_ptr)(path, &sb)) == 0) { - rv = 1000 * (jlong)sb.st_mtime; - } - } else { - struct stat sb; - if (stat(path, &sb) == 0) { - rv = 1000 * (jlong)sb.st_mtime; - } + struct stat64 sb; + if (stat64(path, &sb) == 0) { + rv = 1000 * (jlong)sb.st_mtime; } } END_PLATFORM_STRING(env, path); return rv; @@ -289,16 +210,9 @@ Java_java_io_UnixFileSystem_getLength(JN jlong rv = 0; WITH_FIELD_PLATFORM_STRING(env, file, ids.path, path) { - if (stat64_ptr) { - struct stat64 sb; - if (((*stat64_ptr)(path, &sb)) == 0) { - rv = sb.st_size; - } - } else { - struct stat sb; - if (stat(path, &sb) == 0) { - rv = sb.st_size; - } + struct stat64 sb; + if (stat64(path, &sb) == 0) { + rv = sb.st_size; } } END_PLATFORM_STRING(env, path); return rv; @@ -447,15 +361,6 @@ Java_java_io_UnixFileSystem_rename0(JNIE return rv; } - -/* Bug in solaris /usr/include/sys/time.h? */ -#ifdef __solaris__ -extern int utimes(const char *, const struct timeval *); -#elif defined(__linux___) -extern int utimes(const char *, struct timeval *); -#endif - - JNIEXPORT jboolean JNICALL Java_java_io_UnixFileSystem_setLastModifiedTime(JNIEnv *env, jobject this, jobject file, jlong time) @@ -463,47 +368,22 @@ Java_java_io_UnixFileSystem_setLastModif jboolean rv = JNI_FALSE; WITH_FIELD_PLATFORM_STRING(env, file, ids.path, path) { - struct timeval tv[2]; -#ifdef __solaris__ - timestruc_t ts; - - if (stat64_ptr) { - struct stat64 sb; - if (((*stat64_ptr)(path, &sb)) == 0) - ts = sb.st_atim; - else - goto error; - } else { - struct stat sb; - if (stat(path, &sb) == 0) - ts = sb.st_atim; - else - goto error; - } -#endif - - /* Preserve access time */ -#ifdef __linux__ - struct stat sb; - - if (stat(path, &sb) == 0) { - - tv[0].tv_sec = sb.st_atime; - tv[0].tv_usec = 0; - } -#else - tv[0].tv_sec = ts.tv_sec; - tv[0].tv_usec = ts.tv_nsec / 1000; -#endif - - /* Change last-modified time */ - tv[1].tv_sec = time / 1000; - tv[1].tv_usec = (time % 1000) * 1000; - - if (utimes(path, tv) >= 0) - rv = JNI_TRUE; - - error: ; + struct stat64 sb; + + if (stat64(path, &sb) == 0) { + struct timeval tv[2]; + + /* Preserve access time */ + tv[0].tv_sec = sb.st_atime; + tv[0].tv_usec = 0; + + /* Change last-modified time */ + tv[1].tv_sec = time / 1000; + tv[1].tv_usec = (time % 1000) * 1000; + + if (utimes(path, tv) == 0) + rv = JNI_TRUE; + } } END_PLATFORM_STRING(env, path); return rv; diff -r f4205a7bdfd4 test/java/io/File/SetLastModified.java --- a/test/java/io/File/SetLastModified.java Mon Apr 07 14:19:23 2008 -0700 +++ b/test/java/io/File/SetLastModified.java Thu Apr 10 12:59:48 2008 +0100 @@ -22,11 +22,13 @@ */ /* @test - @bug 4091757 + @bug 4091757 6652379 @summary Basic test for setLastModified method */ import java.io.*; +import java.nio.ByteBuffer; +import java.nio.channels.FileChannel; public class SetLastModified { @@ -95,13 +97,23 @@ public class SetLastModified { if (f.setLastModified(nt)) throw new Exception("Succeeded on non-existent file: " + f); - OutputStream o = new FileOutputStream(f); - o.write('x'); - o.close(); - ot = f.lastModified(); - if (!f.setLastModified(nt)) - throw new Exception("setLastModified failed on file: " + f); - ck(f, nt, f.lastModified()); + // set/check last modified on files of size 1, 1GB+1, 2GB+1, .. + // On Windows we only test with a tiny file as that platform doesn't + // support sparse files by default and so the test takes too long. + final long G = 1024L * 1024L * 1024L; + final long MAX_POSITION = + System.getProperty("os.name").startsWith("Windows") ? 0L : 3L*G; + long pos = 0L; + while (pos <= MAX_POSITION) { + FileChannel fc = new FileOutputStream(f).getChannel(); + fc.position(pos).write(ByteBuffer.wrap("x".getBytes())); + fc.close(); + ot = f.lastModified(); + if (!f.setLastModified(nt)) + throw new Exception("setLastModified failed on file: " + f); + ck(f, nt, f.lastModified()); + pos += G; + } if (!f.delete()) throw new Exception("Can't delete test file " + f); if (!d2.delete()) throw new Exception("Can't delete test directory " + d2);

1 0

4939819: File.canWrite() returns false for the "My Documents" directory (win)
by Alan Bateman 10 Apr '08

10 Apr '08

I need a reviewer for 4939819. This is one that the desktop folks have been asking to be fixed for some time. On Windows the DOS read-only attribute doesn't make a directory read-only. Instead this attribute just prevents a directory from being deleted. The bug is that java.io.File's canWrite method returns false when this attribute is set whereas it should be ignored when checking access to directories. The attached patch fixes this by ignoring the attribute on directories. There shouldn't be any side effects moving from _waccess to GetFileAttributes because the Microsoft CRT has always implemented _waccess as a call to GetFileAttributesW. Thanks, Alan. diff -r f4205a7bdfd4 src/windows/native/java/io/WinNTFileSystem_md.c --- a/src/windows/native/java/io/WinNTFileSystem_md.c Mon Apr 07 14:19:23 2008 -0700 +++ b/src/windows/native/java/io/WinNTFileSystem_md.c Wed Apr 09 14:10:23 2008 +0100 @@ -229,26 +229,29 @@ JNICALL Java_java_io_WinNTFileSystem_che JNICALL Java_java_io_WinNTFileSystem_checkAccess(JNIEnv *env, jobject this, jobject file, jint access) { - jboolean rv = JNI_FALSE; - int mode; - WCHAR *pathbuf = fileToNTPath(env, file, ids.path); - if (pathbuf == NULL) + DWORD attr; + WCHAR *pathbuf = fileToNTPath(env, file, ids.path); + if (pathbuf == NULL) + return JNI_FALSE; + attr = GetFileAttributesW(pathbuf); + free(pathbuf); + if (attr == INVALID_FILE_ATTRIBUTES) return JNI_FALSE; switch (access) { case java_io_FileSystem_ACCESS_READ: case java_io_FileSystem_ACCESS_EXECUTE: - mode = 4; - break; + return JNI_TRUE; case java_io_FileSystem_ACCESS_WRITE: - mode = 2; - break; - default: assert(0); - } - if (_waccess(pathbuf, mode) == 0) { - rv = JNI_TRUE; - } - free(pathbuf); - return rv; + /* Read-only attribute ignored on directories */ + if ((attr & FILE_ATTRIBUTE_DIRECTORY) || + (attr & FILE_ATTRIBUTE_READONLY) == 0) + return JNI_TRUE; + else + return JNI_FALSE; + default: + assert(0); + return JNI_FALSE; + } } JNIEXPORT jboolean JNICALL diff -r f4205a7bdfd4 test/java/io/File/SetReadOnly.java --- a/test/java/io/File/SetReadOnly.java Mon Apr 07 14:19:23 2008 -0700 +++ b/test/java/io/File/SetReadOnly.java Wed Apr 09 14:10:23 2008 +0100 @@ -22,7 +22,7 @@ */ /* @test - @bug 4091757 + @bug 4091757 4939819 @summary Basic test for setReadOnly method */ @@ -59,8 +59,15 @@ public class SetReadOnly { throw new Exception(f + ": Cannot create directory"); if (!f.setReadOnly()) throw new Exception(f + ": Failed on directory"); - if (f.canWrite()) - throw new Exception(f + ": Directory is writeable"); + // The readonly attribute on Windows does not make a folder read-only + if (System.getProperty("os.name").startsWith("Windows")) { + if (!f.canWrite()) + throw new Exception(f + ": Directory is not writeable"); + } else { + if (f.canWrite()) + throw new Exception(f + ": Directory is writeable"); + } + if (!f.delete()) throw new Exception(f + ": Cannot delete directory");

1 0

hg: jdk7/tl/langtools: 4 new changesets
by maurizio.cimadamore＠sun.com 09 Apr '08

09 Apr '08

Changeset: 447c300a24e7 Author: mcimadamore Date: 2008-04-09 14:45 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/447c300a24e7 6450290: Capture of nested wildcards causes type error Summary: A missing capture conversion makes javac to think that some expressions are well-formed even when they aren't Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/wildcards/T6450290.java Changeset: e7bf2e39b8fe Author: mcimadamore Date: 2008-04-09 14:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/e7bf2e39b8fe 6657499: javac 1.6.0 fails to compile class with inner class Summary: Lookup of member inner classes silently fails leading to an unwanted erasure to take place Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/T6657499.java Changeset: 6522ea413d23 Author: mcimadamore Date: 2008-04-09 15:04 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/6522ea413d23 6683438: Bad regression test for CR 6611449 Summary: The regression test for CR 6611449 contains some inconstistencies Reviewed-by: jjg ! test/tools/javac/generics/inference/6611449/T6611449.java ! test/tools/javac/generics/inference/6611449/T6611449.out Changeset: a1d1f335633f Author: mcimadamore Date: 2008-04-09 15:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/a1d1f335633f 6559182: Cast from a raw type with non-generic supertype to a raw type fails unexpectedly Summary: Javac doesn't conform to JLS 4.8 - all the supertypes of a raw type must be erased Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/Casting5.java

1 0

hg: jdk7/tl/langtools: 4 new changesets
by maurizio.cimadamore＠sun.com 09 Apr '08

09 Apr '08

Changeset: 961ae2608114 Author: mcimadamore Date: 2008-04-09 13:19 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/961ae2608114 6531075: Missing synthetic casts when accessing fields/methods of intersection types including type variables Summary: bug when javac generates code involving intersection types Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java + test/tools/javac/generics/6531075/T6531075.java Changeset: d032d5090fd5 Author: mcimadamore Date: 2008-04-09 13:41 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/d032d5090fd5 5009937: hiding versus generics versus binary compatibility Summary: missing implementation of JLS 8.4.8.3 (different arguments with same erasure not always triggering a compiler error) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/5009937/T5009937.java + test/tools/javac/generics/5009937/T5009937.out ! test/tools/javac/generics/InheritanceConflict.java ! test/tools/javac/generics/InheritanceConflict2.java Changeset: 57ba4f70f0d8 Author: mcimadamore Date: 2008-04-09 13:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/57ba4f70f0d8 6365166: javac (generic) unable to resolve methods Summary: Unignore regression test as this bug has been fixed by CR 6278587 Reviewed-by: jjg + test/tools/javac/generics/inference/6356673/T6365166.java Changeset: 25338c55e458 Author: mcimadamore Date: 2008-04-09 14:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/25338c55e458 6481655: Parser confused by combination of parens and explicit type args Summary: Bug in the parser caused by the fact that explicit type arguments are disabled when parsing parenthesized expressions Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/Parser.java + test/tools/javac/generics/T6481655.java

1 0

hg: jdk7/tl/jdk: 14 new changesets
by bradford.wetmore＠sun.com 07 Apr '08

07 Apr '08

Changeset: a8d6215fa863 Author: weijun Date: 2008-03-20 11:57 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a8d6215fa863 6670362: HTTP/SPNEGO should work across realms Reviewed-by: valeriep ! src/share/classes/sun/net/www/protocol/http/NegotiatorImpl.java Changeset: 74bc85c0f2a9 Author: valeriep Date: 2008-03-20 16:02 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/74bc85c0f2a9 4898461: Support for ECB and CBC/PKCS5Padding Summary: Add support for ECB mode and PKCS5Padding Reviewed-by: andreas ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java + test/sun/security/pkcs11/Cipher/TestSymmCiphers.java Changeset: 66c2b0cfc896 Author: valeriep Date: 2008-03-20 17:17 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/66c2b0cfc896 6572331: regression: cipher.wrap operation fails with CKR_ATTRIBUTE_VALUE_INVALID Summary: Check supported key size range and use encryption if needed Reviewed-by: andreas ! src/share/classes/sun/security/pkcs11/P11KeyGenerator.java ! src/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java + test/sun/security/pkcs11/Cipher/TestRSACipherWrap.java Changeset: 84aced25a346 Author: valeriep Date: 2008-03-20 18:41 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/84aced25a346 6599979: KeyStore.setEntry/setKeyEntry() do not override existing entry for secret key objects Summary: Override existing secret key entry when setEntry/setKeyEntry() is called Reviewed-by: andreas ! src/share/classes/sun/security/pkcs11/P11KeyStore.java ! src/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java + test/sun/security/pkcs11/KeyStore/SecretKeysBasic.java + test/sun/security/pkcs11/KeyStore/SecretKeysBasic.sh Changeset: 05afbed1dc4f Author: valeriep Date: 2008-03-21 14:45 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05afbed1dc4f Merge Changeset: b22cbc65a360 Author: wetmore Date: 2008-03-28 12:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b22cbc65a360 Merge Changeset: 8805ae9d160c Author: valeriep Date: 2008-03-31 11:09 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8805ae9d160c 6681652: Two new regression test failures in pkcs11 code Summary: Fixed the test to not assume SunJCE provider being the provider for DES Reviewed-by: wetmore ! test/javax/crypto/Cipher/TestGetInstance.java Changeset: e1bf7407c933 Author: wetmore Date: 2008-03-31 13:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e1bf7407c933 6469580: 1.5.0_08 JVM crashes in SignatureHandlerLibrary::add on Fujitsu Primepower platform Reviewed-by: andreas, valeriep, wetmore Contributed-by: chris.phillips(a)sun.com ! src/solaris/native/sun/security/pkcs11/wrapper/p11_md.c Changeset: 17e93b7fb97d Author: valeriep Date: 2008-03-31 16:12 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/17e93b7fb97d 6682411: JCK test failed w/ ArrayIndexOutOfBoundException (-1) when decrypting with no data Summary: Fixed PKCS5Padding class with additional check and throw BadPaddingException if the check failed Reviewed-by: wetmore ! src/share/classes/sun/security/pkcs11/P11Cipher.java Changeset: c063b7fb55f7 Author: valeriep Date: 2008-03-31 16:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c063b7fb55f7 6682417: JCK test failed w/ ProviderException when decrypted data is not multiple of blocks Summary: Check for CKR_ENCRYPTED_DATA_LEN_RANGE and throw IllegalBlockSizeException Reviewed-by: wetmore ! src/share/classes/sun/security/pkcs11/P11Cipher.java Changeset: 99b3301fc27c Author: valeriep Date: 2008-03-31 16:50 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99b3301fc27c Merge Changeset: df5d7e6ac15e Author: xuelei Date: 2008-04-02 22:44 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/df5d7e6ac15e 6668231: Presence of a critical subjectAltName causes JSSE's SunX509 to fail trusted checks Summary: make the critical extension known to end entity checker. Reviewed-by: wetmore, mullan ! src/share/classes/sun/security/validator/EndEntityChecker.java + test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/CriticalSubjectAltName.java + test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/crisubn.jks + test/sun/security/ssl/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnection/trusted.jks Changeset: b70fc43afb8c Author: wetmore Date: 2008-04-06 10:15 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b70fc43afb8c 6683078: Update JCE framework and provider builds to work on read-only filesystems 6644659: Error in default target of make/javax/crypto in OpenJDK build Reviewed-by: valeriep, ohair ! make/com/sun/crypto/provider/Makefile ! make/common/shared/Defs.gmk ! make/javax/crypto/Defs-jce.gmk ! make/javax/crypto/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile Changeset: f4205a7bdfd4 Author: wetmore Date: 2008-04-07 14:19 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f4205a7bdfd4 Merge

1 0

sun.nio.ch.NativeThread.current
by Martin Buchholz 06 Apr '08

06 Apr '08

There is a mismatch between the spec and implementation of sun.nio.ch.NativeThread.current // Returns an opaque token representing the native thread underlying the // invoking Java thread. On systems that do not require signalling, this // method always returns zero. // static native long current(); ... Java_sun_nio_ch_NativeThread_current(JNIEnv *env, jclass cl) { #ifdef __linux__ return (long)pthread_self(); #else return -1; #endif ... Which is it, zero or -1? Please file a bug. Thanks, Martin

2 1

BigInteger performance improvements
by Alan Eliasen 04 Apr '08

04 Apr '08

I'm planning on tackling the performance issues in the BigInteger class. In short, inefficient algorithms are used for multiplication, exponentiation, conversion to strings, etc. I intend to improve this by adding algorithms with better asymptotic behavior that will work better for large numbers, while preserving the existing algorithms for use with smaller numbers. This encompasses a lot of different bug reports: 4228681: Some BigInteger operations are slow with very large numbers http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4228681 (This was closed but never fixed.) 4837946: Implement Karatsuba multiplication algorithm in BigInteger http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4837946 I've already done the work on this one. My implementation is intended to be easy to read, understand, and check. It significantly improves multiplication performance for large numbers. 4646474: BigInteger.pow() algorithm slow in 1.4.0 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4646474 This will be improved in a couple ways: * Rewrite pow() to use the above Karatsuba multiplication * Implement Karatsuba squaring * Finding a good threshhold for Karatsuba squaring * Rewrite pow() to use Karatsuba squaring * Add an optimization to use left-shifting for multiples of 2 in the base. This improves speed by thousands of times for things like Mersenne numbers. 4641897: BigInteger.toString() algorithm slow for large numbers http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4641897 This algorithm uses a very inefficient algorithm for large numbers. I plan to replace it with a recursive divide-and-conquer algorithm devised by Schoenhage and Strassen. I have developed and tested this in my own software. This operates hundreds or thousands of times faster than the current version for large numbers. It will also benefit from faster multiplication and exponentiation. In the future, we should also add multiplication routines that are even more efficient for very large numbers, such as Toom-Cook multiplication, which is more efficient than Karatsuba multiplication for even larger numbers. Has anyone else worked on these? Is this the right group? I will probably submit the Karatsuba multiplication patch soon. Would it be more preferable to implement *all* of these parts first and submit one large patch? -- Alan Eliasen | "Furious activity is no substitute eliasen(a)mindspring.com | for understanding." http://futureboy.us/ | --H.H. Williams

3 9