July 2008 - core-libs-dev

Re: [PATCH] 4837946: Implement Karatsuba multiplication algorithm in BigInteger
by Alan Eliasen 06 Jun '09

06 Jun '09

Anonymous member wrote: > Out of curiousity, how does the Java implementation compare to GMP in > terms of speed? (Note: These numbers apply to the *revised* patch that I'll be posting in a few minutes.) It depends on the size of the numbers. When I run the regression tests that I wrote, my updated Java version runs in about 2 minutes. When I run the same regression test in Kaffe using GMP, it takes about 2 *hours*. (Some of the same tests using Java 1.6 take many, many hours without my optimizations for the pow() function). But those are a lot of small numbers. There is a lot of overhead in converting from Java to C types and back, and in Kaffe's relative slowness. And currently, only multiply() has been improved in my Java patches that I've submitted. Kaffe is about 25 times slower on the average program anyway. When you run Kaffe/GMP for very large numbers, Kaffe/GMP starts being very much faster. OpenJDK still can't compete for numbers that are on the cutting edge of number theory. But we'll be much better than we were before. If I were to write the same code in pure C using GMP, then GMP would be much faster. But I haven't done that. So it's hard to compare GMP to Java exactly. But some numbers. For multiplying the numbers 3^1000000 * 3^1000001, (with my fixes to do the exponentiation hundreds of thousands of times faster factored out; without these, JDK 1.6 would be thousands of times slower,) the times for 20 iterations are: JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP 292987 ms 28650 ms 866 ms Thus, for numbers of this size, my algorithms are more than 10 times faster than JDK 1.6, but 33 times slower than Kaffe/GMP. For multiplying the somewhat special form 2^1000000 * 2^1000001, (the arguments of this in binary are a 1 followed by a million zeroes) JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP 117298 ms 386 ms 474 ms So, my algorithm is 303 times faster than JDK, and just slightly faster than Kaffe/GMP. For multiplying numbers 3^14000000 * 3^14000001, the time for 1 iteration is: JDK 1.6 OpenJDK1.7 with my patches Kaffe w/GMP 3499115 ms 89505 ms 910 ms Thus, for numbers of this size, my patches make it 38.9 times faster, but still 99 times slower than GMP. Sigh. Well, to be expected. If you work with large numbers, GMP becomes ridiculously faster. Kaffe with GMP becomes only slightly slower than pure GMP as the portion of time in Java gets small. GMP includes 3-way Toom-Cook multiplication, and the much faster FFT multiplication (which is O(n)) for very large numbers, and hand-crafted assembly language that uses 64-bit instructions and limbs on my 64-bit architecture (as opposed to the 32-bit ints used in BigInteger. Hopefully some day in the future, BigInteger will be rewritten to use longs internally instead of ints. Multiplying two 64-bit longs does 4 times as much work as multiplying two 32-bit ints, and will thus likely be significantly faster, especially on 64-bit architectures.) So GMP is still very much faster for very large numbers. It is also *much* faster in turning numbers into strings, and in exponentiation. The algorithms in BigInteger are horrible for pow() and toString(). See the following bugs: 4641897: BigInteger.toString() algorithm slow for large numbers http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4641897 4646474: BigInteger.pow() algorithm slow in 1.4.0 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4646474 I have several fixes for both of these. My JVM-based programming language Frink ( http://futureboy.us/frinkdocs/ ) implements many of these improvements, and is much faster for a variety of arguments. I just need to finish improving these for a variety of different arguments, and considering the threading and memory-size-vs-speed tradeoffs in implementing toString efficiently. -- Alan Eliasen | "Furious activity is no substitute eliasen(a)mindspring.com | for understanding." http://futureboy.us/ | --H.H. Williams

4 8

hg: jdk7/tl/jdk: 6616825: JMX query returns no value in 1.0 compatibility mode - deserialization bug in readObject()
by daniel.fuchs＠sun.com 31 Jul '08

31 Jul '08

Changeset: 98caad5c563c Author: dfuchs Date: 2008-07-31 17:38 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98caad5c563c 6616825: JMX query returns no value in 1.0 compatibility mode - deserialization bug in readObject() Reviewed-by: emcmanus ! src/share/classes/javax/management/ObjectName.java ! test/javax/management/ObjectName/SerialCompatTest.java

1 0

hg: jdk7/tl/jdk: 5108776: Add reliable event handling to the JMX API; ...
by eamonn.mcmanus＠sun.com 31 Jul '08

31 Jul '08

Changeset: 8f52c4d1d934 Author: sjiang Date: 2008-07-31 15:31 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8f52c4d1d934 5108776: Add reliable event handling to the JMX API 6218920: API bug - impossible to delete last MBeanServerForwarder on a connector Reviewed-by: emcmanus + src/share/classes/com/sun/jmx/event/DaemonThreadFactory.java + src/share/classes/com/sun/jmx/event/EventBuffer.java + src/share/classes/com/sun/jmx/event/EventClientFactory.java + src/share/classes/com/sun/jmx/event/EventConnection.java + src/share/classes/com/sun/jmx/event/EventParams.java + src/share/classes/com/sun/jmx/event/LeaseManager.java + src/share/classes/com/sun/jmx/event/LeaseRenewer.java + src/share/classes/com/sun/jmx/event/ReceiverBuffer.java + src/share/classes/com/sun/jmx/event/RepeatedSingletonJob.java + src/share/classes/com/sun/jmx/interceptor/MBeanServerSupport.java + src/share/classes/com/sun/jmx/interceptor/SingleMBeanForwarder.java ! src/share/classes/com/sun/jmx/interceptor/package.html ! src/share/classes/com/sun/jmx/mbeanserver/MBeanInjector.java ! src/share/classes/com/sun/jmx/mbeanserver/MBeanSupport.java + src/share/classes/com/sun/jmx/mbeanserver/PerThreadGroupPool.java ! src/share/classes/com/sun/jmx/mbeanserver/Util.java ! src/share/classes/com/sun/jmx/remote/internal/ClientNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/internal/ProxyInputStream.java ! src/share/classes/com/sun/jmx/remote/internal/ProxyRef.java ! src/share/classes/com/sun/jmx/remote/internal/ServerNotifForwarder.java ! src/share/classes/com/sun/jmx/remote/security/FileLoginModule.java ! src/share/classes/com/sun/jmx/remote/util/EnvHelp.java + src/share/classes/com/sun/jmx/remote/util/EventClientConnection.java ! src/share/classes/com/sun/jmx/snmp/tasks/ThreadService.java ! src/share/classes/javax/management/ImmutableDescriptor.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerConnection.java ! src/share/classes/javax/management/MXBean.java ! src/share/classes/javax/management/QueryParser.java ! src/share/classes/javax/management/StringValueExp.java + src/share/classes/javax/management/event/EventClient.java + src/share/classes/javax/management/event/EventClientDelegate.java + src/share/classes/javax/management/event/EventClientDelegateMBean.java + src/share/classes/javax/management/event/EventClientNotFoundException.java + src/share/classes/javax/management/event/EventConsumer.java + src/share/classes/javax/management/event/EventForwarder.java + src/share/classes/javax/management/event/EventReceiver.java + src/share/classes/javax/management/event/EventRelay.java + src/share/classes/javax/management/event/EventSubscriber.java + src/share/classes/javax/management/event/FetchingEventForwarder.java + src/share/classes/javax/management/event/FetchingEventRelay.java + src/share/classes/javax/management/event/ListenerInfo.java + src/share/classes/javax/management/event/NotificationManager.java + src/share/classes/javax/management/event/RMIPushEventForwarder.java + src/share/classes/javax/management/event/RMIPushEventRelay.java + src/share/classes/javax/management/event/RMIPushServer.java + src/share/classes/javax/management/event/package-info.java ! src/share/classes/javax/management/loading/MLet.java ! src/share/classes/javax/management/modelmbean/ModelMBeanInfoSupport.java ! src/share/classes/javax/management/modelmbean/RequiredModelMBean.java ! src/share/classes/javax/management/relation/RelationService.java + src/share/classes/javax/management/remote/IdentityMBeanServerForwarder.java ! src/share/classes/javax/management/remote/JMXConnector.java ! src/share/classes/javax/management/remote/JMXConnectorServer.java ! src/share/classes/javax/management/remote/JMXConnectorServerFactory.java ! src/share/classes/javax/management/remote/JMXConnectorServerMBean.java ! src/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java ! src/share/classes/javax/management/remote/rmi/RMIConnector.java ! src/share/classes/javax/management/remote/rmi/RMIConnectorServer.java + test/javax/management/MBeanServer/DynamicWrapperMBeanTest.java + test/javax/management/MBeanServer/OldMBeanServerTest.java + test/javax/management/eventService/AddRemoveListenerTest.java + test/javax/management/eventService/CustomForwarderTest.java + test/javax/management/eventService/EventClientExecutorTest.java + test/javax/management/eventService/EventDelegateSecurityTest.java + test/javax/management/eventService/EventManagerTest.java + test/javax/management/eventService/FetchingTest.java + test/javax/management/eventService/LeaseManagerDeadlockTest.java + test/javax/management/eventService/LeaseTest.java + test/javax/management/eventService/ListenerTest.java + test/javax/management/eventService/MyFetchingEventForwarder.java + test/javax/management/eventService/NotSerializableNotifTest.java + test/javax/management/eventService/PublishTest.java + test/javax/management/eventService/ReconnectableConnectorTest.java + test/javax/management/eventService/SharingThreadTest.java + test/javax/management/eventService/SubscribeTest.java + test/javax/management/eventService/UsingEventService.java ! test/javax/management/mxbean/GenericArrayTypeTest.java ! test/javax/management/mxbean/LeakTest.java ! test/javax/management/mxbean/MBeanOperationInfoTest.java ! test/javax/management/mxbean/MXBeanTest.java ! test/javax/management/mxbean/ThreadMXBeanTest.java ! test/javax/management/mxbean/TigerMXBean.java ! test/javax/management/query/QueryNotifFilterTest.java ! test/javax/management/remote/mandatory/connection/CloseServerTest.java ! test/javax/management/remote/mandatory/connection/DeadLockTest.java ! test/javax/management/remote/mandatory/connection/IdleTimeoutTest.java ! test/javax/management/remote/mandatory/connection/RMIExitTest.java ! test/javax/management/remote/mandatory/connection/ReconnectTest.java + test/javax/management/remote/mandatory/connectorServer/ForwarderChainTest.java + test/javax/management/remote/mandatory/connectorServer/StandardForwardersTest.java ! test/javax/management/remote/mandatory/loading/MissingClassTest.java ! test/javax/management/remote/mandatory/notif/AddRemoveTest.java ! test/javax/management/remote/mandatory/notif/DiffHBTest.java ! test/javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java ! test/javax/management/remote/mandatory/notif/ListenerScaleTest.java ! test/javax/management/remote/mandatory/notif/NotifBufferSizePropertyNameTest.java ! test/javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java ! test/javax/management/remote/mandatory/notif/NotificationAccessControllerTest.java ! test/javax/management/remote/mandatory/notif/NotificationBufferCreationTest.java ! test/javax/management/remote/mandatory/notif/NotificationBufferDeadlockTest.java ! test/javax/management/remote/mandatory/notif/NotificationEmissionTest.java ! test/javax/management/remote/mandatory/notif/RMINotifTest.java ! test/javax/management/remote/mandatory/notif/UnexpectedNotifTest.java

1 0

hg: jdk7/tl/jdk: 6689505: Improve MBeanServerNotification.toString
by daniel.fuchs＠sun.com 31 Jul '08

31 Jul '08

Changeset: 7622f1de1486 Author: dfuchs Date: 2008-07-31 14:20 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7622f1de1486 6689505: Improve MBeanServerNotification.toString Reviewed-by: emcmanus ! src/share/classes/javax/management/MBeanServerNotification.java + test/javax/management/MBeanServer/MBeanServerNotificationTest.java

1 0

hg: jdk7/tl/jdk: 6730926: Document that create/registerMBean can throw RuntimeMBeanException from postRegister
by daniel.fuchs＠sun.com 31 Jul '08

31 Jul '08

Changeset: 914370f03119 Author: dfuchs Date: 2008-07-31 12:41 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/914370f03119 6730926: Document that create/registerMBean can throw RuntimeMBeanException from postRegister Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/interceptor/DefaultMBeanServerInterceptor.java ! src/share/classes/javax/management/MBeanRegistration.java ! src/share/classes/javax/management/MBeanServer.java ! src/share/classes/javax/management/MBeanServerConnection.java + test/javax/management/MBeanServer/PostExceptionTest.java

1 0

hg: jdk7/tl/jdk: 13 new changesets
by bradford.wetmore＠sun.com 30 Jul '08

30 Jul '08

Changeset: 571a6e4bbb91 Author: jccollet Date: 2008-07-01 13:29 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/571a6e4bbb91 6713809: FTP fails from multi-homed system Summary: Binds the data socket to the same address as the control socket Reviewed-by: michaelm ! src/share/classes/sun/net/ftp/FtpClient.java Changeset: b6a29195bc04 Author: jccollet Date: 2008-07-01 13:38 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b6a29195bc04 6656849: NullPointerException thrown while de-serializing IPV6 Address. Summary: Check for existence of interface name earlier in code Reviewed-by: michaelm ! src/share/classes/java/net/Inet6Address.java + test/java/net/Inet6Address/serialize/Readme.txt ! test/java/net/Inet6Address/serialize/Serialize.java + test/java/net/Inet6Address/serialize/serial-bge0.ser Changeset: cedc95b10b72 Author: wetmore Date: 2008-07-07 13:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cedc95b10b72 Merge Changeset: 1d621ef0330b Author: weijun Date: 2008-07-09 12:03 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d621ef0330b 6480981: keytool should be able to import certificates from remote SSL servers Reviewed-by: vinnie, wetmore ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/Resources.java + test/sun/security/tools/keytool/PrintSSL.java + test/sun/security/tools/keytool/printssl.sh Changeset: c9be2cc052b5 Author: michaelm Date: 2008-07-14 11:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c9be2cc052b5 6536211: flaw in ServerImpl Summary: removed doPrivileged block Reviewed-by: jccollet ! src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: 3b8e5bfe2be7 Author: chegar Date: 2008-07-19 10:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3b8e5bfe2be7 6726164: jdk\src\windows\native\java\net\NetworkInterface.h(172) : error C2365: 'IpPrefixOriginOther' : redef Summary: Change the NetworkInterface header that allows it to compile on the current compiler/SDK version as well as the SDK bundled with Visual Studio 2008. Reviewed-by: ohair, alanb ! src/windows/native/java/net/NetworkInterface.h Changeset: 8f63365a2586 Author: michaelm Date: 2008-07-23 12:05 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8f63365a2586 6728076: Test case for 6536211 is failing on all platforms Summary: exception needed to be caught and logged Reviewed-by: chegar ! src/share/classes/sun/net/httpserver/ServerImpl.java Changeset: 701eaee7ebed Author: wetmore Date: 2008-07-23 12:16 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/701eaee7ebed Merge ! src/share/classes/sun/net/ftp/FtpClient.java Changeset: 9655476d50f4 Author: weijun Date: 2008-07-27 19:16 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9655476d50f4 6709758: keytool default cert fingerprint algorithm should be SHA1, not MD5 Reviewed-by: mullan, xuelei ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/Resources.java Changeset: b7fce4bac617 Author: chegar Date: 2008-07-28 13:02 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b7fce4bac617 6729881: Compiler warning in networking native code Summary: Cleanup compiler warnings Reviewed-by: alanb, jccollet, michaelm ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c ! src/solaris/native/java/net/SocketInputStream.c ! src/solaris/native/java/net/SocketOutputStream.c ! src/solaris/native/java/net/linux_close.c ! src/solaris/native/java/net/net_util_md.c ! src/windows/native/java/net/Inet4AddressImpl.c ! src/windows/native/java/net/Inet6AddressImpl.c ! src/windows/native/java/net/NetworkInterface.c ! src/windows/native/java/net/NetworkInterface.h ! src/windows/native/java/net/NetworkInterface_win9x.c ! src/windows/native/java/net/NetworkInterface_winXP.c ! src/windows/native/java/net/SocketOutputStream.c ! src/windows/native/java/net/TwoStacksPlainDatagramSocketImpl.c ! src/windows/native/java/net/TwoStacksPlainSocketImpl.c ! src/windows/native/java/net/net_util_md.c ! src/windows/native/java/net/net_util_md.h ! src/windows/native/sun/net/dns/ResolverConfigurationImpl.c ! src/windows/native/sun/net/www/protocol/http/NTLMAuthSequence.c Changeset: 441f88d39988 Author: chegar Date: 2008-07-29 09:53 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/441f88d39988 6730740: Fix for 6729881 has apparently broken several 64 bit tests: "Bad address" Reviewed-by: alanb, jccollet ! src/solaris/native/java/net/linux_close.c ! src/solaris/native/java/net/net_util_md.c Changeset: 95ce89bf8cd2 Author: wetmore Date: 2008-07-29 10:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/95ce89bf8cd2 Merge Changeset: 498c2de672c1 Author: wetmore Date: 2008-07-29 16:57 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/498c2de672c1 Merge

1 0

hg: jdk7/tl/jdk: 6402254: Revisit ModelMBean DescriptorSupport implementation of equals and hashCode.
by daniel.fuchs＠sun.com 29 Jul '08

29 Jul '08

Changeset: 8c667d55b79e Author: dfuchs Date: 2008-07-29 19:21 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8c667d55b79e 6402254: Revisit ModelMBean DescriptorSupport implementation of equals and hashCode. Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/mbeanserver/Util.java ! src/share/classes/javax/management/ImmutableDescriptor.java ! src/share/classes/javax/management/modelmbean/DescriptorSupport.java

1 0

hg: jdk7/tl/jdk: 6730587: TEST: com/sun/jdi/MonitorFrameInfoTest.java fails with -server -Xcomp
by jim.holmlund＠sun.com 28 Jul '08

28 Jul '08

Changeset: f2547e64dc3c Author: jjh Date: 2008-07-28 12:37 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f2547e64dc3c 6730587: TEST: com/sun/jdi/MonitorFrameInfoTest.java fails with -server -Xcomp Summary: Fix test to prevent C2 escape analysis from deleting the required synchronized blocks Reviewed-by: swamyv ! test/com/sun/jdi/MonitorFrameInfo.java

1 0

hg: jdk7/tl/langtools: 6720185: DiagnosticFormatter refactoring
by maurizio.cimadamore＠sun.com 28 Jul '08

28 Jul '08

Changeset: 37470f5ea179 Author: mcimadamore Date: 2008-07-28 10:22 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/37470f5ea179 6720185: DiagnosticFormatter refactoring Summary: Brand new hierarchy of diagnostic formatters for achieving better reusability Reviewed-by: jjg + src/share/classes/com/sun/tools/javac/api/DiagnosticFormatter.java + src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java + src/share/classes/com/sun/tools/javac/util/BasicDiagnosticFormatter.java - src/share/classes/com/sun/tools/javac/util/DiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java + src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java

1 0

StringBuXXXXX.append(char str[], int offset, int len)
by Martin Buchholz 27 Jul '08

27 Jul '08

This is a bug report with fix. StringBuilder, AbstractStringBuilder, and StringBuffer fail to specify IndexOutOfBoundsException for append(char str[], int offset, int len) although other methods in these classes are careful to do so. Here's the fix: diff --git a/src/share/classes/java/lang/AbstractStringBuilder.java b/src/share/classes/java/lang/AbstractStringBuilder.java --- a/src/share/classes/java/lang/AbstractStringBuilder.java +++ b/src/share/classes/java/lang/AbstractStringBuilder.java @@ -525,6 +525,9 @@ * @param offset the index of the first <code>char</code> to append. * @param len the number of <code>char</code>s to append. * @return a reference to this object. + * @throws IndexOutOfBoundsException + * if {@code offset < 0} or {@code len < 0} + * or {@code offset+len > str.length} */ public AbstractStringBuilder append(char str[], int offset, int len) { int newCount = count + len; diff --git a/src/share/classes/java/lang/StringBuffer.java b/src/share/classes/java/lang/StringBuffer.java --- a/src/share/classes/java/lang/StringBuffer.java +++ b/src/share/classes/java/lang/StringBuffer.java @@ -319,6 +319,9 @@ return this; } + /** + * @throws IndexOutOfBoundsException {@inheritDoc} + */ public synchronized StringBuffer append(char str[], int offset, int len) { super.append(str, offset, len); return this; diff --git a/src/share/classes/java/lang/StringBuilder.java b/src/share/classes/java/lang/StringBuilder.java --- a/src/share/classes/java/lang/StringBuilder.java +++ b/src/share/classes/java/lang/StringBuilder.java @@ -201,6 +201,9 @@ return this; } + /** + * @throws IndexOutOfBoundsException {@inheritDoc} + */ public StringBuilder append(char str[], int offset, int len) { super.append(str, offset, len); return this; More changes to these classes to come. Martin

2 1