February 2011 - core-libs-dev

hg: jdk7/tl/jdk: 6702400: ChunkedInputStream expecting -1 from int read, but int->char comparision is wrong
by michael.x.mcmahon＠oracle.com 22 Feb '11

22 Feb '11

Changeset: b853414b8eef Author: michaelm Date: 2011-02-22 14:44 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b853414b8eef 6702400: ChunkedInputStream expecting -1 from int read, but int->char comparision is wrong Reviewed-by: chegar ! src/share/classes/sun/net/httpserver/ChunkedInputStream.java

1 0

hg: jdk7/tl/jdk: 7021327: Changes for 7020888 included changes to other files in error
by alan.bateman＠oracle.com 22 Feb '11

22 Feb '11

Changeset: bac152c6491a Author: alanb Date: 2011-02-22 14:28 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bac152c6491a 7021327: Changes for 7020888 included changes to other files in error Reviewed-by: chegar ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/FilterOutputStream.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/PushbackReader.java ! test/java/lang/ProcessBuilder/Basic.java

1 0

hg: jdk7/tl/jdk: 3 new changesets
by alan.bateman＠oracle.com 22 Feb '11

22 Feb '11

Changeset: dbdafe65af60 Author: alanb Date: 2011-02-21 13:54 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dbdafe65af60 7020517: (fs) FileStore.equals returns true if both volumes have the same serial number Reviewed-by: chegar ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! test/java/nio/file/FileStore/Basic.java Changeset: d7cb44a4d08a Author: alanb Date: 2011-02-22 10:19 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d7cb44a4d08a Merge Changeset: 9d8a0369b906 Author: alanb Date: 2011-02-22 12:04 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9d8a0369b906 7020888: (file) Miscellaneous and trivial clean-ups (typos and opportunities to use suppressed exceptions) Reviewed-by: mduigou, chegar ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FilterOutputStream.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/PushbackReader.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/file/CopyMoveHelper.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! test/java/lang/ProcessBuilder/Basic.java

2 1

hg: jdk7/tl/jdk: 7019705: Add -XX:+AggressiveOpts options to MOAT test
by mike.duigou＠oracle.com 21 Feb '11

21 Feb '11

Changeset: d26e79640fd4 Author: mduigou Date: 2011-02-21 14:53 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d26e79640fd4 7019705: Add -XX:+AggressiveOpts options to MOAT test Reviewed-by: alanb ! test/java/util/Collection/MOAT.java

1 0

hg: jdk7/tl/jdk: 7001685: Renable EnumSetBash Test
by mike.duigou＠oracle.com 21 Feb '11

21 Feb '11

Changeset: 42e4205db024 Author: mduigou Date: 2011-02-21 13:37 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/42e4205db024 7001685: Renable EnumSetBash Test Reviewed-by: alanb, ohair, darcy ! test/ProblemList.txt

1 0

7001685: Renable EnumSetBash Test
by Mike Duigou 21 Feb '11

21 Feb '11

Hi All; I need a quick review for a very minor issue. An EnumSet unit test, EnumSetBash.java, is currently disabled but the bug which caused it to be disabled seems to no longer be reproducible. It is theorized that it had been failing due to a short lived HotSpot bug. This webrev merely re-enables the test. http://cr.openjdk.java.net/~mduigou/7001685/webrev.0/ Cheers! Mike

3 2

SocketPermission's implies() interesting behavior
by Charles Lee 21 Feb '11

21 Feb '11

Hi guys, I am reading the SocketPermission source code recently and find some thing strange. Below is a simple test case to describe the strange thing: SocketPermission star_All = new SocketPermission("*.java.net", "listen,accept,connect"); SocketPermission www_All = new SocketPermission("java.net", "listen,accept,connect"); System.out.println(star_All.implies(www_All)); star_All = new SocketPermission("java.net", "listen,accept,connect"); www_All = new SocketPermission("java.net", "listen,accept,connect"); System.out.println(star_All.implies(www_All)); Return is false and true. The reason is: SocketPermission treat wildcard special. If the initial string has a wildcard, the cname comes from the substring. For example, the cname of "*.java.net" is ".java.net". (Why the first dot remains?) In my initial idea, "*.java.net" should imply "java.net". Any idea about it? More interestingly, I add "localhost.localdomain" and "mytest" pointing to the "127.0.0.1" in the /etc/hosts (Ubuntu) and rewrite the test case to: SocketPermission star_All = new SocketPermission("localhost.localdomain", "listen,accept,connect"); SocketPermission www_All = new SocketPermission("mytest", "listen,accept,connect"); System.out.println(star_All.implies(www_All)); Return is true. If on a multi-host machine, is it reasonable? By the way, I am curious about the reason why SocketPermission does not use the initial string as its cname, for example: SocketPermission star_All = new SocketPermission("*.blabla.bla", "listen,accept,connect"); SocketPermission www_All = new SocketPermission("bla.blabla.bla", "listen,accept,connect"); System.out.println(star_All.implies(www_All)); In the above test case, the two permission looks similiar. If using the initial string, I expect the return should be true. But it return false, because of the UnknowHostException. Any idea about this?

3 3

hg: jdk7/tl/langtools: 7020047: Project Coin: generate null-check around try-with-resources close call
by joe.darcy＠oracle.com 19 Feb '11

19 Feb '11

Changeset: 75e25df50873 Author: darcy Date: 2011-02-18 15:55 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/75e25df50873 7020047: Project Coin: generate null-check around try-with-resources close call Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/TryWithResources/TwrNullTests.java

2 1

hg: jdk7/tl/jdk: 7018385: update javax.sql classes to use try-with-resources
by stuart.marks＠oracle.com 18 Feb '11

18 Feb '11

Changeset: 5bf920749b97 Author: smarks Date: 2011-02-18 12:43 -0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5bf920749b97 7018385: update javax.sql classes to use try-with-resources Reviewed-by: alanb, lancea, darcy ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java

1 0

hg: jdk7/tl/langtools: 7020626: diamond: add diagnostic test for diamond and non-generic classes
by maurizio.cimadamore＠oracle.com 18 Feb '11

18 Feb '11

Changeset: 51e643f41a3a Author: mcimadamore Date: 2011-02-18 16:17 +0000 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/51e643f41a3a 7020626: diamond: add diagnostic test for diamond and non-generic classes Summary: Fix failure in regression test CheckExamples Reviewed-by: jjg + test/tools/javac/diags/examples/DiamondNonGeneric.java

1 0