March 2011 - core-libs-dev

hg: jdk7/tl/jdk: 7029997: Restyling of SortedMap Javadoc
by mike.duigou＠oracle.com 23 Mar '11

23 Mar '11

Changeset: b58572df94f1 Author: mduigou Date: 2011-03-23 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b58572df94f1 7029997: Restyling of SortedMap Javadoc Reviewed-by: darcy, chegar ! src/share/classes/java/util/SortedMap.java

1 0

hg: jdk7/tl/langtools: 7010342: End tag for element P is not open for few html files generated using new javadoc
by bhavesh.patel＠sun.com 23 Mar '11

23 Mar '11

Changeset: 72bdd232e0ea Author: bpatel Date: 2011-03-23 14:40 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/72bdd232e0ea 7010342: End tag for element P is not open for few html files generated using new javadoc Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css + test/com/sun/javadoc/testSubTitle/TestSubTitle.java + test/com/sun/javadoc/testSubTitle/pkg/C.java + test/com/sun/javadoc/testSubTitle/pkg/package.html

1 0

hg: jdk7/tl/jdk: 7028490: better suggestion for jarsigner when TSA is not accessible
by weijun.wang＠oracle.com 23 Mar '11

23 Mar '11

Changeset: c43811a602a8 Author: weijun Date: 2011-03-23 18:26 +0800 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c43811a602a8 7028490: better suggestion for jarsigner when TSA is not accessible Reviewed-by: mullan ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/JarSignerResources.java

1 0

Review Request : 7029997 : Restyling of SortedMap Javadoc
by Mike Duigou 23 Mar '11

23 Mar '11

Hello all; I have made a couple of styling improvements to the JavaDoc for SortedMap; principally conversion of an inline list to use the HTML <ol> tag. The remainder of the changes are updates to the standard javadoc tags. http://cr.openjdk.java.net/~mduigou/7029997/0/webrev/ Thanks, Mike

3 5

hg: jdk7/tl/langtools: 7025314: NLS: translatability violation on standard.properties
by bhavesh.patel＠sun.com 23 Mar '11

23 Mar '11

Changeset: 148d3dc4e1e1 Author: bpatel Date: 2011-03-22 18:32 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/148d3dc4e1e1 7025314: NLS: translatability violation on standard.properties Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! test/com/sun/javadoc/testJavascript/TestJavascript.java ! test/com/sun/javadoc/testNavagation/TestNavagation.java ! test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java

1 0

hg: jdk7/tl/jdk: 7025066: Build systems changes to support SE Embedded Integration
by david.holmes＠oracle.com 22 Mar '11

22 Mar '11

Changeset: fe232d7e4ff1 Author: dholmes Date: 2011-03-22 18:56 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe232d7e4ff1 7025066: Build systems changes to support SE Embedded Integration Summary: Define Embedded specific files and include them in the main files. Allow finer control over some build options. Reviewed-by: ohair, bobv, collins + make/common/Defs-embedded.gmk ! make/common/Defs.gmk ! make/common/Library.gmk + make/common/Release-embedded.gmk ! make/common/Release.gmk ! make/common/shared/Sanity-Settings.gmk ! make/java/zip/Makefile ! make/sun/nio/cs/Makefile ! src/share/classes/sun/misc/Version.java.template

1 0

Re: core-libs-dev Digest, Vol 47, Issue 35
by Guy Korland 22 Mar '11

22 Mar '11

It seems like a great improvement that can help many frameworks. Is there any plan to port the fix to JDK6? Thanks, Guy ________________________________________________________________________________ Date: Mon, 21 Mar 2011 16:29:22 -0700 From: Mike Duigou <mike.duigou(a)oracle.com> Subject: Re: Review Request -- CR6565585: Performance improvements to Method.invoke(), Contrstuctor.newInstance() and Field.getFieldAccessor() To: Brian Goetz <brian.goetz(a)oracle.com> Cc: core-libs-dev(a)openjdk.java.net Message-ID: <F47C38AB-123A-4620-82F2-B6062373DBCC(a)oracle.com> Content-Type: text/plain; charset=us-ascii I've updated the patch to avoid the second read-volatile by having the acquire* methods return a result. Method already used that approach. I am less certain about tackling additional improvements to the caching in this patch. In part because I suspect that the usage patterns for Method.invoke(), Constructor.newInstance() and Field.get*() are different and I don't have any metrics which I can reference to say which is the appropriate strategy for each. My suspicion is the usage pattern for Field differs significantly from Constructor and Method which are likely more similar. If anyone can contribute usage pattern experiences or practical insights into how these are then we can come up with appropriate solutions. The update webrev : http://cr.openjdk.java.net/~mduigou/6565585/1/webrev/ Mike On Mar 17 2011, at 16:26 , Brian Goetz wrote: > You might consider storing the cached item in checkAccess() in a ThreadLocal instead of a static. Not only would this eliminate the volatile accesses, but it reduces the chance of a "miss" in this one-element cache, since it will then be impervious to interleavings where other threads might use reflection. (The purpose of the cache is to speed up the case when some code is grinding through all the members of a Class; it is unlikely that there would be many hits in this cache across threads anyway.) Obviously this is a tradeoff of memory utilization for reduced synchronization traffic + higher cache hit rate + more predictable reflection performance under concurrent load. > > You can eliminate the second read-volatile by having acquireMethodAccessor return the MA instead of re-reading the volatile. > > On 3/17/2011 7:04 PM, Mike Duigou wrote: >> Sorry folks--the webrev url: http://cr.openjdk.java.net/~mduigou/6565585/0/webrev/ >> >> Mike >> >> On Mar 17 2011, at 15:07 , Mike Duigou wrote: >> >>> Method.invoke(), Contrstuctor.newInstance() and Field.getFieldAccessor() all have a needless critical section, causing large slowdowns. This patch a replaces the synchronizations by volatile references. Finally, the changes remove a doubled reference to another volatile variable. This also simplifies the generated code by commoning up the corresponding load instruction used in the fast execution path. >>> >>> Speedups from this change are uniformly 2x or better. >>> >>> The proposed improvement and patch was originated by John Rose. >>> >>> Thanks, >>> >>> Mike >>

2 2

hg: jdk7/tl: 6737397: Should support running JCK test suite with test/Makefile and JPRT
by kelly.ohair＠oracle.com 22 Mar '11

22 Mar '11

Changeset: 970c0898ded2 Author: ohair Date: 2011-03-22 11:07 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/rev/970c0898ded2 6737397: Should support running JCK test suite with test/Makefile and JPRT Reviewed-by: alanb ! make/jprt.properties ! test/Makefile

1 0

hg: jdk7/tl/jdk: 6737397: Should support running JCK test suite with test/Makefile and JPRT
by kelly.ohair＠oracle.com 22 Mar '11

22 Mar '11

Changeset: 870f7c3f0b61 Author: ohair Date: 2011-03-22 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/870f7c3f0b61 6737397: Should support running JCK test suite with test/Makefile and JPRT Reviewed-by: alanb ! make/jprt.properties ! test/Makefile ! test/ProblemList.txt

1 0

Review Request -- CR6565585: Performance improvements to Method.invoke(), Contrstuctor.newInstance() and Field.getFieldAccessor()
by Mike Duigou 22 Mar '11

22 Mar '11

Method.invoke(), Contrstuctor.newInstance() and Field.getFieldAccessor() all have a needless critical section, causing large slowdowns. This patch a replaces the synchronizations by volatile references. Finally, the changes remove a doubled reference to another volatile variable. This also simplifies the generated code by commoning up the corresponding load instruction used in the fast execution path. Speedups from this change are uniformly 2x or better. The proposed improvement and patch was originated by John Rose. Thanks, Mike

4 5