April 2011 - core-libs-dev

Re: Urgent Request for review: 7035109 Regression: awt SplashScreen/test18.sh fails - missing mapfile entry
by Kumar Srinivasan 11 Apr '11

11 Apr '11

Approved!. I agree with Alan if a change is to be made in a component, it is best that it is pushed to that component's forest/repo, where all the necessary/appropriate tests will be performed on a nightly basis. Kumar ----- Alan.Bateman(a)oracle.com wrote: > From: Alan.Bateman(a)oracle.com > To: David.Holmes(a)oracle.com > Cc: awt-dev(a)openjdk.java.net, core-libs-dev(a)openjdk.java.net > Sent: Saturday, April 9, 2011 1:59:17 AM GMT -08:00 US/Canada Pacific > Subject: Re: Urgent Request for review: 7035109 Regression: awt SplashScreen/test18.sh fails - missing mapfile entry > > David Holmes wrote: > > Very simple review - the mapfile was missing an entry for a new > native > > method added in 7030063 and caused an UnsatisfiedLinkError > > > > http://cr.openjdk.java.net/~dholmes/jdk7-clone/webrev-7035109/ > > > > Failing test now passes. > > > > Due to the urgency this will get pushed directly into the TL PIT jdk > > > repo so that it will be paired with 7030063 and present in b138. > There is always a bit of risk pushing AWT or other client area changes > > to the TL forest as probably very few of us run those tests. The > update > the map file looks good to me. > > -Alan.

3 3

Need reviewers: Update of jaxp 1.4.5 source drop bundle
by Kelly O'Hair 10 Apr '11

10 Apr '11

Need reviewer for change in jaxp source drop bundle 7023289: jaxp 1.4.5 development jdk7 2nd integration http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxp-145dev1/webrev/ Joe or someone from the JAXP team may want to comment on the specific changes in this new source bundle. -kto

5 7

Urgent Request for review: 7035109 Regression: awt SplashScreen/test18.sh fails - missing mapfile entry
by David Holmes 09 Apr '11

09 Apr '11

Very simple review - the mapfile was missing an entry for a new native method added in 7030063 and caused an UnsatisfiedLinkError http://cr.openjdk.java.net/~dholmes/jdk7-clone/webrev-7035109/ Failing test now passes. Due to the urgency this will get pushed directly into the TL PIT jdk repo so that it will be paired with 7030063 and present in b138. Thanks, David

2 1

Code review request for 6998871 "Support making the Throwable.stackTrace field immutable"
by Joe Darcy 08 Apr '11

08 Apr '11

Hello. Returning to some earlier work, I've developed a proposed fix for 6998871 "Support making the Throwable.stackTrace field immutable" http://cr.openjdk.java.net/~darcy/6998871.2/ One constructor of Throwable now takes an additional boolean argument to make the stack trace information immutable. Analogous constructors are added to Exception, RuntimeException, and Error. Mandy and David have already reviewed the change; I'm interested in getting additional feedback on the design of the API. Cheers, -Joe

5 9

hg: jdk7/tl/jdk: 7035020: ForkJoinPool.invoke may deadlock if parallelism = 1
by chris.hegarty＠oracle.com 08 Apr '11

08 Apr '11

Changeset: 8fbd15bd6149 Author: dl Date: 2011-04-08 10:33 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8fbd15bd6149 7035020: ForkJoinPool.invoke may deadlock if parallelism = 1 Reviewed-by: chegar ! src/share/classes/java/util/concurrent/ForkJoinPool.java

1 0

hg: jdk7/tl/jdk: 6976117: SSLContext.getInstance("TLSv1.1") returns SSLEngines/SSLSockets without TLSv1.1 enabled
by xuelei.fan＠oracle.com 08 Apr '11

08 Apr '11

Changeset: 9c29dd06e138 Author: xuelei Date: 2011-04-08 02:00 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9c29dd06e138 6976117: SSLContext.getInstance("TLSv1.1") returns SSLEngines/SSLSockets without TLSv1.1 enabled Summary: Reorg the SSLContext implementation Reviewed-by: weijun ! src/share/classes/sun/security/ssl/CipherSuiteList.java - src/share/classes/sun/security/ssl/DefaultSSLContextImpl.java ! src/share/classes/sun/security/ssl/JsseJce.java ! src/share/classes/sun/security/ssl/ProtocolList.java ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/SSLEngineImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLServerSocketImpl.java ! src/share/classes/sun/security/ssl/SSLSocketFactoryImpl.java ! src/share/classes/sun/security/ssl/SSLSocketImpl.java ! src/share/classes/sun/security/ssl/SunJSSE.java + test/sun/security/ssl/javax/net/ssl/SSLContextVersion.java

1 0

hg: jdk7/tl/jdk: 7034700: (unpack200) build fails with fastdebug builds
by kumar.x.srinivasan＠oracle.com 08 Apr '11

08 Apr '11

Changeset: 587e968b03ee Author: ksrini Date: 2011-04-07 17:08 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/587e968b03ee 7034700: (unpack200) build fails with fastdebug builds Reviewed-by: ohair ! make/com/sun/java/pack/Makefile

1 0

Need reviewer: 7034700: simple fix
by Kumar Srinivasan 07 Apr '11

07 Apr '11

Hi, This fixes a build issue in non-product builds, with the fix for 7033954. During the pack200 build the wrong mapfile is picked up due to the idiosyncrasy of the makefile. Thus the fix is simply and explicitly instructing Mapfile-vers.gmk not to use a mapfile for a non-product build. http://cr.openjdk.java.net/~ksrini/7034700/webrev.0/ Thanks Kumar PS: the previous change which activates mapfile checking, for reference : http://cr.openjdk.java.net/~ksrini/7033954/webrev.0/make/com/sun/java/pack/…

2 1

hg: jdk7/tl/jdk: 7029048: (launcher) fence the launcher against LD_LIBRARY_PATH
by kumar.x.srinivasan＠oracle.com 07 Apr '11

07 Apr '11

Changeset: d8dfd1a0bd8d Author: ksrini Date: 2011-04-07 12:06 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d8dfd1a0bd8d 7029048: (launcher) fence the launcher against LD_LIBRARY_PATH Reviewed-by: mchung, ohair ! src/share/bin/jli_util.h ! src/solaris/bin/java_md.c ! test/tools/launcher/ExecutionEnvironment.java + test/tools/launcher/Test7029048.java ! test/tools/launcher/TestHelper.java

1 0

hg: jdk7/tl/jdk: 7034656: Address lint warnings for DriverManager
by lance.andersen＠oracle.com 07 Apr '11

07 Apr '11

Changeset: 5137806a3e34 Author: lancea Date: 2011-04-07 11:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5137806a3e34 7034656: Address lint warnings for DriverManager Reviewed-by: alanb, forax, ohair ! src/share/classes/java/sql/DriverManager.java

1 0