December 2012 - core-libs-dev

Re: Review request:Updated JDK-8004728 Implement core reflection API for parameter reflection
by Peter Levart 20 Dec '12

20 Dec '12

On 12/20/2012 06:33 AM, Eric McCorkle wrote: > On 12/19/12 18:47, Peter Levart wrote: >> >Hi Eric, >> > >> >in Executable.java: >> > >> > 292 private Parameter[] privateGetParameters() { >> > 293 if (null != parameters) >> > 294 return parameters.get(); >> > >> > >> >If/when SoftReference is cleared,privateGetParameters will be returning >> >null forever. Also Executable objects are already SoftReferenced from >> >the Class. Do we need another level of SoftReferencing? > I'd say not. I'll take that bit out. > Hi again, Eric, To be exact: only 'root' Executable objects are SoftReferenced from the Class. The copies that are exposed to user are not referenced at all (by reflection library). So as long as internal JDK code is not calling any new Parameter returning methods on 'root' Executable instances, they will never materialize any Parameter objects. The user only has to be aware that the Executable instance he/she has got hold on has a direct reference to any Parameter instances and vice versa. There is already a precedent for that: annotations are directly referenced from Field/Method/Constructor and they may have direct references to various Class instances. Although the specification does not specify it, a nice addition to the API would be the following method on Executable: Parameter getParameter(String parameterName); ...since parameter names are unique, aren't they? Parameter instances would have to be cached in a Map though. Regards, Peter

1 0

RFR : CR8004015 : Add parent interfaces and default methods to basic functional interfaces
by Mike Duigou 20 Dec '12

20 Dec '12

Hello all; I have updated the webrev again for hopefully the last time: http://cr.openjdk.java.net/~mduigou/8004015/3/webrev/ http://cr.openjdk.java.net/~mduigou/8004015/3/specdiff/overview-summary.html The implementation now uses Primitive.primitiveValue() ie. Integer.integerValue() rather than a cast. Same bytecode but using the intrinsic function makes it more clear that result is either primitive or NPE and that CCE is not possible. I have added @throws NPE for a number of the default methods. We won't be including @throws NPE in all cases where null is disallowed because when the @throws NPE is declared the API is required to throw NPE in that circumstance. So for cases where the NPE is "naturally" thrown or that aren't performance sensitive we will likely add @throws NPE declarations but for performance sensitive methods we won't be adding explicit null checks to match a @throws NPE specification. There's a tradeoff here in some cases. Please feel free to quibble about specific cases as they occur. :-) Mike

2 4

hg: jdk8/tl/jdk: 8005097: Tie isSynthetic javadoc to the JLS
by joe.darcy＠oracle.com 19 Dec '12

19 Dec '12

Changeset: 1f9c19741285 Author: darcy Date: 2012-12-19 11:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f9c19741285 8005097: Tie isSynthetic javadoc to the JLS Reviewed-by: mduigou ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Member.java ! src/share/classes/java/lang/reflect/Method.java

1 0

JDK 8 review request for 8005097 Tie isSynthetic javadoc to the JLS
by Joe Darcy 19 Dec '12

19 Dec '12

Hello, It has come to my attention recently that the various isSynthetic methods in core reflection cite the Java Language Specification, but do not reference a particular section. To remedy this, I've prepared a small patch to add "@jls" tags which cite the section in question: http://cr.openjdk.java.net/~darcy/8005097.0/ Inline patch file below. Thanks, -Joe --- old/src/share/classes/java/lang/Class.java 2012-12-19 11:11:40.000000000 -0800 +++ new/src/share/classes/java/lang/Class.java 2012-12-19 11:11:39.000000000 -0800 @@ -506,6 +506,7 @@ * returns {@code false} otherwise. * @return {@code true} if and only if this class is a synthetic class as * defined by the Java Language Specification. + * @jls 13.1 The Form of a Binary * @since 1.5 */ public boolean isSynthetic() { --- old/src/share/classes/java/lang/reflect/Constructor.java 2012-12-19 11:11:40.000000000 -0800 +++ new/src/share/classes/java/lang/reflect/Constructor.java 2012-12-19 11:11:40.000000000 -0800 @@ -411,6 +411,7 @@ /** * {@inheritDoc} + * @jls 13.1 The Form of a Binary * @since 1.5 */ @Override --- old/src/share/classes/java/lang/reflect/Executable.java 2012-12-19 11:11:40.000000000 -0800 +++ new/src/share/classes/java/lang/reflect/Executable.java 2012-12-19 11:11:40.000000000 -0800 @@ -324,6 +324,7 @@ * @return true if and only if this executable is a synthetic * construct as defined by * <cite>The Java™ Language Specification</cite>. + * @jls 13.1 The Form of a Binary */ public boolean isSynthetic() { return Modifier.isSynthetic(getModifiers()); --- old/src/share/classes/java/lang/reflect/Member.java 2012-12-19 11:11:41.000000000 -0800 +++ new/src/share/classes/java/lang/reflect/Member.java 2012-12-19 11:11:41.000000000 -0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2006, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2012, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -87,6 +87,7 @@ * * @return true if and only if this member was introduced by * the compiler. + * @jls 13.1 The Form of a Binary * @since 1.5 */ public boolean isSynthetic(); --- old/src/share/classes/java/lang/reflect/Method.java 2012-12-19 11:11:41.000000000 -0800 +++ new/src/share/classes/java/lang/reflect/Method.java 2012-12-19 11:11:41.000000000 -0800 @@ -500,6 +500,7 @@ /** * {@inheritDoc} + * @jls 13.1 The Form of a Binary * @since 1.5 */ @Override

2 1

RFR: javax.xml.transform: Using ServiceLoader to load JAXP stream factories (7169894: JAXP Plugability Layer: using service loader)
by Daniel Fuchs 19 Dec '12

19 Dec '12

Hi, Here is a new webrev in the series that addresses using ServiceLoader in JAXP for JDK 8. 7169894: JAXP Plugability Layer: using service loader This changeset addresses modification in the javax.xml.transform package. It is similar to changes proposed for the javax.xml.parsers package [1], with only a few differences due to the specificity of javax.xml.transform. <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.transform/webrev.0…> best regards, -- daniel previous webrevs in the series: [1] javax.xml.parsers: <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.parsers/webrev.06/> [2] javax.xml.datatype: <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.datatype/webrev.02/> [3] javax.xml.stream <http://cr.openjdk.java.net/~dfuchs/JDK-7169894/javax.xml.stream/webrev.01/>

3 7

8003562: Provide a command-line tool to find static dependencies
by Mandy Chung 19 Dec '12

19 Dec '12

As part of prepare for modules [1], this RFE is to provide a command-line tool in JDK8 so that developers can understand the static dependencies of their applications and libraries.As part of Project Jigsaw, a useful class analyzer [2] was developed that makes it very easy to identify the dependencies based on the classfile library thathas also been enhanced to support dependency analysis [3]. Inspired by the sample tool that Jon Gibbons developed, we propose this new command-line name as "jdeps". $ ./bin/jdeps -h Usage: jdeps <options> <files....> where possible options include: -version Version information -classpath <path> Specify where to find class files -v --verbose Print class-level dependencies -r --reverse Invert the dependencies in the output -p Restrict analysis to classes in this package (may be given multiple times) -e --regex Restrict analysis to packages matching pattern (-p and -e are exclusive) -P --profile Show profile or the file containing a package -d --depth Specify the depth of the transitive dependency analysis Default depth is 1. Set depth to 0 to traverse all dependencies. -all Show all classes and members with no breakdown The jdeps tool shows package-level dependencies of the input files that can be .class files, a directory, or a JAR file. Specify the depth for the transitive dependency analysis; otherwise, it only analyzes the input files. jdeps -P option will show where the class/package comes from. For Java SE API, it will show the Profile name (I implement a workaround for now until the profile work is in jdk8). For JDK internal APIs, they will not be exported in modular world. jdeps will indicate any usage of the JDK internal APIs in the output to help developers prepare for transitioning to modules. See below for a few sample output. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8003562/ The implementation classes for jdeps are in the langtools repo along with the com.sun.tools.classfile library. I'm working on adding more unit tests. I'd like to get this webrev out to begin the discussion and get review feedback. Thanks Mandy [1] http://openjdk.java.net/jeps/162 [2] http://hg.openjdk.java.net/jigsaw/jigsaw/jdk/raw-file/543b0d24a920/make/too… [3] http://bugs.sun.com/view_bug.do?bug_id=6907575 Sample Output $./bin/jdeps demo/jfc/Notepad/Notepad.jar <unnamed> (demo/jfc/Notepad/Notepad.jar) -> java.awt -> java.awt.event -> java.beans -> java.io -> java.lang -> java.net -> java.util -> java.util.logging -> javax.swing -> javax.swing.border -> javax.swing.event -> javax.swing.text -> javax.swing.tree -> javax.swing.undo $ ./bin/jdeps -P demo/jfc/Notepad/Notepad.jar <unnamed> (demo/jfc/Notepad/Notepad.jar) -> java.awt compact4 -> java.awt.event compact4 -> java.beans compact4 -> java.io compact1 -> java.lang compact1 -> java.net compact1 -> java.util compact1 -> java.util.logging compact1 -> javax.swing compact4 -> javax.swing.border compact4 -> javax.swing.event compact4 -> javax.swing.text compact4 -> javax.swing.tree compact4 -> javax.swing.undo compact4 $ ./bin/jdeps -d 10 demo/jfc/Notepad/Notepad.jar <unnamed> (demo/jfc/Notepad/Notepad.jar) -> java.awt -> java.awt.event -> java.beans -> java.io -> java.lang -> java.net -> java.util -> java.util.logging -> javax.swing -> javax.swing.border -> javax.swing.event -> javax.swing.text -> javax.swing.tree -> javax.swing.undo java.security (/export/mchung/ws/jdeps-repo/build/macosx-x86_64/j2sdk-image/jre/lib/rt.jar) -> javax.crypto javax.crypto (/export/mchung/ws/jdeps-repo/build/macosx-x86_64/j2sdk-image/jre/lib/jce.jar) -> java.io -> java.lang -> java.lang.reflect -> java.net -> java.nio -> java.security -> java.security.cert -> java.security.spec -> java.util -> java.util.concurrent -> java.util.jar -> java.util.regex -> java.util.zip -> sun.security.jca JDK internal API -> sun.security.util JDK internal API javax.crypto.spec (/export/mchung/ws/jdeps-repo/build/macosx-x86_64/j2sdk-image/jre/lib/jce.jar) -> java.lang -> java.security.spec -> java.util

5 29

hg: jdk8/tl/langtools: 8005098: Provide isSynthesized() information on Attribute.Compound
by jonathan.gibbons＠oracle.com 19 Dec '12

19 Dec '12

Changeset: f72c9c5aeaef Author: jfranck Date: 2012-12-16 11:09 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f72c9c5aeaef 8005098: Provide isSynthesized() information on Attribute.Compound Reviewed-by: jjg ! make/build.properties ! src/share/classes/com/sun/tools/javac/code/Attribute.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Annotate.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterImpl.java ! src/share/classes/com/sun/tools/javadoc/ProgramElementDocImpl.java

1 0

hg: jdk8/tl/jdk: 2 new changesets
by alan.bateman＠oracle.com 19 Dec '12

19 Dec '12

Changeset: 3fd3bcc8bd42 Author: joehw Date: 2012-12-19 12:09 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3fd3bcc8bd42 8004371: (props) Properties.loadFromXML needs small footprint XML parser as fallback when JAXP is not present Reviewed-by: alanb, mchung, psandoz + src/share/classes/jdk/internal/org/xml/sax/Attributes.java + src/share/classes/jdk/internal/org/xml/sax/ContentHandler.java + src/share/classes/jdk/internal/org/xml/sax/DTDHandler.java + src/share/classes/jdk/internal/org/xml/sax/EntityResolver.java + src/share/classes/jdk/internal/org/xml/sax/ErrorHandler.java + src/share/classes/jdk/internal/org/xml/sax/InputSource.java + src/share/classes/jdk/internal/org/xml/sax/Locator.java + src/share/classes/jdk/internal/org/xml/sax/SAXException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotRecognizedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXNotSupportedException.java + src/share/classes/jdk/internal/org/xml/sax/SAXParseException.java + src/share/classes/jdk/internal/org/xml/sax/XMLReader.java + src/share/classes/jdk/internal/org/xml/sax/helpers/DefaultHandler.java + src/share/classes/jdk/internal/util/xml/PropertiesDefaultHandler.java + src/share/classes/jdk/internal/util/xml/SAXParser.java + src/share/classes/jdk/internal/util/xml/XMLStreamException.java + src/share/classes/jdk/internal/util/xml/XMLStreamWriter.java + src/share/classes/jdk/internal/util/xml/impl/Attrs.java + src/share/classes/jdk/internal/util/xml/impl/Input.java + src/share/classes/jdk/internal/util/xml/impl/Pair.java + src/share/classes/jdk/internal/util/xml/impl/Parser.java + src/share/classes/jdk/internal/util/xml/impl/ParserSAX.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF16.java + src/share/classes/jdk/internal/util/xml/impl/ReaderUTF8.java + src/share/classes/jdk/internal/util/xml/impl/SAXParserImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLStreamWriterImpl.java + src/share/classes/jdk/internal/util/xml/impl/XMLWriter.java Changeset: cf15abdcdf88 Author: alanb Date: 2012-12-19 14:53 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cf15abdcdf88 8005248: (props) Integrate small footprint parser into Properties Reviewed-by: joehw, mchung, psandoz, erikj ! make/jdk/Makefile - make/jdk/asm/Makefile ! src/share/classes/java/util/Properties.java + src/share/classes/jdk/internal/util/xml/BasicXmlPropertiesProvider.java ! test/java/util/Properties/LoadAndStoreXML.java + test/java/util/Properties/invalidxml/BadCase.xml + test/java/util/Properties/invalidxml/BadDocType.xml.excluded + test/java/util/Properties/invalidxml/NoClosingTag.xml + test/java/util/Properties/invalidxml/NoDocType.xml.excluded + test/java/util/Properties/invalidxml/NoRoot.xml + test/java/util/Properties/invalidxml/NotQuoted.xml + test/java/util/Properties/invalidxml/README.txt

1 0

RFR 7175464 problems
by Doug Lea 19 Dec '12

19 Dec '12

I ran some of our j.u.c tck tests on lambda builds. Our tests included some for TreeMap because it was updated via jsr166 when NavigableMaps were introduced. I noticed a failure due to: 7175464 : entrySetView field is never updated in NavigableSubMap http://cr.openjdk.java.net/~mduigou/7175464/0/webrev/ Sorry I hadn't paid attention to this when first posted. The failure is pasted below, and shows one reason that entrySetViews were not by default cached. testDescendingSerialization(TreeSubSetTest)junit.framework.AssertionFailedError: expected:<[-1, -2, -3, -4, -5]> but was:<[-1, -2, -3, -4, -5]> at TreeSubSetTest.testDescendingSerialization(TreeSubSetTest.java:981) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at JSR166TestCase.runTest(JSR166TestCase.java:132) at JSR166TestCase.main(JSR166TestCase.java:160) Test code is at: http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/test/tck/TreeSubSet…

1 0

hg: jdk8/tl/langtools: 8004833: Integrate doclint support into javac
by jonathan.gibbons＠oracle.com 19 Dec '12

19 Dec '12

Changeset: 67b01d295cd2 Author: jjg Date: 2012-12-19 11:29 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/67b01d295cd2 8004833: Integrate doclint support into javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/main/Option.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/doclint/DocLintTest.java

1 0