April 2012 - core-libs-dev

Draft j.u.c JEP
by Doug Lea 22 Apr '12

22 Apr '12

I was reminded that we ought to submit a JEP to cover the non-lambda-related additions to java.util.concurrent targeted for JDK8. Below is a draft. Comments and suggestions during the next week before I submit it would be welcome. .... Title: java.util.concurrent additions and changes for JDK8 Author: Doug Lea Organization: SUNY Oswego Created: 2012/4/21 Type: Feature State: Draft Exposure: Open Component: core/lib Scope: SE Discussion: core-libs-dev(a)openjdk.java.net Template: 1.0 Summary ------- In addition to features in support of lambdas, we plan inclusion for OpenJDK8 of a few new classes and methods in java.util.concurrent, as well as ongoing improvements of existing classes, all spurred by experiences and suggestions of users of the java.util.concurrent package. Motivation ---------- The continual evolution of uses of concurrency and parallelism in applications requires continual evolution in library support. Description ----------- A non-exhaustive list: 1. Scalable updatable variables. Maintaining a single count, sum, etc that is updated by possibly many threads is a common scalability problem. A small set of new classes (LongAdder, DoubleAdder, LongMaxUpdater, DoubleMaxUpdater) internally employ contention-reduction techniques that provide huge throughput improvements as compared to Atomic variables. This is made possible by relaxing atomicity guarantees in a way that is acceptable in most applications. 2. Added features (and possibly added APIs) that make ConcurrentHashMaps and classes built from them more useful as Caches. These include methods to compute values for keys when they are not present, as well as improved support for scanning and possibly evicting entries. 3. Added functionality and improved performance for ForkJoinPools that allow them to be used more effectively in the increasingly wider range of applications that users desire. New features include support for completion-based designs that are often most appropriate for IO-bound usages, among others. Possible further additions include reconsideration of a "Fences" API, Sequence Locks, and other related support that better enables construction of STM (Software Transactional Memory) frameworks. However, STM support per se is not a goal for JDK8. Preliminary versions of these components (as well as other minor updates to others) have been, and continue to be, introduced outside of OpenJDK to solicit early feedback and experience reports (mainly by expert users) before integrating into OpenJDK. Sources and mailing list discussions may be found by following links at: Testing ------- We (the continuing set of JSR166 members) provide functionality and performance tests for all components. Risks and Assumptions --------------------- We assume that Oracle engineers will continue to assist integrating into OpenJDK. Dependencies ----------- Some features depend on lambda syntax and JDK declarations of common function types, so we will probably delay integration until we are more confident of their final form. Impact ------ We aren't aware of any other impact on JDK8.

4 4

hg: jdk8/tl/jdk: 6981776: Pack200 must support -target 7 bytecodes
by kumar.x.srinivasan＠oracle.com 22 Apr '12

22 Apr '12

Changeset: ec9876082b4e Author: ksrini Date: 2012-04-22 06:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ec9876082b4e 6981776: Pack200 must support -target 7 bytecodes Summary: pack200 implementation of JSR-200 updated for JSR-292 changes Reviewed-by: jrose, ksrini Contributed-by: john.r.rose(a)oracle.com, kumar.x.srinivasan(a)oracle.com ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java ! src/share/native/com/sun/java/util/jar/pack/bands.cpp ! src/share/native/com/sun/java/util/jar/pack/bands.h ! src/share/native/com/sun/java/util/jar/pack/constants.h ! src/share/native/com/sun/java/util/jar/pack/defines.h ! src/share/native/com/sun/java/util/jar/pack/unpack.cpp ! src/share/native/com/sun/java/util/jar/pack/unpack.h ! test/tools/pack200/AttributeTests.java ! test/tools/pack200/PackageVersionTest.java ! test/tools/pack200/Utils.java - test/tools/pack200/dyn.jar ! test/tools/pack200/pack200-verifier/data/README ! test/tools/pack200/pack200-verifier/data/golden.jar ! test/tools/pack200/pack200-verifier/make/build.xml ! test/tools/pack200/pack200-verifier/src/xmlkit/ClassReader.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassSyntax.java - test/tools/pack200/pack200-verifier/src/xmlkit/ClassWriter.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionAssembler.java - test/tools/pack200/pack200-verifier/src/xmlkit/InstructionSyntax.java

1 0

7163395: jdk8/tl no longer builds on Mac
by Alan Bateman 22 Apr '12

22 Apr '12

I need a reviewer for a trivial change to get jdk8/tl building on Mac again. Jim's changes for 7130404 [1] change the os.arch variable to "x86_64" to be compatible with Apple's JDK but the change-set doesn't add a jvm.cfg to the x86_64 directory. The issue is trivially fixed by moving the jvm,cfg to the right location: $ hg diff -g diff --git a/src/macosx/bin/amd64/jvm.cfg b/src/macosx/bin/x86_64/jvm.cfg rename from src/macosx/bin/amd64/jvm.cfg rename to src/macosx/bin/x86_64/jvm.cfg Note that jdk7u doesn't have this issue as the corresponding change-set added a new jvm,cfg. Thanks, Alan. [1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77b35c5c4b95

3 2

RE: 7163395: jdk8/tl no longer builds on Mac
by Chris Hegarty 22 Apr '12

22 Apr '12

Looks fine Alan. -Chris Alan Bateman <Alan.Bateman(a)oracle.com> wrote: > >I need a reviewer for a trivial change to get jdk8/tl building on Mac >again. Jim's changes for 7130404 [1] change the os.arch variable to >"x86_64" to be compatible with Apple's JDK but the change-set doesn't >add a jvm.cfg to the x86_64 directory. The issue is trivially fixed by >moving the jvm,cfg to the right location: > >$ hg diff -g >diff --git a/src/macosx/bin/amd64/jvm.cfg b/src/macosx/bin/x86_64/jvm.cfg >rename from src/macosx/bin/amd64/jvm.cfg >rename to src/macosx/bin/x86_64/jvm.cfg > >Note that jdk7u doesn't have this issue as the corresponding change-set >added a new jvm,cfg. > >Thanks, >Alan. > >[1] http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77b35c5c4b95

1 0

Code Review Request - Bug #6948101 & 7142596: RMI JPRT tests are failing
by Darryl Mocek 21 Apr '12

21 Apr '12

Hello core-libs. Please review this webrev to fix Bug #6948101 and #7142596. This commit fixes concurrency issues with the RMI tests. - Added TestLibrary.getUnusedRandomPort method. This attempts to return a random port number, which is unused, between the port ranges 1024 and 64000 (inclusive). It will try up to 10 times before giving up. - Changed almost all tests from using hard port numbers to using random port numbers for running the RMI Registry and RMID. - Removed othervm from those tests which don't need it. - Added parameters for tests which spawn a separate VM to pass RMI Registry and RMID ports in cases where needed. - Added PropertyPermission to security policy files where needed. - Removed java/rmi and sun/rmi from tests which cannot be run concurrently. - Removed java/rmi and sun/rmi from tests which must run in othervm mode. - Added java/rmi/Naming to list of tests which cannot be run concurrently. Webrev, can be found here: http://cr.openjdk.java.net/~dmocek/7142596/webrev.00 Thanks, Darryl

2 7

RFR: 7160725 - Strange or obsolete @see tags in some exception java.lang javadoc
by Jim Gish 20 Apr '12

20 Apr '12

Description: Another trivial javadoc update - fixed existing @see ref and added a few more representative of the exception usage Patch: diff -r 00f5665ee0ea src/share/classes/java/lang/IllegalArgumentException.java --- a/src/share/classes/java/lang/IllegalArgumentException.java Tue Apr 17 09:30:29 2012 -0400 +++ b/src/share/classes/java/lang/IllegalArgumentException.java Wed Apr 18 15:28:26 2012 -0400 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1994, 2003, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1994, 2003, 2012 Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -30,7 +30,10 @@ * inappropriate argument. * * @author unascribed + * @see java.lang.Enum#valueOf(Class, String) * @see java.lang.Thread#setPriority(int) + * @see java.lang.Runtime#exec(String) + * @see java.lang.System#getProperty(String) * @since JDK1.0 */ public diff -r 00f5665ee0ea src/share/classes/java/lang/NumberFormatException.java --- a/src/share/classes/java/lang/NumberFormatException.java Tue Apr 17 09:30:29 2012 -0400 +++ b/src/share/classes/java/lang/NumberFormatException.java Wed Apr 18 15:28:26 2012 -0400 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1994, 2001, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1994, 2001, 2012 Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -31,7 +31,8 @@ * have the appropriate format. * * @author unascribed - * @see java.lang.Integer#toString() + * @see java.lang.Float#Float(String) + * @see java.lang.Integer#parseInt(String) * @since JDK1.0 */ public Thanks, Jim Gish

3 3

RFR: 7160714 - Strange or obsolete @see tags in some exception java.util javadoc
by Jim Gish 20 Apr '12

20 Apr '12

Description: just a trivial change to add in Iterator#next() as a @see reference (Alan and I discussed the possibilities here of completeness vs brevity, and we opted for brevity. There are actually other uses, particularly in Deque , and Queue but thought it best to keep it simple) Patch: diff -r 00f5665ee0ea src/share/classes/java/util/NoSuchElementException.java --- a/src/share/classes/java/util/NoSuchElementException.java Tue Apr 17 09:30:29 2012 -0400 +++ b/src/share/classes/java/util/NoSuchElementException.java Wed Apr 18 15:07:49 2012 -0400 @@ -1,5 +1,5 @@ /* - * Copyright (c) 1994, 2008, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1994, 2008, 2012 Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -26,13 +26,12 @@ package java.util; /** - * Thrown by the <code>nextElement</code> method of an - * <code>Enumeration</code> to indicate that there are no more - * elements in the enumeration. + * Thrown by various accessor methods to indicate that the element being requested + * does not exist. * * @author unascribed - * @see java.util.Enumeration * @see java.util.Enumeration#nextElement() + * @see java.util.Iterator#next() * @since JDK1.0 */ public Strange or obsolete @see tags in some exception java.util javadoc Thanks, Jim

4 4

Re: RFR: 7160725 - Strange or obsolete @see tags in some exception java.lang javadoc
by Jim Gish 20 Apr '12

20 Apr '12

Hi David, As I discussed with Alan, I don't think the conventions for @see in general are very clear. One could argue that there are a number of approaches that could be taken, among them: an exhaustive list, a representative list, or one simple example. A complete enumeration in many cases (such as IAE, and NFE) is ridiculously large (something like 2700 for IAE if I recall correctly). Listing them all doesn't make sense, of course. So, in this particular case I was opting for a representative sample of uses - choosing the ones below for being common or typical from a "nearby" package - as being exmplars. Of course, the principal point of this whole fix, was simply to give me a trivial change to run through to help learn the openjdk process, so unless the philosophy, policy, or convention is considered to be paramount, I'd prefer to "take a reasonable shot" at this, as I have done, and move on. Cheers, Jim ----- Original Message ----- From: david.holmes(a)oracle.com To: jim.gish(a)oracle.com Cc: core-libs-dev(a)openjdk.java.net Sent: Wednesday, April 18, 2012 8:12:43 PM GMT -05:00 US/Canada Eastern Subject: Re: RFR: 7160725 - Strange or obsolete @see tags in some exception java.lang javadoc Hi Jim, I guess I don't see the point here. There must be literally dozens of APIs that throw IllegalArgumentException, and a significant number that can throw NumberFormatError. What is so special about these selections? I'd argue for removing the old @see tags. David On 19/04/2012 5:47 AM, Jim Gish wrote: > I've updated the copyrights to just have first and current year. > > Jim > > On 04/18/2012 03:33 PM, Jim Gish wrote: >> Description: >> >> Another trivial javadoc update - fixed existing @see ref and added a >> few more representative of the exception usage >> >> Patch: >> >> diff -r 00f5665ee0ea >> src/share/classes/java/lang/IllegalArgumentException.java >> --- a/src/share/classes/java/lang/IllegalArgumentException.java Tue >> Apr 17 09:30:29 2012 -0400 >> +++ b/src/share/classes/java/lang/IllegalArgumentException.java Wed >> Apr 18 15:28:26 2012 -0400 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 1994, 2003, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 1994, 2003, 2012 Oracle and/or its affiliates. All >> rights reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -30,7 +30,10 @@ >> * inappropriate argument. >> * >> * @author unascribed >> + * @see java.lang.Enum#valueOf(Class, String) >> * @see java.lang.Thread#setPriority(int) >> + * @see java.lang.Runtime#exec(String) >> + * @see java.lang.System#getProperty(String) >> * @since JDK1.0 >> */ >> public >> >> diff -r 00f5665ee0ea >> src/share/classes/java/lang/NumberFormatException.java >> --- a/src/share/classes/java/lang/NumberFormatException.java Tue Apr >> 17 09:30:29 2012 -0400 >> +++ b/src/share/classes/java/lang/NumberFormatException.java Wed Apr >> 18 15:28:26 2012 -0400 >> @@ -1,5 +1,5 @@ >> /* >> - * Copyright (c) 1994, 2001, Oracle and/or its affiliates. All rights >> reserved. >> + * Copyright (c) 1994, 2001, 2012 Oracle and/or its affiliates. All >> rights reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. >> * >> * This code is free software; you can redistribute it and/or modify it >> @@ -31,7 +31,8 @@ >> * have the appropriate format. >> * >> * @author unascribed >> - * @see java.lang.Integer#toString() >> + * @see java.lang.Float#Float(String) >> + * @see java.lang.Integer#parseInt(String) >> * @since JDK1.0 >> */ >> public >> >> Thanks, >> Jim Gish >

3 2

hg: jdk8/tl/corba: 7161925: sjava files in corba don't have copyright string and legal notice
by sean.coffey＠oracle.com 20 Apr '12

20 Apr '12

Changeset: 9cdcc0152526 Author: coffeys Date: 2012-04-20 17:34 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/9cdcc0152526 7161925: sjava files in corba don't have copyright string and legal notice Reviewed-by: chegar Contributed-by: misha.bykov(a)oracle.com ! src/share/classes/com/sun/corba/se/impl/orbutil/DefineWrapper.sjava ! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLTypesUtil_save.sjava

1 0

RFR : 7161925 : sjava files in corba don't have copyright string and legal notice
by Seán Coffey 20 Apr '12

20 Apr '12

This is a copyright patch that misha.bykov(a)oracle.com has asked to contribute. I'm pushing it to jdk8 for him. corba repo found to be lacking headers on 2 files. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7161925 http://cr.openjdk.java.net/~coffeys/webrev.7161925.jdk8/ regards, Sean.

2 1