August 2012 - core-libs-dev

hg: jdk8/tl: Added tag jdk8-b51 for changeset 57c0aee73090
by lana.steuck＠oracle.com 10 Aug '12

10 Aug '12

Changeset: 8d24def5ceb3 Author: katleman Date: 2012-08-09 18:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/8d24def5ceb3 Added tag jdk8-b51 for changeset 57c0aee73090 ! .hgtags

1 0

hg: jdk8/tl/corba: Added tag jdk8-b51 for changeset 9b0f841ca9f7
by lana.steuck＠oracle.com 10 Aug '12

10 Aug '12

Changeset: 80689ff9cb49 Author: katleman Date: 2012-08-09 18:00 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/80689ff9cb49 Added tag jdk8-b51 for changeset 9b0f841ca9f7 ! .hgtags

1 0

hg: jdk8/tl/jdk: 3 new changesets
by valerie.peng＠oracle.com 10 Aug '12

10 Aug '12

Changeset: 114fbbeb8f75 Author: valeriep Date: 2012-08-10 13:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/114fbbeb8f75 7107613: scalability bloker in javax.crypto.CryptoPermissions Summary: Changed the type of field "perms" from Hashtable to ConcurrentHashMap. Reviewed-by: weijun, xuelei ! src/share/classes/javax/crypto/CryptoPermissions.java Changeset: 175036ada2e3 Author: valeriep Date: 2012-08-10 13:08 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/175036ada2e3 7107616: scalability bloker in javax.crypto.JceSecurityManager Summary: Changed the type of field "exemptCache" from HashMap to ConcurrentHashMap. Reviewed-by: weijun, xuelei ! src/share/classes/javax/crypto/JceSecurityManager.java Changeset: 9e97dacbfd35 Author: valeriep Date: 2012-08-10 13:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9e97dacbfd35 7185471: Avoid key expansion when AES cipher is re-init w/ the same key Summary: Saved the last cipher key value and skip key expansion if key value is the same. Reviewed-by: weijun, xuelei ! src/share/classes/com/sun/crypto/provider/AESCrypt.java

1 0

hg: jdk8/tl/jdk: 2 new changesets
by sean.mullan＠oracle.com 10 Aug '12

10 Aug '12

Changeset: 57b5025548d6 Author: mullan Date: 2012-08-10 09:12 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/57b5025548d6 7187962: sun.security.pkcs11.P11DSAKeyFactory.implTranslatePublicKey doesn't check if params is null Reviewed-by: valeriep ! src/share/classes/sun/security/provider/certpath/BasicChecker.java Changeset: 629f357fc17b Author: mullan Date: 2012-08-10 09:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/629f357fc17b Merge

1 0

hg: jdk8/tl/jdk: 7189363: Regex Pattern compilation buggy for special sequences
by xueming.shen＠oracle.com 09 Aug '12

09 Aug '12

Changeset: 717ed00b7787 Author: sherman Date: 2012-08-09 10:15 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/717ed00b7787 7189363: Regex Pattern compilation buggy for special sequences Summary: fixed the incorrect implementation in expr(...) Reviewed-by: psandoz, alanb ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java

1 0

hg: jdk8/tl/jdk: 7183753: [TEST] Some colon in the diff for this test
by dmitry.samersoff＠oracle.com 09 Aug '12

09 Aug '12

Changeset: bf85c3ab2637 Author: dsamersoff Date: 2012-08-09 14:52 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bf85c3ab2637 7183753: [TEST] Some colon in the diff for this test Summary: Reference output file contains extra colon Reviewed-by: sspitsyn, mgronlun ! test/sun/tools/jcmd/help_help.out

1 0

Codereview request for 7189363: Regex Pattern compilation buggy for special sequences
by Xueming Shen 09 Aug '12

09 Aug '12

Hi It appears the optimization (flatten a binary tree structure into a branch/ switch) we put into JDK6 for alternation operation [1] has problem if the first construct is a group "(...)" followed by a greedy/reluctant "once or not at all" quantifier. For example regex "(a)?bc|d" or "(a)??bc|d" can't be found for input "d", while "a?bc|d" or "a??bc|d" just works fine. The root cause is that expr() mistakenly to use the Branch node from the sub-expression (in above case, the branch node for "(a)?" instead of using its own Branch node (because the incorrect use of "prev instance of Branch", see the diff), which basically messes up the internal regex node tree [2] The webrev is at http://cr.openjdk.java.net/~sherman/7189363/webrev Thanks, -Sherman PS: I'm surprised this bug has not been noticed until now. One of the reasons is that the "messed up" regex node tree actually works for most of the cases for this particular regex, for example Pattern.compile("(a)?bc|d").matcher("d").matches() Pattern.compile("(a)?bc|d").matcher("bc").matches() Pattern.compile("(a)?bc|d").matcher("abc").matches() and even Pattern.compile("(a)?bc|de").matcher("de").find() all return true. The "find()" for single "d" fails only because the "minimum length" check (see [2] for details, if interested) [1] http://cr.openjdk.java.net/~sherman/5013651_6271399_6342544/ [2] http://cr.openjdk.java.net/~sherman/7189363/nodes

3 2

hg: jdk8/tl/langtools: 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {}
by sundararajan.athijegannathan＠oracle.com 08 Aug '12

08 Aug '12

Changeset: f071cd32d297 Author: sundar Date: 2012-08-08 22:17 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f071cd32d297 7178324: Crash when compiling for(i : x) try(AutoCloseable x = ...) {} Reviewed-by: darcy, jjg ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java + test/tools/javac/TryWithResources/T7178324.java

1 0

hg: jdk8/tl/jdk: 7189944: (launcher) test/tools/launcher/Arrrrghs.java needs a couple of minor fixes
by kumar.x.srinivasan＠oracle.com 08 Aug '12

08 Aug '12

Changeset: a44671e0b6d7 Author: ksrini Date: 2012-08-08 09:29 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a44671e0b6d7 7189944: (launcher) test/tools/launcher/Arrrrghs.java needs a couple of minor fixes Reviewed-by: darcy, jgish ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java

1 0

Request for simple review of launcher tests 7189944
by Kumar Srinivasan 08 Aug '12

08 Aug '12

Hi, In my previous push for http://cr.openjdk.java.net/~ksrini/7146424/webrev.0/ I missed adding CR number to the regression test Arrrghs.java, also some minor improvements to TestHelper.java for better diagnosis of failing tests. http://cr.openjdk.java.net/~ksrini/7189944/webrev.0/ Thanks Kumar

3 2