September 2012 - core-libs-dev

Re: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling
by Kumar Srinivasan 04 Sep '12

04 Sep '12

Hi Joe, I was thinking about that too, yes I will make it conditional on a system property or env variable. Kumar ----- joe.darcy(a)oracle.com wrote: > From: joe.darcy(a)oracle.com > To: kumar.x.srinivasan(a)oracle.com > Cc: core-libs-dev(a)openjdk.java.net, xueming.shen(a)oracle.com, james.holmlund(a)oracle.com > Sent: Tuesday, September 4, 2012 9:50:03 AM GMT -08:00 US/Canada Pacific > Subject: Re: Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling > > Hi Kumar, > > From a quick look I didn't seen any problems, but defaulting to running a test that writes multiple gibabytes to disk may have unwanted performance costs for general testing. Perhaps that scenario could be included in the test code, but only run on an opt-in basis? > > -Joe > > > On 9/4/2012 6:47 AM, Kumar Srinivasan wrote: > > Hi Sherman, Joe, et. al. > > Please review the launcher changes to read the manifest of > a ZIP64 archive. > > http://cr.openjdk.java.net/~ksrini/7194005/webrev.0/ > > Thanks > Kumar > > > >

2 1

Please review: 7194005: (launcher) needs to be enhanced for 64-bit jar file handling
by Kumar Srinivasan 04 Sep '12

04 Sep '12

Hi Sherman, Joe, et. al. Please review the launcher changes to read the manifest of a ZIP64 archive. http://cr.openjdk.java.net/~ksrini/7194005/webrev.0/ Thanks Kumar

2 1

hg: jdk8/tl/jdk: 7195733: TEST_BUG: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java failing
by xuelei.fan＠oracle.com 04 Sep '12

04 Sep '12

Changeset: b7b33a3c9df0 Author: xuelei Date: 2012-09-04 02:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7b33a3c9df0 7195733: TEST_BUG: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java failing Reviewed-by: chegar, alanb, xuelei Contributed-by: Eric Wang <yiming.wang(a)oracle.com> ! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java

1 0

hg: jdk8/tl/jdk: 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value
by staffan.larsen＠oracle.com 04 Sep '12

04 Sep '12

Changeset: 3338019fda8a Author: sla Date: 2009-06-19 16:50 +0300 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3338019fda8a 6853676: OperatingSystemMXBean.TotalPhysicalMemorySize has incorrect value Reviewed-by: alanb, dholmes, sla Contributed-by: Dmytro Sheyko <dmytro_sheyko(a)hotmail.com> ! src/windows/native/com/sun/management/OperatingSystem_md.c + test/com/sun/management/OperatingSystemMXBean/MemoryStatusOverflow.java

1 0

Re: Not able to complie fresh tl
by Dmitry Samersoff 03 Sep '12

03 Sep '12

Alan, Sorry for not being clean enough. tl/jdk/make/java/rmi repository produce deprecation warning while compiling and these warning threaten as an error. Therefor build are stopped. I use 1.8.0-ea-b37 for compilation. I workarounded the problem with JAVAC_LINT_OPTIONS but would like to know is it a known issue. -Dmitry On 2012-09-03 22:05, Alan Bateman wrote: > On 03/09/2012 18:42, Dmitry Samersoff wrote: >> Hi Everybody >> >> Q. Is it (below) known problem? >> >> Q. Does it make sense to turn deprecation warning off by default or at >> least add an env variable to control it? >> >> >> ../../../src/share/classes/sun/rmi/server/ActivatableRef.java:311: >> warning: [deprecation] newCall(RemoteObject,Operation[],int,long) in >> RemoteRef has been deprecated >> >> public synchronized RemoteCall newCall(RemoteObject obj, >> >> >> etc. >> >> make[2]: Leaving directory `/home/dms/ESC/JSDP/tl/jdk/make/java/rmi' >> > jdk8/tl is built and tested on all platforms, including boot cycle > builds, every night so it mostly be in a healthy state. That said, there > is currently an issue with OPENJDK=true builds in the corba repository. > It's not an issue when the closed repos are present. Sean Coffey is > currently looking into it. From the fragment in your mail then it > doesn't look like you are running into it. From your mail I can't tell > if you are just observing deprecation warnings or the warnings are fatal > (as part of the ongoing effort to reduce javac warnings then they are > fatal in areas that should be warning free). In any case I would suggest > bringing your issue to core-libs-dev@openjdk. > > -Alan. > -- Dmitry Samersoff Java Hotspot development team, SPB04 * There will come soft rains ...

2 1

Review Request: 7193406 - Clean-up JDK Build Warnings in java.util, java.io
by Dan Xu 03 Sep '12

03 Sep '12

Please review the fix of CR 7193406 at http://cr.openjdk.java.net/~dxu/7193406/webrev/. It cleans up warnings in the following java files. src/share/classes/java/io/FilePermission.java src/share/classes/java/util/ArrayDeque.java src/share/classes/java/util/Arrays.java src/share/classes/java/util/Collections.java src/share/classes/java/util/HashMap.java src/share/classes/java/util/JumboEnumSet.java src/share/classes/java/util/PriorityQueue.java src/share/classes/java/util/PropertyResourceBundle.java src/share/classes/java/util/jar/JarVerifier.java src/share/classes/java/util/jar/Pack200.java src/share/classes/sun/util/PreHashedMap.java And it enables fatal warning flag in the following make file. make/java/jar/Makefile In FilePermission.java file, I make one change to its method signature, public Enumeration elements() ==> public Enumeration<Permission> elements() I am not sure whether it will cause an issue of backward compatibility. Please advise. Thanks! - Dan

17 60

RFR [JDK8]: 7169894: JAXP Plugability Layer: using service loader
by Joe Wang 01 Sep '12

01 Sep '12

Hi, This is a patch to replace the manual process in the 3rd step of the JAXP implementation resolution mechanism with ServiceLoader. Please see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7169894 for more details about the issue. Note that FactoryFinder is duplicated for each JAXP subpackage. The ones in the following packages are the same: /jaxp-api/src/javax/xml/datatype/FactoryFinder.java /jaxp-api/src/javax/xml/parsers/FactoryFinder.java /jaxp-api/src/javax/xml/stream/FactoryFinder.java /jaxp-api/src/javax/xml/transform/FactoryFinder.java The following two are similar except that they perform Schema Language or Object Model support check: /jaxp-api/src/javax/xml/validation/SchemaFactoryFinder.java /jaxp-api/src/javax/xml/xpath/XPathFactoryFinder.java It's a bit rush since I have only had time to test regular JDK using JDK 1.6.0_27. Further test on jigsaw is needed. All jaxp unit/SQE tests are passed. But TCK test is still running. So please take this as an initial review. webrev: http://cr.openjdk.java.net/~joehw/jdk8/7169894/webrev/ Thanks, Joe

3 45