January 2014 - core-libs-dev

JDK 9 RFR of JDK-8029561: Optimization in Integer to string conversion
by Brian Burkhalter 03 Jan '14

03 Jan '14

Following up from this thread of last week http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-December/024162.h… with respect to https://bugs.openjdk.java.net/browse/JDK-8029561. The change being suggested in this review request is merely to remove the FIXME comment --- a/src/share/classes/java/lang/Integer.java Mon Dec 30 16:34:06 2013 +0400 +++ b/src/share/classes/java/lang/Integer.java Thu Jan 02 11:21:00 2014 -0800 @@ -376,9 +376,6 @@ // JIT case the dispatch overhead doesn't exist and the // "trick" is considerably faster than the classic code. // - // TODO-FIXME: convert (x * 52429) into the equiv shift-add - // sequence. - // // RE: Division by Invariant Integers using Multiplication // T Gralund, P Montgomery // ACM PLDI 1994 since the code change proposed in the issue report did not show any performance improvement. Thanks, Brian

2 1

Update on 8014320
by Tim Buktu 03 Jan '14

03 Jan '14

Hello, I've been quiet because real life needed my attention. Obviously, the Schoenhage-Strassen and Barrett algorithms are not going to make it into JDK8. I hope that is not a problem for anyone. We shouldn't use the word "problem" anyway but rather think of it as an opportunity :-) for more refinement and testing. Improvements I have planned are: * Compact storage of DFT vectors. At the moment, they are stored as numbers modulo 2^2^(n+1) when (2^2^n)+1 would suffice. This will save memory and may speed up the DFT and IDFT steps. * Use Bailey's algorithm recursively if it improves cache locality and doesn't add too much complexity to the code. * Maybe add a multiplyParallel() method, now that dft() and idft() use Bailey's algorithm which should make them easy to parallelize. * See if dft() and idft() can be made faster on 64-bit CPUs by using long[][] arrays instead of int[][]. As always, comments are welcome. Merry Chris... I mean, Holidays and a happy new year to everyone! Tim

2 2

hg: jdk8/tl/jdk: 2 new changesets
by sean.coffey＠oracle.com 03 Jan '14

03 Jan '14

Changeset: 46c727d6ecc2 Author: aefimov Date: 2013-12-30 16:46 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46c727d6ecc2 8025051: Update resource files for TimeZone display names Reviewed-by: okutsu, mfang ! src/share/classes/sun/util/resources/de/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/es/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/fr/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/it/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/ja/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/ko/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/pt/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/sv/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/zh/TimeZoneNames_zh_TW.java ! test/java/util/Calendar/GenericTimeZoneNamesTest.sh ! test/sun/util/resources/TimeZone/Bug6317929.java + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNamesTest.java + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_de.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_de_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_es.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_es_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_fr.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_fr_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_it.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_it_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ja.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ja_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ko.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_ko_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_pt_BR.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_pt_BR_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_sv.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_sv_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_CN.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_CN_short.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_TW.properties + test/sun/util/resources/TimeZone/TimeZoneNames/TimeZoneNames_zh_TW_short.properties Changeset: c0970860803e Author: coffeys Date: 2014-01-03 16:45 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c0970860803e Merge

1 0

JDK 9 RFR of JDK-8027595: Enable BigInteger overflow tests in JTREG
by Brian Burkhalter 03 Jan '14

03 Jan '14

This follows from the last two paragraphs of this message: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022736.ht… The issue is https://bugs.openjdk.java.net/browse/JDK-8027595. The change is to change "@ test" to "@test" in the affected test files test/java/math/BigInteger/BitLengthOverflow.java test/java/math/BigInteger/DivisionOverflow.java test/java/math/BigInteger/DoubleValueOverflow.java test/java/math/BigInteger/StringConstructorOverflow.java for example /* - * @ test + * @test in all cases. Thanks, Brian

3 8

hg: jdk8/tl/jdk: 2 new changesets
by chris.hegarty＠oracle.com 03 Jan '14

03 Jan '14

Changeset: 18080cca998a Author: dl Date: 2014-01-03 06:22 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18080cca998a 8031133: AbstractMap should specify its default implementation using @implSpec Reviewed-by: chegar, alanb ! src/share/classes/java/util/AbstractMap.java Changeset: 33a60ce1e35d Author: chegar Date: 2014-01-03 06:23 +0000 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/33a60ce1e35d Merge ! src/share/classes/java/util/AbstractMap.java

1 0

RFR(S): JDK-8031134 : PPC64: implement printing on AIX
by Volker Simonis 02 Jan '14

02 Jan '14

Hi, could somebody please review the following small change: http://cr.openjdk.java.net/~simonis/webrevs/8031134/ It's the straight forward implementation of the basic printing infrastructure on AIX and shouldn't have any impact on the existing platforms. As always, this change is intended for the http://hg.openjdk.java.net/ppc-aix-port/stage/jdk repository. Thank you and best regards, Volker

2 1

RFR: JDK-8028712 : Tidy warnings cleanup for java.sql package
by Serge 02 Jan '14

02 Jan '14

Hi all, please review the fix http://cr.openjdk.java.net/~yan/8028712/webrev.02/ <http://cr.openjdk.java.net/%7Eyan/8028712/webrev.02/> for https://bugs.openjdk.java.net/browse/JDK-8028712 This patch cleanup tidy warnings for generated html documentation, and do not affect the appearance of the documentation. Best regards, Serge V. Lugovoy

4 5

hg: jdk8/tl/langtools: 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present
by bhavesh.x.patel＠oracle.com 02 Jan '14

02 Jan '14

Changeset: 4a6f853f8721 Author: bpatel Date: 2014-01-02 02:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4a6f853f8721 8029143: javadoc standard doclet should add Functional Interface blurb when @FunctionalInterface annotation is present Reviewed-by: jjg ! src/share/classes/com/sun/javadoc/ClassDoc.java ! src/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java ! test/com/sun/javadoc/testLambdaFeature/pkg/A.java ! test/com/sun/javadoc/testLambdaFeature/pkg1/FuncInf.java + test/com/sun/javadoc/testLambdaFeature/pkg1/NotAFuncInf.java

1 0