August 2014 - core-libs-dev

RFR: 8054828: [TESTBUG] Typos in java/lang/Long/ParsingTest
by Claes Redestad 11 Aug '14

11 Aug '14

Hi, please review this small patch which resolves a number of typos where java/lang/Long/ParsingTest.java accidentally uses Integer.parseInt instead of Long.parseLong webrev: http://cr.openjdk.java.net/~redestad/8054828/webrev.0/ bug: https://bugs.openjdk.java.net/browse/JDK-8054828 Thanks! /Claes

2 4

Create a child class object based on a parent one
by Weijun Wang 10 Aug '14

10 Aug '14

I have a class A and a sub class B. B contains no extra fields than A. Now there is an object of A and I want to create a B which is "identical" to it. What I am doing is public B(A old) { for (Field f: A.class.getDeclaredFields()) { if (!Modifier.isStatic(f.getModifiers())) { f.setAccessible(true); try { f.set(this, f.get(old)); } catch (Exception e) { throw new RuntimeException(e); } } } } Is there a better way to do this? I can think of Unsafe. Please note I cannot put an A inside B because there are instanceof calls that B must isa A. Also, the A object will be discarded so there is no need to clone the fields. Thanks Max

2 1

RFR: 8054555, javadoc clean-up in java.sql, javax.sql.*
by Lance Andersen 08 Aug '14

08 Aug '14

Hi, Looking for a reviewer for corrections to various javadoc typos The webrev can be found at http://cr.openjdk.java.net/~lancea/8054555/webrev.00/ Best, Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com

4 8

RFR (XL) 8046070 - Class Data Sharing clean up and refactoring, round #2
by Ioi Lam 08 Aug '14

08 Aug '14

Hi Folks, Please review the following clean up and refactoring of the CDS code, for JDK9 http://cr.openjdk.java.net/~iklam/8046070-cds-cleanup-v2/ https://bugs.openjdk.java.net/browse/JDK-8046070 Summary of fix: Clean up and refactor the Class Data Sharing (CDS) code, including: + Improve archive integrity checking + Support bytecode verification during archive dumping time + Allow the user to configure the CDS class list and archive file. + Allow future extension of the CDS class loading mechanism. Tests: JPRT UTE (vm.runtime.testlist, vm.quick.testlist, vm.parallel_class_loading.testlist) Various adhoc SQE tests on Aurora JCK Thanks - Ioi

5 11

RFR JDK-8034032 : Check src/macosx/native/java/util/prefs/MacOSXPreferencesFile.m for JNI pending issues
by Brent Christian 07 Aug '14

07 Aug '14

Please review my fix for: Bug: https://bugs.openjdk.java.net/browse/JDK-8034032 Webrev: http://cr.openjdk.java.net/~bchristi/8034032/webrev.0/ Within jdk/src/macosx/native/java/util/prefs/MacOSXPreferencesFile.m, there is a pattern of making blocks of toCF() calls, where later toCF() calls are made when there could be an exception pending from an earlier toCF() call. toCF()creates a CFString from a Java String. If an error occurs, it will raise an exception by calling the throwIfNull() macro: #define throwIfNull(var, msg) \ do { \ if (var == NULL) { \ throwOutOfMemoryError(env, msg); \ goto bad##var; \ } \ } while (0) Note: "##var" is substituted for whatever text is serving as "var", and throwIfNull() is meant to jump to the cleanup portion of a function (e.g. "badvar") to do cleanup before exiting. This goto behavior is used more as intended elsewhere in MacOSXPreferencesFile.m. toCF() doesn't have such cleanup to do. An example of a series of calls to toCF(): 650 CFStringRef path = toCF(env, jpath); 651 CFStringRef child = toCF(env, jchild); 652 CFStringRef name = toCF(env, jname); It's not until later that we check that everything turned out OK: 661 if (!path || !child || !name) goto badparams; If one toCF() call throws an OOME exception, it will still be pending when the next call to toCF() makes a JNI call, (GetStringLength() in this case). I believe the right thing to do here is to check the success of each toCF() call before making the next toCF() call. I've left the existing null checks / 'goto badparams' as is. I also clear any pending exceptions in throwOutOfMemoryError(). Thanks, -Brent

2 2

RFR: 8042126: DateTimeFormatter "MMMMM" returns English value in Japanese locale
by dmeetry degrave 07 Aug '14

07 Aug '14

Hello, Please review a simple fix (jdk 8 and 9) for 8042126: DateTimeFormatter "MMMMM" returns English value in Japanese locale bug: https://bugs.openjdk.java.net/browse/JDK-8042126 fix: http://cr.openjdk.java.net/~dmeetry/8042126/webrev.01 thanks, dmeetry

3 4

RFR: 8049343: (tz) Support tzdata2014e
by Aleksej Efimov 06 Aug '14

06 Aug '14

Hi, Please review the tzdata2014e [1] integration fix to JDK9: http://cr.openjdk.java.net/~aefimov/8049343/9/webrev.00/ Two issues with JSR310 implementation were discovered during integration process: First issue is related to the internal representation of the '24:00' value. The JSR310 implementation treats this value as a next day 00:00 time. The workaround already exists in the code for similar entries and this failure was resolved in similar way [2]. For the second issue JDK-8051641 [3] was filled and 'sun/util/calendar/zi/TestZoneInfo310.java' test is the only one that fails with this tzdata. Other time zone related test passes without failures. Thank you, Aleksej [1] https://bugs.openjdk.java.net/browse/JDK-8049343 [2] http://cr.openjdk.java.net/~aefimov/8049343/9/webrev.00/src/share/classes/s… [3] https://bugs.openjdk.java.net/browse/JDK-8051641

1 2

RFR [8054221] StringJoiner imlementation optimization
by Ivan Gerasimov 06 Aug '14

06 Aug '14

Hello! Here's the proposal by Martin Buchholz to improve implementation of StringJoiner class: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/StringJoiner-optimizati… I think that result of concatenation in the merge() method can be saved to be reused later. This would be useful, for example, if a StringJoiner is merged into other StringJoiners several times. So, here's my slightly modified version of the Martin's webrev: http://cr.openjdk.java.net/~igerasim/8054221/0/webrev/ I've also modified the test to regularly test cases with empty prefixes/suffixes. Sincerely yours, Ivan

4 12

RFR (XS) JDK-8051861 [TESTBUG] test "java/math/BigInteger/BigIntegerTest.java" does not hold Random value to have a possibility to reproduce it
by vasily stolbov 04 Aug '14

04 Aug '14

Hi, Please review and help me with integration: Problem: java.math.BigInteger.BigIntegerTest uses java.math.Random(), so we have no possibility to reproduce it. Solution: Test gets start random seed from environment variable. If this variable not exists, test write current random seed to log. Bug: https://bugs.openjdk.java.net/browse/JDK-8051861 Fix: (in attachment) Best regards, Vasily

2 5

RFR JDK-8054158: Fix typos in JNDI-related packages
by Pavel Rappo 01 Aug '14

01 Aug '14

Hi everyone, Could you please review my change for JDK-8054158? http://cr.openjdk.java.net/~prappo/8054158/webrev.00/ -Pavel

3 4