February 2015 - core-libs-dev

RFR - 8072450: 9-dev build failed on elinux-i586 and rlinux-i586
by Daniel Fuchs 05 Feb '15

05 Feb '15

Hi, Please find below a fix for: 8072450: 9-dev build failed on elinux-i586 and rlinux-i586 My fix for JDK-8068730 which was integrated from hs-rt into jdk9-dev yesterday is causing a build failure in the jdk9/dev nightly on two platforms. It appears that these platforms have a slightly older version of the compiler - which chokes on jvm.cpp with the following error: hotspot/src/share/vm/prims/jvm.cpp:307: error: integer constant is too large for ��long�� type Adding a LL suffix should solve the issue: ############## diff --git a/src/share/vm/prims/jvm.cpp b/src/share/vm/prims/jvm.cpp --- a/src/share/vm/prims/jvm.cpp +++ b/src/share/vm/prims/jvm.cpp @@ -304,7 +304,7 @@ // java.lang.System, but we choose to keep it here so that it stays next // to JVM_CurrentTimeMillis and JVM_NanoTime -const jlong MAX_DIFF_SECS = 0x0100000000; // 2^32 +const jlong MAX_DIFF_SECS = 0x0100000000LL; // 2^32 const jlong MIN_DIFF_SECS = -MAX_DIFF_SECS; // -2^32 JVM_LEAF(jlong, JVM_GetNanoTimeAdjustment(JNIEnv *env, jclass ignored, jlong offset_secs)) ############## ( or if you prefer here is a webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8072450/webrev.00 ) best regards, -- daniel

4 6

RFR 9: 8067800: Unexpected DateTimeException in the java.time.chrono.HijrahChronology.isLeapYear
by Roger Riggs 04 Feb '15

04 Feb '15

Please review this specification clarification of the range of Hijrah calendar variants. The issue was exposed by a bug in the HijrahChronology.isLeapYear method. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-leap-year-8067800/ Issue: https://bugs.openjdk.java.net/browse/JDK-8067800 A CCC may be needed. Thanks, Roger

3 13

RFR: JDK-8072456 @since tags missing from TimeUnit
by Staffan Larsen 04 Feb '15

04 Feb '15

The MINUTES, HOURS, and DAYS fields of TimeUnit are missing an "@since 1.6" tag. webrev: http://cr.openjdk.java.net/~sla/8072456/webrev.00/ <http://cr.openjdk.java.net/~sla/8072456/webrev.00/> bug: https://bugs.openjdk.java.net/browse/JDK-8072456 <https://bugs.openjdk.java.net/browse/JDK-8072456> Thanks, /Staffan

3 2

RFR: JDK-8072458 jdk/test/Makefile references (to be removed) win32 directory in jtreg
by Staffan Larsen 04 Feb '15

04 Feb '15

The platform specific directories in jtreg are going away in favor of a platform-agnostic directory. Small fix below. Thanks, /Staffan diff --git a/test/Makefile b/test/Makefile --- a/test/Makefile +++ b/test/Makefile @@ -267,8 +267,8 @@ EXTRA_JTREG_OPTIONS += -concurrency:$(CONCURRENCY) endif -# Default JTREG to run (win32 script works for everybody) -JTREG = $(JT_HOME)/win32/bin/jtreg +# Default JTREG to run +JTREG = $(JT_HOME)/bin/jtreg # run in agentvm mode JTREG_BASIC_OPTIONS += -agentvm # Only run automatic tests

2 1

RFR 8/9: 8068278 ArrayIndexOutOfBoundsException instead of DateTimeException in j.t.chrono.JapaneseChronology.eraOf()
by Roger Riggs 03 Feb '15

03 Feb '15

Please review this correction of a JapaneseEra range check in java.time. The error was discovered during development of additional conformance tests (to be delivered separately). Webrev: http://cr.openjdk.java.net/~rriggs//webrev-era-8068278 Issue: <https://bugs.openjdk.java.net/browse/JDK-8068278> 8068278 ArrayIndexOutOfBoundsException instead of DateTimeException in j.t.chrono.JapaneseChronology.eraOf() Thanks, Roger

3 9

RFR 8072030 Race condition in ThenComposeExceptionTest.java
by Paul Sandoz 03 Feb '15

03 Feb '15

Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8072030-thenComposeException-t… I introduced a silly race condition in the test ThenComposeExceptionTest.java. This manifested itself in hotspot testing where various VM options increased the probability of failure. Thanks, Paul.

2 3

RFR: JDK-8068033: Fix Java Launcher for splash screen.
by Kumar Srinivasan 03 Feb '15

03 Feb '15

Hi, Appreciate a review of this fix for JNI correctness when dealing with Splash Screen on MacOSX. http://cr.openjdk.java.net/~ksrini/8068033/webrev.0/ Sergey, I think you took over from Anthony Petrov for SplashScreen, if not please have someone in your team look it over. Thanks Kumar

3 2

JDK 9 RFR of addition to ProblemList.txt
by joe darcy 02 Feb '15

02 Feb '15

Hello, The test javax/xml/ws/8046817/GenerateEnumSchema.java has been failing on windows since some recent changes. Please approve the patch below to put the test on the problem list while a full fix is investigated. Thanks, -Joe diff -r 541a8cef4e0d test/ProblemList.txt --- a/test/ProblemList.txt Thu Jan 29 16:16:35 2015 -0800 +++ b/test/ProblemList.txt Mon Feb 02 11:54:52 2015 -0800 @@ -162,6 +162,9 @@ # 6988950 demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java generic-all +# 8071968 +javax/xml/ws/8046817/GenerateEnumSchema.java windows-all + ############################################################################ # jdk_net

2 1

Time to retire System.runFinalizersOnExit?
by Mandy Chung 02 Feb '15

02 Feb '15

System.runFinalizationOnExit has been deprecated since 1998 (JDK 1.2) and this method is inherently unsafe. I am thinking to propose this method in JDK 9 to throw UnsupportedOperationException. I believe it's rare for existing applications using System.runFinalizationOnExit. My analysis on Maven Central ~315K artifacts that show about ~15 unique artifacts calling System.runFinalizationOnExit while they all come from only 5 classes. Any thought/feedback? Mandy

12 21