May 2015 - core-libs-dev

RFR: JDK-8066859 java/lang/ref/OOMEInReferenceHandler.java failed with java.lang.Exception: Reference Handler thread died
by Peter Levart 07 May '15

07 May '15

Hi, I might have a closure for this long beard issue [1] and I'd like to propose a change [2]. It all started with [3] discussed here [4] which resulted in the fix for one source of OutOfMemoryError(s) terminating ReferenceHandler thread. With this fix, new test was added which started failing intermittently indicating there is another source of OutOfMemoryError(s) being thrown in ReferenceHandler. At that time, the investigation [6] indicated that the source is "r instanceof Cleaner" check and so another change was pushed [5]. The issue JDK-8022321 is internal - I don't have a link. That change was 2-fold: it added code to preload and pre-initialize Cleaner and InterruptedException classes in ReferenceHandler.<clinit> and, cowardly, surrounded "r instanceof Cleaner" check with OOME exception handler. I'm pretty certain that pre-loading of the classes would have been enough. At least it would have not sprung the confusion expressed here [7]. But even that was not enough to prevent intermittent failures. I realized that the test I devised still fails because of Cleaner.clean() throwing OOME. Why this is possible is discussed in the issue [1]. I even modified the test to reproduce such failure with 100% chance. So here I propose two things in [2] : - roll-back of the confusing "r instanceof Cleaner" OOME exception handling to the shape of code predating change [5]. - add handling of OOME in the Cleaner.clean() with updated test that checks the behaviour. Regards, Peter [1] https://bugs.openjdk.java.net/browse/JDK-8066859 [2] http://cr.openjdk.java.net/~plevart/jdk9-dev/OOMEInReferenceHandler/Investi… [3] https://bugs.openjdk.java.net/browse/JDK-8015434 [4] http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-April/016510.html [5] http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d04102f69d46 [6] https://www.mail-archive.com/core-libs-dev%40openjdk.java.net/msg23596.html [7] https://bugs.openjdk.java.net/browse/JDK-8055232

3 7

Add Predicate.of(), Consumer.of(), etc.
by Remi Forax 07 May '15

07 May '15

Hi all, today, I stubble on a variant of JDK-8050818 [1], trying to call negate() on a lambda which is not yet a Predicate (due to target typing) which requires either to cast the lambda to a Predicate and everybody knows that cast are evil or to add a local variable. I think there is a way to fix that, it's not very orthodox so I let you judge. The idea is to introduce a static method 'of' on Predicate, class Predicate<T> { ... public static <T> Predicate<T> of(Predicate<T> predicate) { return predicate; } } so one can write: stream.filter(Predicate.of(String::isEmpty).negate()) compared to stream.filter(((Predicate<String>)String::isEmpty).negate()) so the question is, does it it worth the cost to introduce a static method that basically do nothing on all functional interfaces of java.util.function. cheers, Rémi [1] https://bugs.openjdk.java.net/browse/JDK-8050818

6 7

RFR 9: 8077350 Process API Updates Implementation Review
by Roger Riggs 07 May '15

07 May '15

Please review the API and implementation of the Process API Updates described inJEP 102 <https://bugs.openjdk.java.net/browse/JDK-8046092>. Please review and comment by April 23rd. The recommendation to make ProcessHandle an interface is included allowing the new functions to be extended by Process subclasses. The implementation covers all functions on Unix, Windows, Solaris, and Mac OS X. The API doc: http://cr.openjdk.java.net/~rriggs/ph-apidraft/ The webrev: http://cr.openjdk.java.net/~rriggs/webrev-ph Issue: JDK-8077350 <https://bugs.openjdk.java.net/browse/JDK-8077350> Process API Updates Implementation The code is in the jdk9 sandbox on branch JDK-8046092-branch. Please review and comment, Roger

10 50

JDK 9 RFR of Update to RegEx test to use random number library
by Joseph D. Darcy 06 May '15

06 May '15

Hello, The regression test test/java/util/regex/RegExTest.java has been observed to intermittently fail. As the test uses randomness, I'd like to update to the test to use the random number testing library to better identify the cause of any future failures. Please review the patch below: diff -r 207c1b0356ea test/java/util/regex/RegExTest.java --- a/test/java/util/regex/RegExTest.java Tue May 05 17:55:16 2015 +0100 +++ b/test/java/util/regex/RegExTest.java Tue May 05 14:50:10 2015 -0700 @@ -23,7 +23,7 @@ /** * @test - * @summary tests RegExp framework + * @summary tests RegExp framework (use -Dseed=X to set PRNG seed) * @author Mike McCloskey * @bug 4481568 4482696 4495089 4504687 4527731 4599621 4631553 4619345 * 4630911 4672616 4711773 4727935 4750573 4792284 4803197 4757029 4808962 @@ -33,6 +33,9 @@ * 6350801 6676425 6878475 6919132 6931676 6948903 6990617 7014645 7039066 * 7067045 7014640 7189363 8007395 8013252 8013254 8012646 8023647 6559590 * 8027645 8035076 8039124 8035975 8074678 + * @library /lib/testlibrary + * @build jdk.testlibrary.* + * @run main RegExTest * @key randomness */ @@ -50,7 +53,7 @@ */ public class RegExTest { - private static Random generator = new Random(); + private static Random generator = RandomFactory.getRandom(); private static boolean failure = false; private static int failCount = 0; private static String firstFailure = null; Thanks, -Joe

2 3

RFR(M): 8078896: Add @modules as needed to the jdk_svc tests
by Yekaterina Kantserova 06 May '15

06 May '15

Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8078896 webrev: http://cr.openjdk.java.net/~ykantser/8078896 The push will be pushed to jdk9/dev. Thanks, Katja Alan's clarification from same change in hotspot (RFR: JDK-8075586: add @modules as needed to the open hotspot tests) ========== Just to put more context on this patch and similar patches that will be proposed for tests in other repos. The new @modules tag can be used for test selection (e.g. no point running a test that make use of types in module java.management if the runtime under test does not have the management module), and additionally to declare a dependency on JDK-internal APIs. If my test uses sun.misc.Unsafe for example then the runtime under test needs to export that API for the test to compile and run. Clearly the latter requires the module system in JDK 9 so consider this part as just preparing the tests for when that day comes. One other thing to say to say is that Alex has tooling to examine the test tree and create or change the @modules tag as needed. The intention is that this should run periodically to refresh the @modules tags. In this period before the module system then we can't expect everyone that is adding or changing tests to have internalized the module graph [1] and furthermore know which APIs are exported or not. In other words, the intention is not to needlessly burden anyone that adds or changes tests. Clearly making use of a new jtreg tag means everyone with a local copy of jtreg should grab a recent build. Finally, I hope in time that the TEST.groups files can be cleaned up to remove the needs_* groups, this is important for the group definitions in the jdk repo mostly (but there are some in the hotspot TEST.groups too). -Alan

3 7

RFR 8078645: removeIf(filter) in ConcurrentHashMap removes entries for which filter is false
by Paul Sandoz 06 May '15

06 May '15

Hi Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8078645-ConcurrentMap-views-re… These updates are already in the 166 repo. The documentation update to the class of ConcurrentMap is going through CCC. I took the liberty of also cleaning up some smaller doc errors on ConcurrentMap as made in the 166 repo. Thanks, Paul.

4 12

RFR: JDK-8074002 java.time.ZoneId.systemDefault() should be faster
by Peter Levart 06 May '15

06 May '15

Hi, Please review the following improvement that caches default ZoneId object and makes the frequently executed ZoneId.systemDefault() method faster: http://cr.openjdk.java.net/~plevart/jdk9-dev/ZoneId.systemDefault/webrev.04/ The patch is just a rebased version of webrev.03 + some comments added about the importance of defensive cloning in TimeZone.setDefault(). There was already a discussion about this patch a while ago and Stephen basically approved it in this form: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-February/031714.h… Thanks, Peter Levart

4 5

RFR [9] 8079342: some docs cleanup for CORBA - part 2
by alexander stepanov 06 May '15

06 May '15

Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8079342/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8079342 Just some HTML markup fix for CORBA. Thanks, Alexander

2 7

JEP 132: More-prompt finalization
by Peter Levart 06 May '15

06 May '15

Hi, Is there any interest to propose JEP 132 for JDK9 ? I have some ideas how to achieve it's goals. Regards, Peter

1 0

RFR (XS): 8078225: tools/launcher/FXLauncherTest.java fails intermittently (win)
by Kumar Srinivasan 05 May '15

05 May '15

Hello, Please review the simple fix which allows the test to be run in its own vm, there seems to be some issue with the harness running in a concurrent mode specifically on Windows. Thanks Kumar diff --git a/test/tools/launcher/FXLauncherTest.java b/test/tools/launcher/FXLauncherTest.java --- a/test/tools/launcher/FXLauncherTest.java +++ b/test/tools/launcher/FXLauncherTest.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2015, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -28,7 +28,7 @@ * Test uses main method and blank main method, a jfx app class and an incorrest * jfx app class, a main-class for the manifest, a bogus one and none. * All should execute except the incorrect fx app class entries. - * @run main FXLauncherTest + * @run main/othervm FXLauncherTest */ import java.io.File; import java.io.IOException;

2 1