February 2016 - core-libs-dev

JNI VERSION CHANGE: RFR: 8145098: JNI GetVersion should return JNI_VERSION_9
by Rachel Protacio 19 Feb '16

19 Feb '16

Hello! Small but important change for review: updating the JNI_VERSION and in so doing, changing the format from JNI_VERSION_1_x to JNI_VERSION_x_y (see code/bug for details). Bug: https://bugs.openjdk.java.net/browse/JDK-8145098 hotspot repo webrev: http://cr.openjdk.java.net/~rprotacio/JNI_hotspot/ jdk repo webrev: http://cr.openjdk.java.net/~rprotacio/JNI_jdk/ I grep'ed through the code to find references to the current JNI version and believe I have caught all the ones that needed changing, plus the fact that all these tests pass: * local hotspot jtreg tests * my own sample JNI test to print and visually inspect the version (essentially what is performed by the updated hotspot/test/native_sanity/JniVersion.java test) * jck vm tests * local rbt colcated and noncolocated tests, especially for the purpose of hitting tonga/src/nsk/share/jvmti tests where JNI_GetVersion() is used Thank you, Rachel

5 9

RFR 9: 8149750 Decouple sun.misc.Signal from the base module
by Roger Riggs 19 Feb '16

19 Feb '16

Please review moving the functionality of sun.misc.Signal to jdk.internal.misc and creating a wrapper sun.misc.Signal for existing external uses. A new replacement API will be considered separately. The update includes a test that passes with or without the changes. (Except for an NPE instead of SEGV if null is passed). Webrev: http://cr.openjdk.java.net/~rriggs/webrev-signal-9149750/ Issue: https://bugs.openjdk.java.net/browse/JDK-8149750 Thanks, Roger JEP 260: https://bugs.openjdk.java.net/browse/JDK-8132928

3 10

RFR [9] 8150163: JarFileSystem support for MRJARs should use the JDK specific Version API
by Chris Hegarty 18 Feb '16

18 Feb '16

To support MRJARs, currently JarFileSystem uses sun.misc.Version to retrieve the major version. It should be updated to use the new JDK specific Version API. http://cr.openjdk.java.net/~chegar/8150163/ https://bugs.openjdk.java.net/browse/JDK-8150163 -Chris.

3 2

JDK 9 RFR of JDK-8149915: enabling validate-annotations feature for xsd schema with annotation causes NPE
by Langer, Christoph 18 Feb '16

18 Feb '16

Hi, can you please review the following change for JDK-8149915: http://cr.openjdk.java.net/~clanger/webrevs/8149915.0/ I'm not sure if it is the right thing to set the default for XML_SECURITY_PROPERTY_MANAGER to a new XMLSecurityPropertyManager() object instead of the String "all". But it must not be a String, I think. And also I don't know if my approach to add a field "fSecurityManager" to XML11Configuration. Please advise and let me know how I can do it better. Thanks in advance and best regards Christoph

2 8

RFR - 8132734: java.util.jar.* changes to support multi-release jar files
by Steve Drach 18 Feb '16

18 Feb '16

Hi, Let’s try again, this time there are tests. Please review the following webrev that adds support for multi-release jars as specified in JEP-238. Issue: https://bugs.openjdk.java.net/browse/JDK-8132734 JEP 238: https://bugs.openjdk.java.net/browse/JDK-8047305 Webrev: http://cr.openjdk.java.net/~psandoz/multiversion-jar/jar-webrev/ A multi-release jar file is a jar file that contains a manifest with a main attribute named "Multi-Release", and also contains a directory "META-INF/versions" with subdirectories that contain versioned entries segregated by the major version of Java platform releases. A versioned entry, with a version n, in the "META-INF/versions/{n}" directory overrides the unversioned root entry as well as any entry with a version number i where i < n. The changes in this webrev implement an aliasing mechanism in JarEntry so that when a JarFile client retrieves a JarEntry, the data from the entry pointed to by the alias is returned. There are methods to configure whether or not aliasing is enabled, and if it is, which version of an entry the alias points to. When a JarFile is used by a class loader to load class resources, the default version retrieved is the runtime version of the Java platform (i.e. a version 9 entry is returned when the platform is JDK 9). This mechanism can be configured by System properties. Thanks, Steve

9 91

RFR (JAXP) 8146237: PREFER from Features API taking precedence over catalog file
by huizhe wang 17 Feb '16

17 Feb '16

Hi, Please review a fix on missing property settings read from catalog files. Values from catalog files shall override any other settings including those through the API, e.g. builder().with(CatalogFeatures.Feature.PREFER, "system"). JBS: https://bugs.openjdk.java.net/browse/JDK-8146237 webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8146237/webrev/ Thanks, Joe

2 2

Review Request: 8074069: Move JDK-specific API to jdk.* module
by Mandy Chung 17 Feb '16

17 Feb '16

This patch prepares to move closed JDK-specific APIs from java.base to jdk.net module as specified in the design principles in JEP 200 that standard modules should not non-standard APIs. Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074069/webrev.00/index.html Mandy

2 1

JDK 9 RFR of JDK-8149920: Remove intermittent key from jdk_core tests
by Amy Lu 17 Feb '16

17 Feb '16

sun/nio/cs/FindEncoderBugs.java sun/nio/cs/FindDecoderBugs.java java/util/concurrent/Phaser/Basic.java java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java java/net/SocketPermission/SocketPermissionTest.java java/lang/ProcessHandle/InfoTest.java com/sun/jndi/ldap/LdapTimeoutTest.java For above tests, previous intermittent test failure issues are fixed, no open bug (no failure reported). This patch is to remove @key intermittent from tests. bug: https://bugs.openjdk.java.net/browse/JDK-8149920 webrev: http://cr.openjdk.java.net/~amlu/8149920/webrev.00/ Thanks, Amy

2 1

RFR (S) 8149835: StringConcatFactory should emit classes with the same package as the host class
by Aleksey Shipilev 17 Feb '16

17 Feb '16

Hi, Please review a StringConcatFactory fix that makes generated String concat stubs to be named "<host-class>$$StringConcat/<id>", instead of "java/lang/String$$Concat/<id>": https://bugs.openjdk.java.net/browse/JDK-8149835 Among other things, this helps to dodge the failure caught by stricter access controls in Jake (JDK-8149165), and hopefully caters for future stricter Unsafe.defineAnonymousClass access controls (JDK-8058575). Webrevs: http://cr.openjdk.java.net/~shade/8149835/webrev.jdk.01/ http://cr.openjdk.java.net/~shade/8149835/webrev.langtools.01/ Testing: JPRT, java/lang/String; + copying SCF code to jake forest and running with it. Cheers, -Aleksey

5 7

JDK 9 RFR of JDK-8149922: Remove intermittent key from security tests
by Amy Lu 17 Feb '16

17 Feb '16

sun/security/mscapi/ShortRSAKey1024.sh sun/security/mscapi/SignUsingSHA2withRSA.sh javax/net/ssl/SSLSession/SessionCacheSizeTests.java For above tests, previous intermittent test failure issues are fixed, no open bug (no failure reported). This patch is to remove @key intermittent from tests. This patch also removed SessionCacheSizeTests.java from ProblemList.txt as related bug (JDK-8146387) is resolved. bug: https://bugs.openjdk.java.net/browse/JDK-8149922 https://bugs.openjdk.java.net/browse/JDK-8150047 webrev: http://cr.openjdk.java.net/~amlu/8149922/webrev.00/ Thanks, Amy

1 0