March 2016 - core-libs-dev

RFR 8131913: jdk/internal/jline/console/StripAnsiTest.java can't run in the background
by Jan Lahoda 15 Mar '16

15 Mar '16

Hi, I'd like to ask for a review of a patch for JDK-8131913. The fix is to use the "UnsupportedTerminal", which will not try to switch the OS terminal into the raw mode. The proposed patch is here: http://cr.openjdk.java.net/~jlahoda/8131913/webrev.00/index.html Any comments are welcome. Thanks, Jan

2 2

RFR 8151676/9, Add jdk/internal/jline/console/StripAnsiTest.java into problem list for MacOSX
by Felix Yang 15 Mar '16

15 Mar '16

Hi, please review at your convenience. This test jdk/internal/jline/console/StripAnsiTest.java has been observed hanging on several Mac OSX environments. Suggest to temporarily put into problemlist for Mac OSX. Bug: https://bugs.openjdk.java.net/browse/JDK-8151676 Thanks, Felix Patch: diff -r 13be3e542a07 test/ProblemList.txt --- a/test/ProblemList.txt Thu Mar 10 11:52:54 2016 -0800 +++ b/test/ProblemList.txt Thu Mar 10 22:23:52 2016 -0800 @@ -414,6 +414,10 @@ # jdk_other +# 8150519 + +jdk/internal/jline/console/StripAnsiTest.java macosx-all + ############################################################################ # 8141370

2 4

RFR: 8151847 rmic should support v53 classfiles
by Jonathan Gibbons 15 Mar '16

15 Mar '16

Please review this one character change to have rmic support v53 class files: JBS: https://bugs.openjdk.java.net/browse/JDK-8151847 Webrev: http://cr.openjdk.java.net/~jjg/8151847/webrev/ -- Jon

4 3

RFR: JDK-8133206 - Higher native memory usage caused by upgrade to zlib 1.2.8
by Alex Kashchenko 14 Mar '16

14 Mar '16

Please review the following fix to JDK-8133206: - bug: https://bugs.openjdk.java.net/browse/JDK-8133206 - webrev for jdk9: http://cr.openjdk.java.net/~akasko/jdk9/8133206/webrev.00/ This fix is a forward-port of the patch to jdk7u created by Nikolay Gorshkov: - webrev for jdk7u: http://cr.openjdk.java.net/~nikgor/8133206/jdk7u-dev/webrev.01/ - jdk7u review thread with the issue details: http://mail.openjdk.java.net/pipermail/jdk7u-dev/2015-October/010420.html - the same thread on core-libs-dev: http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-October/035884.ht… Forward-port to jdk9 is almost the same as original patch (with changed paths), one additional inflate(...) call is changed in zip_util.c . jdk9 with this patch passes all the regression tests from java/util/jar, java/util/zip, tools/jar and tools/pack200. I created a jtreg reproducer that works with jdk7u and jdk9: - web link: http://cr.openjdk.java.net/~akasko/jdk9/8133206/reproducer/ - download: http://cr.openjdk.java.net/~akasko/jdk9/8133206/reproducer.zip This reproducer is Linux-only, slow (takes more than a minute) and requires Valgrind and zlib-debuginfo (if system zlib is used). It runs java.util.zip.Inflater under the Memcheck multiple times and parses the output to compare the number of zlib-specific memory allocations. I am not sure whether such reproducer should be included into the jdk regression tests tree, so publishing it as a standalone jtreg test (not a webrev). Please let me know if I need to create a new bug for jdk9 (in addition to JDK-8133206). -- -Alex

2 1

[PING] RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available' when transforming with lots of temporary result trees
by Langer, Christoph 14 Mar '16

14 Mar '16

Hi, Ping - any comments or reviews for this bugfix? Thanks Christoph From: Langer, Christoph Sent: Freitag, 26. Februar 2016 16:02 To: core-libs-dev(a)openjdk.java.net Subject: RFR: JDK-8150704 XALAN: ERROR: 'No more DTM IDs are available' when transforming with lots of temporary result trees Hi, I've created a fix proposal for the issue I have reported in this bug: https://bugs.openjdk.java.net/browse/JDK-8150704 The webrev can be found here: http://cr.openjdk.java.net/~clanger/webrevs/8150704.1/ The Xalan parser would eventually run out of DTM IDs if xsl transformations involve lots of temporary result trees. Those are never released although they could. A testcase is included for this. I've also done some cleanups in the Xalan code and in the tests. Thanks in advance for looking at this :) Best regards Christoph

2 7

JDK 9 RFR of JDK-8151785: Doc typo in src/../java/util/stream/PipelineHelper.java
by Hamlin Li 14 Mar '16

14 Mar '16

Please help to review the tiny doc typo fix for bug https://bugs.openjdk.java.net/browse/JDK-8151785 it should be "copyInto(wrapSink(sink), spliterator);", but it is "intoWrapped(wrapSink(sink), spliterator);", there is no method called intoWrapped. diff -r 25e8c082d7ef src/java.base/share/classes/java/util/stream/PipelineHelper.java --- a/src/java.base/share/classes/java/util/stream/PipelineHelper.java Sun Mar 13 20:26:29 2016 +0100 +++ b/src/java.base/share/classes/java/util/stream/PipelineHelper.java Sun Mar 13 20:46:22 2016 -0700 @@ -98,7 +98,7 @@ * @implSpec * The implementation behaves as if: * <pre>{@code - * intoWrapped(wrapSink(sink), spliterator); + * copyInto(wrapSink(sink), spliterator); * }</pre> * * @param sink the {@code Sink} to receive the results Thank you -Hamlin

2 1

JDK 9 RFR of JDK-8151798: Mark java/util/TimeZone/Bug6772689.java as intermittently failing and demote to tier2
by Amy Lu 14 Mar '16

14 Mar '16

java/util/TimeZone/Bug6772689.java This test is known to fail intermittently (JDK-8149898, JDK-8150804). This patch is to mark the test accordingly with keyword 'intermittent’ and demote it to tier2 until issue resolved. bug: https://bugs.openjdk.java.net/browse/JDK-8151798 webrev: http://cr.openjdk.java.net/~amlu/8151798/webrev.00/ Thanks, Amy --- old/test/TEST.groups 2016-03-14 17:34:51.000000000 +0800 +++ new/test/TEST.groups 2016-03-14 17:34:51.000000000 +0800 @@ -32,6 +32,7 @@ -java/util/WeakHashMap/GCDuringIteration.java \ -java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java \ -java/util/concurrent/forkjoin/FJExceptionTableLeak.java \ + -java/util/TimeZone/Bug6772689.java \ sun/nio/cs/ISO8859x.java \ java/nio/Buffer \ com/sun/crypto/provider/Cipher \ @@ -42,6 +43,7 @@ java/util/WeakHashMap/GCDuringIteration.java \ java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java \ java/util/concurrent/forkjoin/FJExceptionTableLeak.java \ + java/util/TimeZone/Bug6772689.java \ :jdk_io \ :jdk_nio \ -sun/nio/cs/ISO8859x.java \ --- old/test/java/util/TimeZone/Bug6772689.java 2016-03-14 17:34:52.000000000 +0800 +++ new/test/java/util/TimeZone/Bug6772689.java 2016-03-14 17:34:52.000000000 +0800 @@ -24,6 +24,7 @@ /* * @test * @bug 6772689 + * @key intermittent * @summary Test for standard-to-daylight transitions at midnight: * date stays on the given day. */

2 1

RFR(XS): 8151778: TestLookup.java fails after push of JDK-8150782
by Michael Haupt 13 Mar '16

13 Mar '16

Dear all, please review this one-line fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8151778 Webrev: http://cr.openjdk.java.net/~mhaupt/8151778/webrev.00/ TestLookup is lacking a @compile directive. Thanks, Michael -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment

2 3

Re: JDK 9 RFR of JDK-8149896: Remove unnecessary values in FloatConsts and DoubleConsts
by Mike Duigou 13 Mar '16

13 Mar '16

> From: joe darcy <joe.darcy(a)oracle.com> > Hello, > > The the FloatConsts and DoubleConsts classes, while moved to an > internal > package recently (JDK-8145990), contain constants now available via the > public API. All such uses of the redundant values should be removed as > well as the redundant constants themselves. > > http://cr.openjdk.java.net/~darcy/8149896.0/ The changes look good to me and it is very tempting to suggest just retiring DoubleConstants and FloatConstants altogether and move the remaining quite useful constants in to Double and Float. Mike

2 1

RFR: 8054213: Class name repeated in output of Type.toString()
by Sergey Ustimenko 12 Mar '16

12 Mar '16

Hi all, Please review this patch. I'm also looking for sponsor for this one. The unexpected duplication of owner type was produced by Method.toString() for static classes and interfaces. Problem is fixed by slightly changing the way of obtaining simple name of static nested type and concatenating it with owner type. diff --git a/src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java b/src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java --- a/src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java +++ b/src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java @@ -212,15 +212,14 @@ else sb.append(ownerType.toString()); - sb.append("."); - - if (ownerType instanceof ParameterizedTypeImpl) { + if (ownerType instanceof ParameterizedTypeImpl) // Find simple name of nested type by removing the // shared prefix with owner. - sb.append(rawType.getName().replace( ((ParameterizedTypeImpl)ownerType).rawType.getName() + "$", - "")); - } else - sb.append(rawType.getName()); + sb.append(".").append( + rawType.getName().replace(((ParameterizedTypeImpl)ownerType).rawType.getName() + "$", "") + ); + else + sb.append("$").append(rawType.getSimpleName()); } else sb.append(rawType.getName()); diff --git a/test/java/lang/reflect/Method/TestReturnTypeDuplication.java b/test/java/lang/reflect/Method/TestReturnTypeDuplication.java new file mode 100644 --- /dev/null +++ b/test/java/lang/reflect/Method/TestReturnTypeDuplication.java @@ -0,0 +1,72 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8054213 + * @summary Check that Type.toString() generates valid + * output for static classes and interfaces + * @author Sergey Ustimenko + */ +public class TestReturnTypeDuplication { + + private static final String[] SIGNATURES = { + "TestReturnTypeDuplication$Static", + "TestReturnTypeDuplication$StaticParametrised<java.lang.String>", + "TestReturnTypeDuplication$Interface", + "TestReturnTypeDuplication$InterfaceParametrised<java.lang.String>" + }; + + + public static void main(String[] args) throws Exception { + boolean passed = SIGNATURES[0].equals(getFooGenericReturnType("foo0")) && + SIGNATURES[1].equals(getFooGenericReturnType("foo1")) && + SIGNATURES[2].equals(getFooGenericReturnType("foo2")) && + SIGNATURES[3].equals(getFooGenericReturnType("foo3")); + + if(!passed) { + throw new RuntimeException("Generated type names are invalid!"); + } + } + + private static String getFooGenericReturnType(String foo) throws Exception { + return TestReturnTypeDuplication.class.getMethod(foo).getGenericReturnType().getTypeName(); + } + + static class Static {} + + static class StaticParametrised<T> {} + + interface Interface {} + + interface InterfaceParametrised<T> {} + + public TestReturnTypeDuplication.Static foo0(){return null;} + + public TestReturnTypeDuplication.StaticParametrised<String> foo1(){return null;} + + public TestReturnTypeDuplication.Interface foo2(){return null;} + + public TestReturnTypeDuplication.InterfaceParametrised<String> foo3(){return null;} + +}

1 1