May 2016 - core-libs-dev

RFR (JAXP) JDK-8156513: Problem list javax/xml/jaxp/unittest/stream/FactoryFindTest.java
by Amy Lu 10 May '16

10 May '16

javax/xml/jaxp/unittest/stream/FactoryFindTest.java This jaxp test creates and may left over file under testing jdk (jdk/lib/stax.properties) and other tests being affected. (JDK-8156508) This patch is to add this test to ProblemList.txt until mentioned issue resolved. bug: https://bugs.openjdk.java.net/browse/JDK-8156513 webrev: http://cr.openjdk.java.net/~amlu/8156513/webrev.00/ Thanks, Amy --- old/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 +++ new/test/ProblemList.txt 2016-05-09 13:04:09.000000000 +0800 @@ -29,3 +29,5 @@ # 8150145 javax/xml/jaxp/unittest/common/TransformationWarningsTest.java generic-all +# 8156508 +javax/xml/jaxp/unittest/stream/FactoryFindTest.java generic-all

3 6

RFR 8155088, Fix module dependencies in java/sql/* and javax/* tests
by Felix Yang 09 May '16

09 May '16

Hi there, please review the changes to explicitly declare module dependencies for "java/sql/*" and "javax/*" tests; Bug: https://bugs.openjdk.java.net/browse/JDK-8155088 Webrev: http://cr.openjdk.java.net/~xiaofeya/8155088/webrev.00/ Thanks, Felix

2 6

Add date-time patterns 'v' and 'vvvv'
by nadeesh tv 09 May '16

09 May '16

Hi all, Bug Id : https://bugs.openjdk.java.net/browse/JDK-8155823 Issue: Add date-time patterns 'v' and 'vvvv' webrev: http://cr.openjdk.java.net/~ntv/8155823/webrev.03/ This webrev also contain the fix of related bug https://bugs.openjdk.java.net/browse/JDK-8154567 as part of this. Special thanks for Stephen for his help in writing the spec. -- Thanks and Regards, Nadeesh TV

1 0

RFR 8066291: ZoneIdPrinterParser can be optimized
by Bhanu Gopularam 09 May '16

09 May '16

Hi all, Please review fix following issue Bug Id : https://bugs.openjdk.java.net/browse/JDK-8066291 Solution: provided new method to get size of available zone ids webrev : http://cr.openjdk.java.net/~bgopularam/bhanu/JDK-8066291/webrev.00 Thanks, Bhanu

4 17

Add date-time patterns 'v' and 'vvvv'
by nadeesh tv 09 May '16

09 May '16

Hi all, Bug Id : https://bugs.openjdk.java.net/browse/JDK-8155823 Issue: Add date-time patterns 'v' and 'vvvv' webrev: http://cr.openjdk.java.net/~ntv/8155823/webrev.03/ This webrev also contain the fix of related bug https://bugs.openjdk.java.net/browse/JDK-8154567 as part of this. -- Thanks and Regards, Nadeesh TV

1 0

RFR: JDK-8151914 java/util/jar/JarFile/MultiReleaseJar* tests do not declare module dependences
by Alexandre (Shura) Iline 09 May '16

09 May '16

Hi, Can you please take a look on: http://cr.openjdk.java.net/~shurailine/8151914/webrev.01/ ? Thank you Shura

5 12

JDK 9 RFR of JDK-8156512: Mark several tests from java/nio as intermittently failing
by Amy Lu 09 May '16

09 May '16

java/nio/file/WatchService/DeleteInterference.java java/nio/channels/AsynchronousSocketChannel/Basic.java java/nio/file/FileSystem/Basic.java java/nio/channels/FileChannel/InterruptMapDeadlock.java Above nio tests are known to fail intermittently. This patch is to mark the test accordingly with keyword 'intermittent’ until issue resolved. bug: https://bugs.openjdk.java.net/browse/JDK-8156512 webrev: http://cr.openjdk.java.net/~amlu/8156512/webrev.00/ Thanks, Amy --- old/test/java/nio/channels/AsynchronousSocketChannel/Basic.java 2016-05-09 17:15:14.000000000 +0800 +++ new/test/java/nio/channels/AsynchronousSocketChannel/Basic.java 2016-05-09 17:15:14.000000000 +0800 @@ -25,7 +25,7 @@ * @bug 4607272 6842687 6878369 6944810 7023403 * @summary Unit test for AsynchronousSocketChannel * @run main Basic -skipSlowConnectTest - * @key randomness + * @key randomness intermittent */ import java.nio.ByteBuffer; --- old/test/java/nio/channels/FileChannel/InterruptMapDeadlock.java 2016-05-09 17:15:15.000000000 +0800 +++ new/test/java/nio/channels/FileChannel/InterruptMapDeadlock.java 2016-05-09 17:15:14.000000000 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2013, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ /* @test * @bug 8024833 + * @key intermittent * @summary Tests interruption of threads mapping sections of a file channel in * an attempt to deadlock due to nesting of begin calls. */ --- old/test/java/nio/file/FileSystem/Basic.java 2016-05-09 17:15:15.000000000 +0800 +++ new/test/java/nio/file/FileSystem/Basic.java 2016-05-09 17:15:15.000000000 +0800 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2008, 2016, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -23,6 +23,7 @@ /* @test * @bug 4313887 6838333 8132497 + * @key intermittent * @summary Unit test for java.nio.file.FileSystem * @library .. /lib/testlibrary * @build jdk.testlibrary.FileUtils --- old/test/java/nio/file/WatchService/DeleteInterference.java 2016-05-09 17:15:16.000000000 +0800 +++ new/test/java/nio/file/WatchService/DeleteInterference.java 2016-05-09 17:15:16.000000000 +0800 @@ -20,6 +20,7 @@ /** * @test * @bug 8153925 + * @key intermittent * @summary Tests potential interference between a thread creating and closing * a WatchService with another thread that is deleting and re-creating the * directory at around the same time. This scenario tickled a timing bug

2 3

RFR 8147984: WindowsTerminal should support function keys
by Jan Lahoda 08 May '16

08 May '16

Hello, I'd like to enhance the WindowsTerminal in jdk.internal.le with function keys handling. The intent is so that jshell can bind actions for shortcuts including function keys. The patch for adding the function keys support is here: http://cr.openjdk.java.net/~jlahoda/8147984/webrev.00/ An example of a feature that uses/may use this support is here: http://mail.openjdk.java.net/pipermail/kulla-dev/2016-January/001226.html Any comments are welcome! Thanks, Jan

3 7

RFR: 8152084: Introduction of ssliop protocol to corbaloc
by Tomasz Adamski 06 May '16

06 May '16

Hello All, I would like to propose an extension to corbaloc resolution - the ssliop protocol. IORs created from corbaloc url with ssliop protocol will contain SSL tagged component with indication that secured invocation is required. As a result, connection to the resolved object will have to be secured. I'm attaching a webrev of proposed enhancement: http://cr.openjdk.java.net/~adinn/tomaszadamski/8152084/ Regards, Tomek -- Tomasz Adamski Software Engineer JBoss by Red Hat

3 8

Memory leak in sun.rmi.transport.GC
by Mark Thomas 06 May '16

06 May '16

While working my way through Tomcat's memory leak protection / detection / fixing code, I have found an issue that remains unresolved in the latest JDK 9 source. The thread created by the GC class does not explicitly set the context class loader so it inherits the current context class loader. Consider the following sequence where each module has a dedicated class loader (e.g. web applications in a Servlet container). Module A starts an RMIConnectorServer instance. Amongst other things it calls GC.requestLatency(long) which starts the Daemon thread. Module B starts another RMIConnectorServer instance. It also calls GC.requestLatency(long) and the Daemon thread continues. Module A shuts down the RMIConnectorServer and does all the right clean-up. The associated LatencyRequest is cancelled but the Daemon thread continues because of the LatencyRequest from Module B. At this point there is a memory leak because the class loader associated with module A is pinned in memory since a reference to it is held by the context class loader field of the Daemon thread. The fix looks to be trivial. Something along the lines of the following around line 146 of GC: d.setContextClassLoader(GC.class.getClassLoader()); It may appear contrived but I have seen exactly this memory leak occur in production systems where multiple web applications were using RMI. If I can provide any further information or if there is better place / way to submit this then please do let me know. Mark

1 0