October 2017 - core-libs-dev

Confusion (or bugs) regarding the 'UNORDERED' Collector Characteristic
by Chris Dennis 02 Nov '17

02 Nov '17

Hi All, I’m very confused about what was intended with the ‘UNORDERED’ Collector characteristic. My logical inference was that unordered as a Collector characteristic meant that the result of this collector applied to any stream was independent of the order of element delivery. This means that the stream backend could safely elide any ordered characteristic of the stream driving the collector and open up more possible execution pathways (parallelism for example). The javadoc for unordered is two sentences: /** * Indicates that the collection operation does not commit to preserving * the encounter order of input elements. (This might be true if the * result container has no intrinsic order, such as a {@link Set}.) */ The first sentence makes sense, although it is phrased in a way that also explains the behavior seen if you flag an order sensitive collector as unordered. The second sentence is weird, it implies a relation between collectors, encounter order, and an inherent ordering or iteration order of a collection object that might be the target of a collection. To me the important property of a Collection object with regards to ordering of a Collector that fills it is whether reordering the insertions to the collection can change the resultant state, for a Set this is clearly true since only the first presented element that is equal will be stored. There is also a paragraph in the Collector javadoc: * For collectors that do not have the {@code UNORDERED} characteristic, * two accumulated results {@code a1} and {@code a2} are equivalent if * {@code finisher.apply(a1).equals(finisher.apply(a2))}. For unordered * collectors, equivalence is relaxed to allow for non-equality related to * differences in order. (For example, an unordered collector that accumulated * elements to a {@code List} would consider two lists equivalent if they * contained the same elements, ignoring order.) This seems weird, why would we try to define correctness of a parallel reduction against a collector that was sensitive to ordering. Finally, when investigating the properties of the collectors returned from the Collectors static factory I was surprised to discover that none of the collectors that are truly unordered were marked as such (counting, min, max, averaging, summing, summarizing), and the only collector that was marked as unordered was Collectors.toSet(), which although it is explicitly marked as unordered seems like it really shouldn’t be. Whats going on here? Which parts of all this are intended and which (if any) are bugs? Thanks in advance for any enlightenment, Chris Dennis P.S. Coincidentally the unordered toSet() collector works perfectly at the moment due to the happy interaction of the Spliterator.trySplit() contract and the folding/combining behavior of the stream implementations parallel reduction algorithm.

2 2

[Bug][JDK10] Fix duplicated "a" occurrences in docs
by Christoph Dreis 02 Nov '17

02 Nov '17

Hey, similar to JDK-8190323 the attached patch removes duplicated "a" occurrences in java.base docs. Would be happy if this is sponsored. I wasn't sure about the capitalization change on EventObject. What's the rule of thumb in cases where the class does not follow the guidelines for docs[1]? Sticking to the overall class scheme or aligning everything? Cheers, Christoph [1] http://www.oracle.com/technetwork/articles/java/index-137868.html

7 10

RFR: JDK-8190439 - Removal of newrmic
by Lance Andersen 31 Oct '17

31 Oct '17

Hi all, Please review the webrev which removes newrmic as newrmic is not used. The webrev can be found at http://cr.openjdk.java.net/~lancea/8190439/webrev.00/ Best Lance <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com <mailto:Lance.Andersen@oracle.com>

4 3

RFR 8190441: ProblemList some intermittent CORBA tests
by Roger Riggs 31 Oct '17

31 Oct '17

Please review some additions to the ProblemList.txt for intermittent CORBA tests. diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -315,8 +315,12 @@ sun/tools/jhsdb/heapconfig/JMapHeapConfi com/sun/jndi/ldap/DeadSSLLdapTimeoutTest.java 8169942 linux-i586,macosx-all,windows-x64 -javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java 8169737 linux-all - +javax/rmi/PortableRemoteObject/8146975/RmiIiopReturnValueTest.java 8169737 generic-all + org/omg/CORBA/OrbPropertiesTest.java 8175177 generic-all +javax/rmi/PortableRemoteObject/ConcurrentHashmapTest.java 8080643 generic-all + +javax/rmi/ssl/SSLSocketParametersTest.sh 8162906 generic-all + ############################################################################ Issue: https://bugs.openjdk.java.net/browse/JDK-8190441 Thanks, Roger p.s. trying out some attachments to check the mail filters

3 2

RFR: 8190287: Update JDK's internal ASM to ASMv6
by Kumar Srinivasan 31 Oct '17

31 Oct '17

Hello Remi, Sundar and others, Please review the webrev [1] to update JDK's internal ASM to v6. To help with review areas, you can use the browser to search for mq patches commented with // Highlights of changes: 1. updated ASMv6 // jdk-new-asmv6.patch 2. changes to jlink and jar to add ModuleMainClass and ModulePackages attributes //jdk-new-asm-update.patch 3. adjustments to jdk tests //jdk-new-asm-test.patch 4. minor adjustments to hotspot tests //jdk-new-hotspot-test.patch Tests: jdk_tier1, jdk_tier2, testset hotspot, hotspot_tier1, nashorn ant tests, Alan has also run several tests. Big thanks to Alan for #2 and #3 as part of [3]. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8190287/webrev.00/index.html [2] https://bugs.openjdk.java.net/browse/JDK-8190287 [3] https://bugs.openjdk.java.net/browse/JDK-8186236

3 3

RFR 8189319 : Add a java.util.Properties constructor that takes an initial capacity
by Brent Christian 30 Oct '17

30 Oct '17

Hi, It would be useful to have a Properties constructor that takes an argument to set the initial capacity. Such a constructor is present on many of the other Map implementations in the JDK, including Hashtable, the superclass of Properties. In particular, being able to specify the initial capacity of the Properties object created to store the system properties could reduce startup time. The current initial capacity of 8 is insufficient. We could eliminate ~25,000 bytecodes currently spent resizing the Properties by creating one of sufficient initial size. There are ~60 system properties in a minimal Java app. I chose 84 - it provides a good amount of wiggle room (and results in an internal ConcurrentHashMap with a table size of 128; 64 would be too small, IMO). Please review this change: Issue: https://bugs.openjdk.java.net/browse/JDK-8189319 Webrev: http://cr.openjdk.java.net/~bchristi/8189319/webrev.01/ Thanks, -Brent

4 6

Versioning of META-INF/services
by Jan Bartel 30 Oct '17

30 Oct '17

I asked this question over on the jdk9-dev list and they suggested I ask it here instead: http://openjdk.java.net/jeps/238 says: "JAR metadata, such as that found in the MANIFEST.MF file and the META-INF/services directory, need not be versioned." Does the language "need not" actually mean "is not", or is the intention to leave the door open to versioning of META-INF/services? If it is possible to version services, is there any requirement that the annotations on a service must be the same for all versions of that service in a multi-release jar? The motivation for the question is a scenario where we need to support build and pre-deployment discovery of services on a different version of the jvm (ie 9) to deployment/runtime (ie 8). During discovery we examine services returned from the ServiceLoader for particular annotations, such as the @HandlesTypes annotation from the servlet spec. If services can be versioned, and annotations may be different between versions, we would need some support from the jvm to be able to ensure we examine the correct version for the target runtime jvm version. thanks, Jan -- Jan Bartel <janb(a)webtide.com> www.webtide.com *Expert assistance from the creators of Jetty and CometD*

1 0

JDK-8067661: transferTo proposal for Appendable
by Patrick Reinhart 30 Oct '17

30 Oct '17

Hi There, Based on the *transferTo* Method on the InputStream I would propose to introduce a default method on the Readable interface. In that way the method can be used for all existing implementations of Readable and still be implemented in a special way by a individual implementer. /** * Reads all characters from this readable and writes the characters to * the given appendable in the order that they are read. On return, this * readable will be at end its data. * * This method may block indefinitely reading from the readable, or * writing to the appendable. The behavior for the case where the readable * and/or appendable is asynchronously closed, or the thread * interrupted during the transfer, is highly readable and appendable * specific, and therefore not specified. * * If an I/O error occurs reading from the readable or writing to the * appendable, then it may do so after some characters have been read or * written. Consequently the readable may not be at end of its data and * one, or both participants may be in an inconsistent state. That in mind * all additional measures required by one or both participants in order to * eventually free their internal resources have to be taken by the caller * of this method. * * @param out the appendable, non-null * @return the number of characters transferred * @throws IOException if an I/O error occurs when reading or writing * @throws NullPointerException if {@code out} is {@code null} * * @since 18.3 */ default long transferTo(Appendable out) throws IOException { .... } Cheers Patrick

2 2

RFR (JDK10/JAXP) 8181155: Fix lint warnings in JAXP repo: fallthrough and static
by Joe Wang 30 Oct '17

30 Oct '17

Hi, Please review a cleanup of fallthrough and static warnings. For fallthrough, the majority of the changes are suppressing the warnings, while for static, replacing the instances with the class. All jaxp tests and JCK passed. JBS: https://bugs.openjdk.java.net/browse/JDK-8181155 webrevs: http://cr.openjdk.java.net/~joehw/jdk10/8181155/webrev/index.html Thanks, Joe

4 7

[Bug][JDK10] Fix duplicated "the" occurrences in docs and inline comments
by Christoph Dreis 30 Oct '17

30 Oct '17

Hey, Just noticed an occurrence of a duplicated "the" in a Locale doc and looked for other occurrences in java.base while being on it. I don't know if documentation changes follow a special workflow because of possible translations. Please let me know! But I'd be happy if this is sponsored or moved to the appropriate mailing list. Cheers, Christoph ===== PATCH ====== diff -r 359c604930af src/java.base/share/classes/java/lang/WeakPairMap.java --- a/src/java.base/share/classes/java/lang/WeakPairMap.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/java/lang/WeakPairMap.java Sun Oct 29 16:13:11 2017 +0100 @@ -88,7 +88,7 @@ * Maps the specified key pair to the specified value in this WeakPairMap. * Neither the keys nor the value can be null. * The value can be retrieved by calling the {@link #get} method - * with the the same keys (compared by identity). + * with the same keys (compared by identity). * * @param k1 the 1st of the pair of keys with which the specified value is to * be associated diff -r 359c604930af src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java --- a/src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java Sun Oct 29 16:13:11 2017 +0100 @@ -1196,7 +1196,7 @@ static MethodHandle bindCaller(MethodHandle mh, Class<?> hostClass) { - // Code in the the boot layer should now be careful while creating method handles or + // Code in the boot layer should now be careful while creating method handles or // functional interface instances created from method references to @CallerSensitive methods, // it needs to be ensured the handles or interface instances are kept safe and are not passed // from the boot layer to untrusted code. diff -r 359c604930af src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java --- a/src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java Sun Oct 29 16:13:11 2017 +0100 @@ -195,7 +195,7 @@ // In case we need to double-back onto the StringConcatFactory during this // static initialization, make sure we have the reasonable defaults to complete // the static initialization properly. After that, actual users would use the - // the proper values we have read from the the properties. + // the proper values we have read from the properties. STRATEGY = DEFAULT_STRATEGY; // CACHE_ENABLE = false; // implied // CACHE = null; // implied diff -r 359c604930af src/java.base/share/classes/java/util/Locale.java --- a/src/java.base/share/classes/java/util/Locale.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/java/util/Locale.java Sun Oct 29 16:13:11 2017 +0100 @@ -1909,7 +1909,7 @@ * Returns a name for the locale that is appropriate for display to the * user. This will be the values returned by getDisplayLanguage(), * getDisplayScript(), getDisplayCountry(), and getDisplayVariant() assembled - * into a single string. The the non-empty values are used in order, + * into a single string. The non-empty values are used in order, * with the second and subsequent names in parentheses. For example: * <blockquote> * language (script, country, variant) diff -r 359c604930af src/java.base/share/classes/java/util/ServiceLoader.java --- a/src/java.base/share/classes/java/util/ServiceLoader.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/java/util/ServiceLoader.java Sun Oct 29 16:13:11 2017 +0100 @@ -1409,7 +1409,7 @@ * * To achieve laziness the actual work of locating providers is done * when processing the stream. If a service provider cannot be loaded for any - * of the the reasons specified in the <a href="#errors">Errors</a> section + * of the reasons specified in the <a href="#errors">Errors</a> section * above then {@link ServiceConfigurationError} is thrown by whatever method * caused the service provider to be loaded. * diff -r 359c604930af src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java --- a/src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java Sun Oct 29 16:13:11 2017 +0100 @@ -66,7 +66,7 @@ * -m and --add-modules options. The modules are located on a module path that * is constructed from the upgrade module path, system modules, and application * module path. The Configuration is instantiated as the boot layer with each - * module in the the configuration defined to a class loader. + * module in the configuration defined to a class loader. */ public final class ModuleBootstrap { diff -r 359c604930af src/java.base/share/classes/jdk/internal/module/ModuleHashesBuilder.java --- a/src/java.base/share/classes/jdk/internal/module/ModuleHashesBuilder.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/jdk/internal/module/ModuleHashesBuilder.java Sun Oct 29 16:13:11 2017 +0100 @@ -74,7 +74,7 @@ * the outgoing edges from M to non-candidate modules. */ public Map<String, ModuleHashes> computeHashes(Set<String> roots) { - // build a graph containing the the packaged modules and + // build a graph containing the packaged modules and // its transitive dependences matching --hash-modules Graph.Builder<String> builder = new Graph.Builder<>(); Deque<ResolvedModule> deque = new ArrayDeque<>(configuration.modules()); diff -r 359c604930af src/java.base/share/classes/jdk/internal/module/Resources.java --- a/src/java.base/share/classes/jdk/internal/module/Resources.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/jdk/internal/module/Resources.java Sun Oct 29 16:13:11 2017 +0100 @@ -56,7 +56,7 @@ /** * Derive a package name for a resource. The package name * returned by this method may not be a legal package name. This method - * returns null if the the resource name ends with a "/" (a directory) + * returns null if the resource name ends with a "/" (a directory) * or the resource name does not contain a "/". */ public static String toPackageName(String name) { diff -r 359c604930af src/java.base/share/classes/jdk/internal/org/objectweb/asm/Frame.java --- a/src/java.base/share/classes/jdk/internal/org/objectweb/asm/Frame.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/jdk/internal/org/objectweb/asm/Frame.java Sun Oct 29 16:13:11 2017 +0100 @@ -192,7 +192,7 @@ private static final int LOCAL = 0x2000000; /** - * Kind of the the types that are relative to the stack of an input stack + * Kind of the types that are relative to the stack of an input stack * map frame. The value of such types is a position relatively to the top of * this stack. */ diff -r 359c604930af src/java.base/share/classes/sun/security/provider/certpath/ResponderId.java --- a/src/java.base/share/classes/sun/security/provider/certpath/ResponderId.jav a Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/sun/security/provider/certpath/ResponderId.jav a Sun Oct 29 16:13:11 2017 +0100 @@ -119,7 +119,7 @@ * When encoded in DER this object will use the byKey option, a * SHA-1 hash of the responder's public key. * - * @param pubKey the the OCSP responder's public key + * @param pubKey the OCSP responder's public key * * @throws IOException if the internal DER-encoding of the * {@code KeyIdentifier} fails. diff -r 359c604930af src/java.base/share/classes/sun/security/provider/certpath/SunCertPathBuilde rException.java --- a/src/java.base/share/classes/sun/security/provider/certpath/SunCertPathBuil derException.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/sun/security/provider/certpath/SunCertPathBuil derException.java Sun Oct 29 16:13:11 2017 +0100 @@ -94,7 +94,7 @@ } /** - * Creates a <code>SunCertPathBuilderException</code> withe the specified + * Creates a <code>SunCertPathBuilderException</code> with the specified * detail message and adjacency list. * * @param msg the detail message diff -r 359c604930af src/java.base/share/classes/sun/security/ssl/CertStatusReqItemV2.java --- a/src/java.base/share/classes/sun/security/ssl/CertStatusReqItemV2.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/sun/security/ssl/CertStatusReqItemV2.java Sun Oct 29 16:13:11 2017 +0100 @@ -145,7 +145,7 @@ * @return the encoded length of this {@code CertStatusReqItemV2} */ int length() { - // The length is the the status type (1 byte) + the request length + // The length is the status type (1 byte) + the request length // field (2 bytes) + the StatusRequest data length. return request.length() + 3; } diff -r 359c604930af src/java.base/share/classes/sun/security/ssl/MAC.java --- a/src/java.base/share/classes/sun/security/ssl/MAC.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/sun/security/ssl/MAC.java Sun Oct 29 16:13:11 2017 +0100 @@ -188,7 +188,7 @@ * @param type record type * @param bb a ByteBuffer in which the position and limit * demarcate the data to be MAC'd. - * @param isSimulated if true, simulate the the MAC computation + * @param isSimulated if true, simulate the MAC computation * * @return the MAC result */ diff -r 359c604930af src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java --- a/src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/sun/security/ssl/TrustStoreManager.java Sun Oct 29 16:13:11 2017 +0100 @@ -333,7 +333,7 @@ } /** - * Load the the KeyStore as described in the specified descriptor. + * Load the KeyStore as described in the specified descriptor. */ private static KeyStore loadKeyStore( TrustStoreDescriptor descriptor) throws Exception { diff -r 359c604930af src/java.base/share/classes/sun/text/normalizer/Trie2.java --- a/src/java.base/share/classes/sun/text/normalizer/Trie2.java Fri Oct 27 09:51:48 2017 -0700 +++ b/src/java.base/share/classes/sun/text/normalizer/Trie2.java Sun Oct 29 16:13:11 2017 +0100 @@ -592,7 +592,7 @@ // may be lower when iterating over the code points for a single lead surrogate. private int limitCP; - // True while iterating over the the Trie2 values for code points. + // True while iterating over the Trie2 values for code points. // False while iterating over the alternate values for lead surrogates. private boolean doingCodePoints = true;

2 3