December 2017 - core-libs-dev

Re: Fw: Question about JEP 306.
by David Holmes 06 Dec '17

06 Dec '17

Adding core-libs-dev as both mailing lists are named in this JEP. David On 6/12/2017 11:02 AM, A Z wrote: > -I have been wondering what interest, focus or progress > > is happening around OpenJDK JEP 306: > > > http://openjdk.java.net/jeps/306 > > > -As a Java feature request, could I request feature 306? > Underflow and overflow need to be eliminated > from double and float. > > There could be an associativefp option. It should also be the case > that there should be a round half up for the decimal place > beyond the last one in the float or double range, to help support > all notions of > > (pow(sqrt(3),2) == 3) //true > > > -The other thing that there should be is a StrictMath > that works for BigInteger and BigDecimal, allowing: > > pow(BigDecimal,BigDecimal) > pi(...) > e(...) > sin(Bigdecimal) > asin(Bigdecimal) ... > > which would allow for any power at all, as well as the nth root. > It is also a good idea to include a radians and degrees version > of all the trig functions. >

3 2

Proposal for New Functionality: Allow module-info merging in GenModuleInfoSource.java
by Adam Farley8 06 Dec '17

06 Dec '17

Hi All, Currently, GenModuleInfoSource.java does not allow you to merge extra module-info files into the primary module-info file (for a given module) at build time. Put simply; I think it should have this functionality. Can committers please review and opine? You can already see this code change in action while compiling OpenJDK with OpenJ9, so we know it works. I've included the "diff -u" output for the proposed code change in this email's P.S. Best Regards Adam Farley P.S. Code diff: --- original_GenModuleInfoSource.java 2017-12-06 15:46:43.000000000 +0000 +++ improved_GenModuleInfoSource.java 2017-12-06 15:49:04.000000000 +0000 @@ -1,4 +1,10 @@ /* + * =========================================================================== + * (c) Copyright IBM Corp. 2015, 2017 All Rights Reserved + * =========================================================================== + */ + +/* * Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * @@ -156,12 +162,12 @@ } // requires - for (String l : lines) { - if (l.trim().startsWith("requires")) - writer.println(l); - } + //for (String l : lines) { + // if (l.trim().startsWith("requires")) + // writer.println(l); + //} - // write exports, opens, uses, and provides + // write requires, exports, opens, uses, and provides moduleInfo.print(writer); // close @@ -171,12 +177,13 @@ class ModuleInfo { + final Map<String, Statement> requires = new HashMap<>(); final Map<String, Statement> exports = new HashMap<>(); final Map<String, Statement> opens = new HashMap<>(); final Map<String, Statement> uses = new HashMap<>(); final Map<String, Statement> provides = new HashMap<>(); - Statement getStatement(String directive, String name) { + Statement getStatement(String directive, String qualifier, String name) { switch (directive) { case "exports": if (moduleInfo.exports.containsKey(name) && @@ -205,6 +212,10 @@ return uses.computeIfAbsent(name, _n -> new Statement("uses", "", name)); + case "requires": + return uses.computeIfAbsent(name, + _n -> new Statement("requires", qualifier, name)); + case "provides": return provides.computeIfAbsent(name, _n -> new Statement("provides", "with", name, true)); @@ -233,7 +244,7 @@ .stream() .filter(e -> !exports.containsKey(e.getKey()) && e.getValue().filter(modules)) - .forEach(e -> addTargets(getStatement("exports", e.getKey()), + .forEach(e -> addTargets(getStatement("exports", null, e.getKey()), e.getValue(), modules)); @@ -251,7 +262,7 @@ .stream() .filter(e -> !opens.containsKey(e.getKey()) && e.getValue().filter(modules)) - .forEach(e -> addTargets(getStatement("opens", e.getKey()), + .forEach(e -> addTargets(getStatement("opens", null, e.getKey()), e.getValue(), modules)); @@ -272,6 +283,12 @@ .stream() .filter(service -> !uses.containsKey(service)) .forEach(service -> uses.put(service, extraFiles.uses.get(service))); + + // requires + extraFiles.requires.keySet() + .stream() + .filter(require -> !requires.containsKey(require)) + .forEach(require -> requires.put(require, extraFiles.requires.get(require))); } // add qualified exports or opens to known modules only @@ -324,6 +341,11 @@ void print(PrintWriter writer) { + // requires + requires.entrySet().stream() + .sorted(Map.Entry.comparingByKey()) + .forEach(e -> writer.println(e.getValue())); + // print unqualified exports exports.entrySet().stream() .filter(e -> e.getValue().targets.isEmpty()) @@ -418,27 +440,45 @@ String keyword = s[0].trim(); String name = s.length > 1 ? s[1].trim() : null; + String requiresModifiedName1 = s.length > 2 ? s[2].trim() : null; + String requiresModifiedName2 = s.length > 3 ? s[3].trim() : null; trace("%d: %s index=%d len=%d%n", lineNumber, l, index, l.length()); switch (keyword) { case "module": - case "requires": case "}": index = l.length(); // skip to the end continue; + case "requires": case "exports": case "opens": case "provides": case "uses": + String requiresQualifier = null; // assume name immediately after exports, opens, provides, uses - statement = getStatement(keyword, name); + if (keyword.equals("requires")) { + if (requiresModifiedName2 != null) { // 2 modifiers specified + if ((name.equals("transitive") || name.equals("static")) && + (requiresModifiedName1.equals("transitive") || requiresModifiedName1.equals("static"))) { + requiresQualifier = "static transitive"; + name = requiresModifiedName2; + } + } else if (requiresModifiedName1 != null) { // 1 modifier specified + if (name.equals("transitive") || name.equals("static")) { + requiresQualifier = name; + name = requiresModifiedName1; + } + } + } + + statement = getStatement(keyword, requiresQualifier, name); hasTargets = false; int i = l.indexOf(name, keyword.length()+1) + name.length() + 1; l = i < l.length() ? l.substring(i, l.length()).trim() : ""; index = 0; - if (s.length >= 3) { + if (!keyword.equals("requires") && s.length >= 3) { if (!s[2].trim().equals(statement.qualifier)) { throw new RuntimeException(sourcefile + ", line " + lineNumber + ", is malformed: " + s[2]); @@ -594,17 +634,25 @@ @Override public String toString() { StringBuilder sb = new StringBuilder(" "); - sb.append(directive).append(" ").append(name); - if (targets.isEmpty()) { - sb.append(";"); - } else if (targets.size() == 1) { - sb.append(" ").append(qualifier) - .append(orderedTargets().collect(joining(",", " ", ";"))); + if (directive.equals("requires")) { + if (qualifier != null) { + sb.append(directive).append(" ").append(qualifier).append(" ").append(name).append(";"); + } else { + sb.append(directive).append(" ").append(name).append(";"); + } } else { - sb.append(" ").append(qualifier) - .append(orderedTargets() - .map(target -> String.format(" %s", target)) - .collect(joining(",\n", "\n", ";"))); + sb.append(directive).append(" ").append(name); + if (targets.isEmpty()) { + sb.append(";"); + } else if (targets.size() == 1) { + sb.append(" ").append(qualifier) + .append(orderedTargets().collect(joining(",", " ", ";"))); + } else { + sb.append(" ").append(qualifier) + .append(orderedTargets() + .map(target -> String.format(" %s", target)) + .collect(joining(",\n", "\n", ";"))); + } } return sb.toString(); } @@ -620,4 +668,4 @@ System.out.format(fmt, params); } } -} +} \ No newline at end of file Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

2 1

RFR: JDK-8190187: C++ code calling JNI_CreateJavaVM can be killed by Java
by Adam Farley8 06 Dec '17

06 Dec '17

Hi All, We have a bug in OpenJDK where if you pass an info-only option (like -agentlib:jdwp=help) in through the JNI interface, it can exit your code with RC 0. I think this is a bug because if you planned to do anything after starting a Java VM, you have to do it in an exit hook. If an info-only option is used, exit(0) should not happen. Instead, the user's code should be told the VM cannot be used. Bug Link: https://bugs.openjdk.java.net/browse/JDK-8190187 I have proposed the creation of a new JNI return code indicating a "silent exit", where the vm encountered no error, but that it is not in a fit state to be used. See the link for an implementation of this, along with a handy test. In short, if you agree that this is a problem, we need a champion to: 1) Complete the CSR process for the new JNI Return code. 2) Commit the changes that contain (a) the new return code, and (b) the non-Hotspot code that handles the new code. Optionally, if you want to commit the code containing an example of the fix, you will need to: 3) Commit the Hotspot code that channels the new return code. 4) Complete the CSR process for the jdwp behaviour change. 5) Commit the jdwp code. Note that all of this code has *already been written*. This should be an easy commit once the CSR is done with. Best Regards Adam Farley Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

1 0

RFR 8080225 FileInput/OutputStream/FileChannel cleanup should be improved
by Roger Riggs 05 Dec '17

05 Dec '17

Please review a revision to the work on remove a dependency on finalization from FileInputStream, FileOutputStream, and add cleanup of closing file descriptors in FileChannel. The previous version was too aggressive in removing the finalize method and was considered to be insufficiently backward compatible. For compatibility with previous versions, the close method will be called when the FIS/FOS is unreachable only when FIS/FOS has been subclassed to override close() or finalize(). In other cases, the cleaner is used to make sure the FileDescriptor is closed. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-fis-cleanup-8080225/ Issue: https://bugs.openjdk.java.net/browse/JDK-8080225 CSR: Relax FileInputStream/FileOutputStream requirement to use finalize https://bugs.openjdk.java.net/browse/JDK-8187325 Thanks, Roger

3 4

RFR 8015667 Stream.toArray(IntFunction) ArrayStoreException should refer to component type of array
by Paul Sandoz 05 Dec '17

05 Dec '17

Hi, Since Stuart is cleaning up Collection.toArray etc we might as well do the same for Stream.toArray. diff -r df95bd1fd4b1 src/java.base/share/classes/java/util/stream/Stream.java --- a/src/java.base/share/classes/java/util/stream/Stream.java Tue Dec 05 09:44:32 2017 -0800 +++ b/src/java.base/share/classes/java/util/stream/Stream.java Tue Dec 05 10:32:27 2017 -0800 @@ -671,7 +671,8 @@ * <p>This is a <a href="package-summary.html#StreamOps">terminal * operation</a>. * - * @return an array containing the elements of this stream + * @return an array, whose {@linkplain Class#getComponentType runtime component + * type} is {@code Object}, containing the elements of this stream */ Object[] toArray(); @@ -694,13 +695,13 @@ * .toArray(Person[]::new); * }</pre> * - * @param <A> the element type of the resulting array + * @param <A> the component type of the resulting array * @param generator a function which produces a new array of the desired * type and the provided length * @return an array containing the elements in this stream - * @throws ArrayStoreException if the runtime type of the array returned - * from the array generator is not a supertype of the runtime type of every - * element in this stream + * @throws ArrayStoreException if the runtime type of any element of this + * stream is not assignable to the {@linkplain Class#getComponentType + * runtime component type} of the generated array */ <A> A[] toArray(IntFunction<A[]> generator); Paul.

2 1

RFR: 8193064: JarFile::getEntry0 method reference use cause for startup regression
by Claes Redestad 05 Dec '17

05 Dec '17

Hi, desugaring the JarFileEntry::new in JarFile::getEntry0 avoids a hefty startup regression on our smallest startup tests: http://cr.openjdk.java.net/~redestad/8193064/open.00/ I think the implementation could be improved further by using static non-capturing functions rather than Jar-/ZipFileEntry::new (which, since they reference a non static class constructor, are implicitly capturing) and filed: https://bugs.openjdk.java.net/browse/JDK-8193066 Thanks! /Claes

3 4

RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error
by Brent Christian 05 Dec '17

05 Dec '17

Hi, Please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8187222 Webrev: http://cr.openjdk.java.net/~bchristi/8187222/webrev.00/ The method description of ClassLoader.getSystemClassLoader() states (in regards to setting a custom system classloader): "If circular initialization of the system class loader is detected then an unspecified error or exception is thrown." This ambiguity in the method description can and should be removed. The method also has a @throws tag: * @throws IllegalStateException * If invoked recursively during the construction of the class * loader specified by the "{@code java.system.class.loader}" * property. JDK 8 threw an IllegalStateException. This changed to an InternalError in 9b111[1]. Throwing an IllegalStateException conforms to the @throws tag, and returns to the previous behavior of JDK 8 and (earlier on in) 9. Also, as Alan points out in the bug, an InternalError looks like a bug in the JDK itself, whereas IllegalStateException better reflects that the issue likely lies in the custom classloader. Automated build & test job passes cleanly. Thanks, -Brent 1. https://bugs.openjdk.java.net/browse/JDK-8142968

3 10

RFR: 8193031: Collections.addAll is likely to perform worse than Collection.addAll
by Martin Buchholz 05 Dec '17

05 Dec '17

https://bugs.openjdk.java.net/browse/JDK-8193031 http://cr.openjdk.java.net/~martin/webrevs/jdk/Collections-addAll/

3 2

RFR: 8176188: jdk/internal/misc/JavaLangAccess/NewUnsafeString.java failing since 9-b93
by Claes Redestad 05 Dec '17

05 Dec '17

Hi, the compact strings JEP changed semantics of the package-private String(char[], boolean) constructor to do the same as the public String(char[]) constructor. Previously the former was used in trusted, internal code to avoid copying the given char[], but since the char[] now has to be converted to a byte[] that optimization is no longer possible via this method[1], and tests that checked that the returned string shared the given char[] naturally stopped working. To fix this bug I propose the following clean-up: - change all uses of JavaLangAccess.newUnsafeString(char[]) to new String(char[]) - remove the package-private String(char[], boolean) constructor - remove the newUnsafeString from JavaLangAccess - remove the now unnecessary NewUnsafeString test Patch: http://cr.openjdk.java.net/~redestad/8176188/open.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8176188 Thanks! /Claes [1] For some of the usages here we could improve somewhat by exposingthe String(byte[], byte) constructor, but I think that's out of scope here and I think we'd best avoid leaking the coder byte implementation detail outside of java.lang.

5 7

RFR 8192958 [JDK10] : TEST.groups: group jdk_util_other: file not found: jdk/internal/util
by Muneer Kolarkunnu 04 Dec '17

04 Dec '17

Hi, Please review the fix for JDK- 8192958. Bug: https://bugs.openjdk.java.net/browse/JDK-8192958 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8192958/webrev.00/ Issue: There was only one test case under the folder "jdk/internal/util" which was jdk/internal/util/jar/VersionedStream.java. This test case has removed by task JDK-8192879. Fix: Remove entry "jdk/internal/util" from test group jdk_util_other Regards, Muneer

3 2