February 2018 - core-libs-dev

RFR: 8011697(ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one)
by Srinivas Dama 02 Feb '18

02 Feb '18

Hi, Please review http://cr.openjdk.java.net/~sdama/8011697/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8011697 Fix is to make sure ScriptEngineManager always returns a particular engine on all platforms consistently. Regards, Srinivas

3 7

JDK-8196298: Add null Reader and Writer
by Patrick Reinhart 01 Feb '18

01 Feb '18

Hi there, I saw that great extension on InputStream/OutputStream adding a Null implementation there. Based on those I would propose a similar addition to the Reader/Writer. -Patrick Here is what the API would look like based on the existing from InputStream/OutputStream: /** * Returns a new {@code Reader} that contains no characters. The returned * stream is initially open. The stream is closed by calling the * {@code close()} method. Subsequent calls to {@code close()} have no * effect. * * <p> While the stream is open, the {@code ready()}, {@code read()}, * {@code read(char[])}, {@code read(char[], int, int)}, {@code skip()}, and * {@code transferTo()} methods all behave as if end of stream has been * reached. After the stream has been closed, these methods all throw * {@code IOException}. * * <p> The {@code markSupported()} method returns {@code false}. The * {@code mark()} method does nothing, and the {@code reset()} method * throws {@code IOException}. * * @return an {@code Reader} which contains no characters * * @since 11 */ public static Reader nullReader() {} /** * Returns a new {@code Writer} which discards all characters. The * returned stream is initially open. The stream is closed by calling * the {@code close()} method. Subsequent calls to {@code close()} have * no effect. * * <p> While the stream is open, the {@code write(int)}, {@code * write(char[])}, and {@code write(char[], int, int)} methods do nothing. * After the stream has been closed, these methods all throw {@code * IOException}. * * <p> The {@code flush()} method does nothing. * * @return an {@code Writer} which discards all characters * * @since 11 */ public static Writer nullWriter() {}

3 9

Clarification for adding classes shipped with JDK to sun.rmi.registry.registryFilter property in java.security file
by Vipin Mv1 01 Feb '18

01 Feb '18

Hi, After upgrading to oracle 8u121-b12, I get following Exception when running the following testcase. import java.io.*; import java.net.InetAddress; import java.rmi.*; import java.rmi.registry.*; import java.security.Security; /* @test * @run main/othervm RegistryFilterTest */ public class RegistryFilterTest { private static int port = 12345; private static Registry registry; static class RemoteObj implements Serializable, Remote { private static final long serialVersionUID = 01L; final Object obj; RemoteObj(Object obj) { this.obj = obj; } } public static void main(String[] args) throws Exception{ InetAddress in = InetAddress.getLocalHost(); LocateRegistry.createRegistry(port); Registry registry = LocateRegistry.getRegistry("localhost", port); registry.bind("InetAddress", new RemoteObj(in)); registry.unbind("InetAddress"); System.out.println("RMI Registry Test Passed"); } } TestResults ----------------------- Jan 12, 2018 5:32:18 PM java.io.ObjectInputStream filterCheck INFO: ObjectInputFilter REJECTED: class java.net.InetAddress, array length: -1, nRefs: 5, depth: 2, bytes: 216, ex: n/a Caused by: java.io.InvalidClassException: filter status: REJECTED at java.io.ObjectInputStream.filterCheck(ObjectInputStream.java:1406) at java.io.ObjectInputStream.readNonProxyDesc (ObjectInputStream.java:1997) at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1877) at java.io.ObjectInputStream.readOrdinaryObject (ObjectInputStream.java:2170) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1698) at java.io.ObjectInputStream.defaultReadFields (ObjectInputStream.java:2415) at java.io.ObjectInputStream.readSerialData (ObjectInputStream.java:2339) at java.io.ObjectInputStream.readOrdinaryObject (ObjectInputStream.java:2197) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1698) at java.io.ObjectInputStream.readObjectImpl(ObjectInputStream.java:540) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:475) ... 16 more I understand it is due to the new serialization Filtering mechanism introduced to RMI Registry and Distributed Garbage Collection as a part of the following fixes. JDK-8160108 Implement Serialization Filtering JDK-8156804: Better constraint checking(not public) As a result, a new default white list has been introduced for RMIRegistry which allows deserialization only to limited set of classes by default. Which are String.class java.lang.Number.class java.rmi.Remote.class java.lang.reflect.Proxy.class sun.rmi.server.UnicastRef.class java.rmi.server.RMIClientSocketFactory.class java.rmi.server.RMIServerSocketFactory.class java.rmi.activation.ActivationID.class java.rmi.server.UID.class and their subclasses. It also enabled provisions to increase the default white list by 1. updating property "sun.rmi.registry.registryFilter" in java.security file 2. adding -Dsun.rmi.registry.registryFilter in java command line Though the current solution is straight forward, it is difficult from an application point of view to identify such classes without running the application multiple times to come up with comprehensive list to be allowed. This would be a overhead to the developer and should be avoided at least for classes shipped with JDK (for example, java.net.InetAddress as used in testcase). I assume that default list is very limited to reduce the chances of getting exploited by serialization vulnerability. I think, we can spare public packages shipped with JDK by adding them to "sun.rmi.registry.registryFilter" in java.security file out of the box. Please let me know your views. Thanks & Regards, Vipin MV

3 3

java.time.Instant.getEpochSeconds() javadocs still has a typo (JDK-8167166)
by Kurt Alfred Kluever 01 Feb '18

01 Feb '18

Hey folks, I had a quick question about the javadocs of this method. It looks like the `getNanosOfSecond` -> `getNano` mistake was fixed <https://bugs.openjdk.java.net/browse/JDK-8167166>, but the Java9 docs still claim that `getNano()` returns "the nanosecond part of the day" <https://docs.oracle.com/javase/9/docs/api/java/time/Instant.html#getEpochSe…> . It should be "the nanosecond part of the *second*". (Apologies if this isn't the correct way to report things like this...) -- kak

2 1

RFR (JDK11/JAXP) 8193830: Xalan Update: Xalan Java 2.7.2
by Joe Wang 01 Feb '18

01 Feb '18

Hi, Please review an update to Xalan 2.7.2 release. JBS: https://bugs.openjdk.java.net/browse/JDK-8193830 webrev: http://cr.openjdk.java.net/~joehw/jdk11/8193830/webrev/index.html Thanks, Joe

3 2

[11] 8196583 Update jib and test jtreg version to 4.2 b12
by Paul Sandoz 01 Feb '18

01 Feb '18

Hi, The constant dynamic test i recently updated and pushed to hs [*] requires a later version of jtreg to execute correctly (it requires an updated version of asmtools bundled with jtreg). Here are the changes: diff -r 11920d5d14a8 make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Wed Jan 31 17:43:46 2018 -0800 +++ b/make/conf/jib-profiles.js Thu Feb 01 10:39:38 2018 -0800 @@ -829,7 +829,7 @@ jtreg: { server: "javare", revision: "4.2", - build_number: "b11", + build_number: "b12", checksum_file: "MD5_VALUES", file: "jtreg_bin-4.2.zip", environment_name: "JT_HOME", diff -r 11920d5d14a8 test/hotspot/jtreg/TEST.ROOT --- a/test/hotspot/jtreg/TEST.ROOT Wed Jan 31 17:43:46 2018 -0800 +++ b/test/hotspot/jtreg/TEST.ROOT Thu Feb 01 10:39:38 2018 -0800 @@ -58,7 +58,7 @@ docker.support # Minimum jtreg version -requiredVersion=4.2 b11 +requiredVersion=4.2 b12 # Path to libraries in the topmost test directory. This is needed so @library # does not need ../../../ notation to reach them diff -r 11920d5d14a8 test/jaxp/TEST.ROOT --- a/test/jaxp/TEST.ROOT Wed Jan 31 17:43:46 2018 -0800 +++ b/test/jaxp/TEST.ROOT Thu Feb 01 10:39:38 2018 -0800 @@ -23,7 +23,7 @@ groups=TEST.groups # Minimum jtreg version -requiredVersion=4.2 b11 +requiredVersion=4.2 b12 # Path to libraries in the topmost test directory. This is needed so @library # does not need ../../ notation to reach them diff -r 11920d5d14a8 test/jdk/TEST.ROOT --- a/test/jdk/TEST.ROOT Wed Jan 31 17:43:46 2018 -0800 +++ b/test/jdk/TEST.ROOT Thu Feb 01 10:39:38 2018 -0800 @@ -40,7 +40,7 @@ vm.cds # Minimum jtreg version -requiredVersion=4.2 b11 +requiredVersion=4.2 b12 # Path to libraries in the topmost test directory. This is needed so @library # does not need ../../ notation to reach them diff -r 11920d5d14a8 test/langtools/TEST.ROOT --- a/test/langtools/TEST.ROOT Wed Jan 31 17:43:46 2018 -0800 +++ b/test/langtools/TEST.ROOT Thu Feb 01 10:39:38 2018 -0800 @@ -15,7 +15,7 @@ groups=TEST.groups # Minimum jtreg version -requiredVersion=4.2 b11 +requiredVersion=4.2 b12 # Use new module options useNewOptions=true diff -r 11920d5d14a8 test/nashorn/TEST.ROOT --- a/test/nashorn/TEST.ROOT Wed Jan 31 17:43:46 2018 -0800 +++ b/test/nashorn/TEST.ROOT Thu Feb 01 10:39:38 2018 -0800 @@ -8,7 +8,7 @@ groups=TEST.groups # Minimum jtreg version -requiredVersion=4.2 b11 +requiredVersion=4.2 b12 # Use new module options useNewOptions=true Paul. [*] http://hg.openjdk.java.net/jdk/hs/rev/11920d5d14a8

3 2

[11] RFR 8195694: ConstantBootstraps.invoke does not preserve variable arity
by Paul Sandoz 01 Feb '18

01 Feb '18

Hi, Please review this fix to the invoke BSM so that it preserves variable arity, if any: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8195694-constant-bsms-invoke-ar… <http://cr.openjdk.java.net/~psandoz/jdk/JDK-8195694-constant-bsms-invoke-ar…> This will be pushed to the hs repo. Thanks, Paul.

2 4

[11] RFR 8196533 Update CondyNestedTest.java to compile jcod file
by Paul Sandoz 01 Feb '18

01 Feb '18

Hi, Please review an update to a constant dynamic test that updates to compile the jcod file rather than loading a class from class file bytes encoded in a base64 string: http://cr.openjdk.java.net/~psandoz/jdk/JDK-8196533-CondyNestedTest-compile… <http://cr.openjdk.java.net/~psandoz/jdk/JDK-8196533-CondyNestedTest-compile…> This will be pushed to the hs repo. Thanks, Paul.

2 1