May 2018 - core-libs-dev

RFR(JDK11/NIO) 8202285: (fs) Add a method to Files for comparing file contents
by Joe Wang 02 May '18

02 May '18

Hi, Considering extending isSameFile to add isSameContent to Files. Please review. JBS: https://bugs.openjdk.java.net/browse/JDK-8202285 webrev: http://cr.openjdk.java.net/~joehw/jdk11/8202285/webrev/ specdiff: http://cr.openjdk.java.net/~joehw/jdk11/8202285/specdiff/java/nio/file/File… Thanks, Joe

10 23

8202507: Remove IO and NIO AtomicAppend tests from problem list
by Brian Burkhalter 01 May '18

01 May '18

Please review this simple fix for [1]. Somehow this did not make it into the patch I checked in to fix [2]. Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8202507 [2] https://bugs.openjdk.java.net/browse/JDK-8202284 --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -510,7 +510,6 @@ # jdk_io -java/io/FileOutputStream/AtomicAppend.java 8202062 macosx-all java/io/pathNames/GeneralWin32.java 8180264 windows-all java/io/FileInputStream/UnreferencedFISClosesFd.java 8202292 linux-all @@ -552,8 +551,6 @@ java/nio/channels/DatagramChannel/ChangingAddress.java 7141822 macosx-all -java/nio/channels/FileChannel/AtomicAppend.java 8202062 macosx-all - java/nio/channels/Selector/Wakeup.java 6963118 windows-all java/nio/file/WatchService/Basic.java 7158947 solaris-all Solaris 11

2 1

RFR: 8195717: test java/lang/invoke/MethodHandlesTest timed out running testAsCollector1
by Vivek Theeyarath 01 May '18

01 May '18

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8195717 . http://cr.openjdk.java.net/~vtheeyarath/8195717/webrev.02/ The test class has been re factored into multiple classes with the existing MethodHandlesTest.java being made abstract. Testing Done: All the 7 test classes were run using jtreg with the additional VM params mentioned in the bug. Please find attached a text file with the relevant section of the jtr file (each test run 5 times) which includes the timing. Regards Vivek

2 1

[11] RFR (XS): 8202484: Unused field in TimeZone
by Naoto Sato 01 May '18

01 May '18

Hi, Please review this cleanup in TimeZone class, where an unused field is removed. Naoto -- diff -r 7fed08d588b5 src/java.base/share/classes/java/util/TimeZone.java --- a/src/java.base/share/classes/java/util/TimeZone.java +++ b/src/java.base/share/classes/java/util/TimeZone.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1996, 2015, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1996, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -784,9 +784,6 @@ static final String GMT_ID = "GMT"; private static final int GMT_ID_LENGTH = 3; - // a static TimeZone we can reference if no AppContext is in place - private static volatile TimeZone mainAppContextDefault; - /** * Parses a custom time zone identifier and returns a corresponding zone. * This method doesn't support the RFC 822 time zone format. (e.g., +hhmm)

2 1

RFR 8202086 : Improve performance characteristics of sun.security.util.MemoryCache
by Ivan Gerasimov 01 May '18

01 May '18

Hello! This enhancement was generously contributed by Peter Levart [1]. The original webrev is found here [2]. The goal was to improve concurrent accessibility of the cache, while maintaining some additional limitations dictated by the spec. Would you please help review this fix? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8202086 WEBREV: http://cr.openjdk.java.net/~igerasim/8202086/00/webrev/ Thanks in advance! [1] http://mail.openjdk.java.net/pipermail/security-dev/2017-November/016512.ht… [2] http://cr.openjdk.java.net/~plevart/jdk10-dev/8186628_ssl_session_cache_sca… -- With kind regards, Ivan Gerasimov

1 0