August 2018 - core-libs-dev

[12]RFR 8205399 : Set node color on pinned HashMap.TreeNode deletion
by Brent Christian 08 Aug '18

08 Aug '18

Hi, Please review the following fix. Bug: https://bugs.openjdk.java.net/browse/JDK-8205399 Webrev: http://cr.openjdk.java.net/~bchristi/8205399/webrev01/ The vmTestbase/vm/gc/containers/Combination05/TestDescription.java test, which does random adds and removes (via Iterator), has been failing intermittently with an AssertionError. I tracked down a couple sequences of operations that trigger the assertion. Sufficient HashMap collisions convert a bin to a tree, and then values are deleted using Iterator.remove() (pinned node deletion). The condition that fails in HashMap.TreeNode.checkInvariants() is: if (t.red && tl != null && tl.red && tr != null && tr.red) A red TreeNode should not have two red children. Many thanks to Doug Lea for providing the fix for the HashMap red/black tree code. The root node color needs to be set in this case. Thanks, -Brent

2 2

[12]RFR 8208656: Move java/util/Calendar/CalendarTestScripts tests into OpenJDK
by Ying Zhou 08 Aug '18

08 Aug '18

Hello, Please help review the patch to move some tests to OpenJDK. Thank you! Bug: https://bugs.openjdk.java.net/browse/JDK-8208656 Webrev: http://cr.openjdk.java.net/~dzhou/8208656/webrev.00/ <http://cr.openjdk.java.net/%7Edzhou/8208656/webrev.00/> Regards, Daisy

2 1

[12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/
by Chris Yin 08 Aug '18

08 Aug '18

Please review the changes to add another 8 JNDI tests to com/sun/jndi/dns/EnvTests/ in OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8208279 <https://bugs.openjdk.java.net/browse/JDK-8208279> webrev: http://cr.openjdk.java.net/~xyin/8208279/webrev.00/ <http://cr.openjdk.java.net/~xyin/8208279/webrev.00/> Regards, Chris

3 9

RFR (XXS) 8201394: Update java.se module summary to reflect removal of java.se.ee module
by Iris Clark 08 Aug '18

08 Aug '18

Hi. Please review the following minor change to update the java.se module summary. 8201394: Update java.se module summary to reflect removal of java.se.ee module https://bugs.openjdk.java.net/browse/JDK-8201394 In JDK 10, we had the following module summaries: java.base - Defines the foundational APIs of the Java SE Platform java.se - Defines the core Java SE API. java.se.ee - Defines the full API of the Java SE Platform Now that the java.se.ee module has been removed, the description of the java.se module summary should be changed to reflect the fact that it is the embodiment of the SE API. Our module summaries will be as follows: java.base - Defines the foundational APIs of the Java SE Platform [no change] java.se - Defines the API of the Java SE Platform This is the diff: diff -r 331888ea4a78 src/java.se/share/classes/module-info.java --- a/src/java.se/share/classes/module-info.java Tue Jul 31 14:04:29 2018 -0700 +++ b/src/java.se/share/classes/module-info.java Mon Aug 06 14:53:37 2018 -0700 @@ -24,7 +24,7 @@ */ /** - * Defines the core Java SE API. + * Defines the API of the Java SE Platform. * <P> * * <dl> Thanks, iris

4 4

RFR: 8209003: Consolidate use of empty collections in java.lang.module
by Claes Redestad 07 Aug '18

07 Aug '18

Hi, feel free to review this cleanup to consolidate some uses of Collections.empty/unmodifiableXx.. to Set/Map/List.of()/copyOf(), as appropriate. This aligns better with code already generated by jlink, so avoids observing a mix of many implementation classes in some places.. Webrev: http://cr.openjdk.java.net/~redestad/8209003/jdk.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8209003 Due the specified need to throw IAE rather than NPE in certain cases, code in some performance-insensitive API methods in ModuleDescriptor.Builder now does an extra copy up front (List/Set/Map.copyOf will throw NPE on any null element or key). I'd rather keep the code simple than add extra handling to squeeze out the last bit of performance here (maybe I'm getting old...) Thanks! /Claes

3 3

8143850: retrofit ArrayDeque to implement List
by Alex Foster 07 Aug '18

07 Aug '18

Hi, <https://bugs.openjdk.java.net/browse/JDK-8143850> <https://bugs.openjdk.java.net/browse/JDK-8143850> I did this awhile ago and I'd like to submit it. I believe it needs to be a new class because it changes the behavior of equals and hashcode. My implementation is based off of the java 8 version I think and it has changed a lot since then, I could add some of the improvements if you want. Also I'm not sure if we should make a new Deque + List interface for it to implement or not. Code: https://pastebin.com/suXMfMZW Bug: https://bugs.openjdk.java.net/browse/JDK-8143850 Previous discussion:<https://bugs.openjdk.java.net/browse/JDK-8143850> <https://bugs.openjdk.java.net/browse/JDK-8143850>http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-February/024938.h… <https://bugs.openjdk.java.net/browse/JDK-8143850>Alex<http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-February/024938.h…>

6 14

Re: Draft JEP proposal: JDK-8200758: Packaging Tool
by Lennart Börjeson 07 Aug '18

07 Aug '18

I'm concerned about the possible loss of the packager service, i.e. the UserJvmOptionsService class and associated underlying machinery in the jpackager. Background: I'm developing and maintaining an internal GUI tool for log analysis. It reads, parses and aggregates data from many different kinds of logs from our production systems. The amount of memory needed to process all the data can vary quite a lot from run to run, so I've found it very convenient to utilise the UserJvmOptionsService to enable my users to set and manage the JVM settings of the JVM-bundled application created by javapackager. As far as I know, the javapackager, and the packager services, were omitted from JDK 11. While I can still use the javapackager of JDK 10 to package a JDK 11 application, I don't see how I could use the packager services, since they are not present. neither in JDK 11 nor in openjfx 11. I would like to suggest the UserJvmOptionsService, or equivalent, be retained in the successor tool, jpackager. Best regards, /Lennart Börjeson

1 0

[11] RFR: 8208691: Tighten up jdk.includeInExceptions security property
by Sean Mullan 07 Aug '18

07 Aug '18

After further evaluation of the new jdk.includeInExceptions security property originally introduced in JDK-8204233 [1] and further generalized in JDK-8207846 [2], I felt that a stronger warning should be added to the description of the property alerting the user to the potential risks of setting the property. I also added a test to ensure that the property was not accidentally turned on by default (mainly to catch accidental pushes where the property was left on as part of testing, etc). webrev: http://cr.openjdk.java.net/~mullan/webrevs/8208691/webrev.00/ --Sean [1] https://bugs.openjdk.java.net/browse/JDK-8204233 [2] https://bugs.openjdk.java.net/browse/JDK-8207846

2 2

RFR(XXS): 8209018 ProblemList tests affected by JDK-8208690
by Daniel D. Daugherty 07 Aug '18

07 Aug '18

Greetings, I'm in the process of reducing the noise in the JDK12 CI so I need a single (R)eviewer for the following fix: JDK-8209018 ProblemList tests affected by JDK-8208690 https://bugs.openjdk.java.net/browse/JDK-8209018 Here's the diff: $ hg diff diff -r c00451b67854 test/hotspot/jtreg/ProblemList.txt --- a/test/hotspot/jtreg/ProblemList.txt Mon Aug 06 04:31:50 2018 -0400 +++ b/test/hotspot/jtreg/ProblemList.txt Mon Aug 06 12:40:20 2018 -0400 @@ -59,6 +59,9 @@ compiler/cpuflags/TestAESIntrinsicsOnSupportedConfig.java 8190680 generic-all +compiler/c1/Test4917709.java 8208690 generic-all +compiler/runtime/cr6891750/Test6891750.java 8208690 generic-all + ############################################################################# # :hotspot_gc diff -r c00451b67854 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Mon Aug 06 04:31:50 2018 -0400 +++ b/test/jdk/ProblemList.txt Mon Aug 06 12:40:20 2018 -0400 @@ -559,6 +559,9 @@ java/net/DatagramSocket/SendDatagramToBadAddress.java 7143960 macosx-all +java/net/Socket/LingerTest.java 8208690 generic-all +sun/net/www/http/HttpClient/MultiThreadTest.java 8208690 generic-all + ############################################################################ # jdk_nio Thanks, in advance, for any questions, comments or suggestions. Dan

3 11

RFR 8208364: java/lang/reflect/callerCache/ReflectionCallerCacheTest.java missing module dependencies declaration
by Alexandre (Shura) Iline 06 Aug '18

06 Aug '18

Hi, Please taka a quick look on this fix: $ hg diff --- a/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java +++ b/test/jdk/java/lang/reflect/callerCache/ReflectionCallerCacheTest.java @@ -25,8 +25,9 @@ * @test * @bug 8202113 * @summary Test the caller class loader is not kept strongly reachable - * by reflection API + * by reflection API * @library /test/lib/ + * @modules jdk.compiler * @build ReflectionCallerCacheTest Members jdk.test.lib.compiler.CompilerUtils * @run testng/othervm ReflectionCallerCacheTest */ $ Thank you. Shura

3 3