April 2020 - core-libs-dev

Re: JDK 15 RFR of JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations
by Pavel Rappo 09 Apr '20

09 Apr '20

> http://cr.openjdk.java.net/~darcy/8225540.1/ I'm not an expert in this area, but AFAIK this looks good. A couple of nits. 1. The newly added text in the top-level doc comment for AnnotatedElement is missing some <p> tags. It looks nice in source, but it won't be like that in the output. (For better or worse, this is not Markdown.) 2. @implSpec for AnnotatedElement.isAnnotationPresent reads pretty unconventionally. There's nothing wrong with that. I simply wonder if there are any reasons why you picked that wording as opposed to the typical "The default implementation calls/returns/performs/etc. ..."? Also, there's a typo: "the the". 3. Since we are in this area, would you care to fix a couple of typos? diff -r 193e4179def8 src/java.base/share/classes/java/lang/reflect/Modifier.java --- a/src/java.base/share/classes/java/lang/reflect/Modifier.java Wed Apr 08 22:58:42 2020 -0700 +++ b/src/java.base/share/classes/java/lang/reflect/Modifier.java Thu Apr 09 11:28:32 2020 +0100 @@ -377,7 +377,7 @@ /** * The Java source modifiers that can be applied to a method. - * @jls8.4.3 Method Modifiers + * @jls 8.4.3 Method Modifiers */ private static final int METHOD_MODIFIERS = Modifier.PUBLIC | Modifier.PROTECTED | Modifier.PRIVATE | @@ -400,9 +400,6 @@ private static final int PARAMETER_MODIFIERS = Modifier.FINAL; - /** - * - */ static final int ACCESS_MODIFIERS = Modifier.PUBLIC | Modifier.PROTECTED | Modifier.PRIVATE; -Pavel

2 1

RFR: 8242039: Improve jlink VersionPropsPlugin
by Langer, Christoph 09 Apr '20

09 Apr '20

Hi, please review a small improvement for the jlink VersionPropsPlugin. The Plugin modifies the bytecode of java/lang/VersionProps.class to replace the initializion of certain vendor specific system properties with custom values. This modification currently adds two bytecodes per constant, a pop and another ldc. I overhauled it to simply replace the original ldc of the old value with another ldc, loading the custom value. I was playing a bit with the plugin and tried to familiarize with the code – so that’s the outcome 😉 I also added an @SuppressWarnings("unused") in VersionProps.java.template to quiesce an IDE warning. Bug: https://bugs.openjdk.java.net/browse/JDK-8242039 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8242039.0/ Thanks Christoph

3 9

RFR [15/java.xml] 8237187 Obsolete references to java.sun.com
by Joe Wang 09 Apr '20

09 Apr '20

Please review a doc-only change to replace links to sun.com with ones to oracle.com. Only material changes were the two sun.com links, others format, e.g. moving the anchor brackets to within one line. --- a/src/java.base/share/classes/jdk/internal/util/xml/impl/ParserSAX.java +++ b/src/java.base/share/classes/jdk/internal/util/xml/impl/ParserSAX.java @@ -40,14 +40,14 @@ /** * XML non-validating push parser. - * - * This non-validating parser conforms to <a href="http://www.w3.org/TR/REC-xml" - * >Extensible Markup Language (XML) 1.0</a> and <a - * href="http://www.w3.org/TR/REC-xml-names" >"Namespaces in XML"</a> - * specifications. The API supported by the parser are <a - * href="http://java.sun.com/aboutJava/communityprocess/final/jsr030/index.html">CLDC - * 1.0</a> and <a href="http://www.jcp.org/en/jsr/detail?id=280">JSR-280</a>, a - * JavaME subset of <a href="http://java.sun.com/xml/jaxp/index.html">JAXP</a> + * <p> + * This non-validating parser conforms to <a href="http://www.w3.org/TR/REC-xml"> + * Extensible Markup Language (XML) 1.0</a> and + * <a href="http://www.w3.org/TR/REC-xml-names" >Namespaces in XML</a> + * specifications. The API supported by the parser are + * <a href="https://www.oracle.com/technetwork/java/cldc-141990.html">CLDC</a> and + * <a href="http://www.jcp.org/en/jsr/detail?id=280">JSR-280</a>, a JavaME subset of + * <a href="https://www.oracle.com/technetwork/java/intro-140052.html">JAXP</a> * and <a href="http://www.saxproject.org/">SAX2</a>. * * @see org.xml.sax.XMLReader Thanks, Joe

3 2

Re: RFR(XS): 8174768: Make ProcessTools print executed process output into a separate file
by Igor Ignatyev 09 Apr '20

09 Apr '20

Hi Evgeny, (widening the audience, given this affects not just hotspot compiler, but hotspot tests as well as core libs tests in general) overall that looks good to me. one suggestion, for the ease of failure analysis it might be worth to print out the names of created files, although this might potentially clutter the output, I don't think it'll be a problem given we already print out things like 'Gathering output for process ...' , 'Waiting for completion...' in LazyOutputBuffer. > The change has been tested via a mach5 test runs (jdk-tier1 through 4) on the 4 common platforms (linux-x64, windows-x64, macosx-x64, sparcv9). this doesn't include any of hotspot tiers, could you please also run hs-tier1--4? // you can use tierN jobs which include both jdk and hs parts. Thanks, -- Igor > On Mar 30, 2020, at 3:55 AM, Evgeny Nikitin <evgeny.nikitin(a)oracle.com> wrote: > > > Hi, > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8174768 > > Webrev: http://cr.openjdk.java.net/~iignatyev/enikitin/8174768/webrev.00/ > > > The bug had been created as a request to simplify investigation for compiler control tests failures. > I found the functionality pretty generic and useful and made ProcessTools dump output as well as some diagnostic information for every executed process into a separate file. > The diagnostic information contains cmdline, exit code, stdout and stderr. The output files are named like 'pid-<PID>-output.log'. > > The change has been tested via a mach5 test runs (jdk-tier1 through 4) on the 4 common platforms (linux-x64, windows-x64, macosx-x64, sparcv9). > > Please review, > /Evgeny Nikitin.

5 9

RFR: JDK-8242155: Enhance automated macos signing tests
by Andy Herrick 08 Apr '20

08 Apr '20

Please review the fix to issue [1] at [2]. [1] https://bugs.openjdk.java.net/browse/JDK-8242155 [2] http://cr.openjdk.java.net/~herrick/8242155/webrev.01/ /Andy

2 1

[15] RFR (XXS): 8242337: javadoc typo in NumberFormat::setMinimumFractionDigits
by naoto.sato＠oracle.com 08 Apr '20

08 Apr '20

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8242337 Here is the proposed diff: --- diff -r 706df347bcc2 src/java.base/share/classes/java/text/NumberFormat.java --- a/src/java.base/share/classes/java/text/NumberFormat.java +++ b/src/java.base/share/classes/java/text/NumberFormat.java @@ -865,7 +865,7 @@ * Sets the minimum number of digits allowed in the fraction portion of a * number. minimumFractionDigits must be ≤ maximumFractionDigits. If the * new value for minimumFractionDigits exceeds the current value - * of maximumFractionDigits, then maximumIntegerDigits will also be set to + * of maximumFractionDigits, then maximumFractionDigits will also be set to * the new value * * @param newValue the minimum number of fraction digits to be shown; if --- It is simply fixing a typo (possibly a copy/paste mistake). Thanks to Martin for finding this. Naoto

3 2

RFR 15 8242382: test/jdk/TEST.groups cleanup of sun/tools/java
by Roger Riggs 08 Apr '20

08 Apr '20

Please review a trivial cleanup of test/jdk/TEST.groups to remove a latent reference to sun/tools/java. diff --git a/test/jdk/TEST.groups b/test/jdk/TEST.groups --- a/test/jdk/TEST.groups +++ b/test/jdk/TEST.groups @@ -1,4 +1,4 @@ -# Copyright (c) 2013, 2019, Oracle and/or its affiliates. All rights reserved. +# Copyright (c) 2013, 2020, Oracle and/or its affiliates. All rights reserved. # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. # # This code is free software; you can redistribute it and/or modify it @@ -264,13 +264,11 @@ jdk_launcher = \ core_tools = \ tools \ jdk/internal/jrtfs \ - sun/tools/java \ sun/tools/jrunscript svc_tools = \ com/sun/tools/attach \ sun/tools \ - -sun/tools/java \ -sun/tools/jrunscript \ sun/jvmstat Issue: https://bugs.openjdk.java.net/browse/JDK-8242382 Thanks, Roger

3 2

[15] RFR: 8242010: Upgrade IANA Language Subtag Registry to Version 2020-04-01
by naoto.sato＠oracle.com 08 Apr '20

08 Apr '20

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8242010 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8242010/webrev.00/ Besides the upgrade of the data file, I fixed the issue where EquivMapsGenerator had been ignoring "extlang" tag. Now it correctly maps the extlang, such as "zh-cmn" to its preferred language (in this case, "cmn") tag. Naoto

3 3

RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg
by Andy Herrick 07 Apr '20

07 Apr '20

Please review the fix to issue [1] at [2]. This change enables notarization on Mac for dmg images and app-image zip files. /Andy [1]: https://bugs.openjdk.java.net/browse/JDK-8237490 [2]: http://cr.openjdk.java.net/~herrick/8237490

5 15

RFR [15] 8242230: Whitespace typos, relaxed javadoc, formatting
by Pavel Rappo 07 Apr '20

07 Apr '20

Hello, Please review the change for https://bugs.openjdk.java.net/browse/JDK-8242230: http://cr.openjdk.java.net/~prappo/8242230/webrev.00/ This is a documentation cleanup. There are no code changes involved, and the changes in documentation are mostly trivial. The following packages are affected: java.lang, java.text, java.util, java.util.logging, javax.lang.model.util, jdk.internal.reflect -Pavel

4 7