April 2020 - core-libs-dev

RFR: 8243453: Option --describe-module failed with non-ASCII module name under non-UTF8 environment
by Toshio 5 Nakamura 27 Apr '20

27 Apr '20

Hi all, Please review this fix. Also, I'd like to ask a sponsor of the fix, since I'm not a committer. Issue: https://bugs.openjdk.java.net/browse/JDK-8243453 Webrev: http://cr.openjdk.java.net/~tnakamura/8243453/webrev.00/ Under Windows Japanese or Chinese, encoding of command line option cannot be assumed as UTF-8. This fix changes from "(*env)->NewStringUTF()" to "NewPlatformString()" to call Helper method. Tier 1/2 tests on Linux and Windows passed. Best Regards, Toshio Nakamura

2 2

Re: 8243539: update copyright info for JDK-8241638(Internet mail)
by buddyliao(廖彬) 27 Apr '20

27 Apr '20

Hi Max, Thanks for your review, and I need a sponsor to help me merge this patch, would you sponsor me? BRs, Bin 在 2020/4/27 上午11:40，“Weijun Wang”<weijun.wang(a)oracle.com> 写入: This looks fine to me. Do you need a sponsor? Thanks, Max > On Apr 27, 2020, at 10:53 AM, buddyliao(廖彬) <buddyliao(a)tencent.com> wrote: > > Dear all, > > Would you help me to review the following tiny fix? Which is used to update the copyright info for patch https://hg.openjdk.java.net/jdk/jdk/rev/3f8d03880bf5 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8243539 > Webrev: https://cr.openjdk.java.net/~lzang/BuddyLiao/launcher/webrev/ > > Thanks, > Bin

2 3

RFR: 8243539: update copyright info for JDK-8241638
by buddyliao(廖彬) 27 Apr '20

27 Apr '20

Dear all, Would you help me to review the following tiny fix? Which is used to update the copyright info for patch https://hg.openjdk.java.net/jdk/jdk/rev/3f8d03880bf5 Bug: https://bugs.openjdk.java.net/browse/JDK-8243539 Webrev: https://cr.openjdk.java.net/~lzang/BuddyLiao/launcher/webrev/ Thanks, Bin

2 1

RFR: 8243587: Missing comma in copyright header
by Kim Barrett 27 Apr '20

27 Apr '20

Please review this fix for a missing comma in the copyright header for src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/DottedVersion.java. CR: https://bugs.openjdk.java.net/browse/JDK-8243587 Webrev: https://cr.openjdk.java.net/~kbarrett/8243587/webrev/ Testing: Tested locally (linux-x64): make validate-headers fails without the change, succeeds with it.

2 2

RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set
by linzang(臧琳) 26 Apr '20

26 Apr '20

Dear All, May I ask your help to review this tiny fix? Bug: https://bugs.openjdk.java.net/browse/JDK-8241638 Webrev: http://cr.openjdk.java.net/~lzang/8241638/webrev01/ Thanks! BRs, Lin

5 36

Trivial patches for typos in java.base
by Anthony Vanelverdinghe 26 Apr '20

26 Apr '20

Hi I filed 2 bug reports for typos in java.base Javadoc: https://bugs.openjdk.java.net/browse/JI-9064752 with patch diff --git a/src/java.base/share/classes/java/lang/invoke/package-info.java b/src/java.base/share/classes/java/lang/invoke/package-info.java index 82600d4866..a0ad09b03e 100644 --- a/src/java.base/share/classes/java/lang/invoke/package-info.java +++ b/src/java.base/share/classes/java/lang/invoke/package-info.java @@ -31,7 +31,7 @@ * As described in the Java Virtual Machine Specification, certain types in this package * are given special treatment by the virtual machine: * <ul> - * <li>The classes {@link java.lang.invoke.MethodHandle MethodHandle} + * <li>The classes {@link java.lang.invoke.MethodHandle MethodHandle} and * {@link java.lang.invoke.VarHandle VarHandle} contain * <a href="MethodHandle.html#sigpoly">signature polymorphic methods</a> * which can be linked regardless of their type descriptor. @@ -190,7 +190,7 @@ * invoked with just the parameter types of static arguments, thereby supporting a wider * range of methods compatible with the static arguments (such as methods that don't declare * or require the lookup, name, and type meta-data parameters). - * <p> For example, for dynamically-computed call site, a the first argument + * <p> For example, for a dynamically-computed call site, the first argument * could be {@code Object} instead of {@code MethodHandles.Lookup}, and the return type * could also be {@code Object} instead of {@code CallSite}. * (Note that the types and number of the stacked arguments limit and https://bugs.openjdk.java.net/browse/JI-9064753 with patch diff --git a/src/java.base/share/classes/java/util/concurrent/locks/ReentrantLock.java b/src/java.base/share/classes/java/util/concurrent/locks/ReentrantLock.java index 415e50e29c..be46131d3e 100644 --- a/src/java.base/share/classes/java/util/concurrent/locks/ReentrantLock.java +++ b/src/java.base/share/classes/java/util/concurrent/locks/ReentrantLock.java @@ -84,7 +84,7 @@ import jdk.internal.vm.annotation.ReservedStackAccess; * try { * // ... method body * } finally { - * lock.unlock() + * lock.unlock(); * } * } * }}</pre> There's also a typo in a comment inside native code, but I didn't file a bug report for it: diff --git a/src/java.base/unix/native/libjava/ProcessImpl_md.c b/src/java.base/unix/native/libjava/ProcessImpl_md.c index 9c562a3d16..68aa1c457a 100644 --- a/src/java.base/unix/native/libjava/ProcessImpl_md.c +++ b/src/java.base/unix/native/libjava/ProcessImpl_md.c @@ -93,7 +93,7 @@ * grained control about how exactly the process fork is executed. It is * powerful, but Linux-specific. * - * Aside from these three possibilities there is a forth option: posix_spawn(3). + * Aside from these three possibilities there is a fourth option: posix_spawn(3). * Where fork/vfork/clone all fork off the process and leave pre-exec work and * calling exec(2) to the user, posix_spawn(3) offers the user fork+exec-like * functionality in one package, similar to CreateProcess() on Windows. Kind regards, Anthony

1 0

Re: RFR (T): 8242846: removed an empty file test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java
by Ao Qi 25 Apr '20

25 Apr '20

Hi, The original email is waiting for moderator approval. Subscribed to jigsaw-dev and resent the RFR (cc'ed core-libs-dev). Thanks, Ao Qi On Wed, Apr 15, 2020 at 10:11 PM Ao Qi <aoqi(a)loongson.cn> wrote: > > Hi all, > > test/jdk/tools/jlink/plugins/OrderResourcesPluginTest.java was changed > to an empty file by JDK-8162538, but not removed. I think we should > remve this file. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8242846 > webrev: http://cr.openjdk.java.net/~aoqi/8242846/webrev.00/ > > Thanks, > Ao Qi

3 6

trivial correction to javadoc of j.l.i.MethodHandles.arrayElementVarHandle()
by Raffaello Giulietti 24 Apr '20

24 Apr '20

Not sure if this requires an entry in the JBS... Greetings Raffaello diff -r 70c2239696ae src/java.base/share/classes/java/lang/invoke/MethodHandles.java --- a/src/java.base/share/classes/java/lang/invoke/MethodHandles.java Fri Apr 24 16:12:53 2020 +0530 +++ b/src/java.base/share/classes/java/lang/invoke/MethodHandles.java Fri Apr 24 14:08:46 2020 +0200 @@ -3960,7 +3960,7 @@ * {@code short}, {@code char}, {@code int}, {@code long}, * {@code float}, or {@code double} then numeric atomic update access * modes are unsupported. - * <li>if the field type is anything other than {@code boolean}, + * <li>if the component type is anything other than {@code boolean}, * {@code byte}, {@code short}, {@code char}, {@code int} or * {@code long} then bitwise atomic update access modes are * unsupported.

2 3

RFR 15: 8243010: Test support: Customizable Hex Printer
by Roger Riggs 24 Apr '20

24 Apr '20

Please review[2] and comment on a new Hex printing utility to support OpenJDK tests. The usefulness of a hex printing has been discussed from time to time with many suggestions as to the API shape and features. To get an idea of the API and features, take a look at the javadoc[1]. It covers the basic formatting of offset, and values, and extends the descriptive part beyond simple ASCII or printable so that a custom formatter can interpret the byte stream in parallel to the bytes. The webrev includes changes to existing tests that currently use HexDumpEncoder to use HexPrinter. Comments appreciated, Roger [1]Javadoc: http://cr.openjdk.java.net/~rriggs/webrev-hexprinter-8243010/javadoc [2] Webrev: http://cr.openjdk.java.net/~rriggs/webrev-hexprinter-8243010/ [3] Issue: https://bugs.openjdk.java.net/browse/JDK-8243010

4 10

RFR 15 8243099: Adding ADQ support to JDK
by Ivanov, Vladimir A 24 Apr '20

24 Apr '20

Hello everyone, I would like to add support for the Application Device Queue (ADQ) technology to the JDK. The JBS entry and webrev were created for this improvement: JBS: https://bugs.openjdk.java.net/browse/JDK-8243099 Webrev: http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.00/ Please let us know your feedback and comments for this enhancement. Thanks, Vladimir

4 4