January 2021 - core-libs-dev

RFR: JDK-8183372 : Refactor java/lang/Class shell tests to java
by Mahendra Chhipa 02 Feb '21

02 Feb '21

https://bugs.openjdk.java.net/browse/JDK-8183372 ------------- Commit messages: - JDK-8183372 : Refactor java/lang/Class shell tests to java Changes: https://git.openjdk.java.net/jdk/pull/2170/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2170&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8183372 Stats: 296 lines in 4 files changed: 137 ins; 115 del; 44 mod Patch: https://git.openjdk.java.net/jdk/pull/2170.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2170/head:pull/2170 PR: https://git.openjdk.java.net/jdk/pull/2170

4 38

Why does Set.of disallow duplicate elements?
by dfranken.jdk＠gmail.com 02 Feb '21

02 Feb '21

Dear users, While looking at the implementation of Set.of(...) I noticed that duplicate elements are not allowed, e.g. Set.of(1, 1) will throw an IllegalArgumentException. Why has it been decided to do this? My expectation was that duplicates would simply be removed. If I do for instance new HashSet<>(<collection containing duplicates>) it works and duplicates are removed. To me, it looks a bit inconsistent to have duplicates removed for a collection passed in the constructor, but not for a collection (even though it is a vararg array) passed to a static factory method. Kind regards, Dave Franken

6 6

RFR: JDK-8257086: Clarify differences between {Float, Double}.equals and ==
by Joe Darcy 02 Feb '21

02 Feb '21

Updates to the specifications of Double.{equals, compareTo} to explain more explicitly why the obvious wrappers around "==" and "<"/"==" are not sufficient for floating-point values. Once the wording is worked out, I'll replicate it for the analogous methods on Float. ------------- Commit messages: - Fix whitespace - Initial work for JDK-8257086. Changes: https://git.openjdk.java.net/jdk/pull/1699/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1699&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257086 Stats: 65 lines in 1 file changed: 47 ins; 0 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/1699.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1699/head:pull/1699 PR: https://git.openjdk.java.net/jdk/pull/1699

5 17

RFR: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues
by Athijegannathan Sundararajan 01 Feb '21

01 Feb '21

Fixed compilation issues with the test. Test compiles and runs fine locally. ------------- Commit messages: - 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues Changes: https://git.openjdk.java.net/jdk/pull/2091/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2091&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259814 Stats: 16 lines in 1 file changed: 5 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/2091.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2091/head:pull/2091 PR: https://git.openjdk.java.net/jdk/pull/2091

3 5

jpackage problem submitting to Apple Store
by John Crowley 01 Feb '21

01 Feb '21

Hi All, Have been having a problem trying to use jpackage to sign an app and submit it to the Apple Store. Attached are the following: — the script which invokes jpackage. Note that the attached ’…txt’ files show the values for all of the variables. — the output of this script — the output of the script running with —verbose To try to summarize all of the attached: Trying to create a signed DiskOrganizer-x.y.z.pkg to upload to the Apple Store. The problem is with mac-sign and the attempt to load to the Apple Store. Otherwise, have successfully created .app, .pkg, and .dmg versions and they all execute/install as expected on my Mac (except as noted directly below in (4)). This attempt used the jpackage in JDK 16-ea, build 31. Had essentially the same results using JDK 15.0.1 Not shown in the attached is that if you try to manually start by going to DiskOrganizer/Contents/MacOS and execute ./DiskOrganizer directly, it fails with — Error opening "/Applications/DiskOrganizer.app/Contents/Contents/app/DiskOrganizer.cfg" file: No such file or directory — Note the ../Contents/Contents/app… Can fix this after installation by putting in a symlink: ln -s . Contents within the Contents directory. The last step of the pkg1.sh script invokes xcrun altool —validate-app to validate, comments on these specific errors: jpackage generates the Info.plist - some errors from this follow. Tried to make a copy of Info.plist, fix it, and then copy back into the .app, but this then invalidates the signature from —mac-sign. Key LSApplicationCategoryType contains Unknown. Probably need a jpackage —mac-category <type> to allow the user to set this. Installer package may not include install scripts. No idea where such scripts may be located. There are no scripts in the ./inputs directory. Maybe in the runtime created by jlink? The following executables must include the "com.apple.security.app-sandbox" entitlement with a Boolean value of true in the entitlements property list: [( "DiskOrganizer-app.pkg/Payload/DiskOrganizer.app/Contents/MacOS/DiskOrganizer", "DiskOrganizer-app.pkg/Payload/DiskOrganizer.app/Contents/runtime/Contents/Home/lib/jspawnhelper" Probably need an —mac-entitlements <file> option in order to add this, and any other app-specific entitlements, to the code signing step. Ensure that it is signed with your "3rd Party Mac Developer Installer" certificate. Don’t understand this - have assumed that the default was to use the Developer ID Application and Developer ID Installer certs (which are in my keychain). Are the "3rd Party …" certs also needed? Error in keyPath [product-metadata.product-identifier] — No idea where this resides. Do you know? Error in keyPath [product-metadata.product-version — Ditto The lowest minimum system version [none] in the Product Definition Property List — .. does not equal 10.9 (from the Info.plist). Any idea where this gets set on the Apple side? Is it supposed to be somewhere within the .pkg? Maybe need a —mac-min-version <x.y.z> keyword? Cannot find executable file that matches the value of CFBundleExecutable in the nested bundle DiskOrganizer [DiskOrganizer-app.pkg/Payload/DiskOrganizer.app/Contents/app] property list file.) — No idea what this means. The generated .pkg does in fact install OK on my machine, and /Applications/DiskOrganizer.app launches OK with a double-click. For Apple Store you have a Version (<key>CFBundleShortVersionString</key>) which would be set by —app-version and is the version visible to the user. But can also have a <key>CFBundleVersion</key> which is really the build number. This must be 3 numbers separated by periods and must change for each upload to the store. So would be good to be able to set —app-version 1.0 and —app-build 1.0.4 (or —mac-build) to be able to set both values. Otherwise the end user will see things like 1.0.23 (it took 23 uploads to make it through the Apple Store process) - which will be confusing. Sorry for the length of this email, but have been messing around for well over a week with no success. Also tried using jpackage without the —mac-sign, running 'codesign' directly, etc. Still have not found the magic wand to make this all work. Would appreciate any suggestions. Would love to hear "You’re doing it wrong, use this set of jpackage options"! Otherwise, suggestions or pointers to any on-line documents that would help would be great. (Have been Googling everything about this, but almost all of the "answers" assume that you are using Xcode and tell you what parameters to set - nothing about the resulting in-the-trenches process that Xcode then executes.) Thanks, John Crowley Charlotte, NC 203-856-2396 j.crowley(a)computer.org

3 6

RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base"
by Johannes Kuhn 01 Feb '21

01 Feb '21

Simple fix, complex test case. Thanks to @AlanBateman for pointing out the right fix. ------------- Commit messages: - * Minor cleanup. - * Fix Whitespace V2 - * Fix whitespace - * Fix JDK-8259395 - test now passes - Merge branch 'master' of https://github.com/openjdk/jdk into JDK-8259395 - * Add failing tests for JDK-8259395 Changes: https://git.openjdk.java.net/jdk/pull/2000/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2000&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259395 Stats: 142 lines in 4 files changed: 140 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2000.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2000/head:pull/2000 PR: https://git.openjdk.java.net/jdk/pull/2000

3 17

bug jpackage in JDK 15
by Brian Schlining 30 Jan '21

30 Jan '21

Hi everyone, I'm running into a bug with jpackage. I have a mac app that builds just fine using jdk14's jpackage. However, using jdk15's jpackage the built app doesn't run. The tl;dr is that the built executable from jdk15 throws in an extra "Contents" directory in one of its paths: e.g. "[...]/VARS Annotation.app/Contents/Contents/app/VARS Annotation.cfg" # JDK15 "[...]/VARS Annotation.app/Contents/app/VARS Annotation.cfg" # JDK14 I've put the details for the bug in an issue at https://github.com/mbari-media-management/vars-annotation/issues/123 -- ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ Brian Schlining bschlining(a)gmail.com

3 13

RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m
by Weijun Wang 30 Jan '21

30 Jan '21

This fix covers both - [[macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-825… - [[macOS]: Remove JNF dependency from libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK… ------------- Commit messages: - error check, new JavaStringToNSString - do not find class and method in loop - no more header file - better macro, no more JNI_COCOA_ENTER - Merge branch 'master' into 8257858 - callback libosxsecurity/KeystoreImpl.m - new SCDynamicStoreConfig return value format - add framework so link succeeds - 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m Changes: https://git.openjdk.java.net/jdk/pull/1845/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1845&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8257858 Stats: 484 lines in 6 files changed: 153 ins; 212 del; 119 mod Patch: https://git.openjdk.java.net/jdk/pull/1845.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1845/head:pull/1845 PR: https://git.openjdk.java.net/jdk/pull/1845

3 12

RFR: 8249867: xml declaration is not followed by a newline
by Joe Wang 30 Jan '21

30 Jan '21

Please review a patch to add an explicit control over whether a newline should be added after the XML header. This is done by adding a DOM LSSerializer property "jdk-is-standalone" and System property "jdk.xml.isStandalone". This change addresses an incompatibility introduced during 7u4 as an update to Xalan 2.7.1. ------------- Commit messages: - fix test, remove whitespace - 8249867: xml declaration is not followed by a newline Changes: https://git.openjdk.java.net/jdk/pull/2041/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2041&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8249867 Stats: 242 lines in 4 files changed: 193 ins; 1 del; 48 mod Patch: https://git.openjdk.java.net/jdk/pull/2041.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2041/head:pull/2041 PR: https://git.openjdk.java.net/jdk/pull/2041

5 25

RFR: 8258917: NativeMemoryTracking is handled by launcher inconsistenly
by Alex Menkov 29 Jan '21

29 Jan '21

The fix adds NMT handling for non-java launchers ------------- Commit messages: - Handle NMT for non-java launchers Changes: https://git.openjdk.java.net/jdk/pull/2106/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2106&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8258917 Stats: 16 lines in 2 files changed: 8 ins; 1 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/2106.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2106/head:pull/2106 PR: https://git.openjdk.java.net/jdk/pull/2106

4 16