October 2021 - core-libs-dev

RFR: 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file
by Masanori Yano 28 Oct '21

28 Oct '21

Could you please review the 8233674 bug fixes? This problem is caused by the antivirus software opening the file for a short time, so CreateFile() should be retried. ------------- Commit messages: - 8233674: JarURLConnection.getJarFile throws Exception if some process is holding the file Changes: https://git.openjdk.java.net/jdk/pull/5460/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5460&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8233674 Stats: 299 lines in 3 files changed: 261 ins; 12 del; 26 mod Patch: https://git.openjdk.java.net/jdk/pull/5460.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5460/head:pull/5460 PR: https://git.openjdk.java.net/jdk/pull/5460

2 10

RFR: 8276042: Remove unused local variables in java.naming
by Andrey Turbanov 28 Oct '21

28 Oct '21

8276042: Remove unused local variables in java.naming ------------- Commit messages: - [PATCH] Remove unused local variable in java.naming Changes: https://git.openjdk.java.net/jdk/pull/6091/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6091&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276042 Stats: 10 lines in 5 files changed: 0 ins; 5 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/6091.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6091/head:pull/6091 PR: https://git.openjdk.java.net/jdk/pull/6091

4 7

RFR: JDK-8274930: sun/tools/jps/TestJps.java can fail with long VM arguments string
by Alex Menkov 27 Oct '21

27 Oct '21

The fix adds "-XX:PerfMaxStringConstLength" argument running target app (default is 1024, 8K should be enough for any environments) ------------- Commit messages: - JDK-8274930 Changes: https://git.openjdk.java.net/jdk/pull/5858/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5858&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274930 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5858.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5858/head:pull/5858 PR: https://git.openjdk.java.net/jdk/pull/5858

3 3

RFR: 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes
by Andrey Turbanov 27 Oct '21

27 Oct '21

StringBuffer is a legacy synchronized class. There are more modern alternatives which perform better: 1. Plain String concatenation should be preferred 2. StringBuilder is a direct replacement to StringBuffer which generally have better performance In [JDK-8264029](https://bugs.openjdk.java.net/browse/JDK-8264029) I migrated only usages which were automatically detected by IDEA. It turns out there are more usages which can be migrated. ------------- Commit messages: - [PATCH] Cleanup usages of StringBuffer in java.base module - [PATCH] Cleanup usages of StringBuffer in java.base module Changes: https://git.openjdk.java.net/jdk/pull/5432/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5432&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8274879 Stats: 32 lines in 12 files changed: 0 ins; 0 del; 32 mod Patch: https://git.openjdk.java.net/jdk/pull/5432.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5432/head:pull/5432 PR: https://git.openjdk.java.net/jdk/pull/5432

3 7

RFR: 8270490: Charset.forName() taking fallback default value
by Naoto Sato 27 Oct '21

27 Oct '21

During the review of JEP 400, a proposal to provide an overloaded method to `Charset.forName()` was suggested [[1]](https://github.com/openjdk/jdk/pull/4733#discussion_r669693954). This PR is to implement the proposal. A CSR is also drafted as https://bugs.openjdk.java.net/browse/JDK-8275348 ------------- Commit messages: - 8270490: Charset.forName() taking fallback default value Changes: https://git.openjdk.java.net/jdk/pull/6045/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6045&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270490 Stats: 117 lines in 3 files changed: 115 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6045.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6045/head:pull/6045 PR: https://git.openjdk.java.net/jdk/pull/6045

8 38

RFR: 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings
by Claes Redestad 27 Oct '21

27 Oct '21

Enhance ASCII-compatible `DoubleByte` encodings to make use of the `StringCoding.implEncodeAsciiArray` intrinsic, which makes many such `CharsetEncoder`s encode ASCII text at speeds comparable to most single-byte encoders - and also more in line with how well these charsets behave when calling `String.getBytes`: Before: Benchmark (size) (type) Mode Cnt Score Error Units CharsetEncodeDecode.encode 16384 ISO-8859-1 avgt 30 3.021 ± 0.120 us/op CharsetEncodeDecode.encode 16384 Shift-JIS avgt 30 47.793 ± 1.942 us/op CharsetEncodeDecode.encode 16384 GB2312 avgt 30 49.598 ± 2.006 us/op CharsetEncodeDecode.encode 16384 EUC-JP avgt 30 68.709 ± 5.019 us/op CharsetEncodeDecode.encode 16384 EUC-KR avgt 30 48.033 ± 1.651 us/op Patched: Benchmark (size) (type) Mode Cnt Score Error Units CharsetEncodeDecode.encode 16384 ISO-8859-1 avgt 30 2.856 ± 0.078 us/op CharsetEncodeDecode.encode 16384 Shift-JIS avgt 30 5.287 ± 0.209 us/op CharsetEncodeDecode.encode 16384 GB2312 avgt 30 5.490 ± 0.251 us/op CharsetEncodeDecode.encode 16384 EUC-JP avgt 30 7.657 ± 0.368 us/op CharsetEncodeDecode.encode 16384 EUC-KR avgt 30 5.718 ± 0.267 us/op The `isASCIICompatible` predicate on `DoubleByte` was added in JEP 254 for the purpose of implementing such ASCII fast-paths, but is only used in what is now `String.encodeWithEncoder` to speed up `String.getBytes(...)` operations. Testing: tier1-3 ------------- Commit messages: - Use field directly - Grant accessClassInPackage.jdk.internal.access permission to jdk.charsets module - 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings Changes: https://git.openjdk.java.net/jdk/pull/6102/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6102&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275863 Stats: 35 lines in 5 files changed: 24 ins; 4 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/6102.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6102/head:pull/6102 PR: https://git.openjdk.java.net/jdk/pull/6102

4 5

RFR: 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec
by Сергей Цыпанов 26 Oct '21

26 Oct '21

It looks like we cannot use `Long.hashCode(long)` for `java.rmi.server.ObjID.hashCode()` due to JavaDoc: https://docs.oracle.com/en/java/javase/17/docs/api/java.rmi/java/rmi/server…. ------------- Commit messages: - 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec Changes: https://git.openjdk.java.net/jdk/pull/5963/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5963&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275293 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/5963.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5963/head:pull/5963 PR: https://git.openjdk.java.net/jdk/pull/5963

6 10

RFR: 8275767: JDK source code contains redundant boolean operations in jdk.charsets
by Naoto Sato 26 Oct '21

26 Oct '21

Trivial clean-up. ------------- Commit messages: - 8275767: JDK source code contains redundant boolean operations in jdk.charsets Changes: https://git.openjdk.java.net/jdk/pull/6110/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6110&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275767 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6110.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6110/head:pull/6110 PR: https://git.openjdk.java.net/jdk/pull/6110

4 6

RFR: 8275137: jdk.unsupported/sun.reflect.ReflectionFactory.readObjectNoDataForSerialization uses wrong signature
by Julia Boes 26 Oct '21

26 Oct '21

sun.reflect.ReflectionFactory provides MethodHandles for the various serialization methods, it is a critical internal API in the jdk.unsupported module (see JEP 260 [1]) that may be used by 3rd party serialization libraries. One of these serialization methods is readObjectNoData [2]: ```private void readObjectNoData() throws ObjectStreamException;``` The issue: The method that returns the matching handle, sun.reflect.ReflectionFactory.readObjectNoDataForSerialization, uses an erroneous signature `readObjectNoData(ObjectInputStream)` - note the superfluous parameter. This change updates the specification and fixes the implementation in java.base/jdk.internal.reflect.ReflectionFactory. Testing: tier 1-3 [1] https://openjdk.java.net/jeps/260 [2] https://docs.oracle.com/en/java/javase/15/docs/specs/serialization/input.ht… ------------- Commit messages: - initial commit Changes: https://git.openjdk.java.net/jdk/pull/5951/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5951&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8275137 Stats: 28 lines in 3 files changed: 4 ins; 6 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/5951.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/5951/head:pull/5951 PR: https://git.openjdk.java.net/jdk/pull/5951

2 3

Integrated: 8275536: Add test to check that File::lastModified returns same time stamp as Files.getLastModifiedTime
by Clive Verghese 25 Oct '21

25 Oct '21

On Thu, 21 Oct 2021 00:27:20 GMT, Clive Verghese <cverghese(a)openjdk.org> wrote: > The test validated that the precision returned by `java.io.File.lastModified` and `java.nio.file.Files.getLastModifiedTime` are the same. This pull request has now been integrated. Changeset: 97d3280e Author: Clive Verghese <cverghese(a)openjdk.org> Committer: Paul Hohensee <phh(a)openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/97d3280eb4735f5b84cd4a9a1286e35c1c4… Stats: 60 lines in 1 file changed: 60 ins; 0 del; 0 mod 8275536: Add test to check that File::lastModified returns same time stamp as Files.getLastModifiedTime Reviewed-by: alanb, bpb ------------- PR: https://git.openjdk.java.net/jdk/pull/6054

1 0