March 2021 - core-libs-dev

RFR: 8263480: ProblemList two jpackage tests on Windows
by Daniel D.Daugherty 12 Mar '21

12 Mar '21

A trivial fix to ProblemList two new tests on Windows. ------------- Commit messages: - 8263480: ProblemList two jpackage tests on Windows Changes: https://git.openjdk.java.net/jdk/pull/2952/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2952&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263480 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2952.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2952/head:pull/2952 PR: https://git.openjdk.java.net/jdk/pull/2952

3 7

RFR: 8241716: Jpackage functionality to let users choose whether to create shortcuts
by Alexey Semenyuk 11 Mar '21

11 Mar '21

Add support to insert dialog with prompts to create shortcuts in dialog installation sequence of Windows installers created by jpackage. As a side effect of the fix, UI-related WiX source code was moved from main.wxs into generated ui.wxf file. Users can override ui.wxf by placing a file with this name in resource directory. Custom dialogs optionally inserted in dialog installation sequence were placed in distinct WiX sources: InstallDirNotEmptyDlg.wxs and ShortcutPromptDlg.wxs. They can be overridden if files with the corresponding names as placed in resource directory. Moving source code of installer UI from main.wxs into ui.wxf, InstallDirNotEmptyDlg.wxs and ShortcutPromptDlg.wxs files supposed to simplify overriding of the default UI provided by jpackage. ------------- Commit messages: - 8241716: Jpackage functionality to let users choose whether to create shortcuts - 8241716: Jpackage functionality to let users choose whether to create shortcuts Changes: https://git.openjdk.java.net/jdk/pull/2882/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2882&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8241716 Stats: 3069 lines in 23 files changed: 2062 ins; 988 del; 19 mod Patch: https://git.openjdk.java.net/jdk/pull/2882.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2882/head:pull/2882 PR: https://git.openjdk.java.net/jdk/pull/2882

3 4

New candidate JEP: 400: UTF-8 by Default
by mark.reinhold＠oracle.com 11 Mar '21

11 Mar '21

https://openjdk.java.net/jeps/400 Summary: Use UTF-8 as the JDK's default charset, so that APIs that depend on the default charset behave consistently across all platforms and independently of the user’s locale and configuration. - Mark

3 3

RFR: 8263105: security-libs doclint cleanup
by Bradford Wetmore 11 Mar '21

11 Mar '21

Fix various things pointed out by the most recent doclint run in the security-libs area. This is docs only: I will be checking doccheck/doclint, and will be running tier1/tier2 tests. Minor spot checks on generated files. ------------- Commit messages: - Final First Draft - Only 100 warnings output by default - 8263105: security-libs doclint cleanup Changes: https://git.openjdk.java.net/jdk/pull/2856/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2856&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263105 Stats: 351 lines in 39 files changed: 270 ins; 2 del; 79 mod Patch: https://git.openjdk.java.net/jdk/pull/2856.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2856/head:pull/2856 PR: https://git.openjdk.java.net/jdk/pull/2856

7 20

RFR: 8262351: Extra '0' in java.util.Formatter for '%012a' conversion with a sign character
by Ian Graves 10 Mar '21

10 Mar '21

This fixes a zero-adding issue observed in the hex float conversion. ------------- Commit messages: - Fixing zero-padding issue in hex float conversion Changes: https://git.openjdk.java.net/jdk/pull/2881/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2881&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262351 Stats: 55 lines in 2 files changed: 54 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2881.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2881/head:pull/2881 PR: https://git.openjdk.java.net/jdk/pull/2881

3 5

RFR: 8263380: Unintended use of Objects.nonNull in VarHandles
by Claes Redestad 10 Mar '21

10 Mar '21

Use requireNonNull instead. ------------- Commit messages: - Unintended use of Objects.nonNull in VarHandles Changes: https://git.openjdk.java.net/jdk/pull/2914/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2914&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263380 Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/jdk/pull/2914.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2914/head:pull/2914 PR: https://git.openjdk.java.net/jdk/pull/2914

4 6

RFR: 8263333: Improve links from core reflection to JLS and JVMS
by Joe Darcy 10 Mar '21

10 Mar '21

The javadoc of various methods in core reflection would be improved by links into the JLS. ------------- Commit messages: - 8263333: Improve links from core reflection to JLS and JVMS Changes: https://git.openjdk.java.net/jdk/pull/2906/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2906&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263333 Stats: 21 lines in 5 files changed: 20 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/2906.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2906/head:pull/2906 PR: https://git.openjdk.java.net/jdk/pull/2906

2 2

RFR: JDK-8262471: Fix coding style in src/java.base/share/classes/java/lang/CharacterDataPrivateUse.java
by Christoph Göttschkes 10 Mar '21

10 Mar '21

Please review this small patch which fixes the coding style of CharacterDataPrivateUse.java ------------- Commit messages: - Fixes coding style. Changes: https://git.openjdk.java.net/jdk/pull/2754/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2754&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8262471 Stats: 13 lines in 1 file changed: 0 ins; 2 del; 11 mod Patch: https://git.openjdk.java.net/jdk/pull/2754.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2754/head:pull/2754 PR: https://git.openjdk.java.net/jdk/pull/2754

3 5

RFR: 8263102: Expand documention of Method.isBridge
by Joe Darcy 10 Mar '21

10 Mar '21

The existing documentation of Method.isBridge isn't terribly helpful to the reader. This RFE proposes to given a common example of how bridge methods are used. The JLS does *not* have a section discussing bridge methods in detail; bridge methods are a compilation technique for lowering the Java language to the JVM, they are not a language feature per se. The example given is not exhaustive; there can be and are other uses of bridge methods. Once the text is agreed to; I'll update the copyright year as well. ------------- Commit messages: - Fix trailing white space. - Rewording. - Update wording. - 8263102: Expand documention of Method.isBridg Changes: https://git.openjdk.java.net/jdk/pull/2852/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2852&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263102 Stats: 34 lines in 1 file changed: 30 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/2852.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2852/head:pull/2852 PR: https://git.openjdk.java.net/jdk/pull/2852

6 20

Subtle differences in System.getenv() between Windows and Linux
by Galder Zamarreno 09 Mar '21

09 Mar '21

Hi all, One of my colleagues discovered an intriguing difference between Linux and Windows, in the context of GraalVM native-image, when it comes to the returned value for System.getenv(). On windows, the native test he's encountered that a test fails with: > Error: No instances of java.lang.ProcessEnvironment are allowed in the image heap as this class should be initialized at image runtime This does not happen on Linux. The reason it fails on Windows it's because on that env the System.getenv() method returns a ProcessEnvironment type, which happens to extend HashMap [1]. On linux though it returns a plain map [2]. Any reason for this divergence? Is it due to historic reasons? I wondered whether the windows and linux version of this shouldn't be more akin. Galder [1] https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.base/win… [2] https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.base/uni…

2 1