April 2021 - core-libs-dev

RFR: 8264148: Update spec for exceptions retrofitted for exception chaining
by Joe Darcy 02 Apr '21

02 Apr '21

8264148: Update spec for exceptions retrofitted for exception chaining ------------- Commit messages: - Respond to review feedback. - Respond to review feedback. - Merge branch 'master' into 8264148 - Merge branch 'master' into 8264148 - 8264148: Update spec for exceptions retrofitted for exception chaining Changes: https://git.openjdk.java.net/jdk/pull/3182/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3182&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264148 Stats: 84 lines in 22 files changed: 8 ins; 44 del; 32 mod Patch: https://git.openjdk.java.net/jdk/pull/3182.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3182/head:pull/3182 PR: https://git.openjdk.java.net/jdk/pull/3182

6 10

RFR: 8264544: Case-insensitive comparison issue with supplementary characters.
by Naoto Sato 02 Apr '21

02 Apr '21

Please review the fix to the subject issue. Thanks to the contribution by Chris Johnson. ------------- Commit messages: - 8264544: Case-insensitive comparison issue with supplementary characters. Changes: https://git.openjdk.java.net/jdk/pull/3300/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3300&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264544 Stats: 11 lines in 3 files changed: 3 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/jdk/pull/3300.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3300/head:pull/3300 PR: https://git.openjdk.java.net/jdk/pull/3300

4 4

Integrated: 8264109: Add vectorized implementation for VectorMask.andNot()
by Xiaohong Gong 02 Apr '21

02 Apr '21

On Fri, 26 Mar 2021 01:50:33 GMT, Xiaohong Gong <xgong(a)openjdk.org> wrote: > Currently "VectorMask.andNot()" is not vectorized: > public VectorMask<E> andNot(VectorMask<E> m) { > // FIXME: Generate good code here. > return bOp(m, (i, a, b) -> a && !b); > } > This can be implemented with` "and(m.not())" `directly. Since `"VectorMask.and()/not()" `have been vectorized in hotspot, `"andNot"` > can be vectorized as well by calling them. > > The performance gain is >100% for such a simple JMH: > @Benchmark > public Object andNot(Blackhole bh) { > boolean[] mask = fm.apply(SPECIES.length()); > boolean[] r = fmt.apply(SPECIES.length()); > VectorMask<Byte> rm = VectorMask.fromArray(SPECIES, r, 0); > > for (int ic = 0; ic < INVOC_COUNT; ic++) { > for (int i = 0; i < mask.length; i += SPECIES.length()) { > VectorMask<Byte> vmask = VectorMask.fromArray(SPECIES, mask, i); > rm = rm.andNot(vmask); > } > } > return rm; > } This pull request has now been integrated. Changeset: 7d0a0bad Author: Xiaohong Gong <xgong(a)openjdk.org> Committer: Ningsheng Jian <njian(a)openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/7d0a0bad Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod 8264109: Add vectorized implementation for VectorMask.andNot() Reviewed-by: psandoz, njian ------------- PR: https://git.openjdk.java.net/jdk/pull/3211

1 0

Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot() [v2]
by Xiaohong Gong 02 Apr '21

02 Apr '21

> Currently "VectorMask.andNot()" is not vectorized: > public VectorMask<E> andNot(VectorMask<E> m) { > // FIXME: Generate good code here. > return bOp(m, (i, a, b) -> a && !b); > } > This can be implemented with` "and(m.not())" `directly. Since `"VectorMask.and()/not()" `have been vectorized in hotspot, `"andNot"` > can be vectorized as well by calling them. > > The performance gain is >100% for such a simple JMH: > @Benchmark > public Object andNot(Blackhole bh) { > boolean[] mask = fm.apply(SPECIES.length()); > boolean[] r = fmt.apply(SPECIES.length()); > VectorMask<Byte> rm = VectorMask.fromArray(SPECIES, r, 0); > > for (int ic = 0; ic < INVOC_COUNT; ic++) { > for (int i = 0; i < mask.length; i += SPECIES.length()) { > VectorMask<Byte> vmask = VectorMask.fromArray(SPECIES, mask, i); > rm = rm.andNot(vmask); > } > } > return rm; > } Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision: Move the changing to AbstractMask.andNot and revert changes in VectorMask Change-Id: Ie3ec8f53cb24526c8e1ccc68038355d024910818 CustomizedGitHooks: yes ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/3211/files - new: https://git.openjdk.java.net/jdk/pull/3211/files/ccb73d92..33ac041e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3211&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3211&range=00-01 Stats: 9 lines in 2 files changed: 5 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/3211.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3211/head:pull/3211 PR: https://git.openjdk.java.net/jdk/pull/3211

3 4

RFR: 8205502: Make exception message from AnnotationInvocationHandler more informative
by Joe Darcy 01 Apr '21

01 Apr '21

Simple change to make the exception/error messages more informative for various malformed annotation situations. ------------- Commit messages: - Appease jcheck. - 8205502: Make exception message from AnnotationInvocationHandler more informative Changes: https://git.openjdk.java.net/jdk/pull/3317/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3317&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8205502 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/3317.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3317/head:pull/3317 PR: https://git.openjdk.java.net/jdk/pull/3317

4 4

RFR: JDK-8264403: [macos]: App names containing '.' characters results in an error message when launching
by Andy Herrick 01 Apr '21

01 Apr '21

Deriving the cfg file name is broken on mac and linux when the application name has a "." in it. ------------- Commit messages: - Merge branch 'master' into JDK-8264403 - JDK-8264403: [macos]: App names containing '.' characters results in an error message when launching - 8264466: Cut-paste error in InterfaceCalls JMH - 8264149: BreakpointInfo::set allocates metaspace object in VM thread - 8264417: ParallelCompactData::region_offset should not accept pointers outside the current region - 8264112: (fs) Reorder methods/constructor/fields in UnixUserDefinedFileAttributeView.java - 8261957: [PPC64] Support for Concurrent Thread-Stack Processing - 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 - 8263582: WB_IsMethodCompilable ignores compiler directives - 8244540: Print more information with -XX:+PrintSharedArchiveAndExit - ... and 65 more: https://git.openjdk.java.net/jdk/compare/6225ae63...1fe2699e Changes: https://git.openjdk.java.net/jdk/pull/3288/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3288&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264403 Stats: 82 lines in 5 files changed: 80 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/3288.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3288/head:pull/3288 PR: https://git.openjdk.java.net/jdk/pull/3288

2 6

RFR: 8264610: Number.{byteValue, shortValue} spec should use @implSpec
by Joe Darcy 01 Apr '21

01 Apr '21

Please review this small code change and its accompanying CSR: https://bugs.openjdk.java.net/browse/JDK-8264610 ------------- Commit messages: - Update second method. - 8264609: Number.shortValue spec should use @implSpec Changes: https://git.openjdk.java.net/jdk/pull/3314/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3314&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8264610 Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/3314.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3314/head:pull/3314 PR: https://git.openjdk.java.net/jdk/pull/3314

3 3

RFR: 8169629: Annotations with lambda expressions cause AnnotationFormatErrorr
by Joe Darcy 01 Apr '21

01 Apr '21

The stricter checks added by 8035781: Improve equality for annotations in creating the proxy objects used to implement annotations has an unintended by-catch of rejecting annotation's whose type has, say, a field initialized with a lambda expression. While uncommon, it is legal code to have a field in an annotation type. The updated checks skip over the sort of synthetic method used for the initialization. Some different compilation tactics were used before and after nest mates, so the test includes compilation and testing under both situations. ------------- Commit messages: - 8169629: Annotations with lambda expressions cause AnnotationFormatErro Changes: https://git.openjdk.java.net/jdk/pull/3294/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3294&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8169629 Stats: 29 lines in 2 files changed: 25 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/3294.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3294/head:pull/3294 PR: https://git.openjdk.java.net/jdk/pull/3294

2 4

Re: Proposal for Decimal64 and Decimal128 value-based classes
by Raffaello Giulietti 01 Apr '21

01 Apr '21

Ciao Maurizio, admittedly, yours is a fairly convincing argument to wait for the completion of Valhalla, or at least JEP 401. Personally, I wouldn't mind having to denote the primitive class as Decimal128.val in some future (2022? 2023? who knows?) if I could use Decimal128 tomorrow, but I understand your concerns in defending the interests of the community at large (which includes myself). Greetings Raffaello > On 31/03/2021 15:23, Douglas Surber wrote: >> Rather than waiting on Valhala I would prefer that this project be fast tracked and added to OpenJDK ASAP. > > There is a catch here. > > While in principle, we can add these as value-based classes, and migrate > to Valhalla later, there is a biggie difference between doing it > before/after. > > When it comes to "migrated" primitive classes, there is a choice in how > to interpret the "old" utterances of the class name. Let's say that > class Foo is migrated to be a primitive class; does that mean that all > uses of Foo in existing program will automatically get flattening? Or > will references to Foo be interpreted in a conservative fashion, so as > to allow the same operations as before? One important difference in > semantics is assignment to `null` which is prohibited under flattened > semantics, but allowed under "indirect" (or by reference, if you will) > semantics. > > In other words, under the current plan, if Decimal128 is added now and > migrated later, utterances of Decimal128 will behave like they used to > pre-Valhalla, and, to take advantage of flattening you would need to > opt-in with some keyword (e.g. Decimal128.val). > > To me this is kind of a strong argument against going with these classes > now (as much as I understand how useful they'd be even w/o Valhalla) - > and preserving the "good" name (Decimal128) for the flattened case seems > worth, IMHO, waiting few more cycles. > > Maurizio

3 3

Re: RFR: 8264109: Add vectorized implementation for VectorMask.andNot()
by Paul Sandoz 01 Apr '21

01 Apr '21

On Fri, 26 Mar 2021 01:50:33 GMT, Xiaohong Gong <xgong(a)openjdk.org> wrote: > Currently "VectorMask.andNot()" is not vectorized: > public VectorMask<E> andNot(VectorMask<E> m) { > // FIXME: Generate good code here. > return bOp(m, (i, a, b) -> a && !b); > } > This can be implemented with` "and(m.not())" `directly. Since `"VectorMask.and()/not()" `have been vectorized in hotspot, `"andNot"` > can be vectorized as well by calling them. > > The performance gain is >100% for such a simple JMH: > @Benchmark > public Object andNot(Blackhole bh) { > boolean[] mask = fm.apply(SPECIES.length()); > boolean[] r = fmt.apply(SPECIES.length()); > VectorMask<Byte> rm = VectorMask.fromArray(SPECIES, r, 0); > > for (int ic = 0; ic < INVOC_COUNT; ic++) { > for (int i = 0; i < mask.length; i += SPECIES.length()) { > VectorMask<Byte> vmask = VectorMask.fromArray(SPECIES, mask, i); > rm = rm.andNot(vmask); > } > } > return rm; > } Would you mind updating the existing `AbstractMask.andNot` implementation? rather than changing `VectorMask.andNot`. That fits in with the current implementation pattern. ------------- PR: https://git.openjdk.java.net/jdk/pull/3211

2 1