June 2021 - core-libs-dev

RFR: 8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type
by Joe Wang 02 Jun '21

02 Jun '21

Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping. Clarifies the supported types for the evaluateExpression methods. Other changes were javadoc tag usages, e.g. s/the code tag/{@code ------------- Commit messages: - 8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type Changes: https://git.openjdk.java.net/jdk/pull/4258/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4258&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266559 Stats: 77 lines in 4 files changed: 28 ins; 0 del; 49 mod Patch: https://git.openjdk.java.net/jdk/pull/4258.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4258/head:pull/4258 PR: https://git.openjdk.java.net/jdk/pull/4258

3 5

Re: RFR: 8265518: C1: Intrinsic support for Preconditions.checkIndex [v10]
by Yi Yang 02 Jun '21

02 Jun '21

> The JDK codebase re-created many variants of checkIndex(`grep -I -r 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which annotated with @IntrinsicCandidate and it only has a corresponding C1 intrinsic version. > > In fact, there is an utility method `jdk.internal.util.Preconditions.checkIndex`(wrapped by java.lang.Objects.checkIndex) that behaves the same as these variants of checkIndex, we can replace these re-created variants of checkIndex by Objects.checkIndex, it would significantly reduce duplicated code and enjoys performance improvement because Preconditions.checkIndex is @IntrinsicCandidate and it has a corresponding intrinsic method in HotSpot. > > But, the problem is currently HotSpot only implements the C2 version of Preconditions.checkIndex. To reuse it global-widely in JDK code, I think we can firstly implement its C1 counterpart. There are also a few kinds of stuff we can do later: > > 1. Replace all variants of checkIndex by Objects.checkIndex in the whole JDK codebase. > 2. Remove Buffer.checkIndex and obsolete/deprecate InlineNIOCheckIndex flag > > Testing: cds, compiler and jdk Yi Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits: - x86_32 fails - build failed - cmp clobbers its left argument on x86_32 - better check1-4 - AssertionError when expected exception was not thrown - remove extra newline - remove InlineNIOCheckIndex flag - remove java_nio_Buffer in javaClasses.hpp - consolidate ------------- Changes: https://git.openjdk.java.net/jdk/pull/3615/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3615&range=09 Stats: 338 lines in 11 files changed: 242 ins; 78 del; 18 mod Patch: https://git.openjdk.java.net/jdk/pull/3615.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3615/head:pull/3615 PR: https://git.openjdk.java.net/jdk/pull/3615

1 0

RFR: JDK-8267936: PreserveAllAnnotations option doesn't expose the annotation to Java code
by Jaroslav Tulach 01 Jun '21

01 Jun '21

This PR exposes runtime invisible annotations via `Class.getAnnotation` when `-XX:+PreserveAllAnnotations` option is passed to the JVM. Existing `-XX:+PreserveAllAnnotations` option can be very useful for code that needs to access annotations with `RetentionPolicy.CLASS` without the need to parse the .class files manually. While the RuntimeInvisibleAnnotations are kept in the runtime, they are not visible via java.lang.reflect API. I assume that's just an omission. This PR provides a test and a single line fix that makes `-XX:+PreserveAllAnnotations` useful in cooperation with `Class.getAnnotation(...)`. ------------- Commit messages: - Expose runtime invisible annotations via Class.getAnnotation when -XX:+PreserveAllAnnotations is on Changes: https://git.openjdk.java.net/jdk/pull/4245/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4245&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267936 Stats: 65 lines in 2 files changed: 61 ins; 2 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/4245.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4245/head:pull/4245 PR: https://git.openjdk.java.net/jdk/pull/4245

7 25

java.util.List missing from "Collections Framework Overview" javadoc
by Raffaello Giulietti 01 Jun '21

01 Jun '21

Hello, seems like java.util.List is missing from the list in the "Collection Interfaces" section in https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/doc-… Should be easy to fix and doesn't seem to require a CSR as the document is non-normative. Greetings Raffaello

2 2

RFR: 8267670: Update java.io, java.math, and java.text to use switch expressions
by Patrick Concannon 01 Jun '21

01 Jun '21

Hi, Could someone please review my code for updating the code in the `java.io`, `java.math`, and `java.text` packages to make use of the switch expressions? Kind regards, Patrick ------------- Commit messages: - 8267670: Update java.io, java.math, and java.text to use switch expressions Changes: https://git.openjdk.java.net/jdk/pull/4182/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4182&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267670 Stats: 328 lines in 11 files changed: 1 ins; 187 del; 140 mod Patch: https://git.openjdk.java.net/jdk/pull/4182.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4182/head:pull/4182 PR: https://git.openjdk.java.net/jdk/pull/4182

9 31