July 2021 - core-libs-dev

RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo
by Wang Huang 09 Oct '21

09 Oct '21

Dear all, Can you do me a favor to review this patch. This patch use `ldp` to implement String.compareTo. * We add a JMH test case * Here is the result of this test case Benchmark |(size)| Mode| Cnt|Score | Error |Units ---------------------------------|------|-----|----|------|--------|----- StringCompare.compareLL | 64 | avgt| 5 |7.992 | ± 0.005|us/op StringCompare.compareLL | 72 | avgt| 5 |15.029| ± 0.006|us/op StringCompare.compareLL | 80 | avgt| 5 |14.655| ± 0.011|us/op StringCompare.compareLL | 91 | avgt| 5 |16.363| ± 0.12 |us/op StringCompare.compareLL | 101 | avgt| 5 |16.966| ± 0.007|us/op StringCompare.compareLL | 121 | avgt| 5 |19.276| ± 0.006|us/op StringCompare.compareLL | 181 | avgt| 5 |19.002| ± 0.417|us/op StringCompare.compareLL | 256 | avgt| 5 |24.707| ± 0.041|us/op StringCompare.compareLLWithLdp| 64 | avgt| 5 |8.001 | ± 0.121|us/op StringCompare.compareLLWithLdp| 72 | avgt| 5 |11.573| ± 0.003|us/op StringCompare.compareLLWithLdp| 80 | avgt| 5 |6.861 | ± 0.004|us/op StringCompare.compareLLWithLdp| 91 | avgt| 5 |12.774| ± 0.201|us/op StringCompare.compareLLWithLdp| 101 | avgt| 5 |8.691 | ± 0.004|us/op StringCompare.compareLLWithLdp| 121 | avgt| 5 |11.091| ± 1.342|us/op StringCompare.compareLLWithLdp| 181 | avgt| 5 |14.64 | ± 0.581|us/op StringCompare.compareLLWithLdp| 256 | avgt| 5 |25.879| ± 1.775|us/op StringCompare.compareUU | 64 | avgt| 5 |13.476| ± 0.01 |us/op StringCompare.compareUU | 72 | avgt| 5 |15.078| ± 0.006|us/op StringCompare.compareUU | 80 | avgt| 5 |23.512| ± 0.011|us/op StringCompare.compareUU | 91 | avgt| 5 |24.284| ± 0.008|us/op StringCompare.compareUU | 101 | avgt| 5 |20.707| ± 0.017|us/op StringCompare.compareUU | 121 | avgt| 5 |29.302| ± 0.011|us/op StringCompare.compareUU | 181 | avgt| 5 |39.31 | ± 0.016|us/op StringCompare.compareUU | 256 | avgt| 5 |54.592| ± 0.392|us/op StringCompare.compareUUWithLdp| 64 | avgt| 5 |16.389| ± 0.008|us/op StringCompare.compareUUWithLdp| 72 | avgt| 5 |10.71 | ± 0.158|us/op StringCompare.compareUUWithLdp| 80 | avgt| 5 |11.488| ± 0.024|us/op StringCompare.compareUUWithLdp| 91 | avgt| 5 |13.412| ± 0.006|us/op StringCompare.compareUUWithLdp| 101 | avgt| 5 |16.245| ± 0.434|us/op StringCompare.compareUUWithLdp| 121 | avgt| 5 |16.597| ± 0.016|us/op StringCompare.compareUUWithLdp| 181 | avgt| 5 |27.373| ± 0.017|us/op StringCompare.compareUUWithLdp| 256 | avgt| 5 |41.74 | ± 3.5 |us/op >From this table, we can see that in most cases, our patch is better than old one. Thank you for your review. Any suggestions are welcome. ------------- Commit messages: - 8268231: Aarch64: Use ldp in intrinsics for String.compareTo Changes: https://git.openjdk.java.net/jdk/pull/4722/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4722&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268231 Stats: 259 lines in 3 files changed: 255 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/4722.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4722/head:pull/4722 PR: https://git.openjdk.java.net/jdk/pull/4722

6 40

RFR: 4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields
by Lin Zang 30 Sep '21

30 Sep '21

4890732: GZIPOutputStream doesn't support, in fact thwarts, use of optional GZIP fields ------------- Commit messages: - remove trailing spaces - 4890732: support optional GZIP fields in GZIPOutputStream Changes: https://git.openjdk.java.net/jdk/pull/3072/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3072&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-4890732 Stats: 184 lines in 1 file changed: 184 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/3072.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3072/head:pull/3072 PR: https://git.openjdk.java.net/jdk/pull/3072

5 46

RFR: 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0
by Roger Riggs 24 Sep '21

24 Sep '21

On Mac Os X, the OSVersionTest detected a difference in the version number reported in the os.version property and the version number provided by `sw_vers -productVersion`. When the java runtime is built with XCode 11.3, the os.version is reported as 10.16 though the current version numbering is 11.nnn. The workaround is to derive the os.version number from the ProductBuildVersion. When the toolchain is updated to XCode 12.nnn it can be removed. The workaround is enabled only when the environment variable SYSTEM_VERSION_COMPAT is unset. When the SYSTEM_VERSION_COMPAT is set in the environment the version number is reported as reported by Mac OS X. ------------- Commit messages: - 8253702: BigSur java/lang/System/OsVersionTest.java: 10.16 != 11.0 Changes: https://git.openjdk.java.net/jdk/pull/2530/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2530&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253702 Stats: 30 lines in 1 file changed: 21 ins; 2 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/2530.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2530/head:pull/2530 PR: https://git.openjdk.java.net/jdk/pull/2530

5 20

RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators
by Jim Laskey 14 Sep '21

14 Sep '21

This PR is to introduce a new random number API for the JDK. The primary API is found in RandomGenerator and RandomGeneratorFactory. Further description can be found in the JEP https://openjdk.java.net/jeps/356 . javadoc can be found at http://cr.openjdk.java.net/~jlaskey/prng/doc/api/java.base/java/util/random… old PR: https://github.com/openjdk/jdk/pull/1273 ------------- Commit messages: - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862; Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - 8248862: Implement Enhanced Pseudo-Random Number Generators - ... and 15 more: https://git.openjdk.java.net/jdk/compare/f7517386...2b3e4ed7 Changes: https://git.openjdk.java.net/jdk/pull/1292/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1292&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8248862 Stats: 13319 lines in 25 files changed: 11110 ins; 2132 del; 77 mod Patch: https://git.openjdk.java.net/jdk/pull/1292.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/1292/head:pull/1292 PR: https://git.openjdk.java.net/jdk/pull/1292

14 110

RFR: 8270057: Use Objects.checkFromToIndex for j.u.c.CopyOnWriteArrayList
by Yi Yang 14 Sep '21

14 Sep '21

After JDK-8265518(#3615), it's possible to replace all variants of checkIndex by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in the whole JDK codebase. As Mandy suggested, I create this PR for changes involving JUC changes. ------------- Commit messages: - replace Changes: https://git.openjdk.java.net/jdk/pull/4723/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4723&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270057 Stats: 6 lines in 1 file changed: 0 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/4723.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4723/head:pull/4723 PR: https://git.openjdk.java.net/jdk/pull/4723

3 2

RFR: 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform
by Masanori Yano 08 Sep '21

08 Sep '21

Hi all, Could you please review the 8269373 bug fixes? These tests call java.lang.ProcessBuilder in direct, so not used jtreg command option. To run non-localized tests, -Duser.language=en and -Duser.country=US options should be added in ProcessBuilder. ------------- Commit messages: - 8269373: some tests in jdk/tools/launcher/ fails on localized Windows platform Changes: https://git.openjdk.java.net/jdk/pull/4594/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4594&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269373 Stats: 14 lines in 6 files changed: 5 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/4594.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4594/head:pull/4594 PR: https://git.openjdk.java.net/jdk/pull/4594

2 14

RFR: 8214761: Bug in parallel Kahan summation implementation
by Ian Graves 03 Sep '21

03 Sep '21

8214761: Bug in parallel Kahan summation implementation ------------- Commit messages: - 8214761: Bug in parallel Kahan summation implementation Changes: https://git.openjdk.java.net/jdk/pull/4674/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4674&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8214761 Stats: 18 lines in 3 files changed: 11 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/jdk/pull/4674.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4674/head:pull/4674 PR: https://git.openjdk.java.net/jdk/pull/4674

4 11

RFR: 8271225: Add floorDivExact() method to java.lang.[Strict]Math
by Brian Burkhalter 31 Aug '21

31 Aug '21

Add methods `floorDivExact(int,int)` and `floorDivExact(long,long)` to `java.lang.Math` and `java.lang.StrictMath`. ------------- Commit messages: - 8271225: Add floorDivExact() method to java.lang.[Strict]Math Changes: https://git.openjdk.java.net/jdk/pull/4941/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4941&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271225 Stats: 245 lines in 3 files changed: 236 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/4941.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4941/head:pull/4941 PR: https://git.openjdk.java.net/jdk/pull/4941

3 9

RFR: 8260265: UTF-8 by Default
by Naoto Sato 30 Aug '21

30 Aug '21

This is an implementation for the `JEP 400: UTF-8 by Default`. The gist of the changes is `Charset.defaultCharset()` returning `UTF-8` and `file.encoding` system property being added in the spec, but another notable modification is in `java.io.PrintStream` where it continues to use the `Console` encoding as the default charset instead of `UTF-8`. Other changes are mostly clarification of the term "default charset" and their links. Corresponding CSR has also been drafted. JEP 400: https://bugs.openjdk.java.net/browse/JDK-8187041 CSR: https://bugs.openjdk.java.net/browse/JDK-8260266 ------------- Commit messages: - 8260265: UTF-8 by Default Changes: https://git.openjdk.java.net/jdk/pull/4733/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4733&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8260265 Stats: 297 lines in 18 files changed: 184 ins; 9 del; 104 mod Patch: https://git.openjdk.java.net/jdk/pull/4733.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4733/head:pull/4733 PR: https://git.openjdk.java.net/jdk/pull/4733

5 18

RFR: JDK-8267936: PreserveAllAnnotations option isn't tested
by Jaroslav Tulach 24 Aug '21

24 Aug '21

There doesn't seem to be much support for the complete changes in #4245. To get at least something useful from that endeavor I have extracted the test for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it in this pull request without any changes to the JVM behavior. ------------- Commit messages: - Test long time existing behavior of -XX:+PreserveAllAnnotations Changes: https://git.openjdk.java.net/jdk/pull/4280/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4280&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8267936 Stats: 172 lines in 1 file changed: 172 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4280.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4280/head:pull/4280 PR: https://git.openjdk.java.net/jdk/pull/4280

9 37