August 2021 - core-libs-dev

[jdk17] RFR: 8067223: [TESTBUG] Rename Whitebox API package
by Igor Ignatyev 02 Aug '21

02 Aug '21

Hi all, could you please review this big tedious and trivial(-ish) patch which moves `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package? the majority of the patch is the following substitutions: - `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g` - `s/sun.hotspot.parser/jdk.test.whitebox.parser/g` - `s/sun.hotspot.cpuinfo/jdk.test.whitebox.cpuinfo/g` - `s/sun.hotspot.code/jdk.test.whitebox.code/g` - `s/sun.hotspot.gc/jdk.test.whitebox.gc/g` - `s/sun.hotspot.WhiteBox/jdk.test.whitebox.WhiteBox/g` testing: tier1-4 Thanks, -- Igor ------------- Commit messages: - copyright year - update TEST.ROOT - jdk: s/sun\.hotspot\.gc/jdk.test.whitebox.gc/g - jdk: s/sun\.hotspot\.code/jdk.test.whitebox.code/g - jdk: s/sun\.hotspot\.WhiteBox/jdk.test.whitebox.WhiteBox/g - hotspot: 's~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g' - hotspot: s/sun\.hotspot\.parser/jdk.test.whitebox.parser/g - hotspot: s/sun\.hotspot\.cpuinfo/jdk.test.whitebox.cpuinfo/g - hotspot: s/sun\.hotspot\.code/jdk.test.whitebox.code/g - hotspot: 's/sun\.hotspot\.gc/jdk.test.whitebox.gc/g' - ... and 9 more: https://git.openjdk.java.net/jdk17/compare/c8ae7e5b...8f12f2cf Changes: https://git.openjdk.java.net/jdk17/pull/290/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk17&pr=290&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8067223 Stats: 2310 lines in 949 files changed: 0 ins; 0 del; 2310 mod Patch: https://git.openjdk.java.net/jdk17/pull/290.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/290/head:pull/290 PR: https://git.openjdk.java.net/jdk17/pull/290

5 13

Re: [Internet]Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9]
by linzang(臧琳) 02 Aug '21

02 Aug '21

Dear Lance, OK, Thanks for your reviewing and effort! BRs, Lin From: Lance Andersen <lance.andersen(a)oracle.com> Date: Monday, August 2, 2021 at 11:43 PM To: Lin Zang <lzang(a)openjdk.java.net> Cc: "core-libs-dev(a)openjdk.java.net" <core-libs-dev(a)openjdk.java.net> Subject: [Internet]Re: RFR: 4890732: GZIPOutputStream doesn't support optional GZIP fields [v9] On Aug 2, 2021, at 10:39 AM, Lin Zang <lzang(a)openjdk.java.net<mailto:lzang@openjdk.java.net>> wrote: On Tue, 27 Jul 2021 15:52:23 GMT, Alan Bateman <alanb(a)openjdk.org<mailto:alanb@openjdk.org>> wrote: Thank you for reviving the discussion. I have not gone through the latest update in detail but there are some changes that are needed. Before moving forward with the CSR, I would like to give time for additional feedback on naming and design. I am not sure the builder names withXXX are the preferred naming pattern. I have not gone through the latest update in detail but there are some changes that are needed. Before moving forward with the CSR, I would like to give time for additional feedback on naming and design. This proposal will need a few iterations to get to the right API. There are several issues with the proposed GZIPHeaderBuilder, also GZIPHeaderData is mutable (having byte[] as elements in a record is a hazard). I will try to make time in the coming weeks to help. Dear @AlanBateman and @LanceAndersen, Sorry for late response, and really appreciated for your help on looking at this PR. I will update the pr based on Lance's comments first. Thanks! Hi Lin, I would hold off on updates to the PR until Alan has a chance to provide his input. I have not yet had time to go through everything outside of the very quick pass I made earlier. Best Lance Lin ------------- PR: https://git.openjdk.java.net/jdk/pull/3072 [cid:image001.gif@01D787F9.EF1164E0] Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen(a)oracle.com<mailto:Lance.Andersen@oracle.com>

1 0

RFR: 8251329: (zipfs) Files.walkFileTree walks infinitely if zip has dir named "." inside
by Lance Andersen 02 Aug '21

02 Aug '21

Hi, As discussed in the https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-July/079621.html thread, this is the revised patch to address the use of '.' and '..' within Zip FS Zip FS needs to use "." and ".." as links to the current and parent directories and cannot reliably support entries that have "." and ".." as name elements. This patch updates Zip Fs to reject ZIP files that have entries in the CEN that can't be used for files in a file system. Mach5 tiers 1 through 3 have been run without any errors encountered . Best, Lance ------------- Commit messages: - Address missing linefeed after package name - Address overzelous intellij import update - Patch to address JDK-8251329 Changes: https://git.openjdk.java.net/jdk/pull/4900/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4900&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8251329 Stats: 174 lines in 2 files changed: 174 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/4900.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4900/head:pull/4900 PR: https://git.openjdk.java.net/jdk/pull/4900

4 17

RFR: 8271611: Use SecurityConstants.ACCESS_PERMISSION in MethodHandles
by Claes Redestad 02 Aug '21

02 Aug '21

Reusing SecurityConstants.ACCESS_PERMISSION (which was moved from AccessibleObject by JDK-8202419) avoids initialization of ReflectPermission when no SecurityManager is installed ------------- Commit messages: - Use SecurityConstants.ACCESS_PERMISSION in MethodHandles Changes: https://git.openjdk.java.net/jdk/pull/4957/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4957&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8271611 Stats: 5 lines in 1 file changed: 0 ins; 3 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/4957.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4957/head:pull/4957 PR: https://git.openjdk.java.net/jdk/pull/4957

2 3

RFR: 8263561: Re-examine uses of LinkedList
by Сергей Цыпанов 02 Aug '21

02 Aug '21

After I've renamed remove branch GitHub for some reason has closed original https://github.com/openjdk/jdk/pull/2744, so I've decided to recreate it. ------------- Commit messages: - Merge branch 'master' into 8263561 - Merge branch 'master' into purge-linked-list - 8263561: Use sized constructor where reasonable - 8263561: Use interface List instead of particular type where possible - 8263561: Rename requestList -> requests - 8263561: Re-examine uses of LinkedList Changes: https://git.openjdk.java.net/jdk/pull/4304/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4304&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8263561 Stats: 48 lines in 9 files changed: 0 ins; 2 del; 46 mod Patch: https://git.openjdk.java.net/jdk/pull/4304.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4304/head:pull/4304 PR: https://git.openjdk.java.net/jdk/pull/4304

2 7

RFR: 8268113: Re-use Long.hashCode() where possible
by Сергей Цыпанов 02 Aug '21

02 Aug '21

There is a few JDK classes duplicating the contents of Long.hashCode() for hash code calculation. They should explicitly delegate to Long.hashCode(). ------------- Commit messages: - 8268113: Re-use Long.hashCode() where possible Changes: https://git.openjdk.java.net/jdk/pull/4309/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4309&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268113 Stats: 10 lines in 7 files changed: 1 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/4309.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4309/head:pull/4309 PR: https://git.openjdk.java.net/jdk/pull/4309

5 20

RFR: 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt()
by Сергей Цыпанов 02 Aug '21

02 Aug '21

`AbstractStringBuilder.charAt(int)` does bounds check before calling `charAt()` (for non-latin Strings): @Override public char charAt(int index) { checkIndex(index, count); if (isLatin1()) { return (char)(value[index] & 0xff); } return StringUTF16.charAt(value, index); } This can be improved by removing bounds check from ASB.charAt() in favour of one in String*.charAt(). This gives slight improvement: before Benchmark Mode Cnt Score Error Units StringBuilderCharAtBenchmark.latin avgt 50 2,768 ± 0,004 ns/op StringBuilderCharAtBenchmark.utf avgt 50 2,778 ± 0,014 ns/op after Benchmark Mode Cnt Score Error Units StringBuilderCharAtBenchmark.latin avgt 50 2,434 ± 0,004 ns/op StringBuilderCharAtBenchmark.utf avgt 50 2,631 ± 0,004 ns/op ------------- Commit messages: - 8270160 Remove redundant bounds check from AbstractStringBuilder.charAt() Changes: https://git.openjdk.java.net/jdk/pull/4738/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4738&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8270160 Stats: 10 lines in 2 files changed: 1 ins; 5 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/4738.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4738/head:pull/4738 PR: https://git.openjdk.java.net/jdk/pull/4738

2 9

RFR: 8266972: Use String.concat() in j.l.Class where invokedynamic-based String concatenation is not available
by Сергей Цыпанов 02 Aug '21

02 Aug '21

Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 I've found out, that in a few of JDK core classes, e.g. in `j.l.Class` expressions like `baseName.replace('.', '/') + '/' + name` are not compiled into `invokedynamic`-based code, but into one using `StringBuilder`. This happens due to some bootstraping issues. However the code like private String getSimpleName0() { if (isArray()) { return getComponentType().getSimpleName() + "[]"; } //... } can be improved via replacement of `+` with `String.concat()` call. I've used this benchmark to measure impact: @State(Scope.Thread) @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) @Fork(jvmArgsAppend = {"-Xms2g", "-Xmx2g"}) public class ClassMethodsBenchmark { private final Class<? extends Object[]> arrayClass = Object[].class; private Method descriptorString; @Setup public void setUp() throws NoSuchMethodException { //fore some reason compiler doesn't allow me to call Class.descriptorString() directly descriptorString = Class.class.getDeclaredMethod("descriptorString"); } @Benchmark public Object descriptorString() throws Exception { return descriptorString.invoke(arrayClass); } @Benchmark public Object typeName() { return arrayClass.getTypeName(); } } and got those results Mode Cnt Score Error Units descriptorString avgt 60 91.480 ± 1.839 ns/op descriptorString:·gc.alloc.rate.norm avgt 60 404.008 ± 4.033 B/op descriptorString:·gc.churn.G1_Eden_Space avgt 60 2791.866 ± 181.589 MB/sec descriptorString:·gc.churn.G1_Eden_Space.norm avgt 60 401.702 ± 26.047 B/op descriptorString:·gc.churn.G1_Survivor_Space avgt 60 0.003 ± 0.001 MB/sec descriptorString:·gc.churn.G1_Survivor_Space.norm avgt 60 ≈ 10⁻³ B/op descriptorString:·gc.count avgt 60 205.000 counts descriptorString:·gc.time avgt 60 216.000 ms patched Mode Cnt Score Error Units descriptorString avgt 60 65.016 ± 3.446 ns/op descriptorString:·gc.alloc.rate avgt 60 2844.240 ± 115.719 MB/sec descriptorString:·gc.alloc.rate.norm avgt 60 288.006 ± 0.001 B/op descriptorString:·gc.churn.G1_Eden_Space avgt 60 2832.996 ± 206.939 MB/sec descriptorString:·gc.churn.G1_Eden_Space.norm avgt 60 286.955 ± 17.853 B/op descriptorString:·gc.churn.G1_Survivor_Space avgt 60 0.003 ± 0.001 MB/sec descriptorString:·gc.churn.G1_Survivor_Space.norm avgt 60 ≈ 10⁻³ B/op descriptorString:·gc.count avgt 60 208.000 counts descriptorString:·gc.time avgt 60 228.000 ms ----------------- typeName avgt 60 34.273 ± 0.480 ns/op typeName:·gc.alloc.rate avgt 60 3265.356 ± 45.113 MB/sec typeName:·gc.alloc.rate.norm avgt 60 176.004 ± 0.001 B/op typeName:·gc.churn.G1_Eden_Space avgt 60 3268.454 ± 134.458 MB/sec typeName:·gc.churn.G1_Eden_Space.norm avgt 60 176.109 ± 6.595 B/op typeName:·gc.churn.G1_Survivor_Space avgt 60 0.003 ± 0.001 MB/sec typeName:·gc.churn.G1_Survivor_Space.norm avgt 60 ≈ 10⁻⁴ B/op typeName:·gc.count avgt 60 240.000 counts typeName:·gc.time avgt 60 255.000 ms patched typeName avgt 60 15.787 ± 0.214 ns/op typeName:·gc.alloc.rate avgt 60 2577.554 ± 32.339 MB/sec typeName:·gc.alloc.rate.norm avgt 60 64.001 ± 0.001 B/op typeName:·gc.churn.G1_Eden_Space avgt 60 2574.039 ± 147.774 MB/sec typeName:·gc.churn.G1_Eden_Space.norm avgt 60 63.895 ± 3.511 B/op typeName:·gc.churn.G1_Survivor_Space avgt 60 0.003 ± 0.001 MB/sec typeName:·gc.churn.G1_Survivor_Space.norm avgt 60 ≈ 10⁻⁴ B/op typeName:·gc.count avgt 60 189.000 counts typeName:·gc.time avgt 60 199.000 ms I think this patch is likely to improve reflection operations related to arrays. If one finds this patch useful, then I'll create a ticket to track this. Also it'd be nice to have a list of classes, that are compiled in the same way as `j.l.Class` (i.e. have no access to `invokedynamic`) so I could look into them for other snippets where two String are joined so `concat`-based optimization is possible. Pre-sizing of `StringBuilder` for `Class.gdescriptorString()` and `Class.getCanonicalName0()` is one more improvement opportunity here. ------------- Commit messages: - Use String.concat() where invokedynamic-based String concatenation is not available Changes: https://git.openjdk.java.net/jdk/pull/3627/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3627&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8266972 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/3627.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/3627/head:pull/3627 PR: https://git.openjdk.java.net/jdk/pull/3627

5 17

RFR: 8269665: Clean-up toString() methods of some primitive wrappers
by Сергей Цыпанов 02 Aug '21

02 Aug '21

As of JDK 17 some of primitive wrappers, e.g. `Long`, `Integer`, `Double` and `Float` in their implementations of `Object.toString()` delegate to own utility `toString(primitive)` methods. Unlike those, `Boolean`, `Byte`, `Character` and `Short` just duplicate the contents of utility methods in implementations of `Object.toString()`. Yet another issue is a tiny discrepancy in implementation related to `Byte` and `Short` (see the first): public static String toString(byte b) { return Integer.toString((int)b, 10); } public String toString() { return Integer.toString((int)value); } Unlike in overriden method, In utility one they explicitly specify radix which can be skipped, as implementation of `Integer.toString(int,int)` has a fast-path for radix 10, ending in `Integer.toString(int)`. This simplification gives tiny improvement, see benchmark: @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) @Fork(jvmArgsAppend = {"-Xms2g", "-Xmx2g"}) public class ByteToStringBenchmark { @Benchmark public String byteToString() { return Byte.toString((byte) 1); } } Results: before Benchmark Mode Cnt Score Error Units ByteToStringBenchmark.byteToString avgt 30 11,648 ± 1,906 ns/op ByteToStringBenchmark.byteToString:·gc.alloc.rate avgt 30 3288,576 ± 418,119 MB/sec ByteToStringBenchmark.byteToString:·gc.alloc.rate.norm avgt 30 48,001 ± 0,001 B/op ByteToStringBenchmark.byteToString:·gc.churn.G1_Eden_Space avgt 30 3301,804 ± 455,932 MB/sec ByteToStringBenchmark.byteToString:·gc.churn.G1_Eden_Space.norm avgt 30 48,158 ± 2,085 B/op ByteToStringBenchmark.byteToString:·gc.churn.G1_Survivor_Space avgt 30 0,004 ± 0,001 MB/sec ByteToStringBenchmark.byteToString:·gc.churn.G1_Survivor_Space.norm avgt 30 ≈ 10⁻⁴ B/op ByteToStringBenchmark.byteToString:·gc.count avgt 30 202,000 counts ByteToStringBenchmark.byteToString:·gc.time avgt 30 413,000 ms after Benchmark Mode Cnt Score Error Units ByteToStringBenchmark.byteToString avgt 30 10,016 ± 0,530 ns/op ByteToStringBenchmark.byteToString:·gc.alloc.rate avgt 30 3673,700 ± 167,450 MB/sec ByteToStringBenchmark.byteToString:·gc.alloc.rate.norm avgt 30 48,001 ± 0,001 B/op ByteToStringBenchmark.byteToString:·gc.churn.G1_Eden_Space avgt 30 3662,406 ± 205,978 MB/sec ByteToStringBenchmark.byteToString:·gc.churn.G1_Eden_Space.norm avgt 30 47,870 ± 1,750 B/op ByteToStringBenchmark.byteToString:·gc.churn.G1_Survivor_Space avgt 30 0,004 ± 0,002 MB/sec ByteToStringBenchmark.byteToString:·gc.churn.G1_Survivor_Space.norm avgt 30 ≈ 10⁻⁴ B/op ByteToStringBenchmark.byteToString:·gc.count avgt 30 224,000 counts ByteToStringBenchmark.byteToString:·gc.time avgt 30 358,000 ms ------------- Commit messages: - 8269665: Clean-up toString() methods of some primitive wrappers Changes: https://git.openjdk.java.net/jdk/pull/4633/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4633&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8269665 Stats: 10 lines in 4 files changed: 4 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/4633.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4633/head:pull/4633 PR: https://git.openjdk.java.net/jdk/pull/4633

2 7