On Thu, 27 May 2021 17:42:56 GMT, Phil Race <prr@openjdk.org> wrote:
Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
update FtpClient.java
src/java.desktop/share/classes/java/awt/Component.java line 630:
628: } 629: 630: @SuppressWarnings("removal")
I'm confused. I thought the reason this wasn't done in the JEP implementation PR is because of refactoring that was needed because of the usage in this static block and you could not apply the annotation here. Yet it seems you are doing exactly what was supposed to be impossible with no refactoring. Can you explain ?
There *is* a tiny refactoring here: a new variable `s2` is introduced so the 2nd `doPrivileged` call on line 636 is now also in a declaration statement (for `s2`) and therefore annotatable. Without this I cannot add the annotation on line 635. ------------- PR: https://git.openjdk.java.net/jdk/pull/4138