On 4.6.2018 19:40, mandy chung wrote:
Hi Jan,
On 5/31/18 2:11 AM, Jan Lahoda wrote:
Hi,
I'd like to upgrade the JOpt Simple library we are using to version 5.0.4.
Bug: https://bugs.openjdk.java.net/browse/JDK-8203891 Complete webrev: http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/complete/
Delta webrev only showing (all) JDK changes in JOpt Simple and related changes in tests needed for the upgrade, etc.: http://cr.openjdk.java.net/~jlahoda/8203891/webrev.00/joptsimple.delta/ > Probably the biggest issue with this upgrade is that for two subsequent parameters: "--libs=", "/tmp" "/tmp" used to be interpreted as the parameter of "libs", but now the "libs" parameter is empty (as there's nothing behind the '=').
This is a reasonable fix and no whitespace is expected following `=`.
See the changes to test/jdk/tools/jmod/JmodTest.java for an example. Hopefully, this is a reasonable change.
114 "--libs=" + libDir.toString(),
Alternatively, you can take out `=` and run it as jmod --libs /tmp "--libs", libDir.toString(),
Yes, that would work as well, but there are already invocations like this in the test. So I opted for using "--libs=" + ... and similar, so that both variants are covered by the test. Thanks, Jan
Mandy