Hi, I pushed this two days ago. Thank you Andrej for the contribution! cheers /Joel On 9 sep 2014, at 11:21, Joel Borggrén-Franck <joel.franck@oracle.com> wrote:
Hi Andrej,
Can you resend the latest patch attached to a mail to this list?
cheers /Joel
On 2014-08-29, Andrej Golovnin wrote:
Hi Joel,
I have changed the test TestMethodReflectValueOf as you suggested and I have changed the summary of both tests too. You will find the changes in the attached patch. Here is the new webrev: https://db.tt/wQBLVceA
And here is the coverage report in the HTML format:
Out of curiosity, did you generate the coverage report running the jdk_lang test suite?
Yes and I used the following config for JCov:
include_list=jcov_jdk_lang.txt,field=on,abstract=on,native=on,type=all,file=$JCOV_OUT,merge=merge
where jcov_jdk_lang.txt contains the single line:
sun.reflect.*
I think this patch is good to go. I need to file some Oracle internal requests, should take about a week, then I can sponsor this.
I am very pleased to hear that and I hope to contribute more.
Best regards, Andrej Golovnin
--