On Tue, 2 Feb 2021 10:40:01 GMT, Claes Redestad <redestad@openjdk.org> wrote:
- Merge checkEncoding into the byte[]-based normalizedHash. The latter is only used from ZipFile.initCEN right after the checkEncoding today, so verifying this is equivalent is straightforward. - Factor out the logic to calculate hash, check encoding etc into the addEntry method to allow JITs to chew off larger chunks of the logic early on
Roughly 1.2x speedup on the JarFileMeta microbenchmarks, which include the time required to open the jar file and thus exercising the optimized code.
Testing: tier1-4
Claes Redestad has updated the pull request incrementally with one additional commit since the last revision:
Refactor out specific ZipException from checkedHash
Thank you for the update Claes, the changes look fine ------------- Marked as reviewed by lancea (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2306