On Tue, 23 Mar 2021 18:17:00 GMT, Andy Herrick <herrick@openjdk.org> wrote:
Looks good, although i see the following wasn't backed out:
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns
If this is intentional, then no need to worry about it.
Looks good, although i see the following wasn't backed out:
``` src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/JavaApp.icns ```
yes - look again - it was renamed back to java.icns (the 12'th or 22 files changed above)
As long as there are no transient build/test failures, it will be fine. I was just comparing the results with what `git revert 11c8c78c47f21fcd87a5969a859b5c4fced5e47d` generated and noticed this difference. ------------- PR: https://git.openjdk.java.net/jdk/pull/3159