On Dec 8, 2017, at 8:29 AM, Brian Burkhalter <brian.burkhalter@oracle.com> wrote:
On Dec 8, 2017, at 4:39 AM, Alan Bateman <Alan.Bateman@oracle.com> wrote:
I read through the javadoc again and I think it looks good.
On the implementation then Sergey has a point, the requireNonNull isn't needed to check b when b.length is used on the next line.
Already made this change locally.
One other nit is that the "overridden for efficiency" comment between @Override and the method declaration is a distraction. I don't think the comment is needed or just put it on the same line or above the @Overview so it doesn't get in the way.
The NullXXX tests can be converted to TestNG unit tests if you have cycles.
I’ll make the above two changes and re-post later today.
All previous suggested changes have been made in http://cr.openjdk.java.net/~bpb/4358774/webrev.03/ except for the possible change of name for the IS and OS nullStream() methods which awaits consensus. Thanks, Brian