+1 On Jun 24, 2014, at 1:13 PM, Joe Darcy <joe.darcy@oracle.com> wrote:
Hello,
Please review the libraries update portion of allowing @SafeVarargs on private instance methods:
JDK-8048014: Update java.lang.SafeVararags for private methods
The patch is
diff -r 6c26f18d9bc0 src/share/classes/java/lang/SafeVarargs.java --- a/src/share/classes/java/lang/SafeVarargs.java Mon Jun 23 12:12:30 2014 -0700 +++ b/src/share/classes/java/lang/SafeVarargs.java Tue Jun 24 10:03:21 2014 -0700 @@ -1,5 +1,5 @@ /* - * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -45,7 +45,7 @@ * <li> the declaration is a fixed arity method or constructor * * <li> the declaration is a variable arity method that is neither - * {@code static} nor {@code final}. + * {@code static} nor {@code final} nor {@code private}. * * </ul> *
The bulk of the change to allow @SafeVarargs on private methods, including the tests, are over in the langtools repo with javac updates. The javac changes have been reviewed and approved on compiler-dev:
http://mail.openjdk.java.net/pipermail/compiler-dev/2014-June/008855.html
Thanks,
-Joe
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com