15 Feb
2012
15 Feb
'12
3 p.m.
On 13/02/2012 17:36, Xueming Shen wrote:
:
The webrev is at
The changes look reasonable to me and looks like you have all the combinations of redirection covered. I'm not sure about the sun.std*.encoding properties as folks will find them. Probably okay for now. Minor comments - in System.java then it might be better to name the method newPrintStream. It would also be good to add a comment block to that method. In java_props_md.c then I agree with Bill's comment that you don't need 64 bytes. Minor nit is that you don't need spaces are both sides of the *. -Alan.